GNU bug report logs - #65041
[PATCH] gnu: clisp: Add threads support on x84_64-linux.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65041 in the body.
You can then email your comments to 65041 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH] gnu: clisp: Add threads support on x84_64-linux.
Date: Thu,  3 Aug 2023 17:01:59 +0100

Guix's build version of CLISP, fails to load bordeaux-threads:

Error while trying to load definition for system bordeaux-threads
      This implementation is unsupported.

This patch adds support for POSIX_THREADS on x86_64-linux
system.

* gnu/packages/lisp.scm (clisp)[arguments]: Add configuration options to
support threads on x86_64-linux system.

Reported and Co-Authored by Andrew Kravchuk <awkravchuk <at> gmail.com>
---
 gnu/packages/lisp.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 2f4fe6476d..47caa8e389 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -17,7 +17,7 @@
 ;;; Copyright © 2019-2023 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Zhu Zihao <all_but_last <at> 163.com>
-;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus <at> gmail.com>
+;;; Copyright © 2021, 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2021 Paul A. Patience <paul <at> apatience.com>
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson <at> protonmail.com>
 ;;; Copyright © 2022 Joeke de Graaf <joeke <at> posteo.net>
@@ -25,6 +25,7 @@
 ;;; Copyright © 2022 ( <paren <at> disroot.org>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2023 Yovan Naumovski <yovan <at> gorski.stream>
+;;; Copyright © 2023 Andrew Kravchuk <awkravchuk <at> gmail.com.
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -380,6 +381,12 @@ (define-public clisp
                                                      (%current-target-system)))
                                  '("CFLAGS=-falign-functions=4")
                                  '())
+                           ,@(if (string-prefix? "x86_64-linux"
+                                                 (or (%current-system)
+                                                     (%current-target-system)))
+                                 '("--enable-portability"
+                                   "--with-threads=POSIX_THREADS")
+                                 '())
                             "--with-dynamic-ffi"
                             "--with-dynamic-modules"
                             "--with-ffcall"

base-commit: 782cf09b84bc72514e89d783460ea98bc353bf6a
-- 
2.40.1

Message #8 received at 65041 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65041 <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Date: Sat, 26 Aug 2023 17:14:20 +0100

Hi Guix!

A gentle ping on the status of this issue, this patch helps to add
support for thread on x86_64 to CLISP.

Thanks,
Oleg

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #11 received at 65041 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: jgart <jgart <at> dismail.de>, 65041 <at> debbugs.gnu.org
Subject: Re: [bug#65041] [PATCH] gnu: clisp: Add threads support on
 x84_64-linux.
Date: Mon, 28 Aug 2023 16:23:25 +0000

[Message part 1 (text/plain, inline)]

Hi.

As clisp has over 1600 dependent packages, updating it should be done on
a "lisp-team" branch which will be merged into the master branch if all
goes well. However I can't do that right now as I'm on holiday until
next week.


Sharlatan Hellseher <sharlatanus <at> gmail.com> skribis:

> * gnu/packages/lisp.scm (clisp)[arguments]: Add configuration options to
> support threads on x86_64-linux system.
> [...]
> +                           ,@(if (string-prefix? "x86_64-linux"
> +                                                 (or (%current-system)
> +                                                     (%current-target-system)))
> +                                 '("--enable-portability"
> +                                   "--with-threads=POSIX_THREADS")
> +                                 '())

Does clisp only support threads on x86-64, or could it be enabled for
some other architectures?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 65041 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: jgart <jgart <at> dismail.de>, 65041 <at> debbugs.gnu.org
Subject: Re: [bug#65041] [PATCH] gnu: clisp: Add threads support on
 x84_64-linux.
Date: Thu, 31 Aug 2023 14:19:57 +0100

[Message part 1 (text/plain, inline)]

Hi Guillaume,

Andrew tried to build it on Raspberry Pi (ARM based) but it's failed
without that restriction. I had no chance to test on other platform
supported by Guix yet.
I'm including V2 of the patch which include minor adjustment for
target architecture detection simplification.

Thanks,
Oleg

On Mon, 28 Aug 2023 at 17:31, Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>
> Hi.
>
> As clisp has over 1600 dependent packages, updating it should be done on
> a "lisp-team" branch which will be merged into the master branch if all
> goes well. However I can't do that right now as I'm on holiday until
> next week.
>
>
> Sharlatan Hellseher <sharlatanus <at> gmail.com> skribis:
>
> > * gnu/packages/lisp.scm (clisp)[arguments]: Add configuration options to
> > support threads on x86_64-linux system.
> > [...]
> > +                           ,@(if (string-prefix? "x86_64-linux"
> > +                                                 (or (%current-system)
> > +                                                     (%current-target-system)))
> > +                                 '("--enable-portability"
> > +                                   "--with-threads=POSIX_THREADS")
> > +                                 '())
>
> Does clisp only support threads on x86-64, or could it be enabled for
> some other architectures?



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0001-gnu-clisp-Add-threads-support-on-x84_64-linux.patch (text/x-patch, attachment)]

Message #17 received at 65041 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: jgart <jgart <at> dismail.de>, 65041 <at> debbugs.gnu.org
Subject: Re: [bug#65041] [PATCH] gnu: clisp: Add threads support on
 x84_64-linux.
Date: Mon, 04 Sep 2023 13:28:13 +0000

[Message part 1 (text/plain, inline)]

The patch has been applied on the lisp-team branch, along with an update
for sbcl, if you want to test it.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 65041-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 65041-done <at> debbugs.gnu.org
Subject: Re: [bug#65041] [PATCH] gnu: clisp: Add threads support on
 x84_64-linux.
Date: Sat, 23 Sep 2023 09:15:02 +0000

[Message part 1 (text/plain, inline)]

Merged in master at 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
Closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.