GNU bug report logs - #65088
[PATCH] gnu: emacs-helpful: Update to 0.21.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65088 in the body.
You can then email your comments to 65088 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-helpful: Update to 0.21.
Date: Sat,  5 Aug 2023 12:40:08 +0200

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..c01192b7b3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,11 +24360,11 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
+  (let ((commit "ced07fe0d48ce1111d7a8376fdbfef34d927c967")
+        (revision "0"))
     (package
       (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
+      (version (git-version "0.21" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -24373,7 +24373,7 @@ (define-public emacs-helpful
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
+          (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
       (build-system emacs-build-system)
       (propagated-inputs
        (list emacs-dash emacs-elisp-refs emacs-f emacs-s))

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0

Message #8 received at 65088 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 65088 <at> debbugs.gnu.org
Subject: Re: [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21.
Date: Sat, 05 Aug 2023 19:22:23 +0800

Hi Cayetano,

On Sat, 05 Aug 2023 18:40:08 +0800,
Cayetano Santos via Guix-patches via wrote:
> 
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..c01192b7b3 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24360,11 +24360,11 @@ (define-public emacs-download-region
>        (license license:gpl3+))))
>  
>  (define-public emacs-helpful
> -  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> -        (revision "1"))
> +  (let ((commit "ced07fe0d48ce1111d7a8376fdbfef34d927c967")
> +        (revision "0"))
>      (package
>        (name "emacs-helpful")
> -      (version (git-version "0.19" revision commit))
> +      (version (git-version "0.21" revision commit))
>        (source
>         (origin
>           (method git-fetch)
> @@ -24373,7 +24373,7 @@ (define-public emacs-helpful
>                 (commit commit)))

Since it's a tagged release, we can remove the `let' form, use only
"0.21" for version, and `version' for commit.

Thanks

Message #11 received at 65088 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 65088 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: emacs-helpful: Update to 0.21.
Date: Sat,  5 Aug 2023 19:25:57 +0200

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..9ecc58d7d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,31 +24360,29 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
-    (package
-      (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/Wilfred/helpful")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
-      (build-system emacs-build-system)
-      (propagated-inputs
-       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
-      (native-inputs
-       (list emacs-ert-runner emacs-undercover))
-      (arguments
-       `(#:tests? #t
-         #:test-command '("ert-runner")))
-      (home-page "https://github.com/Wilfred/helpful")
-      (synopsis "More contextual information in Emacs help")
-      (description "@code{helpful} is an alternative to the built-in Emacs help
+  (package
+    (name "emacs-helpful")
+    (version "0.21")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Wilfred/helpful")
+             (commit "0.21")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
+    (native-inputs
+     (list emacs-ert-runner emacs-undercover))
+    (arguments
+     `(#:tests? #t
+       #:test-command '("ert-runner")))
+    (home-page "https://github.com/Wilfred/helpful")
+    (synopsis "More contextual information in Emacs help")
+    (description "@code{helpful} is an alternative to the built-in Emacs help
 that provides much more contextual information.
 
 @itemize

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0

Message #14 received at 65088 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 65088 <at> debbugs.gnu.org
Subject: Re: [bug#65088] [PATCH v1] gnu: emacs-helpful: Update to 0.21.
Date: Mon, 07 Aug 2023 19:42:20 +0800

Hi Cayetano,

On Sun, 06 Aug 2023 01:25:57 +0800,
Cayetano Santos via Guix-patches via wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---
>  gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..9ecc58d7d6 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24360,31 +24360,29 @@ (define-public emacs-download-region
>        (license license:gpl3+))))
>
>  (define-public emacs-helpful
> -  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> -        (revision "1"))
> -    (package
> -      (name "emacs-helpful")
> -      (version (git-version "0.19" revision commit))
> -      (source
> -       (origin
> -         (method git-fetch)
> -         (uri (git-reference
> -               (url "https://github.com/Wilfred/helpful")
> -               (commit commit)))
> -         (file-name (git-file-name name version))
> -         (sha256
> -          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
> -      (build-system emacs-build-system)
> -      (propagated-inputs
> -       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
> -      (native-inputs
> -       (list emacs-ert-runner emacs-undercover))
> -      (arguments
> -       `(#:tests? #t
> -         #:test-command '("ert-runner")))
> -      (home-page "https://github.com/Wilfred/helpful")
> -      (synopsis "More contextual information in Emacs help")
> -      (description "@code{helpful} is an alternative to the built-in Emacs help
> +  (package
> +    (name "emacs-helpful")
> +    (version "0.21")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Wilfred/helpful")
> +             (commit "0.21")))


The version specified in the `version' field is available as a
variable, so `(commit version)' can be used instead.


> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
> +    (native-inputs
> +     (list emacs-ert-runner emacs-undercover))
> +    (arguments
> +     `(#:tests? #t
> +       #:test-command '("ert-runner")))
> +    (home-page "https://github.com/Wilfred/helpful")
> +    (synopsis "More contextual information in Emacs help")
> +    (description "@code{helpful} is an alternative to the built-in Emacs help
>  that provides much more contextual information.
>
>  @itemize
>
> base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
> --
> 2.41.0


There's an extra parenthesis to remove ;)
--8<---------------cut here---------------start------------->8---
-      (license license:gpl3+))))
+    (license license:gpl3+)))
--8<---------------cut here---------------end--------------->8---

Thanks

Message #17 received at 65088 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 65088 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: emacs-helpful: Update to 0.21.
Date: Mon,  7 Aug 2023 14:11:03 +0200

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 26 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..d03a9a91f4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,31 +24360,29 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
-    (package
-      (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/Wilfred/helpful")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
-      (build-system emacs-build-system)
-      (propagated-inputs
-       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
-      (native-inputs
-       (list emacs-ert-runner emacs-undercover))
-      (arguments
-       `(#:tests? #t
-         #:test-command '("ert-runner")))
-      (home-page "https://github.com/Wilfred/helpful")
-      (synopsis "More contextual information in Emacs help")
-      (description "@code{helpful} is an alternative to the built-in Emacs help
+  (package
+    (name "emacs-helpful")
+    (version "0.21")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Wilfred/helpful")
+             (commit "0.21")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
+    (native-inputs
+     (list emacs-ert-runner emacs-undercover))
+    (arguments
+     `(#:tests? #t
+       #:test-command '("ert-runner")))
+    (home-page "https://github.com/Wilfred/helpful")
+    (synopsis "More contextual information in Emacs help")
+    (description "@code{helpful} is an alternative to the built-in Emacs help
 that provides much more contextual information.
 
 @itemize
@@ -24403,7 +24401,7 @@ (define-public emacs-helpful
 @item Trace, disassemble functions from inside Helpful.  This is discoverable
 and doesn't require memorisation of commands.
 @end itemize\n")
-      (license license:gpl3+))))
+    (license license:gpl3+)))
 
 (define-public emacs-logview
   (package

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0

Message #22 received at 65088-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 65088-done <at> debbugs.gnu.org
Subject: Re: [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21.
Date: Sun, 27 Aug 2023 11:51:27 +0800

Hi Cayetano,

On Sat, 05 Aug 2023 18:40:08 +0800,
Cayetano Santos via Guix-patches via wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---

I have applied v2 as 5476f79e41c843a7ee43f6fcf64039f527b9f21e, with
(commit "0.21") changed to (commit version).  Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.