GNU bug report logs - #65126
[PATCH] gnu: exiv2: Get rid of reference to GCC.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: iyzsong@HIDDEN; Keywords: patch; dated Mon, 7 Aug 2023 14:04:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 65126 <at> debbugs.gnu.org:


Received: (at 65126) by debbugs.gnu.org; 16 Aug 2023 18:09:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 16 14:09:04 2023
Received: from localhost ([127.0.0.1]:42058 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qWKx5-0001Dd-Uf
	for submit <at> debbugs.gnu.org; Wed, 16 Aug 2023 14:09:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36406)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1qWKx4-0001Cq-3K
 for 65126 <at> debbugs.gnu.org; Wed, 16 Aug 2023 14:09:02 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1qWKwy-0002ag-Ff; Wed, 16 Aug 2023 14:08:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=ZikunTALWBBDiA5BJrfZT5+9G+FZdL+Ovtevuil03Ks=; b=QrmXwJ6tp/FH/GZ6rLrM
 HZC3hfaX14lEwRSyJm1dU3Rt4d9g0asW4h/VLDEiEf5hHtv1H5xoOzrFU6SxpuW++zzrsJGK3q82r
 R1W56wCcW2HnB9uJTimhd24lLMhyW3BfBNrGvr56JxW3WwVi9jvoqexkuueL5U6JgiYqrM022ocCs
 LQzXMMRCMNpa1L1NoRF/LrLMwaZPN81t6KhBISewHBedNEWqwy6Ytm0TLM/U6xjorAUrnZCDgpePW
 /GJqkR03SW+N+rVCTm4Jv1SQXTGY6WtBBLrfUcxuc1PSXHfccryAk+UmBi7bECvJnvlEEWTCMiZlh
 k+DNKLapVw5GIA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: iyzsong@HIDDEN
Subject: Re: bug#65126: [PATCH] gnu: exiv2: Get rid of reference to GCC.
References: <3eba9a4c0ca80fa57106cd50ba827915b9bd91a0.1691416969.git.iyzsong@HIDDEN>
 <875y5e6etl.fsf@HIDDEN>
Date: Wed, 16 Aug 2023 20:08:53 +0200
In-Reply-To: <875y5e6etl.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Wed, 16 Aug 2023 20:07:50 +0200")
Message-ID: <871qg26eru.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 65126
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 65126 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ludovic Court=C3=A8s <ludo@HIDDEN> skribis:

> So=E2=80=A6 LGTM!

Well, wait for <https://qa.guix.gnu.org/issue/65126> to be done.

Ludo=E2=80=99.
Information forwarded to guix-patches@HIDDEN:
bug#65126; Package guix-patches. Full text available.

Message received at 65126 <at> debbugs.gnu.org:


Received: (at 65126) by debbugs.gnu.org; 16 Aug 2023 18:08:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 16 14:08:01 2023
Received: from localhost ([127.0.0.1]:42046 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qWKw4-0001Ay-SC
	for submit <at> debbugs.gnu.org; Wed, 16 Aug 2023 14:08:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33444)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1qWKw2-0001Aj-G3
 for 65126 <at> debbugs.gnu.org; Wed, 16 Aug 2023 14:07:59 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1qWKvw-0002M9-9G; Wed, 16 Aug 2023 14:07:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=fC/6I2KjPQO1CGWK6iUJxyLlZr/pKAuVzHKS9FnmMy8=; b=akDEiWXZQSot0eQYQ+BX
 IoGdQ3L7px0iSHB+w3IdXHFEzzBsJiEmY5dqKH3EohgQNJ6dsltKtj5cIeU4V4JEYq+NEvy/N8Dib
 Yvr90C6nZS/FAR7tTb+EkSK2/ulGck2TsjQ2L8jGaHQbdahmjqTj+RoPRbZR1N+0jAGwVANBMp5y0
 OwMDiRv2r0XChdF4WZji8UmvgW4I82OnSTm46qI4mBgRor/bADFmi4z6k1BmQvPOq/f5IseW/ZE62
 R/gHaiBHlGD+V0MGEpCm4b3a9M7unfyzSBxT1dFjft5sfyKUPUCT7QIk0IiAugtaIEEqb7gEnCN8h
 ezlkoLiagRRCjw==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: iyzsong@HIDDEN
Subject: Re: bug#65126: [PATCH] gnu: exiv2: Get rid of reference to GCC.
References: <3eba9a4c0ca80fa57106cd50ba827915b9bd91a0.1691416969.git.iyzsong@HIDDEN>
Date: Wed, 16 Aug 2023 20:07:50 +0200
In-Reply-To: <3eba9a4c0ca80fa57106cd50ba827915b9bd91a0.1691416969.git.iyzsong@HIDDEN>
 (iyzsong@HIDDEN's message of "Mon, 7 Aug 2023 22:03:03 +0800")
Message-ID: <875y5e6etl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 65126
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 65126 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi!

iyzsong@HIDDEN skribis:

> From: =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@HIDDEN>
>
> This fixes <https://issues.guix.gnu.org/57677>.

s/This fixes/Fixes/, for consistency.

> +         (add-after 'unpack 'patch-gcc-reference
> +           (lambda _
> +             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
> +             (substitute* "cmake/compilerFlags.cmake"
> +               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
> +                ""))))

Well done!  According to
<https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html>,
=E2=80=98_GLIBCXX_ASSERTIONS=E2=80=99 enables various run-time checks; I gu=
ess disabling
it is acceptable.

So=E2=80=A6 LGTM!

Thanks,
Ludo=E2=80=99.
Information forwarded to guix-patches@HIDDEN:
bug#65126; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Aug 2023 14:03:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 07 10:03:29 2023
Received: from localhost ([127.0.0.1]:34006 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qT0pV-0004Pc-59
	for submit <at> debbugs.gnu.org; Mon, 07 Aug 2023 10:03:29 -0400
Received: from lists.gnu.org ([2001:470:142::17]:56458)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iyzsong@HIDDEN>) id 1qT0pR-0004PK-Og
 for submit <at> debbugs.gnu.org; Mon, 07 Aug 2023 10:03:27 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <iyzsong@HIDDEN>) id 1qT0pM-0004oS-CL
 for guix-patches@HIDDEN; Mon, 07 Aug 2023 10:03:20 -0400
Received: from mail.envs.net ([5.199.136.28])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <iyzsong@HIDDEN>) id 1qT0pK-0002UE-3I
 for guix-patches@HIDDEN; Mon, 07 Aug 2023 10:03:20 -0400
Received: from localhost (mail.envs.net [127.0.0.1])
 by mail.envs.net (Postfix) with ESMTP id CD5DC38A0021;
 Mon,  7 Aug 2023 14:03:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa;
 t=1691416994; bh=68tnc8X6IiqwvCnFW2po4gFDGBolZRNiFuSiBPG/ppo=;
 h=From:To:Cc:Subject:Date:From;
 b=dh0mVLw5dQV89PEKFYzBcI6NHYIYgUnqN9zK1X2uCLqxJApBDUhngV+P344jEU5Mw
 bbLtvaWCXYzWagM8Xe773A6bMfTEICLi1h9hvcvNvPE9NFHJvrv6Uy6k7Kq6VLO7hI
 iBMybsRZKwP4OCqESjrDt4SXoravZfWAe7G4VnmyGmnmrpwPFFxgq+NJ2b0w/fTEET
 FK/NUZc/ky2V5Npx77SBlUI+Af69jEPr8LmP46frOEfztf5G1p55DoVQ3Y6AMgQglj
 vGl5NZZ4v9Zr5ucFy2t4pnL+jvJTszn8fVbHNtcMTjyDXE0EKrw6LwboXKBDub8JaC
 rA5PCjIHZohHLpH5sJXLeuGKZwQPDPuieujyYTyXLFmpsQoK2mHP5PMNm5wI+q7jCB
 4PljS9ef72LYHrT7V5CRf72f7lXMJLI89a5ZcUR/zjFmgnWeNXZnsvlMe8VhxIKQF1
 UIUe41uyZ5o+dAFNuMnfxNVvKnGxT2A6EcOA/SrwUOtq57JajSRyOKcVKI0RFmuM7p
 3LlVjOb8EM70fVhOEadHQPApsrvimeYSxSIdJ6EDPvSGQhBc6gwjEOKE+VPmMVcyOM
 9R2v0b6VsVHtkzyM+8WQBwLBJjk/3GM3EL6urQcIic2Tm6UqkuclfdO6M1n+TUpqmE
 /LGxvgIHaFHg6PSmGt47FXYw=
X-Virus-Scanned: Debian amavisd-new at mail.envs.net
Received: from mail.envs.net ([127.0.0.1])
 by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id SqW3YjFBJx4I; Mon,  7 Aug 2023 14:03:10 +0000 (UTC)
Received: from localhost (unknown [36.170.44.61])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.envs.net (Postfix) with ESMTPSA;
 Mon,  7 Aug 2023 14:03:10 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 40d73277;
 Mon, 7 Aug 2023 14:03:12 +0000 (UTC)
From: iyzsong@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: exiv2: Get rid of reference to GCC.
Date: Mon,  7 Aug 2023 22:03:03 +0800
Message-ID: <3eba9a4c0ca80fa57106cd50ba827915b9bd91a0.1691416969.git.iyzsong@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=5.199.136.28; envelope-from=iyzsong@HIDDEN;
 helo=mail.envs.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

From: 宋文武 <iyzsong@HIDDEN>

This fixes <https://issues.guix.gnu.org/57677>.

* gnu/packages/image.scm (exiv2)[arguments]: Add phase to
remove _GLIBCXX_ASSERTIONS from compiler flags.
---
 gnu/packages/image.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 3336e38852..1dbf3cbdd6 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1511,6 +1511,12 @@ (define-public exiv2
                                "-DEXIV2_ENABLE_BMFF=ON")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'patch-gcc-reference
+           (lambda _
+             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
+             (substitute* "cmake/compilerFlags.cmake"
+               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
+                ""))))
          (add-after 'install 'delete-static-libraries
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 56667ee55cd7f3368cbff169352fe440f4f93da5
-- 
2.41.0
Acknowledgement sent to iyzsong@HIDDEN:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#65126; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 16 Aug 2023 18:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.