GNU bug report logs - #65150
[PATCH] gnu: emacs-hide-mode-line: Update to 1.0.3-0.bc5d293.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65150 in the body.
You can then email your comments to 65150 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: guix-patches <at> gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: emacs-hide-mode-line: Update to 1.0.3-0.bc5d293.
Date: Tue,  8 Aug 2023 14:53:40 +0100

* gnu/packages/emacs-xyz.scm (emacs-hide-mode-line): Update to 1.0.3-0.bc5d293.
---

Hi, emacs-hide-mode-line 1.0.2 has a couple of issues that were solved upstream as part of the 1.0.3 release. See the links below for further info.

https://github.com/hlissner/emacs-hide-mode-line/commit/daa4908a14c647382cb24fa2f7ceaa3aba3517d4
https://github.com/hlissner/emacs-hide-mode-line/commit/cc81ba34f49d91e885fc0b0e539d68ca9368b5f5

Unfortunately, no Git tag has been created for version 1.0.3. I've contacted the Author in case they might be willing to create a 1.0.3 tag - but in the meantime I thought of bumping the Guix package using the commit.

Hope this is fine, cheers, Fabio.

 gnu/packages/emacs-xyz.scm | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..12ef23b1cf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34121,25 +34121,27 @@ (define-public emacs-parseclj
     (license license:gpl3+)))
 
 (define-public emacs-hide-mode-line
-  (package
-    (name "emacs-hide-mode-line")
-    (version "1.0.2")
-    (source (origin
+  (let ((commit "bc5d293576c5e08c29e694078b96a5ed85631942")
+        (revision "0"))
+    (package
+     (name "emacs-hide-mode-line")
+     (version (git-version "1.0.3" revision commit))
+     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/hlissner/emacs-hide-mode-line")
-                    (commit (string-append "v" version))))
+                    (commit commit)))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0dfzjgxfkcw4wisbyldsm1km18pfp9j8xgadn6qnsz11l55bpgyp"))))
-    (build-system emacs-build-system)
-    (synopsis "Emacs plugin that hides the mode-line")
-    (description "A minor mode that hides the mode-line in your current
+                "12mfhg0r3gvy59ijy44vsircn251nmisp04k9vvgd2yhykpsr1j6"))))
+     (build-system emacs-build-system)
+     (synopsis "Emacs plugin that hides the mode-line")
+     (description "A minor mode that hides the mode-line in your current
 buffer.  It can be used to toggle an alternative mode-line, toggle its visibility,
 or simply disable the mode-line in buffers where it is not very useful.")
-    (home-page "https://github.com/hlissner/emacs-hide-mode-line")
-    (license license:expat)))
+     (home-page "https://github.com/hlissner/emacs-hide-mode-line")
+     (license license:expat))))
 
 (define-public emacs-helm-cider
   (package

base-commit: 782ef67a59f4b564f16101cf23c30a3777b3f734
-- 
2.41.0

Message #8 received at 65150 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Fabio Natali <me <at> fabionatali.com>
Cc: 65150 <at> debbugs.gnu.org
Subject: Re: [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to
 1.0.3-0.bc5d293.
Date: Mon, 21 Aug 2023 12:59:47 +0800

Hi Fabio,

On Tue, 08 Aug 2023 21:53:40 +0800,
Fabio Natali wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-hide-mode-line): Update to 1.0.3-0.bc5d293.
> ---
>
> Hi, emacs-hide-mode-line 1.0.2 has a couple of issues that were solved upstream as part of the 1.0.3 release. See the links below for further info.
>
> https://github.com/hlissner/emacs-hide-mode-line/commit/daa4908a14c647382cb24fa2f7ceaa3aba3517d4
> https://github.com/hlissner/emacs-hide-mode-line/commit/cc81ba34f49d91e885fc0b0e539d68ca9368b5f5
>
> Unfortunately, no Git tag has been created for version 1.0.3. I've contacted the Author in case they might be willing to create a 1.0.3 tag - but in the meantime I thought of bumping the Guix package using the commit.
>
> Hope this is fine, cheers, Fabio.
>
>  gnu/packages/emacs-xyz.scm | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..12ef23b1cf 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -34121,25 +34121,27 @@ (define-public emacs-parseclj
>      (license license:gpl3+)))
>
>  (define-public emacs-hide-mode-line
> -  (package
> -    (name "emacs-hide-mode-line")
> -    (version "1.0.2")
> -    (source (origin
> +  (let ((commit "bc5d293576c5e08c29e694078b96a5ed85631942")
> +        (revision "0"))
> +    (package
> +     (name "emacs-hide-mode-line")
> +     (version (git-version "1.0.3" revision commit))
> +     (source (origin
>                (method git-fetch)
>                (uri (git-reference
>                      (url "https://github.com/hlissner/emacs-hide-mode-line")
> -                    (commit (string-append "v" version))))
> +                    (commit commit)))
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "0dfzjgxfkcw4wisbyldsm1km18pfp9j8xgadn6qnsz11l55bpgyp"))))
> -    (build-system emacs-build-system)
> -    (synopsis "Emacs plugin that hides the mode-line")
> -    (description "A minor mode that hides the mode-line in your current
> +                "12mfhg0r3gvy59ijy44vsircn251nmisp04k9vvgd2yhykpsr1j6"))))
> +     (build-system emacs-build-system)
> +     (synopsis "Emacs plugin that hides the mode-line")
> +     (description "A minor mode that hides the mode-line in your current
>  buffer.  It can be used to toggle an alternative mode-line, toggle its visibility,
>  or simply disable the mode-line in buffers where it is not very useful.")
> -    (home-page "https://github.com/hlissner/emacs-hide-mode-line")
> -    (license license:expat)))
> +     (home-page "https://github.com/hlissner/emacs-hide-mode-line")
> +     (license license:expat))))
>
>  (define-public emacs-helm-cider
>    (package
>
> base-commit: 782ef67a59f4b564f16101cf23c30a3777b3f734
> --
> 2.41.0

Since the commit refers to a (untagged) release, I'd prefer using the
version string directly instead of a git-version, and adding a comment
for the commit.  You can take a look at emacs-fennel-mode for an
example.

There's also identation issue, which can be fixed with `guix style':
$ ./pre-inst-env guix style emacs-hide-mode-line

Thanks

Message #11 received at 65150 <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 65150 <at> debbugs.gnu.org
Subject: Re: [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to
 1.0.3-0.bc5d293.
Date: Mon, 21 Aug 2023 12:01:09 +0100

[Message part 1 (text/plain, inline)]

On 2023-08-21, 12:59 +0800, Hilton Chain <hako <at> ultrarare.space> wrote:
> Since the commit refers to a (untagged) release, I'd prefer using the
> version string directly instead of a git-version, and adding a comment
> for the commit.  You can take a look at emacs-fennel-mode for an
> example.

Hey Hilton,

This is brilliant, thanks for the feedback.

I think I've updated the patch as requested, including the `guix style'
bit - is it ok if I just add it here as an attachment or should I use
`git send-email' instead?

Let me know if you spot anything else.

Thanks again, best, Fab.

[0001-gnu-emacs-hide-mode-line-Update-to-1.0.3.patch (text/x-diff, inline)]

From 1d2cc850c3e968384998eded9faaab13d6e87483 Mon Sep 17 00:00:00 2001
Message-ID: <1d2cc850c3e968384998eded9faaab13d6e87483.1692615300.git.me <at> fabionatali.com>
From: Fabio Natali <me <at> fabionatali.com>
Date: Mon, 21 Aug 2023 11:47:57 +0100
Subject: [PATCH] gnu: emacs-hide-mode-line: Update to 1.0.3.

* gnu/packages/emacs-xyz.scm (emacs-hide-mode-line): Update to 1.0.3.
---
 gnu/packages/emacs-xyz.scm | 42 +++++++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0f0751e39a..59466b6bda 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34171,25 +34171,29 @@ (define-public emacs-parseclj
     (license license:gpl3+)))
 
 (define-public emacs-hide-mode-line
-  (package
-    (name "emacs-hide-mode-line")
-    (version "1.0.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/hlissner/emacs-hide-mode-line")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0dfzjgxfkcw4wisbyldsm1km18pfp9j8xgadn6qnsz11l55bpgyp"))))
-    (build-system emacs-build-system)
-    (synopsis "Emacs plugin that hides the mode-line")
-    (description "A minor mode that hides the mode-line in your current
-buffer.  It can be used to toggle an alternative mode-line, toggle its visibility,
-or simply disable the mode-line in buffers where it is not very useful.")
-    (home-page "https://github.com/hlissner/emacs-hide-mode-line")
-    (license license:expat)))
+  ;; XXX: Commit below refers to the un-tagged latest release.
+  (let ((commit "bc5d293576c5e08c29e694078b96a5ed85631942"))
+    (package
+      (name "emacs-hide-mode-line")
+      (version "1.0.3")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/hlissner/emacs-hide-mode-line")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "12mfhg0r3gvy59ijy44vsircn251nmisp04k9vvgd2yhykpsr1j6"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/hlissner/emacs-hide-mode-line")
+      (synopsis "Emacs plugin that hides the mode-line")
+      (description
+       "A minor mode that hides the mode-line in your current
+buffer. It can be used to toggle an alternative mode-line, toggle its
+visibility, or simply disable the mode-line in buffers where it is not very
+useful.")
+      (license license:expat))))
 
 (define-public emacs-helm-cider
   (package

base-commit: 3c6b6941a2c76c26ebf0c1bfd7f901a22c19dce1
-- 
2.41.0

Message #16 received at 65150-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Fabio Natali <me <at> fabionatali.com>
Cc: 65150-done <at> debbugs.gnu.org
Subject: Re: [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to
 1.0.3-0.bc5d293.
Date: Sun, 27 Aug 2023 11:53:05 +0800

Hi Fabio,

On Tue, 08 Aug 2023 21:53:40 +0800,
Fabio Natali wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-hide-mode-line): Update to 1.0.3.
> ---

I have addressed a lint warning regarding the description.  Applied as
262efbf9b1bc3d589501d7291d5373a57c04c81b, thank you!

Message #19 received at 65150-done <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 65150-done <at> debbugs.gnu.org
Subject: Re: [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to
 1.0.3-0.bc5d293.
Date: Sun, 27 Aug 2023 10:22:28 +0100

On 2023-08-27, 11:53 +0800, Hilton Chain <hako <at> ultrarare.space> wrote:
> Applied as 262efbf9b1bc3d589501d7291d5373a57c04c81b, thank you!

Brilliant, thank you Hilton! Fabio. 🙏

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.