GNU bug report logs - #65194
[PATCH] gnu: add python-altgraph.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65194 in the body.
You can then email your comments to 65194 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Ford <fanquake <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add python-altgraph.
Date: Thu, 10 Aug 2023 10:41:52 +0200

[Message part 1 (text/plain, inline)]

From c3a2be87c3f2fc4e39e765444e4e08047998bf8a Mon Sep 17 00:00:00 2001
From: fanquake <fanquake <at> gmail.com>
Date: Thu, 10 Aug 2023 10:35:02 +0200
Subject: [PATCH] gnu: add python-altgraph.

* gnu/packages/python-xyz.scm (python-altgraph): New variable.
---
 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b8e8097c7b..8403386277 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11369,6 +11369,28 @@ (define-public python-toposort
 algorithm.")
     (license license:asl2.0)))

+(define-public python-altgraph
+  (package
+    (name "python-altgraph")
+    (version "0.17.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ronaldoussoren/altgraph")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0n9qw0xxss4sbpys5hh1gbzy0bfjkaf4h8fd27vprnbix6q6zlvp"))))
+    (build-system pyproject-build-system)
+    (home-page "https://github.com/ronaldoussoren/altgraph")
+    (synopsis "Python graph (network) package")
+    (description
+     "altgraph is a fork of graphlib: a graph (network) package for
+constructing graphs, BFS and DFS traversals, topological sort, shortest
paths,
+etc. with graphviz output.")
+    (license license:expat)))
+
 (define-public python-three-merge
   (package
     (name "python-three-merge")
-- 
2.41.0

[Message part 2 (text/html, inline)]

Message #8 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 65194 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>, fanquake <fanquake <at> gmail.com>
Subject: [PATCH v2] gnu: Add python-altgraph.
Date: Fri, 29 Sep 2023 15:30:01 +0800

From: fanquake <fanquake <at> gmail.com>

* gnu/packages/python-xyz.scm (python-altgraph): New variable.
---

V1 -> V2:
 - 0.17.3->0.17.4.
 - Adjust description.
 - Rebase.

 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d3d91480ac..a03bbbd4de 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11493,6 +11493,28 @@ (define-public python-toposort
 algorithm.")
     (license license:asl2.0)))
 
+(define-public python-altgraph
+  (package
+    (name "python-altgraph")
+    (version "0.17.4")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ronaldoussoren/altgraph")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "03cingygy7k8cg1l7ffxyrsva1a87y0is14wp04y7zazjab12w87"))))
+    (build-system pyproject-build-system)
+    (home-page "https://github.com/ronaldoussoren/altgraph")
+    (synopsis "Python graph (network) package")
+    (description
+     "@code{altgraph} is a graph (network) package for constructing graphs, BFS
+and DFS traversals, topological sort, shortest paths, etc. with graphviz output.
+")
+    (license license:expat)))
+
 (define-public python-three-merge
   (package
     (name "python-three-merge")

base-commit: 1b0ec97bce2db93ec4159a13fb0a184f012df4fe
-- 
2.41.0

Message #11 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 65194 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>, fanquake <fanquake <at> gmail.com>
Subject: [PATCH v3] gnu: Add python-altgraph.
Date: Fri, 29 Sep 2023 19:33:05 +0800

From: fanquake <fanquake <at> gmail.com>

* gnu/packages/python-xyz.scm (python-altgraph): New variable.
---

V2 -> V3:
 - Correct license to expat-0.

V1 -> V2:
 - 0.17.3->0.17.4.
 - Adjust description.
 - Rebase.

 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d3d91480ac..ec0283838e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11493,6 +11493,28 @@ (define-public python-toposort
 algorithm.")
     (license license:asl2.0)))
 
+(define-public python-altgraph
+  (package
+    (name "python-altgraph")
+    (version "0.17.4")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ronaldoussoren/altgraph")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "03cingygy7k8cg1l7ffxyrsva1a87y0is14wp04y7zazjab12w87"))))
+    (build-system pyproject-build-system)
+    (home-page "https://github.com/ronaldoussoren/altgraph")
+    (synopsis "Python graph (network) package")
+    (description
+     "@code{altgraph} is a graph (network) package for constructing graphs, BFS
+and DFS traversals, topological sort, shortest paths, etc. with graphviz output.
+")
+    (license license:expat-0)))
+
 (define-public python-three-merge
   (package
     (name "python-three-merge")

base-commit: 1b0ec97bce2db93ec4159a13fb0a184f012df4fe
-- 
2.41.0

Message #14 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Hilton Chain" <hako <at> ultrarare.space>, 65194 <at> debbugs.gnu.org
Cc: Munyoki Kilyungi <me <at> bonfacemunyoki.com>, fanquake <fanquake <at> gmail.com>,
 Lars-Dominik Braun <lars <at> 6xq.net>, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Sat, 30 Sep 2023 02:09:10 +0000

Hi Guixers,

Thanks for the patches.

Can you also patch these methods to use our binarie executables in Guix?

https://github.com/ronaldoussoren/altgraph/blob/master/altgraph_tests/test_dot.py#L52

Lars or someone else,

Feel free to let me know if not needed. I'm unsure of when we should and shouldn't for Python libraries sometimes.

Should we document our policy for that in the manual?

all best,

jgart

Message #17 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: Munyoki Kilyungi <me <at> bonfacemunyoki.com>
To: jgart <jgart <at> dismail.de>, Hilton Chain <hako <at> ultrarare.space>,
 65194 <at> debbugs.gnu.org
Cc: fanquake <fanquake <at> gmail.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Mon, 02 Oct 2023 11:14:54 +0300

[Message part 1 (text/plain, inline)]

"jgart" <jgart <at> dismail.de> aliandika:

> Hi Guixers,
>
> Thanks for the patches.
>
> Can you also patch these methods to use our binarie executables in Guix?
>
> https://github.com/ronaldoussoren/altgraph/blob/master/altgraph_tests/test_dot.py#L52
>
I've done a build of python-alt-graph and it
builds just file, tests and all so ...
> Lars or someone else,
>
> Feel free to let me know if not needed. I'm unsure of when we should and shouldn't for Python libraries sometimes.
>

I doubt we need to patch the tests ase you had
earlier indicated since the tests still pass---I
don't know why though.
Just my 2¢s.

> Should we document our policy for that in the manual?
>
> all best,
>
> jgart

-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Munyoki Kilyungi" <me <at> bonfacemunyoki.com>, "Hilton Chain"
 <hako <at> ultrarare.space>, 65194 <at> debbugs.gnu.org
Cc: fanquake <fanquake <at> gmail.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 Marius  Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Mon, 02 Oct 2023 13:59:58 +0000

Hi Bonface,

Thanks for reviewing and testing.

Ok,

I also think that this patch is good to go. If someone else thinks we should patch just reply to comment or we can take care of that in a future ticket so as to not block this one.

I'll try to merge this by tonight/tomorrow after I do another review and test.

all best,

jgart

Message #23 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Munyoki Kilyungi" <me <at> bonfacemunyoki.com>, "Hilton Chain"
 <hako <at> ultrarare.space>
Cc: 65194 <at> debbugs.gnu.org, fanquake <fanquake <at> gmail.com>,
 Lars-Dominik Braun <lars <at> 6xq.net>, Marius  Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Tue, 03 Oct 2023 13:32:49 +0000

Hi fanquake,

Why not use the PyPi source if it includes the tests?

It is what the importer would have produced:

$ guix import pypi altgraph

Starting download of /tmp/guix-file.mH76On
From https://files.pythonhosted.org/packages/de/a8/7145824cf0b9e3c28046520480f207df47e927df83aa9555fb47f8505922/altgraph-0.17.4.tar.gz...
 …17.4.tar.gz  47KiB                  835KiB/s 00:00 ▕██████████████████▏ 100.0%

Starting download of /tmp/guix-file.j6I6jB
From https://files.pythonhosted.org/packages/4d/3f/3bc3f1d83f6e4a7fcb834d3720544ca597590425be5ba9db032b2bf322a2/altgraph-0.17.4-py2.py3-none-any.whl...
 …2.py3-none-any.whl  21KiB           1.8MiB/s 00:00 ▕██████████████████▏ 100.0%
(package
  (name "python-altgraph")
  (version "0.17.4")
  (source
   (origin
     (method url-fetch)
     (uri (pypi-uri "altgraph" version))
     (sha256
      (base32 "01j48np3g50g6insjkszsz0vifwlm6gspria5vdwlkbciywznnhv"))))
  (build-system pyproject-build-system)
  (home-page "https://altgraph.readthedocs.io")
  (synopsis "Python graph (network) package")
  (description "Python graph (network) package")

all best,

jgart

Message #26 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: Michael Ford <fanquake <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: Munyoki Kilyungi <me <at> bonfacemunyoki.com>,
 Hilton Chain <hako <at> ultrarare.space>, 65194 <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Tue, 3 Oct 2023 15:26:13 +0100

[Message part 1 (text/plain, inline)]

Hi jgart,

I'm happy for this to be changed in whatever way is best for inclusion in
Guix.
The original patch I submitted, came from a manifest in a different
project, where
we have just been using the source, and were not running the tests. If the
PyPi souce
would be a better fit here, that is fine with me.

Thanks,

Michael

On Tue, 3 Oct 2023 at 14:32, jgart <jgart <at> dismail.de> wrote:

> Hi fanquake,
>
> Why not use the PyPi source if it includes the tests?
>
> It is what the importer would have produced:
>
> $ guix import pypi altgraph
>
> Starting download of /tmp/guix-file.mH76On
> From
> https://files.pythonhosted.org/packages/de/a8/7145824cf0b9e3c28046520480f207df47e927df83aa9555fb47f8505922/altgraph-0.17.4.tar.gz.
> ..
>  …17.4.tar.gz  47KiB                  835KiB/s 00:00 ▕██████████████████▏
> 100.0%
>
> Starting download of /tmp/guix-file.j6I6jB
> From
> https://files.pythonhosted.org/packages/4d/3f/3bc3f1d83f6e4a7fcb834d3720544ca597590425be5ba9db032b2bf322a2/altgraph-0.17.4-py2.py3-none-any.whl.
> ..
>  …2.py3-none-any.whl  21KiB           1.8MiB/s 00:00 ▕██████████████████▏
> 100.0%
> (package
>   (name "python-altgraph")
>   (version "0.17.4")
>   (source
>    (origin
>      (method url-fetch)
>      (uri (pypi-uri "altgraph" version))
>      (sha256
>       (base32 "01j48np3g50g6insjkszsz0vifwlm6gspria5vdwlkbciywznnhv"))))
>   (build-system pyproject-build-system)
>   (home-page "https://altgraph.readthedocs.io")
>   (synopsis "Python graph (network) package")
>   (description "Python graph (network) package")
>
> all best,
>
> jgart
>

[Message part 2 (text/html, inline)]

Message #29 received at 65194 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Michael Ford" <fanquake <at> gmail.com>
Cc: Munyoki Kilyungi <me <at> bonfacemunyoki.com>,
 Hilton Chain <hako <at> ultrarare.space>, 65194 <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Tue, 03 Oct 2023 16:49:56 +0000

Our usual informal protocol in the past for Python packages has been if the PyPi sources have the tests then we prefer that.

We maybe should formally document the policy to avoid these confusions like this.

Lars or another veteran Guix contributor could you confirm that this is indeed what we should do?

Michael,

Can you send a v4 patch for that?

all best,

jgart

Message #34 received at 65194-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Michael Ford" <fanquake <at> gmail.com>
Cc: Munyoki Kilyungi <me <at> bonfacemunyoki.com>,
 Hilton Chain <hako <at> ultrarare.space>, Lars-Dominik Braun <lars <at> 6xq.net>,
 65194-done <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Wed, 04 Oct 2023 01:51:19 +0000

Hi Guixers,

I applied the patch with some small changes in 0c6198319a.

I fixed up the description and synopsis a bit and added python-pytest as a native-input since the pyproject-build-system does not include it so test wouldn't be run otherwise.

Thanks for your contributions and review to everyone involved. It is much appreciated!

all best,

jgart

Message #37 received at 65194-done <at> debbugs.gnu.org (full text, mbox):

From: Munyoki Kilyungi <me <at> bonfacemunyoki.com>
To: jgart <jgart <at> dismail.de>, Michael Ford <fanquake <at> gmail.com>
Cc: 65194-done <at> debbugs.gnu.org, Hilton Chain <hako <at> ultrarare.space>,
 Lars-Dominik Braun <lars <at> 6xq.net>, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#65194] [PATCH v3] gnu: Add python-altgraph.
Date: Wed, 04 Oct 2023 13:04:35 +0300

[Message part 1 (text/plain, inline)]

"jgart" <jgart <at> dismail.de> aliandika:

> Hi Guixers,
>
> I applied the patch with some small changes in 0c6198319a.
>
> I fixed up the description and synopsis a bit and added python-pytest as a native-input since the pyproject-build-system does not include it so test wouldn't be run otherwise.
>
Nice!  Thanks for the effort +1


-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.