GNU bug report logs - #65337
[PATCH] gnu: picard: Update to 2.9.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65337 in the body.
You can then email your comments to 65337 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH] gnu: picard: Update to 2.9.1.
Date: Wed, 16 Aug 2023 17:35:54 +0800

* gnu/packages/music.scm (picard): Update to 2.9.1.
[url]: Switch mirror.
[#:phases]: Add phase 'set-HOME.
Remove phase 'delete-failing-test.
---
 gnu/packages/music.scm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 8681bb1c10..266022d4a8 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -3780,15 +3780,15 @@ (define-public pianobar
 (define-public picard
   (package
     (name "picard")
-    (version "2.9")
+    (version "2.9.1")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://musicbrainz.osuosl.org/pub/musicbrainz/"
+                    "https://data.musicbrainz.org/pub/musicbrainz/"
                     "picard/picard-" version ".tar.gz"))
               (sha256
                (base32
-                "0afiziaq49sq1dx5r3qis4ymhhkrqlrkfnb6f7gcksj0kwljvsw9"))))
+                "1f1nf53xm94jam8w86a8hx69ilzddjibf29c7f1i353fr6k6bqvs"))))
     (build-system python-build-system)
     (arguments
      (list
@@ -3806,12 +3806,10 @@ (define-public picard
                  (string-append
                   "pyfpcalc', '"
                   (assoc-ref inputs "chromaprint") "/bin/fpcalc")))))
-          (add-before 'check 'delete-failing-test
+          ;; pipe tests require writable $HOME.
+          (add-before 'check 'set-HOME
             (lambda _
-              ;; FIXME: This test fails in build environment.
-              ;; util/pipe.read_from_pipe:244: pipe reader exception:
-              ;; ERROR: Pipe doesn't exist
-              (delete-file "test/test_util_pipe.py"))))))
+              (setenv "HOME" "/tmp"))))))
     (native-inputs
      (list gettext-minimal python-dateutil))
     (inputs

base-commit: 603db2ad71deef6c88e71ec53e5626c1d965fe46
-- 
2.41.0

Message #10 received at 65337-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 65337-done <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: Re: [bug#65337] [PATCH] gnu: picard: Update to 2.9.1.
Date: Sun, 27 Aug 2023 12:06:55 +0800

On Wed, 16 Aug 2023 17:35:54 +0800,
Hilton Chain wrote:
> 
> * gnu/packages/music.scm (picard): Update to 2.9.1.
> [url]: Switch mirror.
> [#:phases]: Add phase 'set-HOME.
> Remove phase 'delete-failing-test.
> ---

Applied as 0ba7debb02ebcc9c27659b1f5af7d12c36474985, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.