GNU bug report logs - #65444
[PATCH] gnu-maintenance: Improve check for disabled host names.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65444 in the body.
You can then email your comments to 65444 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org,
	maxim.cournoyer <at> gmail.com
Subject: [PATCH] gnu-maintenance: Improve check for disabled host names.
Date: Mon, 21 Aug 2023 16:56:21 -0400

Found while investigating <https://issues.guix.gnu.org/65304>.

* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---

 guix/gnu-maintenance.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@ (define html-updatable-package?
                           (let ((scheme (uri-scheme uri))
                                 (host   (uri-host uri)))
                             (and (memq scheme '(http https))
-                                 (not (member host hosting-sites)))))))))
+                                 ;; HOST may contain prefixes,
+                                 ;; e.g. "profanity-im.github.io", hence the
+                                 ;; suffix-based test below.
+                                 (not (any (cut string-suffix? <> host)
+                                           hosting-sites)))))))))
 
     (lambda (package)
       (or (assoc-ref (package-properties package) 'release-monitoring-url)

base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b
-- 
2.41.0

Message #8 received at 65444 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 65444 <at> debbugs.gnu.org,
 Ricardo Wurmus <rekado <at> elephly.net>, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#65444] [PATCH] gnu-maintenance: Improve check for disabled
 host names.
Date: Tue, 22 Aug 2023 18:28:30 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Found while investigating <https://issues.guix.gnu.org/65304>.
>
> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.

LGTM!

Message #13 received at 65444-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 65444-done <at> debbugs.gnu.org,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: bug#65444: [PATCH] gnu-maintenance: Improve check for disabled
 host names.
Date: Fri, 25 Aug 2023 10:08:37 -0400

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> Found while investigating <https://issues.guix.gnu.org/65304>.
>>
>> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
>
> LGTM!

This change was installed with
c655231b72ac28b5a433069fcf86a835c9c83691.  Thanks for the review!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.