GNU bug report logs - #65449
30.0.50; [PATCH] strokes: Support running other function when no stroke matches

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65449 in the body.
You can then email your comments to 65449 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] strokes: Support running other function when no
 stroke matches
Date: Tue, 22 Aug 2023 14:25:24 +0800

[Message part 1 (text/plain, inline)]

Hi,

This patch allows users to call another function when no stroke
matches, instead of signaling an error. I bind down-mouse-3 to
strokes-do-stroke, and would like to pop up the context menu when no
stroke matches. In addition, two arguments stroke and match can be
passed to the function for other uses (e.g. making the error message
more informative).

[0001-strokes-Support-running-other-function-when-no-strok.patch (text/x-patch, attachment)]

Message #8 received at 65449 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 65449 <at> debbugs.gnu.org
Subject: Re: bug#65449: 30.0.50;
 [PATCH] strokes: Support running other function when no stroke matches
Date: Tue, 22 Aug 2023 14:17:28 +0300

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Tue, 22 Aug 2023 14:25:24 +0800
> 
> This patch allows users to call another function when no stroke
> matches, instead of signaling an error. I bind down-mouse-3 to
> strokes-do-stroke, and would like to pop up the context menu when no
> stroke matches. In addition, two arguments stroke and match can be
> passed to the function for other uses (e.g. making the error message
> more informative).

Thanks.  This is a useful extension, IMO, but please extend the doc
string of strokes-no-match-function to explain how it will be called
and what is expected from it, including the expected return value(s)
and their meaning.

Message #11 received at 65449 <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65449 <at> debbugs.gnu.org
Subject: Re: bug#65449: 30.0.50; [PATCH] strokes: Support running other
 function when no stroke matches
Date: Tue, 22 Aug 2023 21:50:58 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> 于2023年8月22日周二 19:17写道：
>
> Thanks.  This is a useful extension, IMO, but please extend the doc
> string of strokes-no-match-function to explain how it will be called
> and what is expected from it, including the expected return value(s)
> and their meaning.

I have updated the doc string in the attached patch. However, the
return value cannot be specified because the return value of
`strokes-execute-stroke' is not specified, i.e., `command-execute'
could return any value.

[0001-strokes-Support-running-other-function-when-no-strok.patch (text/x-patch, attachment)]

Message #14 received at 65449 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 65449 <at> debbugs.gnu.org
Subject: Re: bug#65449: 30.0.50; [PATCH] strokes: Support running other
 function when no stroke matches
Date: Tue, 22 Aug 2023 19:05:47 +0300

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Tue, 22 Aug 2023 21:50:58 +0800
> Cc: 65449 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> 于2023年8月22日周二 19:17写道：
> >
> > Thanks.  This is a useful extension, IMO, but please extend the doc
> > string of strokes-no-match-function to explain how it will be called
> > and what is expected from it, including the expected return value(s)
> > and their meaning.
> 
> I have updated the doc string in the attached patch. However, the
> return value cannot be specified because the return value of
> `strokes-execute-stroke' is not specified, i.e., `command-execute'
> could return any value.

Thanks, looks reasonable.

Let's wait for a few days, to give others a chance to chime in and
voice comments.  If nothing serious comes up, I will install this in a
few days.

Message #19 received at 65449-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: liuhui1610 <at> gmail.com
Cc: 65449-done <at> debbugs.gnu.org
Subject: Re: bug#65449: 30.0.50;
 [PATCH] strokes: Support running other function when no stroke matches
Date: Thu, 31 Aug 2023 12:32:11 +0300

> Cc: 65449 <at> debbugs.gnu.org
> Date: Tue, 22 Aug 2023 19:05:47 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Liu Hui <liuhui1610 <at> gmail.com>
> > Date: Tue, 22 Aug 2023 21:50:58 +0800
> > Cc: 65449 <at> debbugs.gnu.org
> > 
> > I have updated the doc string in the attached patch. However, the
> > return value cannot be specified because the return value of
> > `strokes-execute-stroke' is not specified, i.e., `command-execute'
> > could return any value.
> 
> Thanks, looks reasonable.
> 
> Let's wait for a few days, to give others a chance to chime in and
> voice comments.  If nothing serious comes up, I will install this in a
> few days.

No further comments, so I've now installed this on the master branch,
and I'm closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.