GNU bug report logs - #65504
[PATCH] gnu: emilua: Update to 0.4.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65504 in the body.
You can then email your comments to 65504 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Valter Sage <manipuladordedados <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emilua: Update to 0.4.3
Date: Thu, 24 Aug 2023 08:15:30 -0300

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-gnu-emilua-Update-to-0.4.3.patch (text/x-patch, attachment)]

Message #10 received at 65504-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Valter Sage <manipuladordedados <at> gmail.com>
Cc: 65504-done <at> debbugs.gnu.org
Subject: Re: [bug#65504] [PATCH] gnu: emilua: Update to 0.4.3
Date: Wed, 13 Sep 2023 09:35:30 +0100

[Message part 1 (text/plain, inline)]

Hi Valter,

I started looking at this as it had passed QA, although while it
arguably hadn't made the situation worse, the package looks to have been
failing to build before, and it was still failing to build with these
changes.

guix lint also was reporting a load of new issues:

→ ./pre-inst-env guix lint emilua
gnu/packages/lua.scm:1188:8: emilua <at> 0.4.3: label 'fmt-8' does not match package name 'fmt'
gnu/packages/lua.scm:1188:8: emilua <at> 0.4.3: label 'gcc-12' does not match package name 'gcc'
gnu/packages/lua.scm:1151:8: emilua <at> 0.4.3: invalid phase clause
gnu/packages/lua.scm:1151:3: emilua <at> 0.4.3: tabulation on line 1151, column 3
gnu/packages/lua.scm:1155:11: emilua <at> 0.4.3: tabulation on line 1155, column 11
gnu/packages/lua.scm:1156:11: emilua <at> 0.4.3: tabulation on line 1156, column 11
gnu/packages/lua.scm:1157:11: emilua <at> 0.4.3: tabulation on line 1157, column 11
gnu/packages/lua.scm:1161:0: emilua <at> 0.4.3: trailing white space on line 1161
gnu/packages/lua.scm:1166:0: emilua <at> 0.4.3: line 1166 is way too long (95 characters)
gnu/packages/lua.scm:1167:0: emilua <at> 0.4.3: trailing white space on line 1167
gnu/packages/lua.scm:1174:6: emilua <at> 0.4.3: tabulation on line 1174, column 6
gnu/packages/lua.scm:1175:6: emilua <at> 0.4.3: tabulation on line 1175, column 6
gnu/packages/lua.scm:1176:6: emilua <at> 0.4.3: tabulation on line 1176, column 6
gnu/packages/lua.scm:1179:0: emilua <at> 0.4.3: trailing white space on line 1179
gnu/packages/lua.scm:1188:3: emilua <at> 0.4.3: tabulation on line 1188, column 3
gnu/packages/lua.scm:1196:0: emilua <at> 0.4.3: parentheses feel lonely, move to the previous or next line
gnu/packages/lua.scm:1203:25: emilua <at> 0.4.3: tabulation on line 1203, column 25
gnu/packages/lua.scm:1204:0: emilua <at> 0.4.3: trailing white space on line 1204
gnu/packages/lua.scm:1204:0: emilua <at> 0.4.3: line 1204 is way too long (137 characters)
gnu/packages/lua.scm:1205:0: emilua <at> 0.4.3: trailing white space on line 1205
gnu/packages/lua.scm:1206:0: emilua <at> 0.4.3: tabulation on line 1206, column 0
gnu/packages/lua.scm:1207:0: emilua <at> 0.4.3: tabulation on line 1207, column 0
gnu/packages/lua.scm:1208:0: emilua <at> 0.4.3: tabulation on line 1208, column 0
gnu/packages/lua.scm:1209:0: emilua <at> 0.4.3: tabulation on line 1209, column 0
gnu/packages/lua.scm:1210:0: emilua <at> 0.4.3: tabulation on line 1210, column 0
gnu/packages/lua.scm:1211:0: emilua <at> 0.4.3: tabulation on line 1211, column 0
gnu/packages/lua.scm:1212:0: emilua <at> 0.4.3: tabulation on line 1212, column 0
gnu/packages/lua.scm:1213:0: emilua <at> 0.4.3: tabulation on line 1213, column 0
gnu/packages/lua.scm:1214:0: emilua <at> 0.4.3: tabulation on line 1214, column 0
gnu/packages/lua.scm:1215:0: emilua <at> 0.4.3: tabulation on line 1215, column 0


I've now gone through and fixed all these, the "invalid build clause" as
mentioned by guix lint was what was causing the package to fail to
build. Luckily, I also saw the patch posted to #65515, so I've merged
those changes in here.

Other small tweaks I made include using with-directory-excursion in the
arguments, and removing gawk as a native-input (I think the build system
provides gawk).

I've pushed this to master as 10bc07671e2a3a699d4f56e405f50d766323319a.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.