GNU bug report logs - #65589
[PATCH emacs-team] gnu: emacs-rainbow-delimiters: Fix tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65589 in the body.
You can then email your comments to 65589 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH emacs-team] gnu: emacs-rainbow-delimiters: Fix tests.
Date: Tue, 29 Aug 2023 11:23:30 +0800

* gnu/packages/emacs-xyz.scm (emacs-rainbow-delimiters): Adjust tests for
Emacs 29.
---
 gnu/packages/emacs-xyz.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3514ae5fbe..1318ac57ae 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14171,6 +14171,12 @@ (define-public emacs-rainbow-delimiters
                     (url "https://github.com/Fanael/rainbow-delimiters")
                     (commit version)))
               (file-name (git-file-name name version))
+              ;; Fix tests for Emacs 29
+              ;; https://github.com/Fanael/rainbow-delimiters/pull/78
+              (modules '((guix build utils)))
+              (snippet '(substitute* "rainbow-delimiters-test.el"
+                          (("category c-type " all)
+                           (string-append all "c-<>-c-types-set "))))
               (sha256
                (base32
                 "179mzsd8nvlr0ym9zf9fgdngsgxj3kdgbjblynliirsyk05ssrwc"))))

base-commit: 9d074e16c7a9879d67c348c7b2d70b725adfbdfa
-- 
2.41.0

Message #8 received at 65589 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Hilton Chain <hako <at> ultrarare.space>, 65589 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#65589] [PATCH emacs-team] gnu: emacs-rainbow-delimiters:
 Fix tests.
Date: Sun, 03 Sep 2023 08:20:12 +0400

[Message part 1 (text/plain, inline)]

On 2023-08-29 11:23, Hilton Chain wrote:

> * gnu/packages/emacs-xyz.scm (emacs-rainbow-delimiters): Adjust tests for
> Emacs 29.
> ---
>  gnu/packages/emacs-xyz.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 3514ae5fbe..1318ac57ae 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -14171,6 +14171,12 @@ (define-public emacs-rainbow-delimiters
>                      (url "https://github.com/Fanael/rainbow-delimiters")
>                      (commit version)))
>                (file-name (git-file-name name version))
> +              ;; Fix tests for Emacs 29
> +              ;; https://github.com/Fanael/rainbow-delimiters/pull/78
> +              (modules '((guix build utils)))
> +              (snippet '(substitute* "rainbow-delimiters-test.el"
> +                          (("category c-type " all)
> +                           (string-append all "c-<>-c-types-set "))))
>                (sha256
>                 (base32
>                  "179mzsd8nvlr0ym9zf9fgdngsgxj3kdgbjblynliirsyk05ssrwc"))))
>
> base-commit: 9d074e16c7a9879d67c348c7b2d70b725adfbdfa

I see the the pull request in the comment merged, is this patch still
relevant?

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 65589 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Andrew Tropin <andrew <at> trop.in>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 65589 <at> debbugs.gnu.org
Subject: Re: [bug#65589] [PATCH emacs-team] gnu: emacs-rainbow-delimiters: Fix
 tests.
Date: Sun, 03 Sep 2023 15:35:17 +0800

On Sun, 03 Sep 2023 12:20:12 +0800,
Andrew Tropin wrote:
>
> I see the the pull request in the comment merged, is this patch still
> relevant?

Still relevant.  I opened the pull request right before sending this
patch, it's now merged but not in a release.

Message #16 received at 65589-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 65589-done <at> debbugs.gnu.org
Subject: Re: [bug#65589] [PATCH emacs-team] gnu: emacs-rainbow-delimiters:
 Fix tests.
Date: Mon, 04 Sep 2023 09:06:03 +0400

[Message part 1 (text/plain, inline)]

On 2023-09-03 15:35, Hilton Chain wrote:

> On Sun, 03 Sep 2023 12:20:12 +0800,
> Andrew Tropin wrote:
>>
>> I see the the pull request in the comment merged, is this patch still
>> relevant?
>
> Still relevant.  I opened the pull request right before sending this
> patch, it's now merged but not in a release.

I see.  Thank you for your work!  Applied, checked the build, merged.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.