GNU bug report logs - #65611
[PATCH] gnu: emacs-dired-preview: Add Info manual.

Previous Next

Package: guix-patches;

Reported by: fernseed <at> fernseed.me

Date: Wed, 30 Aug 2023 07:19:03 UTC

Severity: normal

Tags: patch

Done: Andrew Tropin <andrew <at> trop.in>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65611 in the body.
You can then email your comments to 65611 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#65611; Package guix-patches. (Wed, 30 Aug 2023 07:19:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to fernseed <at> fernseed.me:
New bug report received and forwarded. Copy sent to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org. (Wed, 30 Aug 2023 07:19:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: fernseed <at> fernseed.me
To: guix-patches <at> gnu.org
Cc: Kierin Bell <fernseed <at> fernseed.me>
Subject: [PATCH] gnu: emacs-dired-preview: Add Info manual.
Date: Tue, 29 Aug 2023 13:57:12 -0400

From: Kierin Bell <fernseed <at> fernseed.me>

* gnu/packages/emacs-xyz.scm (emacs-dired-preview): Add Info manual.
---
 gnu/packages/emacs-xyz.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3eaf215134..05f1488650 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27347,6 +27347,21 @@ (define-public emacs-dired-preview
                (base32
                 "0d485812k1rv0qrw4xvzv4z3qf370apsajnf4q3pjk3q0r1fpm8b"))))
     (build-system emacs-build-system)
+    (native-inputs (list texinfo))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'makeinfo
+            (lambda _
+              (invoke "emacs"
+                      "--batch"
+                      "--eval=(require 'ox-texinfo)"
+                      "--eval=(find-file \"README.org\")"
+                      "--eval=(org-texinfo-export-to-info)")
+              (install-file "dired-preview.info"
+                            (string-append #$output
+                                           "/share/info")))))))
     (home-page "https://protesilaos.com/emacs/dired-preview")
     (synopsis "Automatically preview file at point in Dired")
     (description

base-commit: 9f4b6bcb5c548f9206b89270b13da54abdff31b1
-- 
2.41.0
Reply sent to Andrew Tropin <andrew <at> trop.in>:
You have taken responsibility. (Wed, 30 Aug 2023 11:51:02 GMT) Full text and rfc822 format available.
Notification sent to fernseed <at> fernseed.me:
bug acknowledged by developer. (Wed, 30 Aug 2023 11:51:03 GMT) Full text and rfc822 format available.

Message #10 received at 65611-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: fernseed <at> fernseed.me, 65611-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Kierin Bell <fernseed <at> fernseed.me>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#65611] [PATCH] gnu: emacs-dired-preview: Add Info manual.
Date: Wed, 30 Aug 2023 15:49:59 +0400

[Message part 1 (text/plain, inline)]
On 2023-08-29 13:57, fernseed <at> fernseed.me wrote:

> From: Kierin Bell <fernseed <at> fernseed.me>
>
> * gnu/packages/emacs-xyz.scm (emacs-dired-preview): Add Info manual.
> ---
>  gnu/packages/emacs-xyz.scm | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 3eaf215134..05f1488650 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -27347,6 +27347,21 @@ (define-public emacs-dired-preview
>                 (base32
>                  "0d485812k1rv0qrw4xvzv4z3qf370apsajnf4q3pjk3q0r1fpm8b"))))
>      (build-system emacs-build-system)
> +    (native-inputs (list texinfo))
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'install 'makeinfo
> +            (lambda _
> +              (invoke "emacs"
> +                      "--batch"
> +                      "--eval=(require 'ox-texinfo)"
> +                      "--eval=(find-file \"README.org\")"
> +                      "--eval=(org-texinfo-export-to-info)")
> +              (install-file "dired-preview.info"
> +                            (string-append #$output
> +                                           "/share/info")))))))
>      (home-page "https://protesilaos.com/emacs/dired-preview")
>      (synopsis "Automatically preview file at point in Dired")
>      (description
>
> base-commit: 9f4b6bcb5c548f9206b89270b13da54abdff31b1

Applied, pushed, good job! (:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=23d2bdfdfa

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#65611; Package guix-patches. (Wed, 30 Aug 2023 16:49:02 GMT) Full text and rfc822 format available.

Message #13 received at 65611-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>, fernseed <at> fernseed.me, 
 65611-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>
Subject: Re: [bug#65611] [PATCH] gnu: emacs-dired-preview: Add Info manual.
Date: Wed, 30 Aug 2023 18:48:20 +0200

Am Mittwoch, dem 30.08.2023 um 15:49 +0400 schrieb Andrew Tropin:
> On 2023-08-29 13:57, fernseed <at> fernseed.me wrote:
> 
> > From: Kierin Bell <fernseed <at> fernseed.me>
> > 
> > * gnu/packages/emacs-xyz.scm (emacs-dired-preview): Add Info
> > manual.
> > ---
> >  gnu/packages/emacs-xyz.scm | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-
> > xyz.scm
> > index 3eaf215134..05f1488650 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -27347,6 +27347,21 @@ (define-public emacs-dired-preview
> >                 (base32
> >                 
> > "0d485812k1rv0qrw4xvzv4z3qf370apsajnf4q3pjk3q0r1fpm8b"))))
> >      (build-system emacs-build-system)
> > +    (native-inputs (list texinfo))
> > +    (arguments
> > +     (list
> > +      #:phases
> > +      #~(modify-phases %standard-phases
> > +          (add-after 'install 'makeinfo
> > +            (lambda _
> > +              (invoke "emacs"
> > +                      "--batch"
> > +                      "--eval=(require 'ox-texinfo)"
> > +                      "--eval=(find-file \"README.org\")"
> > +                      "--eval=(org-texinfo-export-to-info)")
> > +              (install-file "dired-preview.info"
> > +                            (string-append #$output
> > +                                           "/share/info")))))))
> >      (home-page "https://protesilaos.com/emacs/dired-preview")
> >      (synopsis "Automatically preview file at point in Dired")
> >      (description
> > 
> > base-commit: 9f4b6bcb5c548f9206b89270b13da54abdff31b1
> 
> Applied, pushed, good job! (:
I don't see this pushed.  More importantly, there is an emacs-batch-
eval procedure.  Please use that.

Cheers
Information forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#65611; Package guix-patches. (Wed, 30 Aug 2023 18:32:02 GMT) Full text and rfc822 format available.

Message #16 received at 65611 <at> debbugs.gnu.org (full text, mbox):

From: fernseed <at> fernseed.me
To: 65611 <at> debbugs.gnu.org
Cc: Kierin Bell <fernseed <at> fernseed.me>
Subject: [PATCH v2] gnu: emacs-dired-preview: Add Info manual.
Date: Wed, 30 Aug 2023 14:25:17 -0400

From: Kierin Bell <fernseed <at> fernseed.me>

* gnu/packages/emacs-xyz.scm (emacs-dired-preview): Add Info manual.
---
Didn't see this pushed yet either.  Updated as per Liliana's suggestion.

 gnu/packages/emacs-xyz.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3eaf215134..62fc008bb2 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27347,6 +27347,18 @@ (define-public emacs-dired-preview
                (base32
                 "0d485812k1rv0qrw4xvzv4z3qf370apsajnf4q3pjk3q0r1fpm8b"))))
     (build-system emacs-build-system)
+    (native-inputs (list texinfo))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'makeinfo
+            (lambda _
+              (emacs-batch-edit-file "README.org"
+                "(progn (require 'ox-texinfo) (org-texinfo-export-to-info))")
+              (install-file "dired-preview.info"
+                            (string-append #$output
+                                           "/share/info")))))))
     (home-page "https://protesilaos.com/emacs/dired-preview")
     (synopsis "Automatically preview file at point in Dired")
     (description

base-commit: 9f4b6bcb5c548f9206b89270b13da54abdff31b1
-- 
2.41.0
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 28 Sep 2023 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 225 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.