GNU bug report logs - #65627
28.2; erc-button-url-regexp does not recognise gophers://

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65627 in the body.
You can then email your comments to 65627 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troels Henriksen <athas <at> sigkill.dk>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; erc-button-url-regexp does not recognise gophers://
Date: Wed, 30 Aug 2023 13:03:31 +0200

The regex in

  browse-url-button-regexp

does not recognise the gophers:// protocol.  Similarly to https://,
gophers:// is an encrypted variant of the venerable Gopher protocol.
The gophers protocol is supported in curl and other programs that build
on libcurl, and while I can customize `browse-url-button-regexp` myself,
I think it would be useful for all Emacs users if Emacs recognised
gophers:// directly.

A fix is simple: just add 's?' after 'gopher' in the regexp.

Message #10 received at 65627-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Troels Henriksen <athas <at> sigkill.dk>
Cc: 65627-done <at> debbugs.gnu.org
Subject: Re: bug#65627: 28.2;
 erc-button-url-regexp does not recognise gophers://
Date: Wed, 30 Aug 2023 21:01:52 +0200

Version: 29.2

> The regex in
>
>   browse-url-button-regexp
>
> does not recognise the gophers:// protocol.  Similarly to https://,
> gophers:// is an encrypted variant of the venerable Gopher protocol.
> The gophers protocol is supported in curl and other programs that build
> on libcurl, and while I can customize `browse-url-button-regexp` myself,
> I think it would be useful for all Emacs users if Emacs recognised
> gophers:// directly.
>
> A fix is simple: just add 's?' after 'gopher' in the regexp.

Thanks for the bug report.

I see that it is supported by libcurl, here: https://curl.se/libcurl/
There is also FTPS, which we don't have in our regexp.

So I've now fixed this on the master branch (commit 9e2d5a013c9), and
I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.