GNU bug report logs - #65646
[PATCH 2/3] gnu: aalib: Really build the shared library on powerpc64le-linux.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>; Keywords: patch; Done: Maxim Cournoyer <maxim.cournoyer@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.
bug closed, send any further explanations to 65646 <at> debbugs.gnu.org and Maxim Cournoyer <maxim.cournoyer@HIDDEN> Request was from Maxim Cournoyer <maxim.cournoyer@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 31 Aug 2023 04:46:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 31 00:46:23 2023
Received: from localhost ([127.0.0.1]:54561 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qbZZW-0000nk-LG
	for submit <at> debbugs.gnu.org; Thu, 31 Aug 2023 00:46:23 -0400
Received: from lists.gnu.org ([2001:470:142::17]:45860)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1qbZZT-0000nU-B5
 for submit <at> debbugs.gnu.org; Thu, 31 Aug 2023 00:46:21 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1qbZZF-0001st-TT
 for guix-patches@HIDDEN; Thu, 31 Aug 2023 00:46:05 -0400
Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1qbZZC-00030b-5J
 for guix-patches@HIDDEN; Thu, 31 Aug 2023 00:46:05 -0400
Received: by mail-qk1-x72f.google.com with SMTP id
 af79cd13be357-76f14d80ea6so24955485a.2
 for <guix-patches@HIDDEN>; Wed, 30 Aug 2023 21:46:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1693457161; x=1694061961; darn=gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=6pYc+TieB/ja9cyZ0VqfIQarfNzVdLrku1htNKeLp9o=;
 b=M3HXp6iJLNl/CrPnm2nQENObP1gTQmVrg5nNKL2eBAYyG/Nhu6o2Pu5N03osPBMshV
 X9mZxDfw4QVIyas9zrlYVP62ZEj8zSj/PxCidZxyepl2jbsXlZiRevY9MtEDT1pNnClM
 e2AqKts0MBjuravg1fDo8f/TACvOs3Vrpw86Hw8SAdotVgyC7L5sUrm/MeemcdhJQcuk
 4JWCCU0oVYcjfJFV7m3K/cm3BRHqpZI3o2XlrCEJWRgzg9rxKGPkAFBrzHiPlStT8JgX
 vpRA6O/lzEkCaBbc7uxydMXBJaWWS6od96pkot5WaBDuVziwD+hxKVW70av8EJaGskOj
 MPTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1693457161; x=1694061961;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=6pYc+TieB/ja9cyZ0VqfIQarfNzVdLrku1htNKeLp9o=;
 b=fpInDejtVEe8PaBoAjJBpAvXaEqETOzFT/630eqfMTKXOfM5uRxNlgMcNie3UcTxjM
 1cG7+zNTTW3d7Ls1E1eGrVPRSEQJkje4u6+TTS3YsfncYgL3g4Sjd+kwhln1sYIqv8aF
 n5/bmNus9Z537ZGV6kV8QcLIhVOyON/4zA7eUoqJTAP3TW7m1wzvAu6av6wneLpA/foL
 KiEi55XkMWtaCECvtU07HVNAL4IOe5B6yOB8S4c8LxdMwlRUkg2/NXzkcpFXaIYW1J1Z
 h+G0C9J1DCv2gJOACnNQmRpbhxpznmylnNTOj4PYxQqmutw35agu3zk0eoQDY58pjNTY
 P5rw==
X-Gm-Message-State: AOJu0YzooFuBukIYSajshXE5DbtCDLfNVRb7LT0RIE1w2vPwL04ceqIw
 kXyBu0pMxXJP6vgzV+xf4iJ6rwaVtPo=
X-Google-Smtp-Source: AGHT+IGZvUNSEFAzNvW3VVLPEax5DF8AUnHoWZiIz8h0M/dnp1mnRgNqx00M1jViO642u/S+ewXYUw==
X-Received: by 2002:a05:620a:44d1:b0:767:f49c:1d67 with SMTP id
 y17-20020a05620a44d100b00767f49c1d67mr2092668qkp.1.1693457161015; 
 Wed, 30 Aug 2023 21:46:01 -0700 (PDT)
Received: from localhost.localdomain (dsl-10-128-23.b2b2c.ca. [72.10.128.23])
 by smtp.gmail.com with ESMTPSA id
 p17-20020a0ce191000000b0064f4d3bc78csm277003qvl.61.2023.08.30.21.46.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 30 Aug 2023 21:46:00 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: guix-patches@HIDDEN,
	maxim.cournoyer@HIDDEN
Subject: [PATCH 2/3] gnu: aalib: Really build the shared library on
 powerpc64le-linux.
Date: Thu, 31 Aug 2023 00:45:27 -0400
Message-ID: <bc36d1337cb2fa3e3acfc2a047965df766542a6b.1693457128.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <9e32eeeef4dbc36eb02098925f7567b4cce50363.1693457127.git.maxim.cournoyer@HIDDEN>
References: <9e32eeeef4dbc36eb02098925f7567b4cce50363.1693457127.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::72f;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qk1-x72f.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Marcel van der Boom <marcel@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Fixes <https://issues.guix.gnu.org/57134>.

The old build scripts were buggy and causing a static library to be produced
instead, which would fail to be linked by gst-plugins-good.

* gnu/packages/video.scm (aalib) [native-inputs]: Remove labels.
[arguments]: Use gexps.
<configure-flags>: New argument.
<phases>: Remove update-config-scripts and configure override.
Add force-autoreconf.

Reported-by: Marcel van der Boom <marcel@HIDDEN>
---
 gnu/packages/video.scm | 43 +++++++++++++-----------------------------
 1 file changed, 13 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff52b9b38d..1a0880bf3c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -50,7 +50,7 @@
 ;;; Copyright © 2021 Alexey Abramov <levenson@HIDDEN>
 ;;; Copyright © 2021, 2022, 2023 Andrew Tropin <andrew@HIDDEN>
 ;;; Copyright © 2021 David Wilson <david@HIDDEN>
-;;; Copyright © 2021,2022 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel@HIDDEN>
 ;;; Copyright © 2021 Raghav Gururajan <rg@HIDDEN>
 ;;; Copyright © 2021 Thiago Jung Bauermann <bauermann@HIDDEN>
@@ -745,36 +745,19 @@ (define-public aalib
                (base32
                 "1vkh19gb76agvh4h87ysbrgy82hrw88lnsvhynjf4vng629dmpgv"))))
     (build-system gnu-build-system)
-    (native-inputs
-     `(("config" ,config)
-       ("makeinfo" ,texinfo)))
-    (inputs
-     (list ncurses))
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'update-config-scripts
-           (lambda* (#:key inputs native-inputs #:allow-other-keys)
-             ;; Replace outdated config.guess and config.sub.
-             (for-each (lambda (file)
-                         (install-file
-                          (search-input-file
-                           (or native-inputs inputs)
-                           (string-append "/bin/" file)) "."))
-                       '("config.guess" "config.sub"))))
-         (replace 'configure
-                  (lambda* (#:key build inputs outputs #:allow-other-keys)
-                    ;; This old `configure' script doesn't support
-                    ;; variables passed as arguments.
-                    (let ((out     (assoc-ref outputs "out"))
-                          (ncurses (assoc-ref inputs "ncurses")))
-                      (setenv "CONFIG_SHELL" (which "bash"))
-                      (invoke "./configure"
-                              "--disable-static"
-                              (string-append "--prefix=" out)
-                              (string-append "--build=" build)
-                              (string-append "--with-ncurses="
-                                             ncurses))))))))
+     (list
+      #:configure-flags
+      #~(list "--disable-static"
+              (string-append "--with-ncurses="
+                             #$(this-package-input "ncurses")))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'force-autoreconf
+            (lambda _
+              (delete-file "configure"))))))
+    (native-inputs (list autoconf automake libtool texinfo))
+    (inputs (list ncurses))
     (home-page "https://aa-project.sourceforge.net/aalib/")
     (synopsis "ASCII-art library")
     (description
-- 
2.41.0





Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#65646; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Sep 2023 18:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.