GNU bug report logs - #65655
30.0.50; Minor oversights in integer->natnum :type change

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Thu, 31 Aug 2023 10:53:02 UTC

Severity: normal

Found in version 30.0.50

Fixed in version 29.2

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65655 in the body.
You can then email your comments to 65655 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#65655; Package emacs. (Thu, 31 Aug 2023 10:53:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 31 Aug 2023 10:53:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Minor oversights in integer->natnum :type change
Date: Thu, 31 Aug 2023 07:52:01 -0300

The type of the following two options was changed from integer to natnum:
blink-cursor-blinks and url-max-redirections
as part of this commit:

commit 9d866a1f8da870dcf82f87d5ed9d5ca932d5477b
Author: Stefan Kangas <stefankangas <at> gmail.com>
Date:   Tue Jul 5 16:26:45 2022 +0200

    Make some defcustom types more restrictive


But the docstring of blink-cursor-blinks says:
"Use 0 or negative value to blink forever."
Now a negative value can't be used, so it would be good to adapt the
docstring, at least.

And the docstring of url-max-redirections says:
"A negative number means to honor an unlimited number of redirection
requests."
I suggest to change its type back to integer.
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Fri, 01 Sep 2023 20:21:01 GMT) Full text and rfc822 format available.
Notification sent to Mauro Aranda <maurooaranda <at> gmail.com>:
bug acknowledged by developer. (Fri, 01 Sep 2023 20:21:01 GMT) Full text and rfc822 format available.

Message #10 received at 65655-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 65655-done <at> debbugs.gnu.org
Subject: Re: bug#65655: 30.0.50;
 Minor oversights in integer->natnum :type change
Date: Fri, 1 Sep 2023 22:20:12 +0200

Version: 29.2

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> But the docstring of blink-cursor-blinks says:
> "Use 0 or negative value to blink forever."
> Now a negative value can't be used, so it would be good to adapt the
> docstring, at least.
>
> And the docstring of url-max-redirections says:
> "A negative number means to honor an unlimited number of redirection
> requests."
> I suggest to change its type back to integer.

Thanks for spotting these issues.

Fixed on emacs-29 in commit 60dcea7658a.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 30 Sep 2023 11:24:21 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 223 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.