GNU bug report logs - #65671
Eglot: add support for terraform-ls

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65671 in the body.
You can then email your comments to 65671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: me <at> rosstimson.com
To: bug-gnu-emacs <at> gnu.org
Subject: Eglot: add support for terraform-ls
Date: Thu, 31 Aug 2023 20:36:29 +0100

From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
From: Ross Timson <me <at> rosstimson.com>
Date: Thu, 31 Aug 2023 20:28:22 +0100
Subject: [PATCH] Eglot: add support for terraform-ls

Adding support for the official Terraform LSP server.
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 65daa0941d5..3375e7969c2 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -257,7 +257,8 @@ chosen (interactively or automatically)."
                                  . ,(eglot-alternatives
                                      '(("marksman" "server")
                                        ("vscode-markdown-language-server" "--stdio"))))
-                                (graphviz-dot-mode . ("dot-language-server" "--stdio")))
+                                (graphviz-dot-mode . ("dot-language-server" "--stdio"))
+                                (terraform-mode . ("terraform-ls" "serve")))
   "How the command `eglot' guesses the server to start.
 An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
 identifies the buffers that are to be managed by a specific
-- 
2.39.2 (Apple Git-143)

Message #8 received at 65671 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: me <at> rosstimson.com
Cc: 65671 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#65671: Eglot: add support for terraform-ls
Date: Fri, 1 Sep 2023 18:04:05 +0200

> From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
> From: Ross Timson <me <at> rosstimson.com>
> Date: Thu, 31 Aug 2023 20:28:22 +0100
> Subject: [PATCH] Eglot: add support for terraform-ls
>
> Adding support for the official Terraform LSP server.
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 65daa0941d5..3375e7969c2 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -257,7 +257,8 @@ chosen (interactively or automatically)."
>                                   . ,(eglot-alternatives
>                                       '(("marksman" "server")
>                                         ("vscode-markdown-language-server" "--stdio"))))
> -                                (graphviz-dot-mode . ("dot-language-server" "--stdio")))
> +                                (graphviz-dot-mode . ("dot-language-server" "--stdio"))
> +                                (terraform-mode . ("terraform-ls" "serve")))
>    "How the command `eglot' guesses the server to start.
>  An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
>  identifies the buffers that are to be managed by a specific
> --
> 2.39.2 (Apple Git-143)

Makes sense to me.  João, do you have any comments?

Message #11 received at 65671 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: me <at> rosstimson.com, 65671 <at> debbugs.gnu.org
Subject: Re: bug#65671: Eglot: add support for terraform-ls
Date: Fri, 1 Sep 2023 17:13:14 +0100

[Message part 1 (text/plain, inline)]

No, no comments. Push these simple contributions at will, as usual.

It would be useful, at some point, to collect these additions in the
etc/EGLOT-NEWS for (grouped in a single bullet, of course).

João

On Fri, Sep 1, 2023, 17:04 Stefan Kangas <stefankangas <at> gmail.com> wrote:

> > From 00b2b7f5a456278325334509a1396e6b9307914d Mon Sep 17 00:00:00 2001
> > From: Ross Timson <me <at> rosstimson.com>
> > Date: Thu, 31 Aug 2023 20:28:22 +0100
> > Subject: [PATCH] Eglot: add support for terraform-ls
> >
> > Adding support for the official Terraform LSP server.
> > ---
> >  lisp/progmodes/eglot.el | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 65daa0941d5..3375e7969c2 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -257,7 +257,8 @@ chosen (interactively or automatically)."
> >                                   . ,(eglot-alternatives
> >                                       '(("marksman" "server")
> >
>  ("vscode-markdown-language-server" "--stdio"))))
> > -                                (graphviz-dot-mode .
> ("dot-language-server" "--stdio")))
> > +                                (graphviz-dot-mode .
> ("dot-language-server" "--stdio"))
> > +                                (terraform-mode . ("terraform-ls"
> "serve")))
> >    "How the command `eglot' guesses the server to start.
> >  An association list of (MAJOR-MODE . CONTACT) pairs.  MAJOR-MODE
> >  identifies the buffers that are to be managed by a specific
> > --
> > 2.39.2 (Apple Git-143)
>
> Makes sense to me.  João, do you have any comments?
>

[Message part 2 (text/html, inline)]

Message #16 received at 65671-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: me <at> rosstimson.com, 65671-done <at> debbugs.gnu.org
Subject: Re: bug#65671: Eglot: add support for terraform-ls
Date: Fri, 1 Sep 2023 20:02:22 +0200

Version: 29.2

João Távora <joaotavora <at> gmail.com> writes:

> No, no comments. Push these simple contributions at will, as usual.

Thanks.  Fixed up the commit message and pushed to emacs-29 as commit
369f2eea100.

Thank you for the patch, Ross.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.