GNU bug report logs - #65701
[PATCH] gnu: portfolio: Update to 1.0.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65701 in the body.
You can then email your comments to 65701 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: portfolio: Update to 1.0.0.
Date: Sat, 2 Sep 2023 15:11:24 +0200

* gnu/packages/gnome-xyz.scm (portfolio): Update to 1.0.0.
[#:phases]: Add ‘skip-gtk-update-icon-cache’.
[inputs]: Replace gtk+ with gtk.
Replace libhandy with libadwaita.
[native-inputs]: Remove gtk+:bin.
Add pkg-config.
---
 gnu/packages/gnome-xyz.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 6ba0ee0092..8b5dc3030e 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -484,7 +484,7 @@ (define-public gnome-plots
 (define-public portfolio
   (package
     (name "portfolio")
-    (version "0.9.14")
+    (version "1.0.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -493,7 +493,7 @@ (define-public portfolio
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0h09v8lhz3kv6qmwjhx3gr7rp6ccfhrzm54gjnaixl4dcg9zddls"))))
+                "1ai9mx801m5lngkljg42vrpvhbvc3071sp4jypsvbzw55hxnn5ba"))))
     (arguments
      (list #:glib-or-gtk? #t
            #:imported-modules `(,@%meson-build-system-modules
@@ -508,6 +508,10 @@ (define-public portfolio
                             (with-directory-excursion (string-append #$output
                                                                      "/bin")
                               (symlink "dev.tchx84.Portfolio" "portfolio"))))
+                        (add-after 'unpack 'skip-gtk-update-icon-cache
+                          (lambda _
+                            (substitute* "build-aux/meson/postinstall.py"
+                              (("gtk-update-icon-cache") "true"))))
                         (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap
                           (lambda* (#:key inputs outputs #:allow-other-keys)
                             (wrap-program (search-input-file outputs
@@ -519,12 +523,12 @@ (define-public portfolio
                               `("GI_TYPELIB_PATH" =
                                 (,(getenv "GI_TYPELIB_PATH")))))))))
     (build-system meson-build-system)
-    (inputs (list bash-minimal python-pygobject gtk+ libhandy))
+    (inputs (list bash-minimal python-pygobject gtk libadwaita))
     (native-inputs
      (list desktop-file-utils
            gettext-minimal
            `(,glib "bin")
-           `(,gtk+ "bin")
+           pkg-config
            python))
     (home-page "https://github.com/tchx84/Portfolio")
     (synopsis "Minimalist file manager for Linux mobile devices")

base-commit: 9179775b0535ddf038d45f1355f759c4d6dc40dc
prerequisite-patch-id: a6de0ccc2665854539d331239e51c5fa4c3373aa
-- 
2.41.0

Message #8 received at 65701 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 65701 <at> debbugs.gnu.org
Subject: Re: [bug#65701] [PATCH] gnu: portfolio: Update to 1.0.0.
Date: Mon, 04 Sep 2023 23:40:10 -0400

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/gnome-xyz.scm (portfolio): Update to 1.0.0.
> [#:phases]: Add ‘skip-gtk-update-icon-cache’.
> [inputs]: Replace gtk+ with gtk.
> Replace libhandy with libadwaita.
> [native-inputs]: Remove gtk+:bin.
> Add pkg-config.

LGTM, thanks!

-- 
Maxim

Message #13 received at 65701-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 65701-done <at> debbugs.gnu.org
Subject: Re: [bug#65701] [PATCH] gnu: portfolio: Update to 1.0.0.
Date: Sat, 09 Sep 2023 11:03:21 +0200

Am Montag, dem 04.09.2023 um 23:40 -0400 schrieb Maxim Cournoyer:
> Hello,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > * gnu/packages/gnome-xyz.scm (portfolio): Update to 1.0.0.
> > [#:phases]: Add ‘skip-gtk-update-icon-cache’.
> > [inputs]: Replace gtk+ with gtk.
> > Replace libhandy with libadwaita.
> > [native-inputs]: Remove gtk+:bin.
> > Add pkg-config.
> 
> LGTM, thanks!
Thanks for checking, pushed.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.