GNU bug report logs - #65708
30.0.50; Wrong default value for functions in filesets.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65708 in the body.
You can then email your comments to 65708 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Wrong default value for functions in filesets.el
Date: Sat, 2 Sep 2023 19:21:27 -0300

The following user options:
filesets-browse-dir-function
filesets-open-file-function
filesets-save-buffer-function
filesets-commands
filesets-external-viewers

have overridden the default value of the function widget to the value
nil.  That's an invalid default value.  It'd be better to just remove
that.

Message #8 received at 65708 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>, 65708 <at> debbugs.gnu.org
Subject: Re: bug#65708: 30.0.50;
 Wrong default value for functions in filesets.el
Date: Sat, 2 Sep 2023 15:42:07 -0700

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> The following user options:
> filesets-browse-dir-function
> filesets-open-file-function
> filesets-save-buffer-function
> filesets-commands
> filesets-external-viewers
>
> have overridden the default value of the function widget to the value
> nil.  That's an invalid default value.  It'd be better to just remove
> that.

Makes sense, but you forgot to attach the patch.  ;-)

Message #11 received at 65708 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 65708 <at> debbugs.gnu.org
Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in
 filesets.el
Date: Sat, 2 Sep 2023 19:46:58 -0300

On 2/9/23 19:42, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> The following user options:
>> filesets-browse-dir-function
>> filesets-open-file-function
>> filesets-save-buffer-function
>> filesets-commands
>> filesets-external-viewers
>>
>> have overridden the default value of the function widget to the value
>> nil.  That's an invalid default value.  It'd be better to just remove
>> that.
>
> Makes sense, but you forgot to attach the patch.  ;-)

I was writing it but then I found some other problems with the
defcustoms in filesets.el :-(

I'll attach the patch trying to fix all of them (with a description of
the problems, of course).

Message #14 received at 65708 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 65708 <at> debbugs.gnu.org
Subject: Re: bug#65708: 30.0.50; Wrong default value for functions in
 filesets.el
Date: Sat, 2 Sep 2023 20:19:01 -0300

[Message part 1 (text/plain, inline)]

On 2/9/23 19:46, Mauro Aranda wrote:
> On 2/9/23 19:42, Stefan Kangas wrote:
>  > Mauro Aranda <maurooaranda <at> gmail.com> writes:
>  >
>  >> The following user options:
>  >> filesets-browse-dir-function
>  >> filesets-open-file-function
>  >> filesets-save-buffer-function
>  >> filesets-commands
>  >> filesets-external-viewers
>  >>
>  >> have overridden the default value of the function widget to the value
>  >> nil.  That's an invalid default value.  It'd be better to just remove
>  >> that.
>  >
>  > Makes sense, but you forgot to attach the patch.  ;-)
>
> I was writing it but then I found some other problems with the
> defcustoms in filesets.el :-(
>
> I'll attach the patch trying to fix all of them (with a description of
> the problems, of course).

OK, I found a couple of bugs.  To reproduce, with emacs -Q
(require 'filesets)
M-x customize-option RET filesets-commands
Move to the last INS button, the one that inserts a brand new command.
Hit RET:

INS DEL Definition:
            String:
            Command: Value Menu invalid (nil)
            Argument List:
            INS

invalid (nil) indicates a bad default value for the choice widget.  I
fixed that.


M-x customize-option RET filesets-external-viewers
Move to the INS button that inserts a Property for the last Definition.
Hit RET
INS DEL Definition:
            Pattern: .\.\(tiff\|xpm\|gif\|pgn\)\'
            Viewer: Value Menu Program: gqview
            Properties:
            INS DEL Choice: Value Menu :ignore-on-open-all:
                        Boolean: Toggle  on (non-nil)
            INS DEL Choice: Value Menu :ignore-on-read-text:
                        Boolean: Toggle  on (non-nil)
            INS DEL Choice: Value Menu invalid ((:constraintp))
            INS

invalid ((:constraintp)) indicates another bad default value.  I fixed
that, and other default values for the list widgets in this option.


One thing I observed is that there are lot of redundant tags in this
file, like (function :tag "Function").  But anyway, those aren't bugs,
so I didn't bothered.  I attach a patch for the emacs-29 branch.

[0001-Fix-defcustoms-in-filesets.el-Bug-65708.patch (text/x-patch, attachment)]

Message #19 received at 65708-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 65708-done <at> debbugs.gnu.org
Subject: Re: bug#65708: 30.0.50;
 Wrong default value for functions in filesets.el
Date: Sun, 3 Sep 2023 03:59:44 -0700

Version: 30.1

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> One thing I observed is that there are lot of redundant tags in this
> file, like (function :tag "Function").  But anyway, those aren't bugs,
> so I didn't bothered.  I attach a patch for the emacs-29 branch.

Thanks, installed on master.  I didn't put it on the release branch, as
these are not really regressions, and have been there for a long time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.