GNU bug report logs - #65731
[PATCH] services: syncthing: ensure that service runs after mounting home directories

Previous Next

Package: guix-patches;

Reported by: Adam Maleszka <adam_maleszka <at> aol.com>

Date: Mon, 4 Sep 2023 12:26:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65731 in the body.
You can then email your comments to 65731 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#65731; Package guix-patches. (Mon, 04 Sep 2023 12:26:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Adam Maleszka <adam_maleszka <at> aol.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 04 Sep 2023 12:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Maleszka <adam_maleszka <at> aol.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: syncthing: ensure that service runs after
 mounting home directories
Date: Mon, 04 Sep 2023 14:25:23 +0200
[Message part 1 (text/plain, inline)]
Sometimes `syncthing-service-type' fails during startup because it tries
to read configuration files from the user's home directory:

Failure on home directory: mkdir /home/xyz/.config: permission denied

This patch adds `user-processes' to the shepherd service requirements to
ensure that `user-homes' is fired before `syncthing' tries to read data
from the home directory.

* gnu/services/syncthing.scm (syncthing-shepherd-service): add
`user-processes' to requirements

---
 gnu/services/syncthing.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/syncthing.scm b/gnu/services/syncthing.scm
index 2f7c822827..9bb623186b 100644
--- a/gnu/services/syncthing.scm
+++ b/gnu/services/syncthing.scm
@@ -63,7 +63,7 @@ (define syncthing-shepherd-service
                      (list (string->symbol
                             (string-append "syncthing-" user)))))
       (documentation "Run syncthing.")
-      (requirement (if home-service? '() '(loopback)))
+      (requirement (if home-service? '() '(loopback user-processes)))
       (start #~(make-forkexec-constructor
                 (append (list (string-append #$syncthing "/bin/syncthing")
                               "--no-browser"
-- 
2.41.0
[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 17 Sep 2023 09:57:01 GMT) Full text and rfc822 format available.

Notification sent to Adam Maleszka <adam_maleszka <at> aol.com>:
bug acknowledged by developer. (Sun, 17 Sep 2023 09:57:02 GMT) Full text and rfc822 format available.

Message #10 received at 65731-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Adam Maleszka <adam_maleszka <at> aol.com>
Cc: 65731-done <at> debbugs.gnu.org
Subject: Re: bug#65731: [PATCH] services: syncthing: ensure that service
 runs after mounting home directories
Date: Sun, 17 Sep 2023 11:56:22 +0200
Hi,

Adam Maleszka <adam_maleszka <at> aol.com> skribis:

> Sometimes `syncthing-service-type' fails during startup because it tries
> to read configuration files from the user's home directory:
>
> Failure on home directory: mkdir /home/xyz/.config: permission denied
>
> This patch adds `user-processes' to the shepherd service requirements to
> ensure that `user-homes' is fired before `syncthing' tries to read data
> from the home directory.
>
> * gnu/services/syncthing.scm (syncthing-shepherd-service): add
> `user-processes' to requirements

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 15 Oct 2023 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 208 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.