Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 15:24:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 11:24:19 2023 Received: from localhost ([127.0.0.1]:37148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qduOA-0002GO-IH for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 11:24:18 -0400 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:54278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iota@HIDDEN>) id 1qduO5-0002G5-MD for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 11:24:16 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4RgmPG4WtMz9t54; Wed, 6 Sep 2023 17:24:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1694013842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1FS0cah8DcgdC/jtJ5wlSNgG9WLP6BowAm+srTWYPY=; b=W5xNxQMVhgROEP3VeiIiQfv2h5wxs9LkM1C5LRxiNMIf4TvAZVpi7itz5PwX2qJYpCYJ/g GsXxj9Wi7PNSbFQ38Lf46pTrcLkJSZx7R+3z4N6fy6ZPJo51XhKrbWrlHWC6sO08i1Wjjo imoW7HuKSzS107hkeLVJIStNxwoSEU4agi5Fi737nTTUvj+tVK+6loFAtXd8vXa9aPlGjR BW0A+ldASm/8rhlEnyid/9jJDxC0sPDQH/lYg5h3WJ14dAQSzaQ26GcG8jAVsDRItDwuLQ 4HzHcN8DTtut7RdFL7m80a/mrShsnYLM4naw48azpfhs0/50j23SaunZqSA/pg== References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <87ledju2j7.fsf@localhost> From: Sebastian Miele <iota@HIDDEN> To: Ihor Radchenko <yantar92@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Wed, 06 Sep 2023 17:04:48 +0200 In-reply-to: <87ledju2j7.fsf@localhost> Message-ID: <87o7if72b2.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 65734 Cc: emacs-orgmode@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 65734 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > From: Ihor Radchenko <yantar92@HIDDEN> > Date: Wed, 2023-09-06 08:30 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > >>> It would also make sense to group the two edits together via >>> `combine-after-change-calls', although a more universal way to know that >>> certain edits are a part of the same known command (even when called >>> non-interactively) would be useful. >> >> The command kills in two parts for a good reason, which is explained >> in the comments to the code. So making a single group will not work, >> I think, at least not in all situations. > > I think there is misunderstanding. `combine-after-change-calls' will not > affect the two-step modification of the kill ring, if we put it around > `kill-whole-line'. Or do I miss something? I tried to wrap the problematic portion of `kill-whole-line' into `combine-after-change-calls'. It seems to have no effect. The after-change function `org-fold-core--fix-folded-region' still gets called twice, not fixing the bug. I did not dig deeper, because the stuff that makes `combine-after-change-calls' work at least partially goes in C and seems to be scattered over several places. The Emacs Lisp manual states that `combine-after-change-calls' "arranges to call the after-change functions just once for a series of several changes=E2=80=94if that seems safe." So this case does not seem safe. Apa= rt from that, there is no stated guarantee for when it would seem it safe. I conclude that, although this path looked possibly elegant at first, and I wanted to give it a try, this cannot work out.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 13:36:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 09:36:19 2023 Received: from localhost ([127.0.0.1]:33430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdshf-0001UW-Cf for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 09:36:19 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:42044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iota@HIDDEN>) id 1qdshb-0001UG-R4 for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 09:36:17 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Rgk0k5SYdz9t6j; Wed, 6 Sep 2023 15:36:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1694007366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWCRWsroHAZv+o/GtvY3T35tINIM3e1gBg0+gACmBgk=; b=wX1ZJ9sQMVqnnSIfmQBPp3a8RJyGff7QBby6NXjFmatHs0DtP42KivAgVUlOzbf599G1e4 TI4qo/6oym8rZxRB/Kd6dtDrg0ubtpiatyK5bgpN56086hVVeVqDsrX1ml7VYvlt7VJ6y0 RahIBaRGQJkrnO6cGJ9wm+H8s6jP9QpVTr3Od5yYAZ0H3XdFUeqy1XtADHWwicmhQJfppf xbYFHWlVS0X9UwUZVzcMxy64AZdzjijp2ri4nTOY+iHWO5J0j9qRRDR9jhWftsd/J7aBzs NEmvCWJcdW3hNap7PqecP7N+jbV/NjDO5wvRXEK/Yvif1N363i0LcokppezKsw== References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <875y4oaban.fsf@HIDDEN> <83bkeg4o1u.fsf@HIDDEN> <87o7ifu2v8.fsf@localhost> <838r9j339x.fsf@HIDDEN> From: Sebastian Miele <iota@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Wed, 06 Sep 2023 15:30:16 +0200 In-reply-to: <838r9j339x.fsf@HIDDEN> Message-ID: <87tts78lve.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65734 Cc: emacs-orgmode@HIDDEN, Ihor Radchenko <yantar92@HIDDEN>, 65734 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > From: Eli Zaretskii <eliz@HIDDEN> > Date: Wed, 2023-09-06 15:16 +0300 > >> From: Ihor Radchenko <yantar92@HIDDEN> >> Date: Wed, 06 Sep 2023 08:23:23 +0000 >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> >> The following would do it. I think I tested it rather thoroughly. >> >> During testing I found another bug that is addressed by the let-binding >> >> of kill-read-only-ok during the first kill-region below. >> > >> > Thanks. Sadly, we don't have any tests for this function in our test >> > suite, so verifying this non-trivial change will not be easy... >> >> Then, what should we do to move things forward? I guess the first step >> will be writing these missing tests. > > Yes, that'd be most welcome. I will write the tests. And I will probably come up with an updated version of the original patch. There is at least one cosmetic change. And something else that I want to have tried. May take some time. >> Anything else? > > How about asking on emacs-devel that people who use kill-whole-line > frequently install the patch and run with it for some time? (We could > do that after installing the changes on master, of course.)
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 12:20:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 08:20:43 2023 Received: from localhost ([127.0.0.1]:33326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdrWV-0007y7-5W for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 08:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdrWR-0007xr-6d for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 08:20:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdrWK-000258-BD; Wed, 06 Sep 2023 08:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iwCg2S+NTMzWg5DtD5wjH10ZNUrRV8TLD8QRUli2ckg=; b=BaKQd27o28sD 8bWwL/rTqd3OUT8TcZ3NznVQAY2ecMGckd9PUPdnUwdtoyxkJB+PoGOChP1c0d8axYQYXuJ8NK/0Q KKDykseoOhv+j5fLifkcuMjBAEAhu+8nnXC5FUGVSeinsV+bERlwms+0FjFwZc8WQquXTOQDsSOQt iUv3reJX3YX8Afr4zJpFEBU3AhKxHHDuzf3/z2ZrqQjdcq+Z4mf9UPbjOIA+EjoARUlB5mViW1ZNV SpS4MuFrDO/RMsS8Lgvt5mwJkMI2ouOnVBtmUfaf6oda08xAJQc4WrsdnYmjJZUGgWgzszOqNE+kz KUlCDKLjcnMENkWSU9wYUA==; Date: Wed, 06 Sep 2023 15:20:19 +0300 Message-Id: <837cp3333w.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ihor Radchenko <yantar92@HIDDEN> In-Reply-To: <87ledju2j7.fsf@localhost> (message from Ihor Radchenko on Wed, 06 Sep 2023 08:30:36 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <87ledju2j7.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Ihor Radchenko <yantar92@HIDDEN> > Cc: iota@HIDDEN, 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN > Date: Wed, 06 Sep 2023 08:30:36 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> In addition, `org-kill-line' acts specially in certain scenarios: > >> > >> For > >> * Heading <point> text :tag1:tag2: > >> > >> `org-kill-line' will keep and re-align ":tag1:tag2:": > >> > >> * Heading <point> :tag1:tag2: > >> > >> It would be nice if we could express such behavior without overriding > >> the `kill-line' command. > > > > This could be handled by a suitable extension to end-of-visible-line. > > For example, introduce a new text property which end-of-visible-line > > would then handle the same as it currently handles invisible text. > > I am not sure if I like the idea of text property - marking all the tags > in buffer with text property is expensive. Then perhaps just a special value for buffer-invisibility-spec, or some other simple variation of a property Org already uses? > What about something like `end-of-visible-line-function'? That is also a possibility, but it will then affect kill-line _anywhere_ in the buffer, whereas a text property can have a more localized effect. Are you sure kill-line will need this customization on the whole buffer?
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 12:17:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 08:17:07 2023 Received: from localhost ([127.0.0.1]:33301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdrT1-0007ru-GX for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 08:17:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdrT0-0007rN-5K for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 08:17:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdrSs-0001Jt-S2; Wed, 06 Sep 2023 08:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2r/MHYvEoAcx8cl5F0CXtpxhb8IKB6MFP1BKJ3bSCqI=; b=m8k0wpwXo0fw FuHRfMmZ9oz0Q0eeID6Quj3uJibCUNHzqk038y+69wDxhOcmgnhWOwzF3Sp3fTdV+2RfCSn4aHkAx PzGcSPWNdVg7GLmu6v0xCDeMotxscHUQlx0EZpVoU5AAeoXZdZ9LWY/M3Hk4WXSWBBQGm6dWjruJG BCHf3Be0MEHg3yDCZlfk52m9m1XWCjAiBFPy4rDlDq/ImnEXf12lD2iNAxjGF8OPfQJPw6kKJxoFD eVBcJPJpVc9KfoA6aiIxxhIOrOPabxp/0sTA+f29Ch6rEdEmnvjZsEPgkqRV98U4FJkaV6bReS8se AsKfvmPwz017XViJ9VyENQ==; Date: Wed, 06 Sep 2023 15:16:42 +0300 Message-Id: <838r9j339x.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ihor Radchenko <yantar92@HIDDEN> In-Reply-To: <87o7ifu2v8.fsf@localhost> (message from Ihor Radchenko on Wed, 06 Sep 2023 08:23:23 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <875y4oaban.fsf@HIDDEN> <83bkeg4o1u.fsf@HIDDEN> <87o7ifu2v8.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Ihor Radchenko <yantar92@HIDDEN> > Cc: Sebastian Miele <iota@HIDDEN>, 65734 <at> debbugs.gnu.org, > emacs-orgmode@HIDDEN > Date: Wed, 06 Sep 2023 08:23:23 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> The following would do it. I think I tested it rather thoroughly. > >> During testing I found another bug that is addressed by the let-binding > >> of kill-read-only-ok during the first kill-region below. > > > > Thanks. Sadly, we don't have any tests for this function in our test > > suite, so verifying this non-trivial change will not be easy... > > Then, what should we do to move things forward? I guess the first step > will be writing these missing tests. Yes, that'd be most welcome. > Anything else? How about asking on emacs-devel that people who use kill-whole-line frequently install the patch and run with it for some time? (We could do that after installing the changes on master, of course.)
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 08:29:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 04:29:55 2023 Received: from localhost ([127.0.0.1]:60753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdnv9-0004nt-GH for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 04:29:55 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <yantar92@HIDDEN>) id 1qdnv6-0004nf-Gi for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 04:29:54 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E15AF240028 for <65734 <at> debbugs.gnu.org>; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693988985; bh=p5OcqwWSVZV3xyQtHDBgwpktUY+5M1SqLnsTCvK1uG8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=XGg8ANTuxbYaTUEfTr7D8D1mP0FFunqZbQTkVZMY3fxxy7SrPByTIbKYCC5w17AcR e2zG1G7jyx5uJHJpZn5OCRomjVsgmkOFczhoAxeMBIQMi9guhgI9SKKL7EHuLrcvU8 M01Y8pLbAblQKLFKFXt0qOFCFXAE2mG9aaUrK/+S2DANGqdDdIYN0c6ckqiKOWN7s2 9AIJu/D5iaUl1B5y2QupIcJLPxkpPzYt/cbvlQenTgASBHlxRRZNVX5vhqpXjSFTt9 o5NAreKil/fFzAYIvnuoXcsdKYqAJS7iTFrPsywQ+9/d8BXlS1KcHNS86MtnV7dAVz dWtH7ryLSnEcw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RgbCF2vhmz9rxS; Wed, 6 Sep 2023 10:29:45 +0200 (CEST) From: Ihor Radchenko <yantar92@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <83h6o84yz1.fsf@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> Date: Wed, 06 Sep 2023 08:30:36 +0000 Message-ID: <87ledju2j7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: >> It would also make sense to group the two edits together via >> `combine-after-change-calls', although a more universal way to know that >> certain edits are a part of the same known command (even when called >> non-interactively) would be useful. > > The command kills in two parts for a good reason, which is explained > in the comments to the code. So making a single group will not work, > I think, at least not in all situations. I think there is misunderstanding. `combine-after-change-calls' will not affect the two-step modification of the kill ring, if we put it around `kill-whole-line'. Or do I miss something? > ... And relying on after-change > hooks to fix this use case sounds too obscure and fragile to me. Indeed. I did not talk about this particular bug report. What I meant is some way to group change hooks executed by the same function/command. >> In addition, `org-kill-line' acts specially in certain scenarios: >> >> For >> * Heading <point> text :tag1:tag2: >> >> `org-kill-line' will keep and re-align ":tag1:tag2:": >> >> * Heading <point> :tag1:tag2: >> >> It would be nice if we could express such behavior without overriding >> the `kill-line' command. > > This could be handled by a suitable extension to end-of-visible-line. > For example, introduce a new text property which end-of-visible-line > would then handle the same as it currently handles invisible text. I am not sure if I like the idea of text property - marking all the tags in buffer with text property is expensive. What about something like `end-of-visible-line-function'? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 6 Sep 2023 08:23:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 04:22:59 2023 Received: from localhost ([127.0.0.1]:60747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdnoC-0004dd-PQ for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 04:22:59 -0400 Received: from mout02.posteo.de ([185.67.36.66]:37361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <yantar92@HIDDEN>) id 1qdno7-0004dM-AJ for 65734 <at> debbugs.gnu.org; Wed, 06 Sep 2023 04:22:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B4590240105 for <65734 <at> debbugs.gnu.org>; Wed, 6 Sep 2023 10:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693988552; bh=tHw/QHQTV/1nsg2eehA9HZiLQW3Y9ilPfe8+j+E++m8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=qrclMUZUHNgcq7AmNvAlboEK9HBecAUGJzM2dtRuDSsjS0gEEog+RGWEp+y+1kV8i +M98+I61eMCSzGhaGbriVITdoX6CQ/7+xyCb1obKUlcTHgJyYpv18wvYEkMjSq+nlR P5uGj5rzUc97SfmNlBoJX4Q+mYwH12ioCh4dDXl5SUXWUxWqR0SsB8ZYIE1T0Mzo+i SZ8F0CXztpmOHlZ3qgICXuQbyZSsgGBVIPFPKyqD50kFgBOWVbKnemHC0JqAvXdZMl fW7QYPinKwThMI6/xx8DUMp4KzudsgwDHpiKk6mMQNWgwabUvyr7+rgZ/aZ5a3x2eR 0sY9VEpt/PiPw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rgb2w1Rc1z9rxT; Wed, 6 Sep 2023 10:22:32 +0200 (CEST) From: Ihor Radchenko <yantar92@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <83bkeg4o1u.fsf@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <875y4oaban.fsf@HIDDEN> <83bkeg4o1u.fsf@HIDDEN> Date: Wed, 06 Sep 2023 08:23:23 +0000 Message-ID: <87o7ifu2v8.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, Sebastian Miele <iota@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> The following would do it. I think I tested it rather thoroughly. >> During testing I found another bug that is addressed by the let-binding >> of kill-read-only-ok during the first kill-region below. > > Thanks. Sadly, we don't have any tests for this function in our test > suite, so verifying this non-trivial change will not be easy... Then, what should we do to move things forward? I guess the first step will be writing these missing tests. Anything else? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 16:15:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 12:15:40 2023 Received: from localhost ([127.0.0.1]:58177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYiG-0004Fl-Oi for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:15:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdYiD-0003vl-OK for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:15:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdYi7-0004UY-B3; Tue, 05 Sep 2023 12:15:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8t69r5ZtsIsegXAqF4gtdOQ7VrH/8FpEodsoqqL8kZw=; b=nIFOwWhJOGRC IjMoeRpAa/YzkmkSZVl+myEbonwalgiAca9oWw+ISNZ+UNBa6BtfUXu2shM/QRv67y19kx+FgIYYS CLLxF1PJsyTacM/DVuYgQoMEBvdkaSckrqVcQ/Qktx8FmPnp2k9YyGizIl6ezs6C5ktduThX1vvgt FsfjXD4mHVJFeWOO0F5tRtw8+0A8VuHxeYReGIKXj3DV96TUPwBGa2ShFS97sB1Re9MRh1jdsOzKq gWTdLS6nyZxL+k+daGKgl5+6I1H2EW/CRfXN8IX11yT15DD6GQNaLwJzuP1eToHJGS9T6/G1x8MQ7 VdaEx6R11JYfLjD0DaLXYA==; Date: Tue, 05 Sep 2023 19:14:55 +0300 Message-Id: <83a5u04mww.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ihor Radchenko <yantar92@HIDDEN> In-Reply-To: <875y4ovct9.fsf@localhost> (message from Ihor Radchenko on Tue, 05 Sep 2023 15:50:58 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> <83cyyw4of7.fsf@HIDDEN> <875y4ovct9.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, manikulin@HIDDEN, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Ihor Radchenko <yantar92@HIDDEN> > Cc: Max Nikulin <manikulin@HIDDEN>, iota@HIDDEN, > 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN > Date: Tue, 05 Sep 2023 15:50:58 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> On 05/09/2023 17:29, Ihor Radchenko wrote: > >> > Confirmed. > >> > >> It is a regression in comparison to e.g. org-mode-9.3.1. > > > > What changed since org-mode-9.3.1? Was it some change in Emacs, and > > if so, which one? > > The reported bug is a side effect of a feature when Org automatically > reveals hidden outlines that are "broken" due to edits and thus could > not be unfolded easily. For example, when destroying parent heading in a > folding subtree: > > <point>* Heading... > > | > V > > Heading > <unfolded> > > The feature was introduced in Or 9.5. Understood, thanks.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 16:11:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 12:11:35 2023 Received: from localhost ([127.0.0.1]:58162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYeN-0002QG-5A for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:11:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <yantar92@HIDDEN>) id 1qdYeK-0002Q2-Ma for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:11:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EEF4F240106 for <65734 <at> debbugs.gnu.org>; Tue, 5 Sep 2023 18:11:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693930286; bh=7C6/wjyNsm0gpqwFxd9JGOrycaE15QsII5Blzpe0WVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=ST9EHgo8WMWg8ZwlmDO9Vh6cB6zcKohzc9n5/t01FAiEn+yvIfVVw4UmCGxOILBcg 46cg5UOacAhnciE9mPE7DhU5p0sd6PTJIe59heQGXKNrN2WDLnh8atGvEB/ohQzx1V gnNk9xUnTCnuX5Tx1y19mZ4I6FjP/2raLfE9SEJnvOuKe+Ihf6l6kpZXF0SyyfVN56 wcDfPIbGd9QEfhowRe/gnuWp3FWz+6Fk1R5PN1AFFJim/yStxy8vBklHWT86CX9ZXa i2N2mwFmZMu0dqEOtIwTLlcpMNAtXFHDzWOrQRC3e8q3q2XlRIbhZP/5vGTXairfLc 9WhKhEs3QoCqg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rg9VP24pKz9rxB; Tue, 5 Sep 2023 18:11:25 +0200 (CEST) From: Ihor Radchenko <yantar92@HIDDEN> To: Max Nikulin <manikulin@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <87b854c6-f3c1-49ea-be4c-64c99644b47b@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> <83cyyw4of7.fsf@HIDDEN> <875y4ovct9.fsf@localhost> <87b854c6-f3c1-49ea-be4c-64c99644b47b@HIDDEN> Date: Tue, 05 Sep 2023 16:12:17 +0000 Message-ID: <87zg20tx9a.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Max Nikulin <manikulin@HIDDEN> writes: >> The feature was introduced in Or 9.5. > > Or in 9.6? Oops. Yup. Org 9.6 - the latest release. Together with org-fold library. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 16:02:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 12:02:43 2023 Received: from localhost ([127.0.0.1]:58062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYVm-00027e-SD for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:02:43 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:48540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <manikulin@HIDDEN>) id 1qdYVj-00027O-3l for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:02:41 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bceb02fd2bso40137991fa.1 for <65734 <at> debbugs.gnu.org>; Tue, 05 Sep 2023 09:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693929752; x=1694534552; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=q+hc7Oqkr0+bZUiUV0QXHe8TJebC865N7DolS0g45bI=; b=KCLw7t24rjzEguM1yfekDJZuVmBjHeMKfobGFjZl+yvCnuc0h8D/z+LPgtO+Wz/H+g ymbiJXvY7h3l0tFSl4ZkPf9vpq6Cul7yYFW2hQcLYVTrMCSMmVVgVyalXktJ4rKYw6NT jFNHOA0oZJWuTpeD834mrpGrIu7bUmj/wpKYQF9dnJgdn/w/Os+ne1nvCJqpEE8A8XGE NIUz31/XedpkfVyBVavzVhtSxDqG4QYG9zXWrz3vF7PR6S3RTVdy+nWIr1mYlY+aH7sU rMcRDMmw/A5xYGSpeYZjUjFFBBxGXa1d8T0+9IRNVGZuXUcINiXhF6YyZdGC5wwuJvzv EMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693929752; x=1694534552; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q+hc7Oqkr0+bZUiUV0QXHe8TJebC865N7DolS0g45bI=; b=LCQVCJ2svIMIG1QfvS8+rscHdFVrAqB0z08Mmz/VxkfZ7C3m/9c/OYjENdG9yV22Ji WoWUqbphkGgc3wWaDbqdTudliDb5CUMOQ7DJATVX/kbuwMyl1qG5mHw7nD2IQKbn7Jan KABB3bjzXLrSDGcddTbQOIg2Y8PCMUVx2DRK6CvCSX1BfVLfX2y4XpVT8NQqY4lJAh25 8qzO7gMvntg5rWWIn8W1S7Rdlb4ocIJQrcEFVoysyJjx243AzQ5YwSDozcMe4Qg8zdaH pbSRrKlaMi+Q0aDPZWZmlPlruX0e85J0fmDS4RRkNoQ2DWOz4kVDGsXGz1y7PXNN632r PYmw== X-Gm-Message-State: AOJu0YwX0RP9FJ9A+RAcx/gafQrXO3R+bl2DpVsFZJKBhQ3FY0FHv//x WfL/tuCheLtteY1HoGwPtWs= X-Google-Smtp-Source: AGHT+IEAJKoz2MfcSyFqW47wWBG6Hbyyl8M1dKUvUbh/97nT4PgDdlAcRm7FWXxmY+HhdGA9RlspfQ== X-Received: by 2002:a2e:988e:0:b0:2bc:b29e:8fef with SMTP id b14-20020a2e988e000000b002bcb29e8fefmr147777ljj.34.1693929752330; Tue, 05 Sep 2023 09:02:32 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id m19-20020a2eb6d3000000b002bcda31af0fsm2989967ljo.74.2023.09.05.09.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 09:02:31 -0700 (PDT) Message-ID: <87b854c6-f3c1-49ea-be4c-64c99644b47b@HIDDEN> Date: Tue, 5 Sep 2023 23:02:30 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Content-Language: en-US, ru-RU To: Ihor Radchenko <yantar92@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> <83cyyw4of7.fsf@HIDDEN> <875y4ovct9.fsf@localhost> From: Max Nikulin <manikulin@HIDDEN> Mail-Followup-To: Ihor Radchenko <yantar92@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, iota@HIDDEN, 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN In-Reply-To: <875y4ovct9.fsf@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.5 (--) On 05/09/2023 22:50, Ihor Radchenko wrote: > Eli Zaretskii writes: > >>> On 05/09/2023 17:29, Ihor Radchenko wrote: >>>> Confirmed. >>> >>> It is a regression in comparison to e.g. org-mode-9.3.1. >> >> What changed since org-mode-9.3.1? Was it some change in Emacs, and >> if so, which one? That was a comparison on emacs-26.3 > The reported bug is a side effect of a feature when Org automatically > reveals hidden outlines that are "broken" due to edits and thus could > not be unfolded easily. For example, when destroying parent heading in a > folding subtree: > > <point>* Heading... > > | > V > > Heading > <unfolded> > > The feature was introduced in Or 9.5. Or in 9.6? On Emacs-28.2 I have compared Org-9.5.5 and 9.6.8. Unfolding on removing of a heading marker does not work in 9.5.5, but collapsed list items and headers are removed correctly.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 15:50:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 11:50:46 2023 Received: from localhost ([127.0.0.1]:57953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYKD-0001k2-U6 for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:50:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdYKC-0001jo-D3 for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:50:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdYK6-0007ts-4F; Tue, 05 Sep 2023 11:50:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=N0kLEyybNzBoOT6f1HizXRMXMyNUMVNxXw84DfS9O70=; b=QOKEMBYtYludeFCJjXt4 aZA844BqXVtHWbv2SAp9HOagcgkLw7GdYdw0i65ycjqQ3FdSzwo8zNAzq4EwALB/vO6ZjURG5Fcru vpi6ddEYX2nMknIknNJ0unhiRVjEtCvldsB2ZxnpLhDeFlTZFoLxjg2KYnTtResJ5hYkayeiIKy8n JB6jQtNylPIxvMisxPVNb/HrH4UaEDtGSY0KV5HATE7Ba9tu7BdudJqGEQ87rp5Dza+BBxpG3atQD Hap0JW4x35/ZrAsuJhkQ8k46hjnoLYX+SVkkng7eVyH1oGkFsLrW7nwxLYZX29DmJQgb6UGWTZiPW iVZGMlhRs3ftHA==; Date: Tue, 05 Sep 2023 18:50:21 +0300 Message-Id: <83bkeg4o1u.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Sebastian Miele <iota@HIDDEN> In-Reply-To: <875y4oaban.fsf@HIDDEN> (message from Sebastian Miele on Tue, 05 Sep 2023 17:25:38 +0200) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@HIDDEN> <875y4oaban.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: emacs-orgmode@HIDDEN, yantar92@HIDDEN, 65734 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Sebastian Miele <iota@HIDDEN> > Cc: Ihor Radchenko <yantar92@HIDDEN>, 65734 <at> debbugs.gnu.org, > emacs-orgmode@HIDDEN > Date: Tue, 05 Sep 2023 17:25:38 +0200 > > > From: Eli Zaretskii <eliz@HIDDEN> > > Date: Tue, 2023-09-05 14:54 +0300 > > > > […] > > > > So we could decide that this command needs to become smarter when the > > visual line includes invisible text. That is, improve the command > > without making any Org-specific changes anywhere. Patches to that > > effect are welcome. > > The following would do it. I think I tested it rather thoroughly. > During testing I found another bug that is addressed by the let-binding > of kill-read-only-ok during the first kill-region below. Thanks. Sadly, we don't have any tests for this function in our test suite, so verifying this non-trivial change will not be easy...
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 15:50:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 11:50:22 2023 Received: from localhost ([127.0.0.1]:57949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYJq-0001jQ-GA for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:50:22 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <yantar92@HIDDEN>) id 1qdYJn-0001j4-T1 for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:50:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 55EA8240027 for <65734 <at> debbugs.gnu.org>; Tue, 5 Sep 2023 17:50:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693929013; bh=IgEn2mix6wSjfGijs59CBPhdWuE1C7MOeMuGAQZ9CmM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=ZuHbYaI6fbhfSHh1MJY93bDYx7Avtp39Isyni48cku5ItYTPAgc1Yq6O2asxLTg1V jJv/lty/xI58BEU8eNO0Eoy/nFLMr7os6+L4NIdV7WIbwoHj3aMxkfUmDtC7ddtDY5 0lSd+X1fuPOF9fdYWh4cgiC2wKMo62GTuEbAD/pNKbITRd0BJ6+2C4pW6bN4YuIMZI kxyvrPfDZLRS3wlYCoQkzqHciEZKGEVy0p6QteTNOZsRsS856D91gEi2D+u9bTBf+f Rv+qCcfeai9U+XZHrIO1pZS9Gfg64F7oyU5eo/Jo1+rpYbtPY/hKy/IfpBLcL4wpna HMapwG3E/U8mw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rg91w3SWyz6tx8; Tue, 5 Sep 2023 17:50:12 +0200 (CEST) From: Ihor Radchenko <yantar92@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <83cyyw4of7.fsf@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> <83cyyw4of7.fsf@HIDDEN> Date: Tue, 05 Sep 2023 15:50:58 +0000 Message-ID: <875y4ovct9.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, Max Nikulin <manikulin@HIDDEN>, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: >> On 05/09/2023 17:29, Ihor Radchenko wrote: >> > Confirmed. >> >> It is a regression in comparison to e.g. org-mode-9.3.1. > > What changed since org-mode-9.3.1? Was it some change in Emacs, and > if so, which one? The reported bug is a side effect of a feature when Org automatically reveals hidden outlines that are "broken" due to edits and thus could not be unfolded easily. For example, when destroying parent heading in a folding subtree: <point>* Heading... | V Heading <unfolded> The feature was introduced in Or 9.5. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 15:42:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 11:42:48 2023 Received: from localhost ([127.0.0.1]:57932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYCW-0001SK-3A for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:42:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdYCS-0001S7-Tp for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:42:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdYCK-0006Kf-RM; Tue, 05 Sep 2023 11:42:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eeUWn05Aq5jCSbOeID0OIm8FeS3Y8ntVe/WhohwtDyc=; b=pyn45Lmmsz0q dIOma9CCwd0Mns82NK+E8WXtlA0QINCELrd48cn9fsODxGS9JlUuVWCqjyz4acfK12Hrq0bRyrOpB nsmSU2hrYEltVNuJT7FR5Kc8SeE8PkkElLCkGcBIjryXnNzKAShMFaWeOVLGiCU0NsfOlWSezbcc0 4PjhDhF90PSCv1AqfVIKnEJFq6XDkpOCL4KSZh/YDgB5kMeCQj7BESuidfCsTbaBM7zC1kC0CoGCB 3temXQ8S1UWnPVjUrdAftAs8CduSFnCt3IMxE/A4AonSCrtXFzsS9UY+XEz3gcRf0urLvxBSHDfy6 iFMkyDxxykwBRNkbmjUooQ==; Date: Tue, 05 Sep 2023 18:42:20 +0300 Message-Id: <83cyyw4of7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Max Nikulin <manikulin@HIDDEN> In-Reply-To: <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> (message from Max Nikulin on Tue, 5 Sep 2023 21:30:58 +0700) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, yantar92@HIDDEN, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: emacs-orgmode@HIDDEN, 65734 <at> debbugs.gnu.org > Date: Tue, 5 Sep 2023 21:30:58 +0700 > From: Max Nikulin <manikulin@HIDDEN> > > On 05/09/2023 17:29, Ihor Radchenko wrote: > > Confirmed. > > It is a regression in comparison to e.g. org-mode-9.3.1. What changed since org-mode-9.3.1? Was it some change in Emacs, and if so, which one?
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.
Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 15:29:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 11:29:34 2023
Received: from localhost ([127.0.0.1]:57865 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qdXzh-00016e-Pm
for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:29:34 -0400
Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:47606)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iota@HIDDEN>) id 1qdXze-00016O-Kc
for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 11:29:32 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
SHA256) (No client certificate requested)
by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Rg8Yt0yqDz9stN;
Tue, 5 Sep 2023 17:29:22 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001;
t=1693927762;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=PdzbzfHlgAiYE+ZGtYfrys6pTDruDOBScby9SOL7ny8=;
b=n7Muq1EFr6mFICfJ8vozmj9tYqrRKzjiZEp5XSowdCOkIayvpW/1R70LeUUYr7DdekuGIP
3FfUWyXrtq1+CnuX1d+Ema6AIxcgDWDx3KArnuiQpVTdGPoMAyNZn37HP02adloh0yz0PX
a4qG+i1YdaodYZ4ikkiHi+GmWBfIzJ808SwYtyJvoZvYzr8JrR3qmRq6HFGCaGOU0z5QZf
ruhDDQ2AaAo7gAffQAfxdixyHahxTlYB/krZuD1ydeqnWGoknDBqyIqCrMlBpsOlO79BLX
zu8tWWMC1bOlN+MpDmYZsv1W9PTA5yCssOOqmYFk34hI06vsQ7fFmM4kEJUvgg==
References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost>
<83h6o84yz1.fsf@HIDDEN>
From: Sebastian Miele <iota@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8
(release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]
Date: Tue, 05 Sep 2023 17:25:38 +0200
In-reply-to: <83h6o84yz1.fsf@HIDDEN>
Message-ID: <875y4oaban.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 65734
Cc: emacs-orgmode@HIDDEN, Ihor Radchenko <yantar92@HIDDEN>,
65734 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> From: Eli Zaretskii <eliz@HIDDEN>
> Date: Tue, 2023-09-05 14:54 +0300
>
> [=E2=80=A6]
>
> So we could decide that this command needs to become smarter when the
> visual line includes invisible text. That is, improve the command
> without making any Org-specific changes anywhere. Patches to that
> effect are welcome.
The following would do it. I think I tested it rather thoroughly.
During testing I found another bug that is addressed by the let-binding
of kill-read-only-ok during the first kill-region below.
diff --git a/lisp/simple.el b/lisp/simple.el
index abd587245fe..d983cb85ab3 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6631,28 +6631,50 @@ kill-whole-line
(unless (eq last-command 'kill-region)
(kill-new "")
(setq last-command 'kill-region))
- (cond ((zerop arg)
- ;; We need to kill in two steps, because the previous command
- ;; could have been a kill command, in which case the text
- ;; before point needs to be prepended to the current kill
- ;; ring entry and the text after point appended. Also, we
- ;; need to use save-excursion to avoid copying the same text
- ;; twice to the kill ring in read-only buffers.
- (save-excursion
- (kill-region (point) (progn (forward-visible-line 0) (point))))
- (kill-region (point) (progn (end-of-visible-line) (point))))
- ((< arg 0)
- (save-excursion
- (kill-region (point) (progn (end-of-visible-line) (point))))
- (kill-region (point)
- (progn (forward-visible-line (1+ arg))
- (unless (bobp) (backward-char))
- (point))))
- (t
- (save-excursion
- (kill-region (point) (progn (forward-visible-line 0) (point))))
- (kill-region (point)
- (progn (forward-visible-line arg) (point))))))
+ ;; - We need to kill in two steps, because the previous command
+ ;; could have been a kill command, in which case the text before
+ ;; point needs to be prepended to the current kill ring entry and
+ ;; the text after point appended.
+ ;; - We need to be careful to avoid copying text twice to the kill
+ ;; ring in read-only buffers.
+ ;; - We need to determine the boundaries of visible lines before we
+ ;; do the first kill, because that may change visibility
+ ;; (bug#65734).
+ (let ((regions-begin (point-marker))
+ region1-end)
+ (cond ((zerop arg)
+ (setq region1-end (save-excursion
+ (forward-visible-line 0)
+ (point-marker)))
+ (end-of-visible-line))
+ ((< arg 0)
+ (setq region1-end (save-excursion
+ (end-of-visible-line)
+ (point-marker)))
+ (forward-visible-line (1+ arg))
+ (unless (bobp) (backward-char)))
+ (t
+ (setq region1-end (save-excursion
+ (forward-visible-line 0)
+ (point-marker)))
+ (progn (forward-visible-line arg))))
+ ;; - Pass the marker positions and not the markers themselves.
+ ;; kill-region determines whether to prepend or append to a
+ ;; previous kill by checking the direction of the region. But
+ ;; it deletes the content and hence moves the markers before
+ ;; that. That effectively makes every region delimited by
+ ;; markers an (empty) forward region.
+ ;; - Make the first kill-region emit a non-local exit only if the
+ ;; second kill-region below would not operate on a non-empty
+ ;; region.
+ (let ((kill-read-only-ok (or kill-read-only-ok
+ (/=3D regions-begin (point)))))
+ (kill-region (marker-position regions-begin)
+ (marker-position region1-end)))
+ (kill-region (marker-position regions-begin)
+ (point))
+ (set-marker regions-begin nil)
+ (set-marker region1-end nil)))
=20
(defun forward-visible-line (arg)
"Move forward by ARG lines, ignoring currently invisible newlines only.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 14:31:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 10:31:14 2023 Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdX5F-0002SH-Ue for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:31:14 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:56494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <manikulin@HIDDEN>) id 1qdX59-0002Ry-9p for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 10:31:13 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bcfdadd149so43762421fa.0 for <65734 <at> debbugs.gnu.org>; Tue, 05 Sep 2023 07:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693924261; x=1694529061; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=f9SzSruMZN14vOrUTo9X3u+ZTXlMyYaRIrSlGRbVJOI=; b=Z7ZmcmamitcL4uXoHmVrss2TqnypMFuvc2lqgtmyXYXs34SnVy1n30SEbDbxTfibBp 3lc4TFw2An2UapnlKvsrVJqENVggVmRfnvFPGncp0pWXv7cJgoNBmzAt/kWr4nTZWU/0 BH8KsxPGUCuB+gH+YISxMPI68m95zzrySo31PLdqUOCsRcbo3vYWpSk9sCi7WvJzbu3h S8PcLjYCpZygo3/1iSeW+8PN9oNXNEJ+Uks+dlxYLilaMFwRxeYzvDUHZaGk4yhxxBGw T54nXCIfBxEjRGJ+Lb5nQlaATsnwEOBmfClk1xZL3B6Yn4FTZiCneR2GbPtfF5v1OdBw dMOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693924261; x=1694529061; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f9SzSruMZN14vOrUTo9X3u+ZTXlMyYaRIrSlGRbVJOI=; b=c4vDcvKh7gvvOjgndFvOzTsIiJ528YCIwSZsym1KZ93t0V/1l5SVBnGZ5w8ZByJZG9 wd4ZUU5QFlSKuHEcUBwoterqgm6puUJQEd/yYsPtnX9fx+b0j5fJDDD4DIQ8JPcDA9Xi lHHkv1k0MX91mFuB4XJnJdi5cxoRm/6VzrneUo0XGEOXkEG6vp0UGpgKur0MMoOrRCVe HXFQ8na1i0y2waVoyru8exjOd58Ojf3svGn59c4CwdPJ6TWHCtrt0LcRes9b+c/BZOS7 tohdGGVd8NdmBkX66ggaitYflhDtxoNNQasfG4Fqu47syjmbXasZxA6WCbfvbGI1wY00 6r+g== X-Gm-Message-State: AOJu0YzOS2LrfvLom6DnkXW/G7/nWrBA3MsqIMrTXZ20mGlXc0eM2Rbc YB732tYiU11zvZCximTLTe8= X-Google-Smtp-Source: AGHT+IE+nQ8Y9pZTTpJWw1hNDyN+6VyROjjJqWC2zJXipXnh9hp6qJ2Xlhmxkis2Kn292UmL1xCVpw== X-Received: by 2002:a2e:8955:0:b0:2b9:e53f:e201 with SMTP id b21-20020a2e8955000000b002b9e53fe201mr9623694ljk.31.1693924260626; Tue, 05 Sep 2023 07:31:00 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id v10-20020a2e7a0a000000b002bcd2653872sm2965896ljc.30.2023.09.05.07.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 07:31:00 -0700 (PDT) Message-ID: <ce55662a-190f-f719-8383-fa53ce808191@HIDDEN> Date: Tue, 5 Sep 2023 21:30:58 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] To: Ihor Radchenko <yantar92@HIDDEN>, Sebastian Miele <iota@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> Content-Language: en-US, ru-RU From: Max Nikulin <manikulin@HIDDEN> Mail-Followup-To: Ihor Radchenko <yantar92@HIDDEN>, Sebastian Miele <iota@HIDDEN>, 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN In-Reply-To: <87tts8vrpb.fsf@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65734 Cc: emacs-orgmode@HIDDEN, 65734 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.5 (--) On 05/09/2023 17:29, Ihor Radchenko wrote: > Confirmed. It is a regression in comparison to e.g. org-mode-9.3.1. I noticed it for multiline plain list items - ab cd Only first line is removed by C-S-<backspace> when the item is folded by TAB. For headings I usually use C-c C-x C-w, so I had less chance to face this issue.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 11:54:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 07:54:54 2023 Received: from localhost ([127.0.0.1]:54597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdUdx-0006cp-GV for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 07:54:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdUdu-0006ca-R4 for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 07:54:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdUdo-0002OK-UX; Tue, 05 Sep 2023 07:54:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ctXI1vAgVua1DQvvuF/IvtUNvDeBYd0bzAqagmg8kgQ=; b=cSthk9Eh5b53 iSbCjSEWtiXN5OSY3SYkBZ/R86opoBABFT3sIsAOjLCbcda+jnlhjP+AU378IL+HjyeVAHDwTqiMD 3/EpYYiiQSBLqmnLAba1nRgCAhs09fHlCnitJSF4b1N13ydA8yPjn6Ohxd3rPRV1iofM/cm6DGbM5 fEVxo8b7cdP2L74ZxifupgBVfPCSp0y3+Btp32CWsXZRl7DgwzHVZe/sVpF5BMBVrlDg9ClcvxWFu Lxs6qmwqOMh0AHSlIMag4jycwW41ao/AFCeFEZfBexdPD0iYeP0/HAOwkjmWCVCeFvA47C37xD/6X 6jwAi526Vjn2SXltcbeJkQ==; Date: Tue, 05 Sep 2023 14:54:26 +0300 Message-Id: <83h6o84yz1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ihor Radchenko <yantar92@HIDDEN> In-Reply-To: <87tts8vrpb.fsf@localhost> (message from Ihor Radchenko on Tue, 05 Sep 2023 10:29:20 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@HIDDEN> <87tts8vrpb.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN, iota@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN > From: Ihor Radchenko <yantar92@HIDDEN> > Date: Tue, 05 Sep 2023 10:29:20 +0000 > > As I described in the above, Org needs more control over the behaviour of > `kill-line'/`kill-whole-line' when the visible line contains multiple > lines of hidden text - to protect accidental deletions. > A hook, where Org can intervene with a yes/no prompt, would be useful. > It would also make sense to group the two edits together via > `combine-after-change-calls', although a more universal way to know that > certain edits are a part of the same known command (even when called > non-interactively) would be useful. The command kills in two parts for a good reason, which is explained in the comments to the code. So making a single group will not work, I think, at least not in all situations. And relying on after-change hooks to fix this use case sounds too obscure and fragile to me. Moreover, I don't think this is specific to Org: any mode that folds or hides portions of text might hit the same problem. So we could decide that this command needs to become smarter when the visual line includes invisible text. That is, improve the command without making any Org-specific changes anywhere. Patches to that effect are welcome. > In addition, `org-kill-line' acts specially in certain scenarios: > > For > * Heading <point> text :tag1:tag2: > > `org-kill-line' will keep and re-align ":tag1:tag2:": > > * Heading <point> :tag1:tag2: > > It would be nice if we could express such behavior without overriding > the `kill-line' command. This could be handled by a suitable extension to end-of-visible-line. For example, introduce a new text property which end-of-visible-line would then handle the same as it currently handles invisible text.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 5 Sep 2023 10:28:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 06:28:42 2023 Received: from localhost ([127.0.0.1]:54125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdTIY-0007Li-77 for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 06:28:42 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <yantar92@HIDDEN>) id 1qdTIU-0007LT-Pj for 65734 <at> debbugs.gnu.org; Tue, 05 Sep 2023 06:28:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5DFA3240027 for <65734 <at> debbugs.gnu.org>; Tue, 5 Sep 2023 12:28:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693909712; bh=8Ah3fNK74InKWYUdXrhkbtS79qxkX3g3JM3vIBnS/tQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=fvr6vd3OsTvPJ0dPiGV8RusGR2Gaao9z9eETXKgginJAZLQj/ciXYGAb3cK/uiSSs /AIbhawcdEupgnp31UB8JyJdzYklo6FeTG2kho6+VYm4qv93v4yTLGHbhEU5o9fQt3 WTnGM4BeHsGVkDViXXXdX2HSqwrHZVwkcwl0KBz6koalkhrr9sdCghio2/1xjUlt1W uK6AM3z+rFnkFez2ED8rUM8Hrp61jikPWAc0fgWgIxpQ/BcX0TnB6a9Dgc+/ceZLYF aNkakYq2RAAveRcTNTjKrAjcZDr7DtRKD3TB7KE54k5s99i9HQTK2Sm0RM3I9ugR29 IYmDgs8JjfGnw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rg1tl2WVnz6trs; Tue, 5 Sep 2023 12:28:31 +0200 (CEST) From: Ihor Radchenko <yantar92@HIDDEN> To: Sebastian Miele <iota@HIDDEN> Subject: Re: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <87il8pao4l.fsf@HIDDEN> References: <87il8pao4l.fsf@HIDDEN> Date: Tue, 05 Sep 2023 10:29:20 +0000 Message-ID: <87tts8vrpb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org, emacs-orgmode@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Sebastian Miele <iota@HIDDEN> writes: > I first reported this to bug-gnu-emacs@HIDDEN (see > https://debbugs.gnu.org/65734). However, Eli asks: > >> I'm not sure I understand why this is deemed a problem in Emacs. >> Shouldn't Org redefine C-S-<backspace> if the default binding doesn't >> suit what happens in Org buffers? Did you discuss this with Org >> developers? Confirmed. I am CCing debbugs as I'd like to clarify things to be in sync with Emacs. > In an emacs -Q, create an Org buffer with the following contents: > > --8<---------------cut here---------------start------------->8--- > * AB > ** C > --8<---------------cut here---------------end--------------->8--- This will produce * AB... > Fold the subtree under the heading AB, so that only a single line is > displayed (ending in "..."). With point between A and B, hit > C-S-<backspace> (kill-whole-line). > > Expected: The whole _visible_ line, i.e., the entire contents of the > buffer is erased. Actual behavior: The line with heading C remains. This indeed happens because `kill-whole-line' deletes the line in two steps: "* A" and then the rest. The first deletion leaves B<begin invisible> ** C<end invisible> which drastically alters the outline structure and triggers or to automatically unfold the subtree, leaving B ** C visible. Then, `kill-whole-line' proceeds with the second part of the deletion and deletes the now visible line, leading to the observed behaviour. The first deletion would be an equivalent of deleting "(defun" (defun foo ()... in outline-mode and would make it hard to unfold the body, if such single deletion where performed. In Org mode, because of frequent user requests about accidental deletions of hidden text, we try our best to protect deletions of invisible folded outlines. Automatic unfolding is one of the ways to attract user's attention to potential accidental edit. > Contrast this with the same experiment, except that the point is at the > beginning of the line containing AB when hitting C-S-<backspace>. Then > the expected behavior happens. According to the source of > kill-whole-line, the intended effect indeed is to kill a whole _visible_ > line. Currently, Org mode, similar to Eli's suggestion re-binds `kill-line' to Org's own version - `org-kill-line'. But not `kill-whole-line'. We can certainly do the same for `kill-whole-line', but in our previous discussion https://yhetil.org/emacs-devel/87tu8rq2l6.fsf@localhost/, you asked to consider extending the built-in Emacs commands instead of overriding them. As I described in the above, Org needs more control over the behaviour of `kill-line'/`kill-whole-line' when the visible line contains multiple lines of hidden text - to protect accidental deletions. A hook, where Org can intervene with a yes/no prompt, would be useful. It would also make sense to group the two edits together via `combine-after-change-calls', although a more universal way to know that certain edits are a part of the same known command (even when called non-interactively) would be useful. In addition, `org-kill-line' acts specially in certain scenarios: For * Heading <point> text :tag1:tag2: `org-kill-line' will keep and re-align ":tag1:tag2:": * Heading <point> :tag1:tag2: It would be nice if we could express such behavior without overriding the `kill-line' command. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at 65734) by debbugs.gnu.org; 4 Sep 2023 15:21:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 04 11:21:13 2023 Received: from localhost ([127.0.0.1]:52284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdBO4-0002kZ-J9 for submit <at> debbugs.gnu.org; Mon, 04 Sep 2023 11:21:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qdBO1-0002jz-VM for 65734 <at> debbugs.gnu.org; Mon, 04 Sep 2023 11:21:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qdBNw-0004JS-IH; Mon, 04 Sep 2023 11:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7ahRt/wjTK4lHDvlmLpmIr0eHW6Abli8IxWhkqYZoP4=; b=aU45XwACF08a v/8SP8pdHSrV7txvOrSaUgP+ccxmCG4+iKn5nSXbiV2lEC5kKIOdNYe+Ui66SjKzqStxVTJ+8bs4b EFsDnC+Twe2EflqnsdOTyBE7cJlNzuTU98DccKtoeO4hSHPxLOW0X38fRFrNw7ar5b2LC5E4fp9p0 cmfVp6AclIS65hIGaAEQJVotEDxph55lVhuyugJjIAxgYOrQ4zlrP81fVRcOIdUfWuYFvpLg0b2FK W+Ryj89lQkNWsLGcnWU1dn8Q0M7ekABnjoSyUn2qm2cG0s+kCrt/jGNnPwLMmfhMUW8md53ZrPczD zNoJikJZ9r4VZfV7KODDLw==; Date: Mon, 04 Sep 2023 18:20:46 +0300 Message-Id: <8334zu55ip.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Sebastian Miele <iota@HIDDEN> In-Reply-To: <877cp6atag.fsf@HIDDEN> (message from Sebastian Miele on Mon, 04 Sep 2023 16:44:19 +0200) Subject: Re: bug#65734: 29.1.50; kill-whole-line and visibility of Org subtrees References: <877cp6atag.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65734 Cc: 65734 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Sebastian Miele <iota@HIDDEN> > Date: Mon, 04 Sep 2023 16:44:19 +0200 > > In an emacs -Q, create an Org buffer with the following contents: > > <-----cut-here-----> > * AB > ** C > <-----cut-here-----> > > Fold the subtree under the heading AB, so that only a single line is > diplayed (ending in "..."). With point between A and B, hit > C-S-<backspace> (kill-whole-line). > > Expected: The whole _visible_ line, i.e., the entire contents of the > buffer is erased. Actual behavior: The line with heading C remains. > > Contrast this with the same experiment, except that the point is at the > beginning of the line containing AB when hitting C-S-<backspace>. Then > the expected behavior happens. And according to the source of > kill-whole-line, the intended effect indeed is to kill a whole _visible_ > line. > > The following patch fixes the issue: > > diff --git a/lisp/simple.el b/lisp/simple.el > index abd587245fe..44221f3fc24 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -6649,9 +6649,7 @@ kill-whole-line > (unless (bobp) (backward-char)) > (point)))) > (t > - (save-excursion > - (kill-region (point) (progn (forward-visible-line 0) (point)))) > - (kill-region (point) > + (kill-region (save-excursion (forward-visible-line 0) (point)) > (progn (forward-visible-line arg) (point)))))) > > (defun forward-visible-line (arg) > > The reason for the issue probably is: Without the patch, the killing > happens in two stages. The first kill-region kills from the beginning > of the line until after the A. That kills the leading *. That probably > somehow triggers Org visibility changes. With the patch applied the > whole killing happens in one stage, probably without causing an > intermediate change of visibility. I'm not sure I understand why this is deemed a problem in Emacs. Shouldn't Org redefine C-S-<backspace> if the default binding doesn't suit what happens in Org buffers? Did you discuss this with Org developers? Thanks.
bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 4 Sep 2023 14:48:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 04 10:48:48 2023 Received: from localhost ([127.0.0.1]:52156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdAsh-0007UE-FB for submit <at> debbugs.gnu.org; Mon, 04 Sep 2023 10:48:48 -0400 Received: from lists.gnu.org ([2001:470:142::17]:43234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iota@HIDDEN>) id 1qdAse-0007U0-Dn for submit <at> debbugs.gnu.org; Mon, 04 Sep 2023 10:48:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iota@HIDDEN>) id 1qdAsY-0006kH-Qm for bug-gnu-emacs@HIDDEN; Mon, 04 Sep 2023 10:48:38 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <iota@HIDDEN>) id 1qdAsV-0004f3-Nb for bug-gnu-emacs@HIDDEN; Mon, 04 Sep 2023 10:48:38 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4RfWj53xDBz9sq3 for <bug-gnu-emacs@HIDDEN>; Mon, 4 Sep 2023 16:48:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1693838905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6Huq3AG4xSZflw5Niv52R/X7Zyuny0jyJiF91e4h/m8=; b=Qnj0Npve51aCohXN9JhsUWCOeAjaMxjylcE43pNpmr1giz7XZruFiQmtBM6+bYiJuLs3KI n5BR1xXRqoYnV7U0lt2PsQxuwzq9CrbfVgIeWGg6OjRDkkrXYRQDRwQ2UE1WCFKmuEYX6J XGyU/qvQ5jJHnYEvlU74sm/IQw7Dvvv/8Ttc5umWhys3Mm6HNvitVUPGucdnP91xolxs9X A37snohwihK82Yd3sOx/BNnqlLr4Xyo3KqIyVIMZEGQEVJzmfaaq2+Vo6o89/2gQev1fZC /0v9/rGhQH7b4CMpNLwZcUhhaAeexapUApd7aRFHUVH8NgK9rjGHjGFGEdswpA== From: Sebastian Miele <iota@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.1.50; kill-whole-line and visibility of Org subtrees Date: Mon, 04 Sep 2023 16:44:19 +0200 Message-ID: <877cp6atag.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4RfWj53xDBz9sq3 Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=iota@HIDDEN; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) In an emacs -Q, create an Org buffer with the following contents: <-----cut-here-----> * AB ** C <-----cut-here-----> Fold the subtree under the heading AB, so that only a single line is diplayed (ending in "..."). With point between A and B, hit C-S-<backspace> (kill-whole-line). Expected: The whole _visible_ line, i.e., the entire contents of the buffer is erased. Actual behavior: The line with heading C remains. Contrast this with the same experiment, except that the point is at the beginning of the line containing AB when hitting C-S-<backspace>. Then the expected behavior happens. And according to the source of kill-whole-line, the intended effect indeed is to kill a whole _visible_ line. The following patch fixes the issue: diff --git a/lisp/simple.el b/lisp/simple.el index abd587245fe..44221f3fc24 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -6649,9 +6649,7 @@ kill-whole-line (unless (bobp) (backward-char)) (point)))) (t - (save-excursion - (kill-region (point) (progn (forward-visible-line 0) (point)))) - (kill-region (point) + (kill-region (save-excursion (forward-visible-line 0) (point)) (progn (forward-visible-line arg) (point)))))) (defun forward-visible-line (arg) The reason for the issue probably is: Without the patch, the killing happens in two stages. The first kill-region kills from the beginning of the line until after the A. That kills the leading *. That probably somehow triggers Org visibility changes. With the patch applied the whole killing happens in one stage, probably without causing an intermediate change of visibility. In GNU Emacs 29.1.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-09-04 built on huette Repository revision: 5cbe96d17f67e58091de1653f409d87bcc2b3e99 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Arch Linux Configured using: 'configure --with-x-toolkit=gtk --with-native-compilation --with-tree-sitter --with-json --with-mailutils --with-imagemagick' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode cl-loaddefs cl-lib bytecomp byte-compile rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 66653 8786) (symbols 48 7137 0) (strings 32 20076 3360) (string-bytes 1 606691) (vectors 16 16454) (vector-slots 8 296368 15462) (floats 8 29 22) (intervals 56 240 0) (buffers 984 12))
Sebastian Miele <iota@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#65734; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.