GNU bug report logs - #65738
[PATCH] Fix java-ts-mode tests

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65738 in the body.
You can then email your comments to 65738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Cc: Theodor Thornhill <theo <at> thornhill.no>
Subject: [PATCH] Fix java-ts-mode tests
Date: Mon, 04 Sep 2023 11:42:18 -0500

[Message part 1 (text/plain, inline)]

Tags: patch

Attached is a patch to make the java-ts-mode tests pass (and adds Java
to the build-module script). Currently they fail with the message:

Running 2 tests (2023-09-04 11:33:58-0500, selector ‘t’)
Test java-ts-mode-test-indentation backtrace:
  cdr(java)
  mapcan(cdr (java (sexp "\\(?:_type\\|a\\(?:ccess\\|nnotation\\|rgume
  treesit-thing-defined-p(sexp nil)
  treesit-major-mode-setup()
  (let ((delay-mode-hooks t)) (prog-mode) (setq major-mode 'java-ts-mo
  (progn (make-local-variable 'delay-mode-hooks) (let ((delay-mode-hoo
  java-ts-mode()
  (lambda nil (setq indent-tabs-mode nil) (setq java-ts-mode-indent-of
  ert-test--erts-test(((dummy . t) (code)) "/home/jm/src/emacs/test/li
  ert-test-erts-file("/home/jm/src/emacs/test/lisp/progmodes/java-ts-m
  (closure (t) nil (let* ((fn-0 #'treesit-ready-p) (args-1 (condition-
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name java-ts-mode-test-indentation :docume
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test 
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "/home/jm/src/emacs/lisp/progmodes/java-ts-mode
  command-line()
  normal-top-level()
Test java-ts-mode-test-indentation condition:
    (wrong-type-argument listp java)
   FAILED  1/2  java-ts-mode-test-indentation (0.000824 sec) at test/lisp/progmodes/java-ts-mode-tests.el:26
Test java-ts-mode-test-movement backtrace:
  cdr(java)
  mapcan(cdr (java (sexp "\\(?:_type\\|a\\(?:ccess\\|nnotation\\|rgume
  treesit-thing-defined-p(sexp nil)
  treesit-major-mode-setup()
  (let ((delay-mode-hooks t)) (prog-mode) (setq major-mode 'java-ts-mo
  (progn (make-local-variable 'delay-mode-hooks) (let ((delay-mode-hoo
  java-ts-mode()
  (lambda nil (java-ts-mode) (forward-sentence 1))()
  ert-test--erts-test(((dummy . t) (code)) "/home/jm/src/emacs/test/li
  ert-test-erts-file("/home/jm/src/emacs/test/lisp/progmodes/java-ts-m
  (closure (t) nil (let* ((fn-5 #'treesit-ready-p) (args-6 (condition-
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name java-ts-mode-test-movement :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [... ...] :te
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "/home/jm/src/emacs/lisp/progmodes/java-ts-mode
  command-line()
  normal-top-level()
Test java-ts-mode-test-movement condition:
    (wrong-type-argument listp java)
   FAILED  2/2  java-ts-mode-test-movement (0.000795 sec) at test/lisp/progmodes/java-ts-mode-tests.el:30

Ran 2 tests, 0 results as expected, 2 unexpected (2023-09-04 11:33:58-0500, 0.128382 sec)

2 unexpected results:
   FAILED  java-ts-mode-test-indentation
   FAILED  java-ts-mode-test-movement



In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-08-29 built on localhost
Repository revision: fb9312722f7b0166f178b601811213a576be5ae4
Repository branch: main
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation=aot --with-pgtk
 --prefix=/home/jm/.opt'

[0001-Fix-java-ts-mode-tests.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 65738-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: 65738-done <at> debbugs.gnu.org, theo <at> thornhill.no
Subject: Re: bug#65738: [PATCH] Fix java-ts-mode tests
Date: Thu, 07 Sep 2023 12:07:34 +0300

> Cc: Theodor Thornhill <theo <at> thornhill.no>
> Date: Mon, 04 Sep 2023 11:42:18 -0500
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Attached is a patch to make the java-ts-mode tests pass (and adds Java
> to the build-module script). Currently they fail with the message:

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.