GNU bug report logs - #65739
[PATCH] Add Ruby to the tree-sitter build-module script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65739 in the body.
You can then email your comments to 65739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add Ruby to the tree-sitter build-module script
Date: Mon, 04 Sep 2023 12:09:50 -0500

[Message part 1 (text/plain, inline)]

Tags: patch

While looking at the java-ts-modes tests I noticed Ruby was missing from
the build-module script.



In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-08-29 built on localhost
Repository revision: fb9312722f7b0166f178b601811213a576be5ae4
Repository branch: main
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation=aot --with-pgtk
 --prefix=/home/jm/.opt'

[0001-Add-Ruby-to-the-tree-sitter-build-module-script.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 65739 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>, 65739 <at> debbugs.gnu.org
Cc: Perry Smith <pedz <at> easesoftware.com>, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
Date: Mon, 4 Sep 2023 12:16:57 -0700

john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> Tags: patch
>
> While looking at the java-ts-modes tests I noticed Ruby was missing from
> the build-module script.

Yuan and Perry, any comments here?

> In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
>  3.24.38, cairo version 1.17.8) of 2023-08-29 built on localhost
> Repository revision: fb9312722f7b0166f178b601811213a576be5ae4
> Repository branch: main
> System Description: Fedora Linux 38 (Workstation Edition)
>
> Configured using:
>  'configure --with-native-compilation=aot --with-pgtk
>  --prefix=/home/jm/.opt'
>
> From cb73036bb916bef5fd5b862b935d8d564d7f6771 Mon Sep 17 00:00:00 2001
> From: john muhl <jm <at> pub.pink>
> Date: Mon, 4 Sep 2023 12:08:34 -0500
> Subject: [PATCH] Add Ruby to the tree-sitter build-module script
>
> * admin/notes/tree-sitter/build-module/batch.sh (languages): Add
> Ruby.
> ---
>  admin/notes/tree-sitter/build-module/batch.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/batch.sh b/admin/notes/tree-sitter/build-module/batch.sh
> index 1d4076564dc..ec7231dd82f 100755
> --- a/admin/notes/tree-sitter/build-module/batch.sh
> +++ b/admin/notes/tree-sitter/build-module/batch.sh
> @@ -16,6 +16,7 @@ languages=
>      'javascript'
>      'json'
>      'python'
> +    'ruby'
>      'rust'
>      'toml'
>      'tsx'
> --
> 2.41.0

Message #11 received at 65739 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Stefan Kangas <stefankangas <at> gmail.com>, john muhl <jm <at> pub.pink>,
 65739 <at> debbugs.gnu.org
Cc: Perry Smith <pedz <at> easesoftware.com>, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
Date: Tue, 5 Sep 2023 04:07:28 +0300

On 04/09/2023 22:16, Stefan Kangas wrote:
> john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors"<bug-gnu-emacs <at> gnu.org>  writes:
> 
>> Tags: patch
>>
>> While looking at the java-ts-modes tests I noticed Ruby was missing from
>> the build-module script.
> Yuan and Perry, any comments here?

Am neither, but this looks "obviously correct" to me without testing 
(the ruby grammar doesn't need any special settings to compile).

Message #16 received at 65739-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 65739-done <at> debbugs.gnu.org
Subject: Re: bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
Date: Wed, 10 Jan 2024 13:42:34 -0800

Version: 30.1

john muhl <jm <at> pub.pink> writes:

> Tags: patch
>
> While looking at the java-ts-modes tests I noticed Ruby was missing from
> the build-module script.

Thanks, installed on master (a0133f63450) and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.