GNU bug report logs - #65742
30.0.50; default-toplevel-value and forwarded symbols

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65742 in the body.
You can then email your comments to 65742 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; default-toplevel-value and forwarded symbols
Date: Mon, 04 Sep 2023 21:02:59 +0200

[Message part 1 (text/plain, inline)]

Function default-toplevel-value does not take let-bindings for forwarded
symbols into account.

(progn
  (defvar my-var nil)
  (setq my-var t)
  (let ((my-var :let))
    (default-toplevel-value 'my-var)))
=> t

(progn
  (setq lexical-binding t)
  (let ((lexical-binding :let))
    (default-toplevel-value 'lexical-binding)))
=> nil

[0001-default-toplevel-value-nor-working-for-forwarded-sym.patch (text/x-patch, inline)]

From d6cd84bcd1bb86d32d49e660d4041f655bf295f1 Mon Sep 17 00:00:00 2001
From: Gerd Moellmann <gerd.moellmann <at> gmail.com>
Date: Mon, 4 Sep 2023 20:48:28 +0200
Subject: [PATCH] default-toplevel-value nor working for forwarded syms

* src/eval.c (default_toplevel_binding): Handle SPECPDL_LET_LOCAL.
---
 src/eval.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/eval.c b/src/eval.c
index 9268b65aa85..59055a75782 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -664,6 +664,7 @@ default_toplevel_binding (Lisp_Object symbol)
     {
       switch ((--pdl)->kind)
 	{
+	case SPECPDL_LET_LOCAL:
 	case SPECPDL_LET_DEFAULT:
 	case SPECPDL_LET:
 	  if (EQ (specpdl_symbol (pdl), symbol))
-- 
2.42.0

Message #8 received at 65742 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 65742 <at> debbugs.gnu.org
Subject: Re: bug#65742: 30.0.50; default-toplevel-value and forwarded symbols
Date: Mon, 04 Sep 2023 22:18:21 +0300

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Date: Mon, 04 Sep 2023 21:02:59 +0200
> 
> Function default-toplevel-value does not take let-bindings for forwarded
> symbols into account.
> 
> (progn
>   (defvar my-var nil)
>   (setq my-var t)
>   (let ((my-var :let))
>     (default-toplevel-value 'my-var)))
> => t
> 
> (progn
>   (setq lexical-binding t)
>   (let ((lexical-binding :let))
>     (default-toplevel-value 'lexical-binding)))
> => nil
> 
> >From d6cd84bcd1bb86d32d49e660d4041f655bf295f1 Mon Sep 17 00:00:00 2001
> From: Gerd Moellmann <gerd.moellmann <at> gmail.com>
> Date: Mon, 4 Sep 2023 20:48:28 +0200
> Subject: [PATCH] default-toplevel-value nor working for forwarded syms
> 
> * src/eval.c (default_toplevel_binding): Handle SPECPDL_LET_LOCAL.
> ---
>  src/eval.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/eval.c b/src/eval.c
> index 9268b65aa85..59055a75782 100644
> --- a/src/eval.c
> +++ b/src/eval.c
> @@ -664,6 +664,7 @@ default_toplevel_binding (Lisp_Object symbol)
>      {
>        switch ((--pdl)->kind)
>  	{
> +	case SPECPDL_LET_LOCAL:
>  	case SPECPDL_LET_DEFAULT:
>  	case SPECPDL_LET:
>  	  if (EQ (specpdl_symbol (pdl), symbol))
> -- 
> 2.42.0

Adding Stefan.

Message #11 received at 65742 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 65742 <at> debbugs.gnu.org
Subject: Re: bug#65742: 30.0.50; default-toplevel-value and forwarded symbols
Date: Mon, 04 Sep 2023 15:24:31 -0400

> Function default-toplevel-value does not take let-bindings for forwarded
> symbols into account.
>
> (progn
>   (defvar my-var nil)
>   (setq my-var t)
>   (let ((my-var :let))
>     (default-toplevel-value 'my-var)))
> => t
>
> (progn
>   (setq lexical-binding t)
>   (let ((lexical-binding :let))
>     (default-toplevel-value 'lexical-binding)))
> => nil

Looks right to me: `lexical-binding` is set buffer-locally by the
`setq`, so the global/toplevel value is not affected.


        Stefan

Message #14 received at 65742 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 65742 <at> debbugs.gnu.org
Subject: Re: bug#65742: 30.0.50; default-toplevel-value and forwarded symbols
Date: Mon, 04 Sep 2023 21:55:09 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Function default-toplevel-value does not take let-bindings for forwarded
>> symbols into account.
>>
>> (progn
>>   (defvar my-var nil)
>>   (setq my-var t)
>>   (let ((my-var :let))
>>     (default-toplevel-value 'my-var)))
>> => t
>>
>> (progn
>>   (setq lexical-binding t)
>>   (let ((lexical-binding :let))
>>     (default-toplevel-value 'lexical-binding)))
>> => nil
>
> Looks right to me: `lexical-binding` is set buffer-locally by the
> `setq`, so the global/toplevel value is not affected.

Right, I forgot the setq.  How embarrasing.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.