GNU bug report logs - #65743
[PATCH 0/2] gnu: python-qtsass: Update to 0.4.0, fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65743 in the body.
You can then email your comments to 65743 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 0/2] gnu: python-qtsass: Update to 0.4.0, fix build.
Date: Mon,  4 Sep 2023 20:18:00 +0100

Hi Guix!

As I investigated the circular dependency between (gnu packages python-xyz)
and (gnu packages astronomy), I discovered several packages that were failing
to build and had only a few dependencies. To resolve this issue, I have
created a patch set that includes minor tweaks and updates.

Sharlatan Hellseher (2):
  gnu: python-libsass: Update to 0.22.0.
  gnu: python-qtsass: Update to 0.4.0, fix build.

 gnu/packages/python-xyz.scm | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)


base-commit: 710d9050524213a83e4ce9efe9765d7fbc233839
-- 
2.40.1

Message #8 received at 65743 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65743 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 1/2] gnu: python-libsass: Update to 0.22.0.
Date: Mon,  4 Sep 2023 20:19:44 +0100

* gnu/packages/python-xyz.scm (python-libsass): Update to 0.22.0.
[phases]: Add new phase 'silent-failing-tests and disable 2 failing
tests to complete build.
---
 gnu/packages/python-xyz.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a950de3b46..5410f294d5 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14359,7 +14359,7 @@ (define-public python-idna
 (define-public python-libsass
   (package
     (name "python-libsass")
-    (version "0.20.1")
+    (version "0.22.0")
     (source
      (origin
        ;; PyPI tarball is missing some test files.
@@ -14369,7 +14369,7 @@ (define-public python-libsass
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1r0kgl7i6nnhgjl44sjw57k08gh2qr7l8slqih550dyxbf1akbxh"))))
+        (base32 "0j6c7jb1bnpmz76gs5za41qwgrs7v1yd1jkgvsy5ql6dg2ph9vp4"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -14377,6 +14377,14 @@ (define-public python-libsass
          ;; Use Guix package of libsass instead of compiling from a checkout.
          (add-before 'build 'set-libsass
            (lambda _ (setenv "SYSTEM_SASS" "indeed")))
+         ;; XXX: Silent 2 failing test, check why they are failing.
+         (add-before 'check 'silent-failing-tests
+           (lambda _
+             (substitute* "sasstests.py"
+               (("def test_build_one")
+                "def __off_test_build_one")
+               (("def test_stack_trace_formatting")
+                "def __off_test_stack_trace_formatting"))))
          (replace 'check
            (lambda* (#:key tests? #:allow-other-keys)
              (when tests?
-- 
2.40.1

Message #11 received at 65743 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65743 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 2/2] gnu: python-qtsass: Update to 0.4.0, fix build.
Date: Mon,  4 Sep 2023 20:19:45 +0100

* gnu/packages/python-xyz.scm (python-qtsass): Update to 0.4.0, fix
build.
[native-inputs]: Add python-flaky.
---
 gnu/packages/python-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5410f294d5..16bb186a29 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -30006,7 +30006,7 @@ (define-public python-helper
 (define-public python-qtsass
   (package
     (name "python-qtsass")
-    (version "0.3.0")
+    (version "0.4.0")
     (source
      (origin
        ;; There are no tests in the PyPI tarball.
@@ -30016,7 +30016,7 @@ (define-public python-qtsass
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "09s04aa14d8jqbh71clrb5y7vcmkxlp94mwmvzrkxahry3bk03cb"))))
+        (base32 "1skdihfby2f41zxgwa5zv44vdxjrw301rh88rjmzj4xbdlix6cig"))))
     (build-system python-build-system)
     (arguments
      `(#:test-target "pytest"
@@ -30028,7 +30028,7 @@ (define-public python-qtsass
              (for-each make-file-writable (find-files "."))
              #t)))))
     (native-inputs
-     (list python-pytest python-pytest-cov python-pytest-runner))
+     (list python-flaky python-pytest python-pytest-cov python-pytest-runner))
     (propagated-inputs
      (list python-libsass))
     (home-page "https://github.com/spyder-ide/qtsass")
-- 
2.40.1

Message #14 received at 65743 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: jgart <jgart <at> dismail.de>, 65743 <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>
Subject: Re: bug#65743: [PATCH 0/2] gnu: python-qtsass: Update to 0.4.0, fix
 build.
Date: Tue, 05 Sep 2023 09:20:27 -0400

Hi Sharlatan,

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> * gnu/packages/python-xyz.scm (python-libsass): Update to 0.22.0.
> [phases]: Add new phase 'silent-failing-tests and disable 2 failing
> tests to complete build.
> ---
>  gnu/packages/python-xyz.scm | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index a950de3b46..5410f294d5 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -14359,7 +14359,7 @@ (define-public python-idna
>  (define-public python-libsass
>    (package
>      (name "python-libsass")
> -    (version "0.20.1")
> +    (version "0.22.0")
>      (source
>       (origin
>         ;; PyPI tarball is missing some test files.
> @@ -14369,7 +14369,7 @@ (define-public python-libsass
>               (commit version)))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "1r0kgl7i6nnhgjl44sjw57k08gh2qr7l8slqih550dyxbf1akbxh"))))
> +        (base32 "0j6c7jb1bnpmz76gs5za41qwgrs7v1yd1jkgvsy5ql6dg2ph9vp4"))))
>      (build-system python-build-system)
>      (arguments
>       '(#:phases
> @@ -14377,6 +14377,14 @@ (define-public python-libsass
>           ;; Use Guix package of libsass instead of compiling from a checkout.
>           (add-before 'build 'set-libsass
>             (lambda _ (setenv "SYSTEM_SASS" "indeed")))
> +         ;; XXX: Silent 2 failing test, check why they are failing.
> +         (add-before 'check 'silent-failing-tests
> +           (lambda _
> +             (substitute* "sasstests.py"
> +               (("def test_build_one")
> +                "def __off_test_build_one")
> +               (("def test_stack_trace_formatting")
> +                "def __off_test_stack_trace_formatting"))))

In my experience, it's nice to do a minimal investigation up-front and
report upstream; otherwise odds are that it will never happen :-).

-- 
Thanks,
Maxim

Message #17 received at 65743 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65743 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH v2 1/2] gnu: python-libsass: Update to 0.22.0.
Date: Tue,  5 Sep 2023 23:24:29 +0100

* gnu/packages/python-xyz.scm (python-libsass): Update to 0.22.0.
[phases]: Add new phase 'silent-failing-tests and disable 2 failing
tests to complete build.
---
 gnu/packages/python-xyz.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a950de3b46..cdf5ee6293 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14359,7 +14359,7 @@ (define-public python-idna
 (define-public python-libsass
   (package
     (name "python-libsass")
-    (version "0.20.1")
+    (version "0.22.0")
     (source
      (origin
        ;; PyPI tarball is missing some test files.
@@ -14369,7 +14369,7 @@ (define-public python-libsass
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1r0kgl7i6nnhgjl44sjw57k08gh2qr7l8slqih550dyxbf1akbxh"))))
+        (base32 "0j6c7jb1bnpmz76gs5za41qwgrs7v1yd1jkgvsy5ql6dg2ph9vp4"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -14377,6 +14377,17 @@ (define-public python-libsass
          ;; Use Guix package of libsass instead of compiling from a checkout.
          (add-before 'build 'set-libsass
            (lambda _ (setenv "SYSTEM_SASS" "indeed")))
+         ;; XXX: Silent 2 failing tests, reported to upstream (closed), see
+         ;; https://github.com/sass/libsass-python/issues/440.  It passed with
+         ;; libsass <at> 3.6.5 which requires rebuild the world (1200+ packages),
+         ;; remove when v3.6.5 is available.
+         (add-before 'check 'silent-failing-tests
+           (lambda _
+             (substitute* "sasstests.py"
+               (("def test_build_one")
+                "def __off_test_build_one")
+               (("def test_stack_trace_formatting")
+                "def __off_test_stack_trace_formatting"))))
          (replace 'check
            (lambda* (#:key tests? #:allow-other-keys)
              (when tests?
-- 
2.41.0

Message #20 received at 65743 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65743 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH v2 2/2] gnu: python-qtsass: Update to 0.4.0, fix build.
Date: Tue,  5 Sep 2023 23:24:30 +0100

* gnu/packages/python-xyz.scm (python-qtsass): Update to 0.4.0, fix
build.
[native-inputs]: Add python-flaky.
---
 gnu/packages/python-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index cdf5ee6293..1d273bbb4d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -30009,7 +30009,7 @@ (define-public python-helper
 (define-public python-qtsass
   (package
     (name "python-qtsass")
-    (version "0.3.0")
+    (version "0.4.0")
     (source
      (origin
        ;; There are no tests in the PyPI tarball.
@@ -30019,7 +30019,7 @@ (define-public python-qtsass
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "09s04aa14d8jqbh71clrb5y7vcmkxlp94mwmvzrkxahry3bk03cb"))))
+        (base32 "1skdihfby2f41zxgwa5zv44vdxjrw301rh88rjmzj4xbdlix6cig"))))
     (build-system python-build-system)
     (arguments
      `(#:test-target "pytest"
@@ -30031,7 +30031,7 @@ (define-public python-qtsass
              (for-each make-file-writable (find-files "."))
              #t)))))
     (native-inputs
-     (list python-pytest python-pytest-cov python-pytest-runner))
+     (list python-flaky python-pytest python-pytest-cov python-pytest-runner))
     (propagated-inputs
      (list python-libsass))
     (home-page "https://github.com/spyder-ide/qtsass")
-- 
2.41.0

Message #25 received at 65743-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: jgart <jgart <at> dismail.de>, 65743-done <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, guix-patches <at> gnu.org
Subject: Re: [bug#65743] [PATCH v2 2/2] gnu: python-qtsass: Update to 0.4.0,
 fix build.
Date: Wed, 13 Sep 2023 09:46:56 +0100

[Message part 1 (text/plain, inline)]

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> * gnu/packages/python-xyz.scm (python-qtsass): Update to 0.4.0, fix
> build.
> [native-inputs]: Add python-flaky.
> ---
>  gnu/packages/python-xyz.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks, I've pushed both of these patches to master as
7f150a18957daddb53caf11e23eb12122198d65c.

I tweaked the commit message in the first one just to mention the update
in the first line, then the previously failing tests later.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.