GNU bug report logs - #65755
[PATCH 0/3] Mark some packages as not supported on the hurd.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65755 in the body.
You can then email your comments to 65755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Mark some packages as not supported on the hurd.
Date: Tue, 05 Sep 2023 12:17:12 +0100

[Message part 1 (text/plain, inline)]

Mark some packages as not supported on the hurd.

Christopher Baines (3):
  gnu: musl-cross: Remove i586-gnu from supported-systems.
  gnu: linux-libre-headers: Remove i586-gnu from supported-systems.
  gnu: skalibs: Remove i586-gnu from %supported-systems.

 gnu/packages/heads.scm   | 1 +
 gnu/packages/linux.scm   | 1 +
 gnu/packages/skarnet.scm | 1 +
 3 files changed, 3 insertions(+)


base-commit: e7b6cd86ef856b52817428227f9c3d3297312262
-- 
2.41.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 65755 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: skalibs: Remove i586-gnu from %supported-systems.
Date: Tue,  5 Sep 2023 12:35:12 +0100

* gnu/packages/skarnet.scm (skalibs)[supported-systems]: Remove i586-gnu.
---
 gnu/packages/skarnet.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm
index 2c7b0f9c23..6781e2eb58 100644
--- a/gnu/packages/skarnet.scm
+++ b/gnu/packages/skarnet.scm
@@ -49,6 +49,7 @@ (define-public skalibs
                       (substitute* "Makefile"
                         (("\\$\\(wildcard src/lib\\*/\\*.c\\)")
                          "$(sort $(wildcard src/lib*/*.c))")))))))
+    (supported-systems (delete "i586-gnu" %supported-systems))
     (home-page "https://skarnet.org/software/skalibs/")
     (synopsis "Platform abstraction libraries for skarnet.org software")
     (description
-- 
2.41.0

Message #11 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 65755 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: linux-libre-headers: Remove i586-gnu from
 supported-systems.
Date: Tue,  5 Sep 2023 12:35:11 +0100

As I don't think attempting to build for the Hurd is useful.

* gnu/packages/heads.scm (make-linux-libre-headers*): Remove i586-gnu from
supported-systems.
---
 gnu/packages/linux.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 9142f6edf1..9e28eb44ad 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -737,6 +737,7 @@ (define (make-linux-libre-headers* version gnu-revision source)
                    (format p "~a-default~%" ,version)))))))
        #:allowed-references ()
        #:tests? #f))
+    (supported-systems (delete "i586-gnu" %supported-systems))
     (home-page "https://www.gnu.org/software/linux-libre/")
     (synopsis "GNU Linux-Libre kernel headers")
     (description "Headers of the Linux-Libre kernel.")
-- 
2.41.0

Message #14 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 65755 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: musl-cross: Remove i586-gnu from supported-systems.
Date: Tue,  5 Sep 2023 12:35:10 +0100

As I don't think musl supports the Hurd.

* gnu/packages/heads.scm (musl-cross)[supported-systems]: Remove i586-gnu.
---
 gnu/packages/heads.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/heads.scm b/gnu/packages/heads.scm
index 212849f2a9..268d4d0198 100644
--- a/gnu/packages/heads.scm
+++ b/gnu/packages/heads.scm
@@ -158,6 +158,7 @@ (define-public musl-cross
            (uri "http://www.musl-libc.org/releases/musl-1.1.24.tar.gz")
            (sha256
             (base32 "18r2a00k82hz0mqdvgm7crzc7305l36109c0j9yjmkxj2alcjw0k"))))))
+    (supported-systems (delete "i586-gnu" %supported-systems))
     (home-page "https://github.com/osresearch/heads")
     (synopsis "Musl-cross gcc 5 toolchain")
     (description "Musl-cross toolchain: binutils, gcc 5 and musl.")

base-commit: e7b6cd86ef856b52817428227f9c3d3297312262
-- 
2.41.0

Message #17 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 65755 <at> debbugs.gnu.org
Subject: Re: bug#65755: [PATCH 0/3] Mark some packages as not supported on
 the hurd.
Date: Tue, 12 Sep 2023 09:21:53 +0200

Hi,

Christopher Baines <mail <at> cbaines.net> skribis:

>   gnu: musl-cross: Remove i586-gnu from supported-systems.
>   gnu: linux-libre-headers: Remove i586-gnu from supported-systems.
>   gnu: skalibs: Remove i586-gnu from %supported-systems.

LGTM!

Ludo’.

Message #22 received at 65755-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65755-done <at> debbugs.gnu.org
Subject: Re: bug#65755: [PATCH 0/3] Mark some packages as not supported on
 the hurd.
Date: Tue, 12 Sep 2023 08:46:04 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>>   gnu: musl-cross: Remove i586-gnu from supported-systems.
>>   gnu: linux-libre-headers: Remove i586-gnu from supported-systems.
>>   gnu: skalibs: Remove i586-gnu from %supported-systems.
>
> LGTM!

Great, I've pushed this to master as
53f510dad6cc1b55b4abdbbfd55e507a9463a80f.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: 65755 <at> debbugs.gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>, Christopher Baines <mail <at> cbaines.net>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: This broke make check on master
Date: Fri, 15 Sep 2023 20:32:02 +0200

Hi,

Marius found that building the updated "guix" package on the
just-rebased hurd-team branch failed.

It turns out that the packages.scm test on master fails notably:
package-transitive-supported-systems, implicit inputs

--8<---------------cut here---------------start------------->8---
test-name: package-transitive-supported-systems, implicit inputs
location: /home/janneke/src/guix/master/tests/packages.scm:496
source:
+ (test-equal
+   "package-transitive-supported-systems, implicit inputs"
+   %supported-systems
+   (let ((p (dummy-package
+              "foo"
+              (build-system gnu-build-system)
+              (supported-systems
+                `("does-not-exist" "foobar" ,@%supported-systems)))))
+     (parameterize
+       ((%current-system "armhf-linux"))
+       (package-transitive-supported-systems p))))
expected-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "i586-gnu" "powerpc-linux")
actual-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "powerpc-linux")
result: FAIL
--8<---------------cut here---------------end--------------->8---

The culprit is this commit

    0e08ad7f19d5b29a4883468552b5d213a7bdb66e
    gnu: linux-libre-headers: Remove i586-gnu from supported-systems.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Message #28 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 65755 <at> debbugs.gnu.org,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: This broke make check on master
Date: Fri, 15 Sep 2023 19:56:06 +0100

[Message part 1 (text/plain, inline)]

Janneke Nieuwenhuizen <janneke <at> gnu.org> writes:

> Marius found that building the updated "guix" package on the
> just-rebased hurd-team branch failed.
>
> It turns out that the packages.scm test on master fails notably:
> package-transitive-supported-systems, implicit inputs
>
> test-name: package-transitive-supported-systems, implicit inputs
> location: /home/janneke/src/guix/master/tests/packages.scm:496
> source:
> + (test-equal
> +   "package-transitive-supported-systems, implicit inputs"
> +   %supported-systems
> +   (let ((p (dummy-package
> +              "foo"
> +              (build-system gnu-build-system)
> +              (supported-systems
> +                `("does-not-exist" "foobar" ,@%supported-systems)))))
> +     (parameterize
> +       ((%current-system "armhf-linux"))
> +       (package-transitive-supported-systems p))))
> expected-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "i586-gnu" "powerpc-linux")
> actual-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "powerpc-linux")
> result: FAIL

I would say interesting, but I've struggled with the supported system
stuff for years. The data service does use
package-transitive-supported-systems, but in a very weird way. To check
if a package supports a system, you call
package-transitive-supported-systems with the package and system (as the
second optional argument), then check if that system is present in the
returned list.

This is to say that in my uninformed opinion, the presence of the system
which you pass to package-transitive-supported-systems in the returned
list seems to mean something, but I wouldn't be able to say anything
else about the returned value.

I don't think there's anything wrong with adjusting the expectation to
have the test pass, but to me the longer term thing to do is look at
changing the code around supported systems.

On not breaking tests when making changes though, I don't generally run
make check unless I'm changing code in guix/ but it would be nice to
start QA doing that for every patch series. We should also probably try
to avoid tests that break when making changes to packages.

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 65755 <at> debbugs.gnu.org,
 Janneke Nieuwenhuizen <janneke <at> gnu.org>
Subject: Re: bug#65755: [PATCH 0/3] Mark some packages as not supported on
 the hurd.
Date: Fri, 15 Sep 2023 21:43:53 +0200

Christopher Baines <mail <at> cbaines.net> skribis:

> Janneke Nieuwenhuizen <janneke <at> gnu.org> writes:
>
>> Marius found that building the updated "guix" package on the
>> just-rebased hurd-team branch failed.
>>
>> It turns out that the packages.scm test on master fails notably:
>> package-transitive-supported-systems, implicit inputs
>>
>> test-name: package-transitive-supported-systems, implicit inputs
>> location: /home/janneke/src/guix/master/tests/packages.scm:496
>> source:
>> + (test-equal
>> +   "package-transitive-supported-systems, implicit inputs"
>> +   %supported-systems
>> +   (let ((p (dummy-package
>> +              "foo"
>> +              (build-system gnu-build-system)
>> +              (supported-systems
>> +                `("does-not-exist" "foobar" ,@%supported-systems)))))
>> +     (parameterize
>> +       ((%current-system "armhf-linux"))
>> +       (package-transitive-supported-systems p))))
>> expected-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "i586-gnu" "powerpc-linux")
>> actual-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "powerpc-linux")
>> result: FAIL

[...]

> I don't think there's anything wrong with adjusting the expectation to
> have the test pass, but to me the longer term thing to do is look at
> changing the code around supported systems.

Agreed, we need to change the expected result to:

  (filter target-linux? %supported-systems)

This is expected given that ‘%current-system’ is set to *-linux.

> On not breaking tests when making changes though, I don't generally run
> make check unless I'm changing code in guix/ but it would be nice to
> start QA doing that for every patch series.

Yes!

> We should also probably try to avoid tests that break when making
> changes to packages.

We try to avoid it but there are a few cases where we test real packages
that we hope rarely change.

Thanks,
Ludo’.

Message #34 received at 65755 <at> debbugs.gnu.org (full text, mbox):

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65755 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>,
 Christopher Baines <mail <at> cbaines.net>
Subject: Re: bug#65755: [PATCH 0/3] Mark some packages as not supported on
 the hurd.
Date: Fri, 15 Sep 2023 22:06:18 +0200

Ludovic Courtès writes:

Hi,

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Janneke Nieuwenhuizen <janneke <at> gnu.org> writes:
>>
>>> Marius found that building the updated "guix" package on the
>>> just-rebased hurd-team branch failed.
[..]

>> I don't think there's anything wrong with adjusting the expectation to
>> have the test pass, but to me the longer term thing to do is look at
>> changing the code around supported systems.
>
> Agreed, we need to change the expected result to:
>
>   (filter target-linux? %supported-systems)
>
> This is expected given that ‘%current-system’ is set to *-linux.

That makes sense (and fixes it :)

Pushed to master as edca2863bcb52388fe454e14136264a4f7490273

Thanks!
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.