GNU bug report logs - #65762
[PATCH] ; Fix error in 'tex-recenter-output-buffer'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65762 in the body.
You can then email your comments to 65762 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Tue, 05 Sep 2023 19:12:41 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

This fixes an issue in `tex-recenter-output-buffer` (which affect
several other commands that rely on it) where it calls `display-buffer`
and tries to select the returned window, without checking that
`display-buffer` returned non-nil.  This leads to an error when
`display-tex-shell-buffer-action` or `display-buffer-alist` are
configured to prevent the display of the *tex-shell* buffer.

[0001-Fix-error-in-tex-recenter-output-buffer.patch (text/patch, attachment)]

Message #8 received at 65762 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>, Tassilo Horn <tsdh <at> gnu.org>
Cc: 65762 <at> debbugs.gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 13:57:11 +0300

> Date: Tue, 05 Sep 2023 19:12:41 +0200
> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> This fixes an issue in `tex-recenter-output-buffer` (which affect
> several other commands that rely on it) where it calls `display-buffer`
> and tries to select the returned window, without checking that
> `display-buffer` returned non-nil.  This leads to an error when
> `display-tex-shell-buffer-action` or `display-buffer-alist` are
> configured to prevent the display of the *tex-shell* buffer.

Thanks.  Tassilo, any comments?

Message #11 received at 65762 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Eshel Yaron <me <at> eshelyaron.com>, 65762 <at> debbugs.gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 13:03:26 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

Hi Eshel & Eli,

>> This fixes an issue in `tex-recenter-output-buffer` (which affect
>> several other commands that rely on it) where it calls
>> `display-buffer` and tries to select the returned window, without
>> checking that `display-buffer` returned non-nil.  This leads to an
>> error when `display-tex-shell-buffer-action` or
>> `display-buffer-alist` are configured to prevent the display of the
>> *tex-shell* buffer.
>
> Thanks.  Tassilo, any comments?

Yes, looks right in cases where display-tex-shell-buffer-action is
display-buffer-no-window or maybe something similar is achieved by
display-buffer-alist which would lead to errors right now.  But I'm no
authority here, tex-mode.el is not tex.el (from auctex).

Bye,
Tassilo

Message #14 received at 65762 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>, martin rudalics <rudalics <at> gmx.at>
Cc: me <at> eshelyaron.com, 65762 <at> debbugs.gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 15:27:14 +0300

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eshel Yaron <me <at> eshelyaron.com>, 65762 <at> debbugs.gnu.org
> Date: Wed, 06 Sep 2023 13:03:26 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> Hi Eshel & Eli,
> 
> >> This fixes an issue in `tex-recenter-output-buffer` (which affect
> >> several other commands that rely on it) where it calls
> >> `display-buffer` and tries to select the returned window, without
> >> checking that `display-buffer` returned non-nil.  This leads to an
> >> error when `display-tex-shell-buffer-action` or
> >> `display-buffer-alist` are configured to prevent the display of the
> >> *tex-shell* buffer.
> >
> > Thanks.  Tassilo, any comments?
> 
> Yes, looks right in cases where display-tex-shell-buffer-action is
> display-buffer-no-window or maybe something similar is achieved by
> display-buffer-alist which would lead to errors right now.  But I'm no
> authority here, tex-mode.el is not tex.el (from auctex).

Thanks.

Martin, any further comments?

Message #17 received at 65762 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Tassilo Horn <tsdh <at> gnu.org>
Cc: me <at> eshelyaron.com, 65762 <at> debbugs.gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 6 Sep 2023 18:21:18 +0200

> Martin, any further comments?

The patch looks good and should be applied.

martin

Message #22 received at 65762-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 65762-done <at> debbugs.gnu.org, me <at> eshelyaron.com, tsdh <at> gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 19:39:10 +0300

> Date: Wed, 6 Sep 2023 18:21:18 +0200
> Cc: me <at> eshelyaron.com, 65762 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> 
>  > Martin, any further comments?
> 
> The patch looks good and should be applied.

Thanks, installed on the emacs-29 branch and closing the bug.

Message #25 received at 65762-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 65762-done <at> debbugs.gnu.org, me <at> eshelyaron.com,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 6 Sep 2023 09:51:02 -0700

Version: 30.1

martin rudalics <rudalics <at> gmx.at> writes:

>> Martin, any further comments?
>
> The patch looks good and should be applied.

Thanks, installed on master as commit ba7690c230a.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.