GNU logs - #65788, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?=
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 06 Sep 2023 16:58:02 +0000
Resent-Message-ID: <handler.65788.B.169401947928510 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 65788 <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
Date: Wed, 06 Sep 2023 18:57:38 +0200
Message-ID: <87pm2vme7x.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::333;
 envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x333.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi,

Tangential of bug#65787 [1], the annoyance is the order of the updates.
It leads to poor messages.  Let exemplify at the extreme case.

--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 28	sept. 06 2023 14:54:50	(current)
  guix 6113e05
    repository URL: https://git.savannah.gnu.org/git/guix.git
    commit: 6113e0529d61df7425f64e30a6bf77f7cfdfe5a5

$ rm -fr ~/.cache/guix/checkouts/pjmkglp4t7znuugeurpurzikxq3tnlaywmisyr27sh=
j7apsnalwq

$ guix time-machine -q --commit=3D6113e05 -- describe
receiving objects   2% =E2=96=95=E2=96=88=E2=96=8B
    =E2=80=A6some time flies=E2=80=A6
indexing objects  21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=
=96=88=E2=96=88                                                            =
                           =E2=96=8F
    =E2=80=A6some time flies=E2=80=A6
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.or=
g/git/guix.git'...
   =E2=80=A6instant=E2=80=A6
Computing Guix derivation for 'x86_64-linux'... \
--8<---------------cut here---------------end--------------->8---

The reason is because the logic:

        (when (procedure? validate-channels)
          (validate-channels channels))
        (run-with-store store
          (mlet* %store-monad ((instances
                                -> (latest-channel-instances store channels
                                                             #:authenticate?
                                                             authenticate?))

where =E2=80=99validate-channels=E2=80=99 (validate-guix-channel) reads,

                (checkout commit relation (update-cached-checkout
                                           (channel-url guix-channel)
                                           #:ref reference
                                           #:starting-commit
                                           %oldest-possible-commit)))

and =E2=80=99latest-channel-instances=E2=80=99 which is the ones that displ=
ays,

                     (format (current-error-port)
                             (G_ "Updating channel '~a' from Git repository=
 at '~a'...~%")
                             (channel-name channel)
                             (channel-url channel))


this =E2=80=99latest-channel-instances=E2=80=99 reads under the hood,

               ((checkout commit relation)
                (update-cached-checkout (channel-url channel)
                                        #:ref (channel-reference channel)
                                        #:starting-commit starting-commit)))


Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals.  So=
mehow, it is
in guix/scripts/ because it captures =E2=80=99ref=E2=80=99.  However, this =
capture is
redundant and is normally managed by =E2=80=99channel-list=E2=80=99.  There=
fore, I would
be tempted to have this validation for the reachable commit close to the
=E2=80=9CUpdating=E2=80=9D message.

WDYT?

Cheers,
simon


1: <https://issues.guix.gnu.org/issue/65787>

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: bug#65788: Acknowledgement (poor information when updating using
 =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?=)
Message-ID: <handler.65788.B.169401947928510.ack <at> debbugs.gnu.org>
References: <87pm2vme7x.fsf@HIDDEN>
X-Gnu-PR-Message: ack 65788
X-Gnu-PR-Package: guix
Reply-To: 65788 <at> debbugs.gnu.org
Date: Wed, 06 Sep 2023 16:58:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 65788 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
65788: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65788
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?=
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 28 Oct 2023 14:18:03 +0000
Resent-Message-ID: <handler.65788.B65788.16985026597252 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Simon Tournier <zimon.toutoune@HIDDEN>
Cc: 65788 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87pm2vme7x.fsf@HIDDEN> (Simon Tournier's message of "Wed, 06
 Sep 2023 18:57:38 +0200")
References: <87pm2vme7x.fsf@HIDDEN>
Date: Sat, 28 Oct 2023 16:16:56 +0200
Message-ID: <875y2q96hz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

(Cc: Maxim.)

Simon Tournier <zimon.toutoune@HIDDEN> skribis:

> $ guix time-machine -q --commit=3D6113e05 -- describe
> receiving objects   2% =E2=96=95=E2=96=88=E2=96=8B
>     =E2=80=A6some time flies=E2=80=A6
> indexing objects  21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=
=96=88=E2=96=88                                                            =
                           =E2=96=8F
>     =E2=80=A6some time flies=E2=80=A6
> Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.=
org/git/guix.git'...
>    =E2=80=A6instant=E2=80=A6
> Computing Guix derivation for 'x86_64-linux'... \

To be clear, the problem you see is that =E2=80=9CUpdating channel=E2=80=9D=
 is printed
too late, after =E2=80=9Creceiving objects=E2=80=9D etc., right?

> Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals.  =
Somehow, it is
> in guix/scripts/ because it captures =E2=80=99ref=E2=80=99.  However, thi=
s capture is
> redundant and is normally managed by =E2=80=99channel-list=E2=80=99.  The=
refore, I would
> be tempted to have this validation for the reachable commit close to the
> =E2=80=9CUpdating=E2=80=9D message.

Yes, that=E2=80=99s a good idea.

As I started looking into it, I realized we could reuse the existing
#:validate-pull mechanism of =E2=80=98latest-channel-instances=E2=80=99 for=
 the purposes
of this commit check in =E2=80=98time-machine=E2=80=99.

The main advantage is that this would address a performance issue with
the implementation of =E2=80=98validate-guix-channel=E2=80=99 in commit
79ec651a286c71a3d4c72be33a1f80e76a560031, namely the fact that it opens
and traverses the repository one extra time for this check.  (The
#:validate-pull mechanism is integrated with =E2=80=98latest-channel-instan=
ces=E2=80=99
precisely to avoid this cost.)

Here=E2=80=99s my proposal to do that:

  https://issues.guix.gnu.org/66793

Ludo=E2=80=99.

PS: We should define rules for =E2=80=9CReviewed-by=E2=80=9D tags because I=
 don=E2=80=99t think
    I LGTM=E2=80=99d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).

Message sent to bug-guix@HIDDEN:

Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?=
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 31 Oct 2023 14:57:02 +0000
Resent-Message-ID: <handler.65788.B65788.169876420226224 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 65788 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <875y2q96hz.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 28 Oct 2023 16:16:56 +0200")
References: <87pm2vme7x.fsf@HIDDEN> <875y2q96hz.fsf@HIDDEN>
Date: Tue, 31 Oct 2023 10:55:54 -0400
Message-ID: <87bkcesux1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

[...]

> PS: We should define rules for =E2=80=9CReviewed-by=E2=80=9D tags because=
 I don=E2=80=99t think
>     I LGTM=E2=80=99d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).

It was a friendly credit added based on substantial comments I received
and acted upon from your review,
e.g. https://issues.guix.gnu.org/64746#7.

I don't mind if we codify to add these only when the reviewer added
their 'LGTM' approval stamp; there's an ongoing change adding some
guidelines for reviews in bug#66436, we should add this bit in.

--=20
Thanks,
Maxim

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#65788: poor information when updating using =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?time-machine=E2=80=9D?=
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 19 Dec 2023 14:44:02 +0000
Resent-Message-ID: <handler.65788.B65788.17029969838556 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 65788
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 65788 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 65788-submit <at> debbugs.gnu.org id=B65788.17029969838556
          (code B ref 65788); Tue, 19 Dec 2023 14:44:02 +0000
Received: (at 65788) by debbugs.gnu.org; 19 Dec 2023 14:43:03 +0000
Received: from localhost ([127.0.0.1]:35152 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFbJE-0002D8-6l
	for submit <at> debbugs.gnu.org; Tue, 19 Dec 2023 09:43:03 -0500
Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:40298)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1rFbJ9-0002CW-4f
 for 65788 <at> debbugs.gnu.org; Tue, 19 Dec 2023 09:42:55 -0500
Received: by mail-wm1-x335.google.com with SMTP id
 5b1f17b1804b1-40c2655da63so11651845e9.1
 for <65788 <at> debbugs.gnu.org>; Tue, 19 Dec 2023 06:42:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1702996967; x=1703601767; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=NF8FPIfSVi02+SLpcETjP3Xo9oPD0Zcj+7NykSbMI4U=;
 b=AWsaQ80dJqmK1RgpsjVJLpeU986w5cWKplTR29TKOz+JSbyjIRRJKIMVSw6pdS8fSi
 VtzVZqJ9pYiUF5sLX8G+hBDvUiY0NySqmNibRmTYthSZ8T0AdeKF4IQw9NNRuz+U1ZP9
 IiGf0Vr4bmYgxbb8UHIYwHxl2f0H1I7rTsCZ4Z48MLw6JMiZs76v64cgOFRMOqaNLsi3
 pPhQSz8sFpuBUW7zw9NDo6YA0zIXIiVMnAQn81oUM/IRMKV2pxC1brf9Kiwc/VGP8Azp
 qeMGhbnJzW3rZsQTBY/MP+hkpBogNPEnlvw5QKkBpw3W75XLvvLfzbsJOnOUMHdyHI2I
 fzUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1702996967; x=1703601767;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=NF8FPIfSVi02+SLpcETjP3Xo9oPD0Zcj+7NykSbMI4U=;
 b=jEqfA/eBL0tOhT3nyWzoChSYHrz/nQKH20pDT4Qjj9TJMB5QbegoNaRWoV0XZroNGu
 q5BqaEs9LqCn7H/v5IY52llQC4kr3OdR7MNKQLF65TWC/YhWosXjXLBFz6fjhG9kmD5Y
 turlkRgsHoGMN9izyS1didblh3X9iUGCVBd+9LgGTbPG2g/RRUEhy8VviaDPxd83uZ8h
 1rk95QLbmM/nlSq1A59cbepee57udIV2vjVKkG+tFPpY36S1App+jWmx6uQjaQrwWJhX
 v7DJhMdT5tleVB2oeLae+rsKEsc8c8BRnLWHcYsoLqncq7X8R4qiauqsB7dM/khO9p3m
 VmcQ==
X-Gm-Message-State: AOJu0Ywl2tCM7zLFIeLvDDy/z6KApri7Nn9BBIcWdVpGbkUda3mP1beb
 uoiH+C0ufAfD7c2whfP1m+E=
X-Google-Smtp-Source: AGHT+IFdgZ0NHA2ns3i923UMG3z9foog3OwYEohuvxoQIJMJ1tmq6EEeU4dyQN0bk6IXbaKrmm8Bcw==
X-Received: by 2002:a05:600c:3b23:b0:40c:6e2a:35ec with SMTP id
 m35-20020a05600c3b2300b0040c6e2a35ecmr8444020wms.0.1702996966585; 
 Tue, 19 Dec 2023 06:42:46 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
 o21-20020a05600c4fd500b0040c5cf930e6sm3102238wmq.19.2023.12.19.06.42.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 19 Dec 2023 06:42:46 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <875y2q96hz.fsf@HIDDEN>
References: <87pm2vme7x.fsf@HIDDEN> <875y2q96hz.fsf@HIDDEN>
Date: Tue, 19 Dec 2023 15:36:51 +0100
Message-ID: <87h6ke45to.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,

On Sat, 28 Oct 2023 at 16:16, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:

>> Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. =
 Somehow, it is
>> in guix/scripts/ because it captures =E2=80=99ref=E2=80=99.  However, th=
is capture is
>> redundant and is normally managed by =E2=80=99channel-list=E2=80=99.  Th=
erefore, I would
>> be tempted to have this validation for the reachable commit close to the
>> =E2=80=9CUpdating=E2=80=9D message.
>
> Yes, that=E2=80=99s a good idea.
>
> As I started looking into it, I realized we could reuse the existing
> #:validate-pull mechanism of =E2=80=98latest-channel-instances=E2=80=99 f=
or the purposes
> of this commit check in =E2=80=98time-machine=E2=80=99.

[...]

> Here=E2=80=99s my proposal to do that:
>
>   https://issues.guix.gnu.org/66793

This improvement does not address this issue with
%oldest-possible-commit, right?

In addition, we also need to consider =E2=80=99inferior-for-channels=E2=80=
=99 which
calls =E2=80=99cached-channel-instance=E2=80=99 =E2=80=93 currently with th=
e default (const #t)
for #:validate-channels.

For an instance of bug with inferiors, please look at:

        Dependence on an old version of a package.
        Philippe Veber <philippe.veber@HIDDEN>
        Sun, 10 Dec 2023 09:18:50 +0100
        id:CAOOOohRJu0QH+czx3qAwNxCY0X9JBd4NdUd9vjBvt-kDFCHkmA@HIDDEN=
om
        https://lists.gnu.org/archive/html/help-guix/2023-12
        https://yhetil.org/guix/CAOOOohRJu0QH+czx3qAwNxCY0X9JBd4NdUd9vjBvt-=
kDFCHkmA@HIDDEN


Cheers,
simon

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.