GNU bug report logs - #65792
[PATCH] gnu: rottlog: Add gawk as an input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65792 in the body.
You can then email your comments to 65792 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Skyler <skyvine <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: rottlog: Add gawk as an input.
Date: Thu, 07 Sep 2023 02:01:51 +0000

[Message part 1 (text/plain, inline)]

This avoids an issue where rottlog will delete the entire /tmp directory
if gawk is not installed.

* gnu/packages/admin.scm (rottlog): Add gawk input, also update the
patch-paths build phase for awk invocations.
---
gnu/packages/admin.scm | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 604cd70c02..ea437e9f26 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1931,7 +1931,11 @@ (define-public rottlog
(lambda* (#:key inputs #:allow-other-keys)
(substitute* "rc/rc"
(("/usr/sbin/sendmail")
- (search-input-file inputs "/bin/mail")))))
+ (search-input-file inputs "/bin/mail")))
+ (with-fluids ((%default-port-encoding "ISO-8859-1"))
+ (substitute* "src/rottlog"
+ (("awk")
+ (search-input-file inputs "/bin/awk"))))))
(add-after 'build 'set-packdir
(lambda _
;; Set a default location for archived logs.
@@ -1950,7 +1954,7 @@ (define-public rottlog
(lambda _
(invoke "make" "install-info"))))))
(native-inputs (list autoconf automake texinfo util-linux)) ; for 'cal'
- (inputs (list coreutils mailutils))
+ (inputs (list coreutils gawk mailutils))
(home-page "https://www.gnu.org/software/rottlog/")
(synopsis "Log rotation and management")
(description

base-commit: e365c26a34fa485f9af46538fcea128db681c33d
--
2.41.0

[Message part 2 (text/html, inline)]

Message #8 received at 65792 <at> debbugs.gnu.org (full text, mbox):

From: Skyler <skyvine <at> protonmail.com>
To: "65792 <at> debbugs.gnu.org" <65792 <at> debbugs.gnu.org>
Subject: (No Subject)
Date: Thu, 07 Sep 2023 17:17:25 +0000

[Message part 1 (text/plain, inline)]

Additional context: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65793

[Message part 2 (text/html, inline)]

Message #17 received at 65792-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Skyler <skyvine <at> protonmail.com>
Cc: 65792-done <at> debbugs.gnu.org
Subject: Re: bug#65792: [PATCH] gnu: rottlog: Add gawk as an input.
Date: Thu, 14 Sep 2023 16:54:06 +0200

Hi,

Skyler <skyvine <at> protonmail.com> skribis:

> This avoids an issue where rottlog will delete the entire /tmp directory
> if gawk is not installed.
>
> * gnu/packages/admin.scm (rottlog): Add gawk input, also update the
> patch-paths build phase for awk invocations.

Applied, thank you, and thanks for explaining!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.