GNU bug report logs - #65813
[PATCH] Fix elixir-ts-mode with embedded heex

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65813 in the body.
You can then email your comments to 65813 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Cc: Yuan Fu <casouri <at> gmail.com>
Subject: [PATCH] Fix elixir-ts-mode with embedded heex
Date: Thu, 07 Sep 2023 15:46:47 -0500

[Message part 1 (text/plain, inline)]

Tags: patch

The elixir test with embedded heex fails after d05494a9ff8. Restoring
the ‘(when (eq (treesit-parser-language parser) language)’ part fixes
it. The call to ‘(treesit-parser-list language)’ was not working right
either since t-p-l expects the optional argument to be a buffer but
language is a string like "heex".

[0001-Check-embedded-languages-use-the-correct-parser.patch (text/patch, attachment)]

Message #10 received at 65813-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 65813-done <at> debbugs.gnu.org
Subject: Re: bug#65813: [PATCH] Fix elixir-ts-mode with embedded heex
Date: Thu, 7 Sep 2023 16:06:10 -0700

[Message part 1 (text/plain, inline)]

> On Sep 7, 2023, at 1:46 PM, john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
> 
> Tags: patch
> 
> The elixir test with embedded heex fails after d05494a9ff8. Restoring
> the ‘(when (eq (treesit-parser-language parser) language)’ part fixes
> it. The call to ‘(treesit-parser-list language)’ was not working right
> either since t-p-l expects the optional argument to be a buffer but
> language is a string like "heex".
> 

[0001-Check-embedded-languages-use-the-correct-parser.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

Thank you very much, John. I pushed a fix to master.

Yuan

Message #13 received at 65813-done <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 65813-done <at> debbugs.gnu.org
Subject: Re: bug#65813: [PATCH] Fix elixir-ts-mode with embedded heex
Date: Thu, 07 Sep 2023 19:09:27 -0500

Yuan Fu <casouri <at> gmail.com> writes:

>> On Sep 7, 2023, at 1:46 PM, john muhl via Bug reports for GNU Emacs,
>> the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>> 
>> Tags: patch
>> 
>> The elixir test with embedded heex fails after d05494a9ff8. Restoring
>> the ‘(when (eq (treesit-parser-language parser) language)’ part fixes
>> it. The call to ‘(treesit-parser-list language)’ was not working right
>> either since t-p-l expects the optional argument to be a buffer but
>> language is a string like "heex".
>> 
>
> [2. text/patch; 0001-Check-embedded-languages-use-the-correct-parser.patch]...
>
>
> Thank you very much, John. I pushed a fix to master.

You’re welcome. Tests (not just elixir) are now complaining about
‘treesit-local-parsers-in’ being missing.

  Test ruby-ts-indent-empty-if-else condition:
      (void-function treesit-local-parsers-in)

Message #16 received at 65813-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 65813-done <at> debbugs.gnu.org
Subject: Re: bug#65813: [PATCH] Fix elixir-ts-mode with embedded heex
Date: Thu, 7 Sep 2023 17:46:29 -0700

> On Sep 7, 2023, at 5:09 PM, john muhl <jm <at> pub.pink> wrote:
> 
> Yuan Fu <casouri <at> gmail.com> writes:
> 
>>> On Sep 7, 2023, at 1:46 PM, john muhl via Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>>> 
>>> Tags: patch
>>> 
>>> The elixir test with embedded heex fails after d05494a9ff8. Restoring
>>> the ‘(when (eq (treesit-parser-language parser) language)’ part fixes
>>> it. The call to ‘(treesit-parser-list language)’ was not working right
>>> either since t-p-l expects the optional argument to be a buffer but
>>> language is a string like "heex".
>>> 
>> 
>> [2. text/patch; 0001-Check-embedded-languages-use-the-correct-parser.patch]...
>> 
>> 
>> Thank you very much, John. I pushed a fix to master.
> 
> You’re welcome. Tests (not just elixir) are now complaining about
> ‘treesit-local-parsers-in’ being missing.
> 
>  Test ruby-ts-indent-empty-if-else condition:
>      (void-function treesit-local-parsers-in)

Seems that I pushed some untested commits with the fix commit. I’ve fixed the problem on master. Thanks for your patience.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.