GNU bug report logs - #65916
[PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65916 in the body.
You can then email your comments to 65916 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".
Date: Wed, 13 Sep 2023 15:39:18 +0200

* gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
'fix-references that remove the * character from the name of the
requirements.
---
 gnu/packages/bioinformatics.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index e24d70e569..06ff34e877 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
     (arguments
      (list
       #:phases
-      '(modify-phases %standard-phases
+      #~(modify-phases %standard-phases
+         (add-after 'unpack 'fix-references
+           (lambda _
+              (substitute* "setup.py"
+                ((".\\*\"") ".0\""))))
          (replace 'check
            (lambda* (#:key tests? #:allow-other-keys)
              (when tests?

base-commit: 9996896dc252a02ba3b17473a685ce8957237546
-- 
2.41.0

Message #10 received at 65916-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 65916-done <at> debbugs.gnu.org
Subject: Re: [bug#65916] [PATCH] gnu: python-hicmatrix: Fix "'build':
 uncaught exception".
Date: Wed, 13 Sep 2023 22:21:32 +0200

Hi, thanks for the patch.

> * gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
> 'fix-references that remove the * character from the name of the
> requirements.
> ---
>  gnu/packages/bioinformatics.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index e24d70e569..06ff34e877 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
>      (arguments
>       (list
>        #:phases
> -      '(modify-phases %standard-phases
> +      #~(modify-phases %standard-phases
> +         (add-after 'unpack 'fix-references
> +           (lambda _
> +              (substitute* "setup.py"
> +                ((".\\*\"") ".0\""))))

I simplified this to remove the “.0”, renamed the phase because it isn’t
about fixing references, and removed the gexp.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.