GNU logs - #66002, boring messages

Message sent to bug-grep@HIDDEN:

Subject: bug#66002: [PATCH] build: suppress suggest-attribute=cold warnings
Resent-From: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-grep@HIDDEN
Resent-Date: Fri, 15 Sep 2023 15:28:02 +0000
Resent-Message-ID: <handler.66002.B.169479162213599 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66002 <at> debbugs.gnu.org
Cc: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
From: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
Date: Fri, 15 Sep 2023 13:45:00 +0000
Message-Id: <20230915134500.1718945-1-glebfm@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=194.107.17.57; envelope-from=glebfm@HIDDEN;
 helo=vmicros1.altlinux.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Mailman-Approved-At: Fri, 15 Sep 2023 11:26:57 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Following the glibc commit glibc-2.38~298 ("Mark various cold functions
as __COLD"), GNU grep build with -flto flag triggers a GCC warning:

sigsegv.c: In function ‘stackoverflow_deinstall_handler.part.0’:
sigsegv.c:1441:1: error: function might be candidate for attribute ‘cold’ [-Werror=suggest-attribute=cold]

* configure.ac (GNULIB_WARN_CFLAGS): Suppress -Wsuggest-attribute=cold.

Tiny-change: yes
---
 configure.ac | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configure.ac b/configure.ac
index 844a259bd..b793cabde 100644
--- a/configure.ac
+++ b/configure.ac
@@ -159,6 +159,11 @@ if test $gl_gcc_warnings != no; then
   # Remove the following and save the result in GNULIB_WARN_CFLAGS.
   nw=
   nw="$nw -Wunused-macros"
+
+  # To prevent warnings in sigsegv.c if the perror function
+  # has "cold" attribute.
+  nw="$nw -Wsuggest-attribute=cold"
+
   gl_WARN_ADD([-Wno-format-nonliteral])
   gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw])
   AC_SUBST([GNULIB_WARN_CFLAGS])
-- 
glebfm

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
Subject: bug#66002: Acknowledgement ([PATCH] build: suppress
 suggest-attribute=cold warnings)
Message-ID: <handler.66002.B.169479162213599.ack <at> debbugs.gnu.org>
References: <20230915134500.1718945-1-glebfm@HIDDEN>
X-Gnu-PR-Message: ack 66002
X-Gnu-PR-Package: grep
X-Gnu-PR-Keywords: patch
Reply-To: 66002 <at> debbugs.gnu.org
Date: Fri, 15 Sep 2023 15:28:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-grep@HIDDEN

If you wish to submit further information on this problem, please
send it to 66002 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66002: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66002
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-grep@HIDDEN:

Subject: bug#66002: [PATCH] build: suppress suggest-attribute=cold warnings
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-grep@HIDDEN
Resent-Date: Sat, 16 Sep 2023 00:05:02 +0000
Resent-Message-ID: <handler.66002.B66002.169482266526153 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>, 66002 <at> debbugs.gnu.org
Message-ID: <0d8eed7c-fd35-66c2-986c-62569e7160a9@HIDDEN>
Date: Fri, 15 Sep 2023 17:04:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
References: <20230915134500.1718945-1-glebfm@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
In-Reply-To: <20230915134500.1718945-1-glebfm@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 9/15/23 08:45, Gleb Fotengauer-Malinovskiy wrote:
> Following the glibc commit glibc-2.38~298 ("Mark various cold functions
> as __COLD"), GNU grep build with -flto flag triggers a GCC warning:
>=20
> sigsegv.c: In function =E2=80=98stackoverflow_deinstall_handler.part.0=E2=
=80=99:
> sigsegv.c:1441:1: error: function might be candidate for attribute =E2=80=
=98cold=E2=80=99 [-Werror=3Dsuggest-attribute=3Dcold]
>=20
> * configure.ac (GNULIB_WARN_CFLAGS): Suppress -Wsuggest-attribute=3Dcol=
d.

I'm not seeing this problem on Fedora 38 when I manually mark error,=20
error_at_line, and perror with _GL_ATTRIBUTE_COLD. I am compiling with=20
gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1) and configuring with=20
"./configure --enable-gcc-warnings 'CC=3Dgcc -flto'". This is grep commit=
=20
102be2bfa571355ff44db39348438a0def1ab382.

If you're using an older GCC, I wouldn't worry about the false alarm,=20
whatever it's about (it's not clear from the diagnostic). The=20
attribute-cold diagnostics are occasionally helpful for minor=20
performance tuning, and are harmless if ignored.

Message sent to bug-grep@HIDDEN:

Subject: bug#66002: [PATCH] build: suppress suggest-attribute=cold warnings
Resent-From: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-grep@HIDDEN
Resent-Date: Sat, 16 Sep 2023 23:06:01 +0000
Resent-Message-ID: <handler.66002.B66002.169490550231938 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Paul Eggert <eggert@HIDDEN>
Cc: 66002 <at> debbugs.gnu.org
Date: Sun, 17 Sep 2023 01:28:53 +0400
From: Gleb Fotengauer-Malinovskiy <glebfm@HIDDEN>
Message-ID: <ZQYeFaerbRNau7Lc@HIDDEN>
References: <20230915134500.1718945-1-glebfm@HIDDEN>
 <0d8eed7c-fd35-66c2-986c-62569e7160a9@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0d8eed7c-fd35-66c2-986c-62569e7160a9@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Fri, Sep 15, 2023 at 05:04:05PM -0700, Paul Eggert wrote:
> On 9/15/23 08:45, Gleb Fotengauer-Malinovskiy wrote:
> > Following the glibc commit glibc-2.38~298 ("Mark various cold functions
> > as __COLD"), GNU grep build with -flto flag triggers a GCC warning:
> > 
> > sigsegv.c: In function ‘stackoverflow_deinstall_handler.part.0’:
> > sigsegv.c:1441:1: error: function might be candidate for attribute ‘cold’ [-Werror=suggest-attribute=cold]
> > 
> > * configure.ac (GNULIB_WARN_CFLAGS): Suppress -Wsuggest-attribute=cold.
> 
> I'm not seeing this problem on Fedora 38 when I manually mark error, 
> error_at_line, and perror with _GL_ATTRIBUTE_COLD. I am compiling with 
> gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1) and configuring with 
> "./configure --enable-gcc-warnings 'CC=gcc -flto'". This is grep commit 
> 102be2bfa571355ff44db39348438a0def1ab382.
> 
> If you're using an older GCC,

I've encountered this warning with a version of GCC that's very similar:
gcc-13 (GCC) 13.2.1 20230817 (ALT Sisyphus 13.2.1-alt2)

I'm not certain what's different in our testing, but I managed to
reproduce it on Fedora 38.  This occurred both when I made a simple edit
to the /usr/include/stdio.h header:
-extern void perror (const char *__s);
+extern void perror (const char *__s) __attribute__ ((__cold__));
and with glibc version 2.38.9000-8.fc40.x86_64 from Rawhide.

> I wouldn't worry about the false alarm, 
> whatever it's about (it's not clear from the diagnostic). The 
> attribute-cold diagnostics are occasionally helpful for minor 
> performance tuning, and are harmless if ignored.

I'm not insisting that this needs to be addressed, but I do believe that
someone else might encounter this issue.

-- 
glebfm

Last modified: Sat, 16 Sep 2023 23:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.