GNU bug report logs - #66038
[PATCH] gnu: muchsync: Update to 7.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66038 in the body.
You can then email your comments to 66038 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hendursaga <hendursaga <at> aol.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: muchsync: Update to 7.
Date: Sat, 16 Sep 2023 17:48:29 -0400

* gnu/packages/mail.scm (muchsync): Update to 7.
---
 gnu/packages/mail.scm | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ecaab1c7cd..d070cf9518 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1621,19 +1621,17 @@ (define-public bower
 (define-public muchsync
   (package
     (name "muchsync")
-    (version "6")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://www.muchsync.org/src/"
-                           "muchsync-" version ".tar.gz"))
-       (sha256
-        (base32 "1s799kx16nm5ry1fcqcc0grgxrwnnp4cnzd0hzwbkvc5v2sf6g8b"))))
+    (version "7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.muchsync.org/src/" "muchsync-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1b5ylf0xgb59x6hna5gllm6nb1jn50wqvp7xfls83x0frmpjygpq"))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list pandoc pkg-config))
-    (inputs
-     (list openssl notmuch sqlite xapian))
+    (native-inputs (list pandoc pkg-config))
+    (inputs (list openssl notmuch sqlite xapian))
     (home-page "https://www.muchsync.org/")
     (synopsis "Synchronize notmuch mail across machines")
     (description

base-commit: 952a0ce2800e4fe9165184151412858ed8d34760
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Hendursaga <hendursaga <at> aol.com>
Cc: 66038-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#66038] [PATCH] gnu: muchsync: Update to 7.
Date: Mon, 25 Sep 2023 11:56:07 +0100

[Message part 1 (text/plain, inline)]

Hendursaga via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/mail.scm (muchsync): Update to 7.
> ---
>  gnu/packages/mail.scm | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)

Thanks for the patch. I've tweaked the patch to remove the indentation
changes, as I wasn't sure those were intentional, and I've added a bit
to the commit message about the change to https, as that seems sensible.

Pushed to master as 7a563a4fafba05db0f423d9c4a7badc8f394182f.

Chris

[signature.asc (application/pgp-signature, inline)]

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hendursaga <hendursaga <at> aol.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 66038-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#66038] [PATCH] gnu: muchsync: Update to 7.
Date: Mon, 25 Sep 2023 13:21:13 -0400

Christopher Baines <mail <at> cbaines.net> writes:

> Thanks for the patch. I've tweaked the patch to remove the indentation
> changes, as I wasn't sure those were intentional[...]

I ran it through `guix style` as I thought one was supposed to do.
Should I have added something to the ChangeLog message to make that more
clear, perhaps?

I don't think I've replied to a "done" issue before, so I hope my
automagically generated Cc's are appropriate!

~ Hendursaga

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Hendursaga <hendursaga <at> aol.com>
Cc: 66038-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#66038] [PATCH] gnu: muchsync: Update to 7.
Date: Mon, 25 Sep 2023 18:54:12 +0100

[Message part 1 (text/plain, inline)]

Hendursaga <hendursaga <at> aol.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Thanks for the patch. I've tweaked the patch to remove the indentation
>> changes, as I wasn't sure those were intentional[...]
>
> I ran it through `guix style` as I thought one was supposed to do.
> Should I have added something to the ChangeLog message to make that more
> clear, perhaps?

Something to the commit message maybe, and it can also be useful to keep
stylistic changes and functional changes in separate commits. So you
would have a "apply guix style" commit and a "update to X" commit.

> I don't think I've replied to a "done" issue before, so I hope my
> automagically generated Cc's are appropriate!

Yep, I think it's fine.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.