Received: (at 66063-done) by debbugs.gnu.org; 25 Sep 2023 17:58:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 25 13:58:51 2023 Received: from localhost ([127.0.0.1]:46601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qkpr9-0003Vd-1K for submit <at> debbugs.gnu.org; Mon, 25 Sep 2023 13:58:51 -0400 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]:54405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1qkpr4-0003VE-8A; Mon, 25 Sep 2023 13:58:49 -0400 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-65b0dad1f98so14948776d6.0; Mon, 25 Sep 2023 10:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695664708; x=1696269508; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=BCkrnQroar2FgpOW8eZz95NTBE+5aAi90fs3Mfhrt7c=; b=cZFZQy/W2lYize5cxK4QsvC0c4P5Qp9J4UiG1SAuMJxudGZoRfzjjCQaEEQVFh25fm 5ZRkwImCSpuUBn2rQTHKCzYLcwbgJ4r6XpwraM7kuyzNeefooPb5GpadTo+Fvg+5aRJ4 8U+Qa/SaFYQRqxh3rMQda3tn4kh8Zn0IcwYvUPrNada6+skN+55C93H45qj3zF1V1VM6 /vZ3C3oLPotQpu6IK4FcWAeMaQ+QXlO/Cfqx4zqgs4nex3EBvrxgOD4nMxa0w8vWXMI3 l407xib3qMDn8+c9UGn7Ixb4oOMhWPFlH0jvgw4wwNOwoa/srG5baXHeUviVH8alcu81 VG3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695664708; x=1696269508; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BCkrnQroar2FgpOW8eZz95NTBE+5aAi90fs3Mfhrt7c=; b=fzAUAWMTFe9zMxYtX2BzgFWQdlTUTF5iYl4jQ29UGCFkH+MqIFblQpUTUjn1my1nqk FzvlGCIvJQ3XOZeN/TU3WnUvqTLHFJHYNcDskvPF3DVURT6yEG2LDyARhx7Yc+Y5e8fG rQ3cH8fZLAXqArNnn5FUIPV60p5/UvEl65W5xC61EY1FoDfw94TXxAoDRZdoitnxwAIF P9+cHrvChYg55AO+Pbm+muK3UylV2RhClbF3eYGHQxYjd5umeg7X7XNyKbGeW0wh5NGZ ZbN41pTC7mqy3K/BeB3p6rh/fAfVupYIbh4eWLte+DXYqhDdP+/LPFmZ32z11H0yamLr gUIA== X-Gm-Message-State: AOJu0YxaD/Iows8n6UbUYcVQQSO0BSWUQ2CaIj6Nh4H6vse0fxhNwcHZ h+/mvooCfxyuqJU/RfAWBek= X-Google-Smtp-Source: AGHT+IEcmZL3t/CUSDwN91lBFoiy4xAI9kcaGET0NKLdnL8QPIUHoGW+mPyaXrBpCmddX2VnIGNLxg== X-Received: by 2002:a05:6214:2f0c:b0:658:2857:ed64 with SMTP id od12-20020a0562142f0c00b006582857ed64mr7671874qvb.18.1695664707982; Mon, 25 Sep 2023 10:58:27 -0700 (PDT) Received: from hurd (dsl-10-130-229.b2b2c.ca. [72.10.130.229]) by smtp.gmail.com with ESMTPSA id b19-20020a0ccd13000000b00646e0411e8csm1268296qvm.30.2023.09.25.10.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 10:58:27 -0700 (PDT) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#66063: [PATCH v2 0/3] Resolve a circular module dependencies in embedded modules References: <cover.1694406359.git.maxim.cournoyer@HIDDEN> <dbe1824a3b222919340538d30ef3948092ba9bc7.1694406359.git.maxim.cournoyer@HIDDEN> <87r0n1kedj.fsf_-_@HIDDEN> <8734zhv49z.fsf@HIDDEN> <87o7i5glwr.fsf@HIDDEN> <877coo715m.fsf@HIDDEN> Date: Mon, 25 Sep 2023 13:58:26 -0400 In-Reply-To: <877coo715m.fsf@HIDDEN> (Maxim Cournoyer's message of "Sun, 17 Sep 2023 20:52:53 -0400") Message-ID: <871qem2kzh.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66063-done Cc: Ricardo Wurmus <rekado@HIDDEN>, 66063-done <at> debbugs.gnu.org, 65860-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes: > Hi Ludovic, > > Ludovic Court=C3=A8s <ludo@HIDDEN> writes: > > [...] > >> I agree that this needs to be addressed. I wondered whether/how hard we >> should search for a different solution. > > OK. I think the current situation needs to be resolved ASAP, but longer > term I'm definitely willing to revisit our strategy when it comes to > cross compiler toolchains. > > [...] > >> BTW, another issue with the package-returning procedures: they return a >> fresh package object at each call, which defeats caching. I think you >> should be able to observe it with: >> >> GUIX_PROFILING=3Dobject-cache guix build axoloti-runtime -d --no-graf= ts >> >> The effect will be more acute on the build farms since they compute >> derivations for everything that depends on these toolchains. >> >> The solution would be to make those procedures memoizing, with =E2=80=98= mlambda=E2=80=99 >> or similar. > > I haven't tried measuring the impact, but I've use mlambda in the v2 > just sent; thanks for the suggesting it! I've now pushed this series. If we can make AVR a native target/platform in Guix, that may make things simpler/nicer, but otherwise, this is at least resolved. --=20 Thanks, Maxim
guix-patches@HIDDEN:bug#66063; Package guix-patches.
Full text available.Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 18 Sep 2023 00:42:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 17 20:42:26 2023
Received: from localhost ([127.0.0.1]:51650 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qi2LJ-0001kw-NG
for submit <at> debbugs.gnu.org; Sun, 17 Sep 2023 20:42:25 -0400
Received: from lists.gnu.org ([2001:470:142::17]:53528)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1qi2LE-0001ke-F2
for submit <at> debbugs.gnu.org; Sun, 17 Sep 2023 20:42:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1qi2L0-0003LC-U4
for guix-patches@HIDDEN; Sun, 17 Sep 2023 20:42:06 -0400
Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1qi2Kz-0000l0-HF
for guix-patches@HIDDEN; Sun, 17 Sep 2023 20:42:06 -0400
Received: by mail-qt1-x82c.google.com with SMTP id
d75a77b69052e-412091b9035so27069471cf.1
for <guix-patches@HIDDEN>; Sun, 17 Sep 2023 17:42:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1694997724; x=1695602524; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=G77VGTyTUSStty3lRb2ULl6KZpQ/rczhAkj/o3X02Jk=;
b=SDmelu6P5xwVxIXj0kFlVl+lpofim5hYbeEDLSvmgQjk4G7YJR+iMNZrUvg856343m
GKIT9w6IXePChSfmMe7IvSd1OoiSePVnTzH9Z2xDXVgduQJVGJECaLbO0mxvxlcCdxfm
7ilJ2i49yCcIuIVJJGoKtRWN/oCagiBeEvCjsgE5KrOSI+HcjJDbAz6V6zxVRR3Labbc
yWUq8qh2G0qe+PpMMmERcK3p5h0jemyYbp2+c+W+cC4mXT5drr8O83qFsbrbW6Ykc0nG
S7Rs2kP/fQYfJwwiIxePcwpOSbijsGa7Chu6U5Gja25wZ8AhIcyhC1AIGDYNkYL5thmJ
jW5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1694997724; x=1695602524;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=G77VGTyTUSStty3lRb2ULl6KZpQ/rczhAkj/o3X02Jk=;
b=dY7UBiIuJgDreRZdSjdELEUqqCXFn8e0SLLzsnRZy03OBIwn+sPnwmt5D1x8UZ9/DA
IkedgVbENr1IQbIRrhhiM/kphGofvRIA4fbavzanZILZfQNljyR/bLIpRFEbAfdaz1sl
NBFslo7YGzXKokekHecA5v9axbGUe2dWQFls9vgqGbD1pulm6Qfds1vRHkpk36EwEoG8
evtLa/GPZs62dFfOYPvtluueEkFpz7o6uWAACcR92c98e/lxYjrPbztHIfPrr3C8hDoT
MrBOSt9Qx+EJ/FgBDM7UGVvLhVSn9jiBNc23pECC6vxKUFotHB1IJEnJVXGfoBDkUSwc
wAcw==
X-Gm-Message-State: AOJu0YyL0M+iJYEfAC3SU6Mr9gIM2DtwzrESq4Z4VhX3mdkU7FHHVGYb
flk1ibI6nDdUGPp8dgY9G+xZ9j45PuY=
X-Google-Smtp-Source: AGHT+IGv4fEmVCqznIVgKBKEtHrQfJqWqa69nAEGKfSS4RHdDZlSu4SEoyOyy1vAgGECiDx6dAjvFA==
X-Received: by 2002:ac8:550f:0:b0:406:56cb:b617 with SMTP id
j15-20020ac8550f000000b0040656cbb617mr8335752qtq.53.1694997724068;
Sun, 17 Sep 2023 17:42:04 -0700 (PDT)
Received: from localhost.localdomain (dsl-10-149-131.b2b2c.ca. [72.10.149.131])
by smtp.gmail.com with ESMTPSA id
d8-20020a05620a166800b0076ceb5eb309sm2791563qko.74.2023.09.17.17.42.02
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 17 Sep 2023 17:42:03 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH v2 0/3] Resolve a circular module dependencies in embedded
modules
Date: Sun, 17 Sep 2023 20:41:52 -0400
Message-ID: <cover.1694997702.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::82c;
envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qt1-x82c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
This series is the culmination of at least a day of effort tracking down the
source of a module dependency cycle (!). The last commit adds some guidelines
in the hope to avoid a repeat (perhaps 'lint' could be taught to
automate these checks).
Changes in v2:
- Use mlambda for procedures
- Fix ((make-avr-toolchain)) typo
- Use mlambda for procedures
Maxim Cournoyer (3):
gnu: avr: Delay all cross compilation packages.
gnu: embedded: Turn packages using top-level variables into
procedures.
doc: Add new 'Circular Module Dependencies' section.
doc/contributing.texi | 56 ++
gnu/packages/avr-xyz.scm | 2 +-
gnu/packages/avr.scm | 214 +++---
gnu/packages/axoloti.scm | 6 +-
gnu/packages/embedded.scm | 1227 ++++++++++++++++++---------------
gnu/packages/raspberry-pi.scm | 2 +-
6 files changed, 838 insertions(+), 669 deletions(-)
base-commit: fc1b4756e36857e66986a30a6652ee988f8f30fd
--
2.41.0
Maxim Cournoyer <maxim.cournoyer@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#66063; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.