GNU bug report logs -
#66071
30.0.50; term-scroll-to-bottom-on-output missing choices
Previous Next
Reported by: Mauro Aranda <maurooaranda <at> gmail.com>
Date: Mon, 18 Sep 2023 12:18:01 UTC
Severity: normal
Tags: patch
Found in version 30.0.50
Fixed in version 29.2
Done: Stefan Kangas <stefankangas <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66071 in the body.
You can then email your comments to 66071 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 12:18:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Mon, 18 Sep 2023 12:18:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
The docstring says term-scroll-to-bottom-on-output may be set to the
symbols this and others, but its :type is just a boolean.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 12:21:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 66071 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
tags 66071 patch
quit
Patch attached.
[0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patch (text/x-patch, attachment)]
Added tag(s) patch.
Request was from
Mauro Aranda <maurooaranda <at> gmail.com>
to
control <at> debbugs.gnu.org.
(Mon, 18 Sep 2023 12:21:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 14:22:02 GMT)
Full text and
rfc822 format available.
Message #13 received at 66071 <at> debbugs.gnu.org (full text, mbox):
>>>>> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda <maurooaranda <at> gmail.com> said:
Mauro> tags 66071 patch
Mauro> quit
Mauro> Patch attached.
Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 00:00:00 2001
Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type (Bug#66071)
Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add missing choices.
Mauro> ---
Mauro> lisp/term.el | 5 ++++-
Mauro> 1 file changed, 4 insertions(+), 1 deletion(-)
Mauro> diff --git a/lisp/term.el b/lisp/term.el
Mauro> index b8466b21332..5dd73447cfb 100644
Mauro> --- a/lisp/term.el
Mauro> +++ b/lisp/term.el
Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
Mauro> See variable `term-scroll-show-maximum-output'.
Mauro> This variable is buffer-local."
Mauro> - :type 'boolean
Mauro> + :type '(choice (const :tag "Don't scroll" nil)
Mauro> + (const :tag "Scroll selected window only" this)
Mauro> + (const :tag "Scroll unselected windows" others)
Mauro> + (other :tag "Scroll all windows" t))
Mauro> :group 'term)
The code (and the docstring) also mention 'all.
Robert
--
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 15:13:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 66071 <at> debbugs.gnu.org (full text, mbox):
On 18/9/23 11:20, Robert Pluim wrote:
> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
<maurooaranda <at> gmail.com> said:
> Mauro> Patch attached.
>
> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17
00:00:00 2001
> Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type
(Bug#66071)
>
> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
missing choices.
> Mauro> ---
> Mauro> lisp/term.el | 5 ++++-
> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Mauro> diff --git a/lisp/term.el b/lisp/term.el
> Mauro> index b8466b21332..5dd73447cfb 100644
> Mauro> --- a/lisp/term.el
> Mauro> +++ b/lisp/term.el
> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
>
> Mauro> See variable `term-scroll-show-maximum-output'.
> Mauro> This variable is buffer-local."
> Mauro> - :type 'boolean
> Mauro> + :type '(choice (const :tag "Don't scroll" nil)
> Mauro> + (const :tag "Scroll selected window
only" this)
> Mauro> + (const :tag "Scroll unselected windows"
others)
> Mauro> + (other :tag "Scroll all windows" t))
> Mauro> :group 'term)
>
> The code (and the docstring) also mention 'all.
I know, that's why I put other, to catch either t or 'all, since it
doesn't make sense to have 2 different items for the same option. And
adding something to match only t or 'all didn't seem worth the trouble.
Am I missing something?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 15:23:01 GMT)
Full text and
rfc822 format available.
Message #19 received at 66071 <at> debbugs.gnu.org (full text, mbox):
>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda <maurooaranda <at> gmail.com> said:
Mauro> On 18/9/23 11:20, Robert Pluim wrote:
>> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
Mauro> <maurooaranda <at> gmail.com> said:
>> Mauro> Patch attached.
>>
>> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17
Mauro> 00:00:00 2001
>> Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
>> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
>> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output
Mauro> :type (Bug#66071)
>>
>> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
Mauro> missing choices.
>> Mauro> ---
>> Mauro> lisp/term.el | 5 ++++-
>> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> Mauro> diff --git a/lisp/term.el b/lisp/term.el
>> Mauro> index b8466b21332..5dd73447cfb 100644
>> Mauro> --- a/lisp/term.el
>> Mauro> +++ b/lisp/term.el
>> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
>>
>> Mauro> See variable `term-scroll-show-maximum-output'.
>> Mauro> This variable is buffer-local."
>> Mauro> - :type 'boolean
>> Mauro> + :type '(choice (const :tag "Don't scroll" nil)
>> Mauro> + (const :tag "Scroll selected window
Mauro> only" this)
>> Mauro> + (const :tag "Scroll unselected windows"
Mauro> others)
>> Mauro> + (other :tag "Scroll all windows" t))
>> Mauro> :group 'term)
>>
>> The code (and the docstring) also mention 'all.
Mauro> I know, that's why I put other, to catch either t or 'all, since it
Mauro> doesn't make sense to have 2 different items for the same option. And
Mauro> adding something to match only t or 'all didn't seem worth the trouble.
Mauro> Am I missing something?
Both before and after your patch, the defcustom and the docstring
disagree. The docstring says 'all', but thatʼs not a value you can get
via customize.
Personally Iʼd be inclined to delete 'all' from the docstring. People
already using 'all' wonʼt notice, since the code will still recognize
it.
Robert
--
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Mon, 18 Sep 2023 15:30:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 66071 <at> debbugs.gnu.org (full text, mbox):
On 18/9/23 12:22, Robert Pluim wrote:
>>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda
<maurooaranda <at> gmail.com> said:
>
> Mauro> On 18/9/23 11:20, Robert Pluim wrote:
> >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
> Mauro> <maurooaranda <at> gmail.com> said:
> >> Mauro> Patch attached.
> >>
> >> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon
Sep 17
> Mauro> 00:00:00 2001
> >> Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
> >> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
> >> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output
> Mauro> :type (Bug#66071)
> >>
> >> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
> Mauro> missing choices.
> >> Mauro> ---
> >> Mauro> lisp/term.el | 5 ++++-
> >> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> Mauro> diff --git a/lisp/term.el b/lisp/term.el
> >> Mauro> index b8466b21332..5dd73447cfb 100644
> >> Mauro> --- a/lisp/term.el
> >> Mauro> +++ b/lisp/term.el
> >> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
> >>
> >> Mauro> See variable `term-scroll-show-maximum-output'.
> >> Mauro> This variable is buffer-local."
> >> Mauro> - :type 'boolean
> >> Mauro> + :type '(choice (const :tag "Don't scroll" nil)
> >> Mauro> + (const :tag "Scroll selected window
> Mauro> only" this)
> >> Mauro> + (const :tag "Scroll unselected
windows"
> Mauro> others)
> >> Mauro> + (other :tag "Scroll all windows" t))
> >> Mauro> :group 'term)
> >>
> >> The code (and the docstring) also mention 'all.
>
> Mauro> I know, that's why I put other, to catch either t or 'all,
since it
> Mauro> doesn't make sense to have 2 different items for the same
option. And
> Mauro> adding something to match only t or 'all didn't seem worth
the trouble.
>
> Mauro> Am I missing something?
>
> Both before and after your patch, the defcustom and the docstring
> disagree. The docstring says 'all', but thatʼs not a value you can get
> via customize.
>
> Personally Iʼd be inclined to delete 'all' from the docstring. People
> already using 'all' wonʼt notice, since the code will still recognize
> it.
That's fine by me, thanks.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Sun, 24 Sep 2023 11:40:02 GMT)
Full text and
rfc822 format available.
Message #25 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 18/9/23 12:22, Robert Pluim wrote:
>>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda
<maurooaranda <at> gmail.com> said:
>
> Mauro> On 18/9/23 11:20, Robert Pluim wrote:
> >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
> Mauro> <maurooaranda <at> gmail.com> said:
> >> Mauro> Patch attached.
> >>
> >> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon
Sep 17
> Mauro> 00:00:00 2001
> >> Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
> >> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
> >> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output
> Mauro> :type (Bug#66071)
> >>
> >> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
> Mauro> missing choices.
> >> Mauro> ---
> >> Mauro> lisp/term.el | 5 ++++-
> >> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> Mauro> diff --git a/lisp/term.el b/lisp/term.el
> >> Mauro> index b8466b21332..5dd73447cfb 100644
> >> Mauro> --- a/lisp/term.el
> >> Mauro> +++ b/lisp/term.el
> >> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
> >>
> >> Mauro> See variable `term-scroll-show-maximum-output'.
> >> Mauro> This variable is buffer-local."
> >> Mauro> - :type 'boolean
> >> Mauro> + :type '(choice (const :tag "Don't scroll" nil)
> >> Mauro> + (const :tag "Scroll selected window
> Mauro> only" this)
> >> Mauro> + (const :tag "Scroll unselected
windows"
> Mauro> others)
> >> Mauro> + (other :tag "Scroll all
windows" t))
> >> Mauro> :group 'term)
> >>
> >> The code (and the docstring) also mention 'all.
>
> Mauro> I know, that's why I put other, to catch either t or
'all, since it
> Mauro> doesn't make sense to have 2 different items for the same
option. And
> Mauro> adding something to match only t or 'all didn't seem
worth the trouble.
>
> Mauro> Am I missing something?
>
> Both before and after your patch, the defcustom and the docstring
> disagree. The docstring says 'all', but thatʼs not a value you can get
> via customize.
>
> Personally Iʼd be inclined to delete 'all' from the docstring. People
> already using 'all' wonʼt notice, since the code will still recognize
> it.
>
> Robert
I've incorporated your suggestion in the attached patch.
[0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#66071; Package
emacs.
(Sun, 24 Sep 2023 11:40:02 GMT)
Full text and
rfc822 format available.
Reply sent
to
Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility.
(Sat, 30 Sep 2023 23:38:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Mauro Aranda <maurooaranda <at> gmail.com>:
bug acknowledged by developer.
(Sat, 30 Sep 2023 23:38:01 GMT)
Full text and
rfc822 format available.
Message #33 received at 66071-done <at> debbugs.gnu.org (full text, mbox):
Version: 29.2
Mauro Aranda <maurooaranda <at> gmail.com> writes:
> I've incorporated your suggestion in the attached patch.
Thanks, installed on emacs-29.
[1: 47770b0eca4]: 2023-10-01 01:35:23 +0200
Fix term-scroll-to-bottom-on-output :type
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47770b0eca4ba94f6b2a5dd740ff42023c8159c4
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sun, 29 Oct 2023 11:24:10 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 193 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.