GNU bug report logs - #66115
[PATCH] Ensure that directory is expanded in package-vc-checkout

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Joseph Turner <joseph@HIDDEN>; Keywords: patch; dated Wed, 20 Sep 2023 07:17:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.
bug unarchived. Request was from Joseph Turner <joseph@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
bug archived. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 66115 <at> debbugs.gnu.org:


Received: (at 66115) by debbugs.gnu.org; 24 Sep 2023 06:55:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 24 02:55:29 2023
Received: from localhost ([127.0.0.1]:40918 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qkJ1d-0004xV-2C
	for submit <at> debbugs.gnu.org; Sun, 24 Sep 2023 02:55:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46598)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qkJ1X-0004xC-Jt
 for 66115 <at> debbugs.gnu.org; Sun, 24 Sep 2023 02:55:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qkJ1G-0007nA-90; Sun, 24 Sep 2023 02:55:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=2dKWLGnVHTxMIamOMOgaF89Kge7wiNAa1wxEHKsmZB4=; b=B+uoZw+u+cvX
 6fWkzJSV6DaSbIzw+vHsVCtWsFo88mIY4HBy7gNKqBI0xk9kT/MojYA0NwWTQcALLeo9eUIxfoGhg
 cDXOl24nvYtPIylwLYVMjonqEQoHRPWM1ZOaSMrn7n1S+xd4QWq4QyUcVgVmxAkX5QYoRXo330Smp
 hvvSgyKmZqMP59Z9V3KPmZmEcGScCf2G2EhJnLgNRlCC7t+6DimyKUiYQFVWBMz6O7BMUW1VLEPzl
 Pyg4PXF4i8dES0WeIMjYKXudK3Qp1eMXkgoXLUCL2tlZnNHYS2FB+ec+Jr3M9NbabRJgriy28aEnp
 sE6AMtxSvj2j5XlBlyU7fQ==;
Date: Sun, 24 Sep 2023 09:54:38 +0300
Message-Id: <834jjk3vtd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <877cogp205.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in
 package-vc-checkout
References: <87a5thfh7i.fsf@HIDDEN>
 <87lecyvcyd.fsf@HIDDEN> <871qeqppxm.fsf@HIDDEN>
 <875y42v5um.fsf@HIDDEN> <877cogp205.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66115
Cc: 66115 <at> debbugs.gnu.org, philipk@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 66115-done <at> debbugs.gnu.org
> Date: Sat, 23 Sep 2023 22:34:24 -0700
> From:  Joseph Turner via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> It appears that the fix was applied to master. Would it make sense to
> apply it to emacs-29?

The installed change affects much more than the original issue, so I'd
prefer for it to stay on master.

I'm okay with installing the original patch on emacs-29, but be sure
to say "do not merge to master" in the commit log message if you do.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#66115; Package emacs. Full text available.

Message received at 66115-done <at> debbugs.gnu.org:


Received: (at 66115-done) by debbugs.gnu.org; 24 Sep 2023 05:35:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 24 01:35:42 2023
Received: from localhost ([127.0.0.1]:40892 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qkHmP-0002bC-UG
	for submit <at> debbugs.gnu.org; Sun, 24 Sep 2023 01:35:42 -0400
Received: from out-206.mta0.migadu.com ([2001:41d0:1004:224b::ce]:42021)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1qkHmN-0002b1-Nl
 for 66115-done <at> debbugs.gnu.org; Sun, 24 Sep 2023 01:35:41 -0400
References: <87a5thfh7i.fsf@HIDDEN>
 <87lecyvcyd.fsf@HIDDEN> <871qeqppxm.fsf@HIDDEN>
 <875y42v5um.fsf@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1695533726;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=q4ucI8i17UnorFWSW5K3NZcNyJ9GrJQshCTUHKbTcA4=;
 b=frjzKgAuWo24BMzsbXGyuRNxGuUCSRmaAbYen+O1xNsSNj6ApYLwBNKpx9JUpraKhvc4Zc
 1FH0shLZ1EWxtvOdt2sw4wRkLbqC48wXSpXVVfhjlUMopuqEw0rcp5/daE5fwKGdh2LoRJ
 auSyWSZvbF2C92KsLdaLiqOK116fMtM=
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in
 package-vc-checkout
Date: Sat, 23 Sep 2023 22:34:24 -0700
In-reply-to: <875y42v5um.fsf@HIDDEN>
Message-ID: <877cogp205.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66115-done
Cc: 66115-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

It appears that the fix was applied to master. Would it make sense to
apply it to emacs-29?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#66115; Package emacs. Full text available.

Message received at 66115-done <at> debbugs.gnu.org:


Received: (at 66115-done) by debbugs.gnu.org; 22 Sep 2023 10:51:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 22 06:51:36 2023
Received: from localhost ([127.0.0.1]:35362 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qjdl2-0002rF-Bh
	for submit <at> debbugs.gnu.org; Fri, 22 Sep 2023 06:51:36 -0400
Received: from mout02.posteo.de ([185.67.36.66]:58719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1qjdkw-0002qw-QF
 for 66115-done <at> debbugs.gnu.org; Fri, 22 Sep 2023 06:51:34 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 5204A240104
 for <66115-done <at> debbugs.gnu.org>; Fri, 22 Sep 2023 12:51:14 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1695379874; bh=feQ8uJiXM6ty0jdbZjtelvFVPKxLcjwkPTOWSJaL35s=;
 h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From;
 b=QsqpC5gwgO2HUThQ27YsSb/0qH7iYY3kT7E7V27qvqIiL6T0zOajEM7ht7fv3y7sV
 uoFSq3vu78mshA02+etMpYZmItsSyKN3P1RZi+WuqcDbsiqGlfTltaitBimp9ZaTWp
 pM1SLaON8mdHQACU/czLHc5heVS25ClMpreIVtGo4kZ8Atj0jcWB1SoriU2MylPDqF
 oz/ac4ubsgVACDWkNKtz+NNd0wqK3UAhoj5cHgVIMKi19JZItVrJySdP4dWs6srrBS
 T9SpgO9/y22Xbbvsoi8aDWNtJ5BpwU+5nlDbG607/c0z6iQTtD2ektNZUmN0gVi6+S
 q2AhBfmwtf8Uw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4RsTb5555dz9rxM;
 Fri, 22 Sep 2023 12:51:13 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Joseph Turner <joseph@HIDDEN>
Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in
 package-vc-checkout
In-Reply-To: <871qeqppxm.fsf@HIDDEN> (Joseph Turner's message of
 "Fri, 22 Sep 2023 01:33:45 -0700")
References: <87a5thfh7i.fsf@HIDDEN> <87lecyvcyd.fsf@HIDDEN>
 <871qeqppxm.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
 mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
 BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
 Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
 NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
 z4oM
Date: Fri, 22 Sep 2023 10:51:13 +0000
Message-ID: <875y42v5um.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66115-done
Cc: 66115-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>> Joseph Turner <joseph@HIDDEN> writes:
>>
>>> Tags: patch
>>>
>>> Tags: patch
>>>
>>> This patch fixes a serious bug which caused package-vc-checkout to fail
>>> entirely when its second argument `directory' was not expanded.
>>>
>>> From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001
>>> From: Joseph Turner <joseph@HIDDEN>
>>> Date: Wed, 20 Sep 2023 00:12:10 -0700
>>> Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout
>>>
>>> * lisp/emacs-lisp/package-vc.el (package-vc-checkout)
>>> ---
>>>  lisp/emacs-lisp/package-vc.el | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
>>> index 29b540d86b8..47d8c996ff0 100644
>>> --- a/lisp/emacs-lisp/package-vc.el
>>> +++ b/lisp/emacs-lisp/package-vc.el
>>> @@ -834,6 +834,7 @@ for the last released version of the package."
>>>               (setf dir subdir)
>>>             (user-error "Directory not empty: %S" (expand-file-name dir)))))
>>>       (list desc dir (and current-prefix-arg :last-release))))
>>> +  (setf directory (expand-file-name directory))
>>>    (package-vc--archives-initialize)
>>>    (let ((pkg-spec (or (package-vc--desc->spec pkg-desc)
>>>                        (and-let* ((extras (package-desc-extras pkg-desc))
>>
>> DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'.
>> Wouldn't it be more robust to ensure that `vc-clone' can handle
>> unexpanded directory names, eg. like this:
>>
>> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
>> index 2f4b028bb4a..7f334397a5e 100644
>> --- a/lisp/vc/vc.el
>> +++ b/lisp/vc/vc.el
>> @@ -3676,8 +3676,7 @@ vc-clone
>>  checkout.  If BACKEND is nil, iterate through every known backend
>>  in `vc-handled-backends' until one succeeds.  If REV is non-nil,
>>  it indicates a specific revision to check out."
>> -  (unless directory
>> -    (setq directory default-directory))
>> +  (setq directory (expand-file-name (or directory default-directory)))
>>    (if backend
>>        (progn
>>          (unless (memq backend vc-handled-backends)
>
> Yes, certainly. Your solution is better.

OK, closing the issue.
Notification sent to Joseph Turner <joseph@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Philip Kaludercic <philipk@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 66115 <at> debbugs.gnu.org:


Received: (at 66115) by debbugs.gnu.org; 22 Sep 2023 08:34:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 22 04:34:19 2023
Received: from localhost ([127.0.0.1]:35286 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qjbcB-0002Fa-3i
	for submit <at> debbugs.gnu.org; Fri, 22 Sep 2023 04:34:19 -0400
Received: from out-218.mta0.migadu.com ([2001:41d0:1004:224b::da]:41432)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1qjbc7-0002FM-HW
 for 66115 <at> debbugs.gnu.org; Fri, 22 Sep 2023 04:34:18 -0400
References: <87a5thfh7i.fsf@HIDDEN> <87lecyvcyd.fsf@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1695371641;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=YezTbSQzqzXGucaqGRpod2SEdOcM4hTiVMw0u83QpUU=;
 b=IaojodDdbQFFRfCjD8TNr1qmW28piy7eNjw+0V8YtgnfeZnOTqPkiRX6Dv7B3PCJExM2T9
 yQhU7fcijhibHIH96e0Ck2jibxeH/z2v23IP9ihP99b+TDD6VrCaAcMi70nO3XEYgR/gw6
 xGEEqIh8aeMUTUH/d8Ki4JqZS4Thl7w=
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in
 package-vc-checkout
Date: Fri, 22 Sep 2023 01:33:45 -0700
In-reply-to: <87lecyvcyd.fsf@HIDDEN>
Message-ID: <871qeqppxm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66115
Cc: 66115 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Philip Kaludercic <philipk@HIDDEN> writes:

> Joseph Turner <joseph@HIDDEN> writes:
>
>> Tags: patch
>>
>> Tags: patch
>>
>> This patch fixes a serious bug which caused package-vc-checkout to fail
>> entirely when its second argument `directory' was not expanded.
>>
>> From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001
>> From: Joseph Turner <joseph@HIDDEN>
>> Date: Wed, 20 Sep 2023 00:12:10 -0700
>> Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout
>>
>> * lisp/emacs-lisp/package-vc.el (package-vc-checkout)
>> ---
>>  lisp/emacs-lisp/package-vc.el | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
>> index 29b540d86b8..47d8c996ff0 100644
>> --- a/lisp/emacs-lisp/package-vc.el
>> +++ b/lisp/emacs-lisp/package-vc.el
>> @@ -834,6 +834,7 @@ for the last released version of the package."
>>               (setf dir subdir)
>>             (user-error "Directory not empty: %S" (expand-file-name dir)))))
>>       (list desc dir (and current-prefix-arg :last-release))))
>> +  (setf directory (expand-file-name directory))
>>    (package-vc--archives-initialize)
>>    (let ((pkg-spec (or (package-vc--desc->spec pkg-desc)
>>                        (and-let* ((extras (package-desc-extras pkg-desc))
>
> DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'.
> Wouldn't it be more robust to ensure that `vc-clone' can handle
> unexpanded directory names, eg. like this:
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 2f4b028bb4a..7f334397a5e 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -3676,8 +3676,7 @@ vc-clone
>  checkout.  If BACKEND is nil, iterate through every known backend
>  in `vc-handled-backends' until one succeeds.  If REV is non-nil,
>  it indicates a specific revision to check out."
> -  (unless directory
> -    (setq directory default-directory))
> +  (setq directory (expand-file-name (or directory default-directory)))
>    (if backend
>        (progn
>          (unless (memq backend vc-handled-backends)

Yes, certainly. Your solution is better.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#66115; Package emacs. Full text available.

Message received at 66115 <at> debbugs.gnu.org:


Received: (at 66115) by debbugs.gnu.org; 22 Sep 2023 08:18:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 22 04:18:06 2023
Received: from localhost ([127.0.0.1]:35252 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qjbMU-0001oD-GD
	for submit <at> debbugs.gnu.org; Fri, 22 Sep 2023 04:18:06 -0400
Received: from mout02.posteo.de ([185.67.36.66]:38863)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1qjbMR-0001nh-Uz
 for 66115 <at> debbugs.gnu.org; Fri, 22 Sep 2023 04:18:05 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 46914240101
 for <66115 <at> debbugs.gnu.org>; Fri, 22 Sep 2023 10:17:47 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1695370667; bh=h2CmNmGcUALdirATzLHeIfR0YmeG/6rA8Bmn4rzPrJM=;
 h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From;
 b=YMlmspT6Y22Ox+5NvNBM5xqEtANZdDtmNfcfeyBg1uiE3AmVC+NH3goQfOVjBKXWI
 E5/Z0QsRtEkBMrcUX+Wboutc6R44Ah+4fuQDwSOt5TToqKgvD1rtiNtbx1ryIWr4uR
 NM/noeP8/LYOH5POIeC/lEvLDhJ2++Nu37fS/y/60NmSKeyGpk0PAIWdzseJXgEE4X
 LmviBD+MRvxfYE1ngtbyXqcxgGFC89EgWGFC8yzxX09IKqg/Ls7FkNFYm7GDFRoT+1
 TMOdYQ/wKHfV88sXU9JBU+JF9qCdPd921Cy8h4dBoaF8CDx7S4WjrXArg8OA0k/kFf
 I3RwDzg9fEHsw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4RsQB25Bd5z9rxN;
 Fri, 22 Sep 2023 10:17:46 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Joseph Turner <joseph@HIDDEN>
Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in
 package-vc-checkout
In-Reply-To: <87a5thfh7i.fsf@HIDDEN> (Joseph Turner's message of
 "Wed, 20 Sep 2023 00:14:02 -0700")
References: <87a5thfh7i.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
 mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
 BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
 Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
 NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
 z4oM
Date: Fri, 22 Sep 2023 08:17:46 +0000
Message-ID: <87lecyvcyd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66115
Cc: 66115 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain

Joseph Turner <joseph@HIDDEN> writes:

> Tags: patch
>
> Tags: patch
>
> This patch fixes a serious bug which caused package-vc-checkout to fail
> entirely when its second argument `directory' was not expanded.
>
> From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@HIDDEN>
> Date: Wed, 20 Sep 2023 00:12:10 -0700
> Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout
>
> * lisp/emacs-lisp/package-vc.el (package-vc-checkout)
> ---
>  lisp/emacs-lisp/package-vc.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index 29b540d86b8..47d8c996ff0 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -834,6 +834,7 @@ for the last released version of the package."
>               (setf dir subdir)
>             (user-error "Directory not empty: %S" (expand-file-name dir)))))
>       (list desc dir (and current-prefix-arg :last-release))))
> +  (setf directory (expand-file-name directory))
>    (package-vc--archives-initialize)
>    (let ((pkg-spec (or (package-vc--desc->spec pkg-desc)
>                        (and-let* ((extras (package-desc-extras pkg-desc))

DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'.
Wouldn't it be more robust to ensure that `vc-clone' can handle
unexpanded directory names, eg. like this:


--=-=-=
Content-Type: text/plain
Content-Disposition: inline

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 2f4b028bb4a..7f334397a5e 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -3676,8 +3676,7 @@ vc-clone
 checkout.  If BACKEND is nil, iterate through every known backend
 in `vc-handled-backends' until one succeeds.  If REV is non-nil,
 it indicates a specific revision to check out."
-  (unless directory
-    (setq directory default-directory))
+  (setq directory (expand-file-name (or directory default-directory)))
   (if backend
       (progn
         (unless (memq backend vc-handled-backends)

--=-=-=--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#66115; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Sep 2023 07:16:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 20 03:16:18 2023
Received: from localhost ([127.0.0.1]:58184 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qirRa-0002f6-Ed
	for submit <at> debbugs.gnu.org; Wed, 20 Sep 2023 03:16:18 -0400
Received: from lists.gnu.org ([2001:470:142::17]:48330)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1qirRY-0002eo-Er
 for submit <at> debbugs.gnu.org; Wed, 20 Sep 2023 03:16:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1qirRJ-0006SY-Hv
 for bug-gnu-emacs@HIDDEN; Wed, 20 Sep 2023 03:16:01 -0400
Received: from out-219.mta0.migadu.com ([91.218.175.219])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1qirRD-0000xF-SY
 for bug-gnu-emacs@HIDDEN; Wed, 20 Sep 2023 03:16:00 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1695194151;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=C+T3WKBlfjVgzrdBzJ0rANBE1GU3UcBxm40cyIZ13UA=;
 b=LfvRqeGIUivU1HqVPFqYsgFew20warlfzUKbqOd1EbKArOFJnPTmnNzylMrs6QhkVB3AQz
 aAPwjRMp4WPNdr+2xGVCaiThuqBeBrFv9TBc4l/TiiKzh4StvuG9BDpuA9yStulmFsn132
 ZO9hACVlg9aIDuJw+CxAcxqZlCmrg5U=
From: Joseph Turner <joseph@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout
Date: Wed, 20 Sep 2023 00:14:02 -0700
X-Debbugs-CC: Philip Kaludercic <philipk@HIDDEN>
Message-ID: <87a5thfh7i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Migadu-Flow: FLOW_OUT
Received-SPF: pass client-ip=91.218.175.219;
 envelope-from=joseph@HIDDEN; helo=out-219.mta0.migadu.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

Tags: patch

This patch fixes a serious bug which caused package-vc-checkout to fail
entirely when its second argument `directory' was not expanded.


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Ensure-that-directory-is-expanded-in-package-vc-chec.patch

From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Wed, 20 Sep 2023 00:12:10 -0700
Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout

* lisp/emacs-lisp/package-vc.el (package-vc-checkout)
---
 lisp/emacs-lisp/package-vc.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index 29b540d86b8..47d8c996ff0 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -834,6 +834,7 @@ for the last released version of the package."
              (setf dir subdir)
            (user-error "Directory not empty: %S" (expand-file-name dir)))))
      (list desc dir (and current-prefix-arg :last-release))))
+  (setf directory (expand-file-name directory))
   (package-vc--archives-initialize)
   (let ((pkg-spec (or (package-vc--desc->spec pkg-desc)
                       (and-let* ((extras (package-desc-extras pkg-desc))
-- 
2.41.0


--=-=-=--
Acknowledgement sent to Joseph Turner <joseph@HIDDEN>:
New bug report received and forwarded. Copy sent to philipk@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to philipk@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#66115; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Nov 2023 22:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.