Received: (at 66144-done) by debbugs.gnu.org; 5 Feb 2025 22:31:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 17:31:24 2025 Received: from localhost ([127.0.0.1]:53097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfnvX-0005Dq-Ng for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 17:31:23 -0500 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:58546) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tfnvT-0005DW-5C for 66144-done <at> debbugs.gnu.org; Wed, 05 Feb 2025 17:31:21 -0500 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-aa68b513abcso60265166b.0 for <66144-done <at> debbugs.gnu.org>; Wed, 05 Feb 2025 14:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738794673; x=1739399473; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=1cGZT1yVCyIYO/tUNJEBJ6MTAbKT2IWrYmZfWa72kvA=; b=S2M8tq8MZK/E6fQTnnhzkWjXka6Dt4BlB+WbLMXhylIPllv/IuA+Ua711qvc4oUW44 sA/mhTB8aeY+7LkdK1BQBJZiDz0WfBfHrBrj/kfnxiuNUI+pkrbYhlXI0wiK2w0pxb6n G+4g558geMJBz7yfl4FPGdidV0vHxnwVf2f0MhovZDS2ueGxtEeK4gW0te8IEjgmdxwH jgNoR3/c3gYZvS5S3vgcZ/rmjLWFpqhBIFn7zC42Zw7B8fo9RyA6VlscU5ukS7wC7Vqn fT+jnPH/FXrRXCyl8nGjKlMLXvhaZ/wJDBJuFz88F42ORXEQWIGeeWl4QlrUMmLRpwes ft6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738794673; x=1739399473; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1cGZT1yVCyIYO/tUNJEBJ6MTAbKT2IWrYmZfWa72kvA=; b=MEktC5Q3dqWSx60JtF4+vzJQeoeiSfyZez3bO5MAirriDAOMgeUshYu+Kf6hzB+qdo nwcDd3zXxwqYnYlFSJ/4tiTryeD4VTsbb6xJEWusP3D3Fopl32en6XP3W9VLCbZCaXWt LwzJqyw4YTUQPgDTn3woWScuXKdLboYOYPOYxGS/AUlLaoLszWps+YpQQ3ucOeKWT21O vuCkFCElvgitXEGkzlNjZRYVxuNkKRP9BqIk4ssDtT7EDPAmgd5ZXzx764eA3jZhH8oz l3FafmdRiHzoVO7PkVYsxT1MMDkZt+Z3Tgc+hoPquEmaPJRoaeeXXSm8v3BqxCR4b5+a BpXQ== X-Forwarded-Encrypted: i=1; AJvYcCV7Kc0pp77MyZpxUm6D2YXwvItm7o2UaGdBw0IfKNyYaCmdvVXFMVcY+ZpyS+eVDzfNkdTdEHi8LFOy <at> debbugs.gnu.org X-Gm-Message-State: AOJu0Ywy/Nu08xzocYGI51UgeejtmmdTHb1ZqhuRi3rK8Y11/iW1xv+0 mAruPzpF/YVzGAZzsaNlJe9k520YhF4Yoq7NCzCwAlb3GwKQZNROrZQiPtsadvNuh9GzMkfw0kh QCA1PZNAHLHWth/S0fk1r4iEjDSZNtwAy X-Gm-Gg: ASbGncsV+Jp0drzW66hDAyHMnVCGwFsLb2gcmNS0Lc5UiUDitUBHDPeEJ74cgh9D3jw 1ZM0lVGkOndWa+oYiVLMVIC8WACcYUPP/agd2SBQZT7uzn5B1NIVZMM463Q/6YlvFxKOgDJU8NA == X-Google-Smtp-Source: AGHT+IEyg59TLgktprDbY2Y2ms/R4VDnEm9aFY9zq5IEcaXjZ8hTT4F7wOw14AoVwBVdSiBWMrxfzA1idpo1Mdeyi0I= X-Received: by 2002:a17:906:7952:b0:ab6:362b:a83a with SMTP id a640c23a62f3a-ab75e234979mr442151666b.8.1738794672738; Wed, 05 Feb 2025 14:31:12 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 5 Feb 2025 14:31:11 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CALDnm53KQf0xDytOtVEssq9HdMSde6Jyc5DL33ZM1juS=4=2VA@HIDDEN> References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> <CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN> <CADwFkmkd38AWLrZRjYog+RCJr3hTr1Yfx=T=uxtd7KpRN2Hv0A@HIDDEN> <m2r0axtiad.fsf@HIDDEN> <CALDnm53KQf0xDytOtVEssq9HdMSde6Jyc5DL33ZM1juS=4=2VA@HIDDEN> MIME-Version: 1.0 Date: Wed, 5 Feb 2025 14:31:11 -0800 X-Gm-Features: AWEUYZlr-vznNS8T-hXxEInE4ppRNEFvn_mPOcKUm7WQcjYGN6FcssncDrmNG0o Message-ID: <CADwFkm=M3p0JQEC92_L4FRAPBX9EWRcoOSYSa4wa8ZWcKV=ZRg@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>, Daniel Pettersson <daniel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144-done Cc: Javier Olaechea <pirata@HIDDEN>, 66144-done <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > I'll leave it up to you whether to keep the bug open for "fixing" > this in jsonrpc.el (IMO it should be closed since the original problem is > solved). I have re-read parts of the thread, and I think this fix is good until we run into some other real-world use case that is hurt by this jsonrpc.el behaviour. I'm therefore closing this bug report now.
Aaron Zeng <azeng@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:
Received: (at 66144) by debbugs.gnu.org; 4 Feb 2025 12:09:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 04 07:09:04 2025
Received: from localhost ([127.0.0.1]:42980 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfHjj-0003l8-SB
for submit <at> debbugs.gnu.org; Tue, 04 Feb 2025 07:09:04 -0500
Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]:49436)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>)
id 1tfHjh-0003kU-76
for 66144 <at> debbugs.gnu.org; Tue, 04 Feb 2025 07:09:01 -0500
Received: by mail-oo1-xc36.google.com with SMTP id
006d021491bc7-5fa2685c5c0so2152922eaf.3
for <66144 <at> debbugs.gnu.org>; Tue, 04 Feb 2025 04:09:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738670935; x=1739275735; darn=debbugs.gnu.org;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:from:to:cc:subject:date
:message-id:reply-to;
bh=yPOKbLbrRAWwu4J43rp91kP/4bQ7qx1vhV8dri1zIZM=;
b=RECY/Os41atrGBlnxVrVOfeKL5om7vV59eNo47PIB9kt44rlfM3yr409OxJCdLpKBN
nnKLaIlO7iR4eSoGXAl6W0GSdSdnbke3bj6ThJnsvnE04uKMmjqAdwvup0y8COJzcexd
dEBMj+uw7uGmoWFw2r4H5OgGgiTXpkHV0Hj0ErDuGh28t+jrH1PClrto9ztJJkqp70GQ
d2dkWZd9WGNtkHpWfkinUu3NZt9DjAqX2Ozp6tugE1dwbAlENJuldXcy+dkK+y/014bt
BbaWgUboTVks+cnyc+gFFdhwr8fX/EVLgiKNfo59zdR+Ioy6KAAuelQJkNZp88cbqm6Y
5xNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738670935; x=1739275735;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=yPOKbLbrRAWwu4J43rp91kP/4bQ7qx1vhV8dri1zIZM=;
b=bayGvt9hUiNLchV+YJ4BJJIAU0FXvG8Qei5Fs+ZMiX8RCe41yg76qphJhX8Cuk/ds4
pSb8jUN6o2/D5ql+SZJoflQ4s45fOSlrUw5/Y3NjR+X92ydTlXqeEpBhzJZti79N2zlo
zp2jtZyCalPjc8w3ueANNXKP6A/WUFozupyeU5zBJS8aeUiMVnQkRtiv2ZZ3ptE5lb/o
t7QkvDKNBQW2XpZ4nA74HptU79ttIwNuaezv64XiiNyw8Gwg1MFL65HMq/e7NqpnGHlo
3tQJ+Cw48nuuwpi9zY4IXx6peIGZyDZc5LDkJ3USvHrfMuOu88O3pN+9TelJGfGkTyzw
fD8w==
X-Forwarded-Encrypted: i=1;
AJvYcCVJwBRdVDKN4ELsrERleMJLOD17Gtzy+GW9sfk3vMciF2EensuA86zIEjpOdMw2UHCHV0LJpA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzdVdnSxXMg1Sd+00a51lbHW5R4hC24AcxBqVDtGXNyOEts3JCl
oUEpCOx2SKhzNoVs53NwxmohBhVX9SfJ4c8eQ+JqQTe0aIr38McLMmQgKXXyNog7KYZg2g0+3AE
tJH3+SDvPQFYGh9024Ih+sa4ifYE=
X-Gm-Gg: ASbGncvPHu5lqmnuYAOXoLCFk6ObLE3TeMHYlj2NT0hLwdJg9e2VhA3OQ10o31nqDss
IrcjxeZmXYcFLL9Y+RixofzDrL4f+uv3T+bnObIv2XikckD4mw0F8Zqa/v4qRFkJZHIlBHkBJ
X-Google-Smtp-Source: AGHT+IElJaYUHf5j6lHSq5jIcIsRJlGfk80mW/qsHnSRiKND2YPKnrVABz4GhXVrBw8YzY60U8DdJTzIWWwX3UcANcU=
X-Received: by 2002:a05:6870:de10:b0:29e:2991:d953 with SMTP id
586e51a60fabf-2b32f0ad5edmr15572227fac.20.1738670935281; Tue, 04 Feb 2025
04:08:55 -0800 (PST)
MIME-Version: 1.0
References: <q7ma5tfi6ot.fsf@HIDDEN>
<CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
<83bkd1sjr1.fsf@HIDDEN>
<CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN>
<CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN>
<CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN>
<CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN>
<CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN>
<CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN>
<CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN>
<CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN>
<CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN>
<CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN>
<CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN>
<CADwFkmkd38AWLrZRjYog+RCJr3hTr1Yfx=T=uxtd7KpRN2Hv0A@HIDDEN>
<m2r0axtiad.fsf@HIDDEN>
In-Reply-To: <m2r0axtiad.fsf@HIDDEN>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Tue, 4 Feb 2025 12:08:58 +0000
X-Gm-Features: AWEUYZk69NZrukQsPSK8vDvEalSFvG3S1x0WnKLbrjwT5E5ncqTfFDuVtVMMUdE
Message-ID: <CALDnm53KQf0xDytOtVEssq9HdMSde6Jyc5DL33ZM1juS=4=2VA@HIDDEN>
Subject: Re: bug#66144: 29.1;
eglot-shutdown request params violate JSONRPC spec
To: Daniel Pettersson <daniel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66144
Cc: Javier Olaechea <pirata@HIDDEN>, 66144 <at> debbugs.gnu.org,
Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
I've now pushed Javier's idea to Emacs master, sending eglot-{} instead of =
nil
as arguments to the shutdown request.
I'll leave it up to you whether to keep the bug open for "fixing"
this in jsonrpc.el (IMO it should be closed since the original problem is
solved).
Jo=C3=A3o
On Fri, Aug 9, 2024 at 11:58=E2=80=AFPM Daniel Pettersson
<daniel@HIDDEN> wrote:
>
> Javier Olaechea <pirata@HIDDEN> writes:
>
> > I did sit down twice to read the jsonrpc.el code and understand what
> > I need to do to make the
> > change I hoped to. But unfortunately I can't even say I understood
> > jsonrpc--async-request-1 well
> > enough.Or even, if that is indeed the function we need to change so
> > that we don't seed a params
>
> As I see it there are two candidates:
>
> Modify calls to jsonrpc-connection-send (jsonrpc--async-request-1,
> jsonrpc-notify, to keep the behavior consistent) such that
> jsonrpc-connection-send is not called with keyword :params if params is
> nil.
>
> Or make the change in jsonrpc-convert-to-endpoint which makes the
> behavior part of jsonrpc.el's API. We are already doing some
> sanitizing here before serialization of a similar character.
>
> I think both options are fine, but I would favor the second one.
>
> > attribute when params is nil. It seems that we are passing the
> > params down in multiple arms?
>
> Both solution candidates above should account for this.
>
> This sort of change does come with some extensive regression testing, as
> Jo=C3=A3o mentioned.
--=20
Jo=C3=A3o T=C3=A1vora
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 9 Aug 2024 22:59:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 09 18:59:28 2024 Received: from localhost ([127.0.0.1]:38761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1scYa0-0008Dz-I9 for submit <at> debbugs.gnu.org; Fri, 09 Aug 2024 18:59:28 -0400 Received: from mail-lj1-f173.google.com ([209.85.208.173]:56669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <daniel.dpettersson.net@HIDDEN>) id 1scYZy-0008Dj-Tx for 66144 <at> debbugs.gnu.org; Fri, 09 Aug 2024 18:59:27 -0400 Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ef2c56da6cso27385331fa.1 for <66144 <at> debbugs.gnu.org>; Fri, 09 Aug 2024 15:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723244332; x=1723849132; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EVrVYzY28ARbv7Q68hodmEraI0FpahO6d7jANWa2yKc=; b=LrhlY0AzuBylFv6NfYRNUWbuDul92IuWtJZ7Qd4JjrwrdEcxJN9B7BG21sP2lv06rX +7G6wCF7JJoyAZ77nVGxCl6CZFglQTgsLW8jNq1whZt90PNdVSvAfuEfNmihRpoBsPQT B5EgOMPyTogQNJmwZVaphumOUH1RMQ5scR/qjc0ZVpneHYBY6fSsBarODF9QUl4MFjZc 2GntzcpqNKY+NwERxXkTouIQtJ6p1/uAFxVSaHiYkeBj6Q6RiI++B241qIUbG2cvgkuv P5o7DGUzbeoQgjmchnHC7BfG5Wa75JoipGOz6DL88DW1/pFoI9/Xg5RpefWRr9vX5phb L4og== X-Forwarded-Encrypted: i=1; AJvYcCXTyYqQ4WWSvplfZPtKo5KWMlpxyLnkToiQrEAabnR4kd954UZplYVqMdOcrYizhkhIS9+MhSAZbuQvrfKxTkuMefLgb04= X-Gm-Message-State: AOJu0Yzz9T2VzBRGapYxqdgkpfCel66KATT4uCniWl4nIyGgAm8dgrVQ n+D8dyS61yjEGemgV7NDxzG8saRvthLVGP1LyWIjNMn8dpxuqfxz X-Google-Smtp-Source: AGHT+IH20utcJcHS5YxFAvK0xnXWDXUf7mpNgRMzUxfmOCfx61k+e3g5ZZPFfeAoaKKRELDPdI33Xg== X-Received: by 2002:a05:6512:224f:b0:52e:be50:9c55 with SMTP id 2adb3069b0e04-530eea2b9a0mr2273685e87.52.1723244331818; Fri, 09 Aug 2024 15:58:51 -0700 (PDT) Received: from Daniels-Air (c-2fc1e455.027-357-6d6c6d4.bbcust.telenor.se. [85.228.193.47]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53200f1b375sm56182e87.202.2024.08.09.15.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 15:58:51 -0700 (PDT) From: Daniel Pettersson <daniel@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec In-Reply-To: <CADwFkmkd38AWLrZRjYog+RCJr3hTr1Yfx=T=uxtd7KpRN2Hv0A@HIDDEN> (Stefan Kangas's message of "Thu, 25 Jul 2024 00:06:28 -0700") References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> <CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN> <CADwFkmkd38AWLrZRjYog+RCJr3hTr1Yfx=T=uxtd7KpRN2Hv0A@HIDDEN> Date: Sat, 10 Aug 2024 00:58:50 +0200 Message-ID: <m2r0axtiad.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Javier Olaechea <pirata@HIDDEN>, 66144 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Javier Olaechea <pirata@HIDDEN> writes: > I did sit down twice to read the jsonrpc.el code and understand what > I need to do to make the > change I hoped to. But unfortunately I can't even say I understood > jsonrpc--async-request-1 well > enough.Or even, if that is indeed the function we need to change so > that we don't seed a params As I see it there are two candidates: Modify calls to jsonrpc-connection-send (jsonrpc--async-request-1, jsonrpc-notify, to keep the behavior consistent) such that jsonrpc-connection-send is not called with keyword :params if params is nil. Or make the change in jsonrpc-convert-to-endpoint which makes the behavior part of jsonrpc.el's API. We are already doing some sanitizing here before serialization of a similar character. I think both options are fine, but I would favor the second one. > attribute when params is nil. It seems that we are passing the > params down in multiple arms? Both solution candidates above should account for this. This sort of change does come with some extensive regression testing, as Jo=C3=A3o mentioned.
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 25 Jul 2024 07:07:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 25 03:07:45 2024 Received: from localhost ([127.0.0.1]:35227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sWsZl-0004a4-Lx for submit <at> debbugs.gnu.org; Thu, 25 Jul 2024 03:07:45 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:45242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1sWsZi-0004Zn-8u for 66144 <at> debbugs.gnu.org; Thu, 25 Jul 2024 03:07:44 -0400 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc34677so743967a12.2 for <66144 <at> debbugs.gnu.org>; Thu, 25 Jul 2024 00:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721891189; x=1722495989; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=QkSeutF8PYzX0CO6dTqUJ9n8c1Tq/mgNXYpbB3bH12U=; b=SG5iG6YyfJLGpXyfyNcyer44vwQVC6Atiql8Lll4njS+f0lBZMAGalGxVkSJ6yVJjQ Yny/KI2lq5Goh4HUVUwdxPnT+6wpPl1p+iud/fzCicddlCRrd1FS8Pkx0STCNxr7tqjV sPYeLV/HMwLyYwt1DkDIfazA15PA24YW7kFB0H+3TVZoWN1Jo50MyA58e4XPl0yITmTe CfSHro4NUHBlFGMV80mEhCZO2GbZM2wfB616cJab9wZuI9ido2l2i6ytma+kOxNASVix wo3QYj3nGxC+bo/JAYPNhFRunTY1XPIavX5Yn6znfkB27ivvEjEit9f3RTN5ZkomXis7 kuoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721891189; x=1722495989; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QkSeutF8PYzX0CO6dTqUJ9n8c1Tq/mgNXYpbB3bH12U=; b=PneW0ZeIwlRVm1q86rf8rTJCucUMYS693ODog4yNvUGU5fOm0V+HrqwXLX2YWkVrQP OkZumHHi1S+bZXpYF5g9krzFFctoI+c3f7Fr3hJkMnhziXYj9ikrc6puVdW9hDD6+cCE UlCEqkQKuJ+M4IX+RmpVQFaCxzH/ge/wDkZV4LA1yTjodpAiUwZ1wU5xYbNpXy1JFo5f KhtGGdixusmeH/KqfxCfE7eGZ3vpzOzsrQszxk++CNP4fF3auVlWQ0699S60ZtTCk9Ig Jom17TXMsJsFjvwVdpfHgT45NzNq2a6iuV0xofFTf+3eqcMn8FG/otMO01kwXuLQ3q8N 9MIQ== X-Gm-Message-State: AOJu0Yyhf8TC1DYtzWwodvQ7W4a+3LPVaitbr5dXis16IMaiBxEOVtnC d55SpUIr4hDMwzgSSVHi8wHTPEEOSnsu+5yTPY0Khd1pAjx2wJQgu8AuQOzJmlEYaQ2Qmzn/hJ7 +n9TaqLvgJuf+uxJI6cKK1d0D4Mw= X-Google-Smtp-Source: AGHT+IFBLWeLLUXXY6wNjiwj2b3L3hb74zDuwsSim1PRb2tshMWFWBu578B8SpgYfnpAagiXjDgYBghNDvlbJTsZF4E= X-Received: by 2002:a05:6402:5216:b0:5a1:f74d:2d58 with SMTP id 4fb4d7f45d1cf-5ac2c1c443cmr1289927a12.24.1721891189173; Thu, 25 Jul 2024 00:06:29 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Jul 2024 00:06:28 -0700 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN> (Javier Olaechea's message of "Sat, 3 Feb 2024 23:15:18 -0500") References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> <CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN> MIME-Version: 1.0 Date: Thu, 25 Jul 2024 00:06:28 -0700 Message-ID: <CADwFkmkd38AWLrZRjYog+RCJr3hTr1Yfx=T=uxtd7KpRN2Hv0A@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Daniel Pettersson <daniel@HIDDEN>, 66144 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Javier Olaechea <pirata@HIDDEN> writes: > I did sit down twice to read the jsonrpc.el code and understand what I need to do to make the > change I hoped to. But unfortunately I can't even say I understood jsonrpc--async-request-1 well > enough.Or even, if that is indeed the function we need to change so that we don't seed a params > attribute when params is nil. It seems that we are passing the params down in multiple arms? Daniel, can you help answer Javier's questions in this bug thread?
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 4 Feb 2024 04:16:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 03 23:16:19 2024 Received: from localhost ([127.0.0.1]:47418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rWTvX-00018B-J4 for submit <at> debbugs.gnu.org; Sat, 03 Feb 2024 23:16:19 -0500 Received: from mail-yw1-x1129.google.com ([2607:f8b0:4864:20::1129]:52467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pirata@HIDDEN>) id 1rWTvV-00017u-Ag for 66144 <at> debbugs.gnu.org; Sat, 03 Feb 2024 23:16:17 -0500 Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-602d222c078so31803527b3.0 for <66144 <at> debbugs.gnu.org>; Sat, 03 Feb 2024 20:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707020160; x=1707624960; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QsIxg6KzdGWDQ4VD7/XSxl6fBhs/ENO8ibKN0IISpdg=; b=PRfeJ+IGGQtg8g9fufVfQpijBcYMh0fhciUVtJogIV3IQjIHqZpNFTJtWUKpyossey OpiVB1huZDV3tHar/mmZxlM/liKQBcqJEM0lEyShRzLCzEiccN+7maFkQOeHlB9cOj09 LrqPA/Vj6T+YVaPAazBxe91zQCZW66mhKXwl2v3q0YCJzW8qDuyxfU935Vd7E+SK6/Ap 3lQrIPfyCk3hrfTlMAg1pEhjbl6DhoruV+8eVeyDnmiz4+41E/L2WiIyA0Xe1jZLXYp3 Pq47vLOmPtYP7yuWuRgw3l5os9X67B2hBUcZ3E4b0Wg9tAetr93F+dJGuYrjw5YeF7Qs HWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707020160; x=1707624960; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QsIxg6KzdGWDQ4VD7/XSxl6fBhs/ENO8ibKN0IISpdg=; b=BSb90u+OYUelzMC783KuHfoOMO7mVzMuawx2UzDbErk3J3i7cP0RwazhFDtjVl/84J UBrFdfSk5peCU+ihp9D/Fk+vV8NQ1g8r2OV0uq5fKdso+Q25nEMQzMNAWn4OJPA1SuBz NR5JGOpQpgI5HDq4YOpxsdkB1xnwZgTAWqMv4dph2iV4/u9loWXvY0TjnyOcqMHsZa+E r/Tof4IwEg3tYfBInRNhWlzCpWa8nxYHVeBSx7ZZlaceWTFEqLbUPjM8QCY+KoqVggHb tUMAec5cb8pCs9BYg6Jl4Lc0sNDMbuMypbkBWJbol6umzUcaOqfx/2Xl9BoUoLeSVe5M mEsA== X-Gm-Message-State: AOJu0Yyzuwt/syIVZIsD5DxVHqYGk9syPqgFsvFl7pRL3RR6zuOb77bJ UyvtPPFM3KEqa43vh2IFYTcauruQdi89wHPDZSBReaQp7uY0A0MrFpEr77POgxFIug2XFWUNIRA 5UexLjq/KS134l+5tFEbm34FHdaw= X-Google-Smtp-Source: AGHT+IFkTScMHcXjzL+4EDv/tJ598m6wBIoyPtrcbwzedDQXyBpwsQfH8eHI9EcaUNrNEPSkJ3VK/Q2m9nxL6qwbQZE= X-Received: by 2002:a81:6cce:0:b0:604:978:e76d with SMTP id h197-20020a816cce000000b006040978e76dmr7119252ywc.8.1707020130030; Sat, 03 Feb 2024 20:15:30 -0800 (PST) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> In-Reply-To: <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> From: Javier Olaechea <pirata@HIDDEN> Date: Sat, 3 Feb 2024 23:15:18 -0500 Message-ID: <CAFVS=zAjHrVRz_8b9W4Fw=6dznqq9XbiRLD-3-hr6Xsw8_bBEg@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec To: Stefan Kangas <stefankangas@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000799a19061086981d" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: 66144 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000799a19061086981d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Javier, did you make any progress here? > I did sit down twice to read the jsonrpc.el code and understand what I need to do to make the change I hoped to. But unfortunately I can't even say I understood jsonrpc--async-request-1 well enough.Or even, if that is indeed the function we need to change so that we don't seed a params attribute when params is nil. It seems that we are passing the params down in multiple arms? --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000799a19061086981d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div dir=3D"ltr"><br></div><br><div class=3D"gmail_qu= ote"><br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Javier, did you make any progress here?<br> </blockquote></div><br></div>I did sit down twice to read the jsonrpc.el co= de and=C2=A0 understand what I need to do to make the change I hoped to. Bu= t unfortunately I can't even say I understood jsonrpc--async-request-1 = well enough.Or even, if that is indeed the function we need to change so th= at we don't seed a params attribute when params is nil. It seems that w= e are passing the params down in multiple arms?<br clear=3D"all"><div><br><= span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class= =3D"gmail_signature">"I object to doing things that computers can do.&= quot; =E2=80=94 Olin Shivers</div></div></div> --000000000000799a19061086981d--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 2 Feb 2024 07:42:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 02 02:42:37 2024 Received: from localhost ([127.0.0.1]:43601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rVoC4-0002GH-Ms for submit <at> debbugs.gnu.org; Fri, 02 Feb 2024 02:42:36 -0500 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:51606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rVoC2-0002G1-1E for 66144 <at> debbugs.gnu.org; Fri, 02 Feb 2024 02:42:35 -0500 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2d066b82658so23020021fa.3 for <66144 <at> debbugs.gnu.org>; Thu, 01 Feb 2024 23:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706859737; x=1707464537; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=DCrQ7Drpsk2RQWt2UhZONRvqttqaVyYXQvGKsL1SM+E=; b=jaddrTGozkjBecf5VMnx6ivECfNSghIA2waKwZoCBVgyDHPNhucxYhOU8lnKT8MfMv OKEmdazquSw3XuGXZ43XMwpYDZNkx5o6NJRbnIL1wN8XEqFihTuVx17VmgxLXymXCmQD lVtcmMh3f302Zag6a9Gw3xTTIF/Pli4ojr6TcHJZOjE9QQSE6b3oydIeNcpe+e0YDykV GTgNOy92LPRF3rWvUTrkXYUgit9DawHIEDAJnH3VD6rxevLDYdLoSZ0K9EdfhDlJb0z2 1UEjM25JmtUKE66MZuLmKUraC8lVO2pzKATmATVzBwu5V+sSOvoPKgfrhHRt/5ZS+FKj mJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706859737; x=1707464537; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DCrQ7Drpsk2RQWt2UhZONRvqttqaVyYXQvGKsL1SM+E=; b=XeR85xUQTZlo68cUeBHCssgBPNfaGuMIHjH44mDqdAs96zoGD+YgLU8kh5kBn/TBCf cPhIZpmQI56laCgNmT0Bh/xvTTAJ4RwK2pQtZvvOlw3HHCQ6VYBN9nySFEPy1+5qG61F 0cvwz5EfrEPfOxJomYxuEaNniNVGd5hgo6se6YLZ4g/t1YlqUjNt4JDbh9B3jKiSkPdU BYoFr3gIaHNJu+pX19xnX3UFkpFYen1Krsx2ZT7kTrmocB6Fc2nBOEluqaxbvr6JgFYf UctkuFFHY9uv7CzylsyIWgFcXovD/MI8M0yRo2q/fa+wzc8xURP9vCCJjRV+fvLbTCrF CkrA== X-Gm-Message-State: AOJu0YxYl3M9FdpZkS12Lv/TCc9svDedovhuTxvTJvaFx4IeFFiWWmBN ydaQGP5d+F0hCuiMPbObL4vMzimBQfL6eVjG/HH/QuOLuI62cNj8OG46tjgxtdDsO3vs1/rFZtp MNAKwhi5T7pZavSxuz6M144TY7QA= X-Google-Smtp-Source: AGHT+IHyz4ynFfkK/Q1vUoyHYjwXmHGa7v57uKnzp0phtVUW3HhlSYKveffg/gHdBLGXV0H4XyN/c1yvzRIa3Zowyb0= X-Received: by 2002:a2e:9114:0:b0:2d0:7590:7dd6 with SMTP id m20-20020a2e9114000000b002d075907dd6mr713604ljg.5.1706859737165; Thu, 01 Feb 2024 23:42:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 1 Feb 2024 23:42:16 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> (Javier Olaechea's message of "Sat, 14 Oct 2023 17:54:54 -0500") References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> MIME-Version: 1.0 Date: Thu, 1 Feb 2024 23:42:16 -0800 Message-ID: <CADwFkmm3R6hE+4hbze=Fm8sGiVVaph-4PpG6QKDR7jXUUJcG5g@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: 66144 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Javier Olaechea <pirata@HIDDEN> writes: >> Great, then I'd say we should first apply your patch. > > I've also checked that it fixes the issue with ocamllsp. I agree that we should apply the change > as it fixes the issue that Aaron is facing. I can work on the jsonrpc regardless and I will take into > consideration the issues that you've mentioned Javier, did you make any progress here? Thanks.
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 22:55:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 18:55:42 2023 Received: from localhost ([127.0.0.1]:50849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrnXo-0000C5-L0 for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 18:55:42 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:44449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pirata@HIDDEN>) id 1qrnXj-0000Be-Du for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 18:55:40 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d9ac31cb021so3553774276.1 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 15:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697324106; x=1697928906; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zrSKUdxcsjckQUoa20WqNGrjYF9c3MgCf296+V4GMfg=; b=hWajmYFI9FT5CoC5C/ykLcV8JWwwobyZ26uvuFNynqF2gXvUHrjqWLH+iX500qo5l2 CzhGcy3TOFQnhVhHghqqyl1T3JiEztBV64gymzWkjXzwF6edFmrlosCbgkAynOzSPQFJ mqc98BloDOc6EVsh043Ep7GESIIfvJ9ZLueJUh6qjjWV7bblyWhKjlQJ1E/WA8W2mxEn JxI1z8rk1z2yWMRr1qpTI0nBk4CtEF3gA2daFPfr9fOa4wESwWJlpOW/b5KNx5HohSic pCpNPcQXkqhKCTFNz/JiJgC5QfAqMSVHfXd4Uucv9ied5w53iFvOxztU7Gl5jyeeLGh5 Sz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697324106; x=1697928906; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zrSKUdxcsjckQUoa20WqNGrjYF9c3MgCf296+V4GMfg=; b=WUHsoCTnF36taMIe9Q02Wa9pbKHUfNFlPKBN0unA6xRsXBkrT5nsduxVXx3Ni7ZA6C 5OOy+h82my0lKdCjtWAAxFo46IyXPlpXjJzWa0ZHVcIXN50Psayus8iUftWjeGAyE/8Z K34WOsFqjr5wcS89Srp+j62BDDnsjwwHL3tGe0SeMGTG2tBI418q6y3VqNVQy10mtxCf dCOkz9Z/Ah9HFDACsyHKkPCttjcw2ujctlHUIAF/9sRLJCGo1MnujhCWiIyboCN7ppeM Dc71msw+QEWAkp0sRZ0dnweqWgdkWHpwdQexHfIFW6AeRwlg9ik9PzwIUioh9edZ1e7c umYQ== X-Gm-Message-State: AOJu0YxCpdORqQNorvhSdh+HNbH10Pw7otxyraYvh2p7EjUY6slovSJZ flZ9qPWIPloCbS7lTvkjyfV7PDqM6vZkresFvxQ= X-Google-Smtp-Source: AGHT+IEFLeHClVafD0lHf5cnGMqw4QIMczib+pIcDsHlJscExzAZTd8/UNBttIi9xlBAjJvdy5ypQFHBczbYfy4ypco= X-Received: by 2002:a0d:d845:0:b0:5a8:2078:48e5 with SMTP id a66-20020a0dd845000000b005a8207848e5mr5272231ywe.31.1697324105865; Sat, 14 Oct 2023 15:55:05 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> In-Reply-To: <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> From: Javier Olaechea <pirata@HIDDEN> Date: Sat, 14 Oct 2023 17:54:54 -0500 Message-ID: <CAFVS=zAZrtAmODm9Rw21Dhw3W0wPGLQbHz3vtXde-h2LLma-jw@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000661e950607b51067" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000661e950607b51067 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Great, then I'd say we should first apply your patch. I've also checked that it fixes the issue with ocamllsp. I agree that we should apply the change as it fixes the issue that Aaron is facing. I can work on the jsonrpc regardless and I will take into consideration the issues that you've mentioned --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000661e950607b51067 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div>> Great, then I'd say we= should first apply your patch.<span class=3D"gmail-im"><br></span><div><br= ></div><div>I've also checked that it fixes the issue with ocamllsp. I = agree that we should apply the change as it fixes the issue that Aaron is f= acing. I can work on the jsonrpc regardless and I will take into considerat= ion the issues that you've mentioned<br><br></div><span class=3D"gmail-= im"></span><br><span class=3D"gmail_signature_prefix">-- </span><br><div di= r=3D"ltr" class=3D"gmail_signature">"I object to doing things that com= puters can do." =E2=80=94 Olin Shivers</div></div> --000000000000661e950607b51067--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 20:29:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 16:29:53 2023 Received: from localhost ([127.0.0.1]:50687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrlGi-00011S-UR for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 16:29:53 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:61675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1qrlGg-000119-35 for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 16:29:51 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50305abe5f0so4206350e87.2 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 13:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697315360; x=1697920160; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b36P6bam7V7/jYOgt88b8Gb2zI3xk78DuCpJgxXYMl4=; b=fZkqVuMfAeZ4AqqLok+uqQfq0BTuk5o1VMfGLVIM0SqqhpWXVh1wK1L1joe0YJO+zf q/MfHO1QegDpPVGyacopXVic4BpOoPb6F1C8mNaqDNyVNCyn4yKZeoJ8In//YU8H6728 tuaz/cRjqYzBnNSB2VjnUcmI8qSsE8Yr5CW+EK6b+e8HOiX1AUbaOMv0DpbEYSBlvkOy ojWAL0Hf5cfW58McBL7yPdES1s8ocfeo22GBVv5VGYZot9TcGTmK6rA+IbFZssVrF0ZO J+9e/tZaZLyUzwWdjEmCCVRoPkrzIyGEv+ek0uXMC9L9f/RDHUYgDJc4gAH7qQTBCpL3 2g+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697315360; x=1697920160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b36P6bam7V7/jYOgt88b8Gb2zI3xk78DuCpJgxXYMl4=; b=EkYD/62/nZtOjKo9jh4bcMcQyBW1QSzA8ClPAnW83fKLrgTSVdvVp6jMlot+sFHw3G /PDPv+ajzu02emgJflV6iNuKkaf9+6rLI33eMlYTGpP/K8848c2Rc9lKCvcgkPEHYXt+ aLuZ/5LyFCtP9SYUbSaVcRkmYmsUUxOKsVifg1uoQ1tj5HWccN4WEHiGwvI7s64MqY0W YQfxpD2lEnsFsAJvbGw6JUMYCbCfs5z1/QNH1yXQ0ORa21S6Bo7WAMVPf716JJC4DfN1 zC6ah9UFFl39tI/Vd0pa96QT/wGoVib7P7nr6B7419Cot5SmZEZm06B7Gq62/ziC6FYU XOwg== X-Gm-Message-State: AOJu0YyF8e/jSbqIqnm9pN+0eS6Cxiy3UyLUE1BpTMXE1GUUArBfemBu lrZL32vw4ArcZtbLZ0JQmfbvWBwoK9LpkY7otnOXNHi2BSQ= X-Google-Smtp-Source: AGHT+IEWHsdmNFWyEcmfHhiQ6eN//2ooZwb5fDOoZu1T1xeHDftqxFsiot8zovwCS2DiGp1WICF2+G3iJUMDQtyFnas= X-Received: by 2002:a05:6512:b01:b0:503:19d9:4b6f with SMTP id w1-20020a0565120b0100b0050319d94b6fmr29884521lfu.0.1697315359890; Sat, 14 Oct 2023 13:29:19 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> In-Reply-To: <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sat, 14 Oct 2023 21:32:05 +0100 Message-ID: <CALDnm5066oKuig=TbE=1g6J1b1ZnPUOqj1k=Gb7Fx_8xwtCJkg@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Oct 14, 2023 at 9:14=E2=80=AFPM Javier Olaechea <pirata@HIDDEN> = wrote: > > > Can you test gopls shutdowns > with your patch Javier? > > I have tested locally with gopls v0.11.0 and M-x > eglot-shutdown works successfully afaict. Both w/o and > w/ the patch applied. Great, then I'd say we should first apply your patch. > However I think it might be better to modify jsonrpc-request > so that when the param argument is nil the JSON serialization > omits the param key. I'm thinking of using the `,@(when param > (list param)) idiom. jsonrpc has tests. I'd like to give it > a go this weekend to see if I can come up with an acceptable > way to have jsonrpc.el conform with the standard w/o changing > the API. What do you think? Maybe, but I don't know if it's worth it. Especially because we risk that other servers don't like this new behavior in particular. It's a very risky change IMO. Anyway, I would like to confirm some things: * That the JSONRPC standard actually allows this. I think you've done this already, but please double check. * That the LSP Base Protocol, which is partially re-described in the LSP spec also seems to allow this. * That the Eglot tests pass after this patch. And ideally test this with some major servers, like rust-analyzer, pylsp, pyright, etc. Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 20:14:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 16:14:59 2023 Received: from localhost ([127.0.0.1]:50607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrl2J-0000Zh-3q for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 16:14:59 -0400 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]:59805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pirata@HIDDEN>) id 1qrl2F-0000ZR-Ly for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 16:14:57 -0400 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-579de633419so38939457b3.3 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 13:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697314466; x=1697919266; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3tePycsQmhIV50h8VEABd8e7zGzwY9ONfw5c/owO7yM=; b=IFBd8Bic2ACVlqnRNuRcW3Jd5aQXODMGQJ64Jc41ehHoAJf/wyNF5lf1Cq1zcSl3nA yVr4dzXzjPsE6Yjm2WPockWOq77nphxICz1R1jPZpOKTdVCVBecywQsmxoVYDbn6VFEA Q3H6VOuSpPiGDCcvSWf2RMb0fDoMRSyHBHWjiH1FK8diMGoQGRZYhBkOA+4M7qGFLWCW fIM0BiyaIUTZVF17l9GYNqfNLkgYZmZOaUv5+z/17oYAwtRHUpNtBb6vVUepfkZ8Efmn NwkQWOPJsmj4b6YAMvvg5xz6Yr0YEOUOWIPoMV3BHrXTk357tsQjD/OM/k9FAaTMgb79 bBeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697314466; x=1697919266; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3tePycsQmhIV50h8VEABd8e7zGzwY9ONfw5c/owO7yM=; b=JEHskTTTjLEvu9QO7Dn/TBCeYQBxBRA/yJD+UQxcK2tEO9kyUWpdUjpIuSO7JmxCAs imXRSCJzkdhsWzefhLHf+oGb6cXWUqZ3m22kviXdmXOOPJEioUJoHiV99R1192zDcyqJ MwfiK50wCmpzwsIBZ+4ZN4U5bxUKfkniqHVLs9I1cA7nfxqotmkveWf67gIs5zZe/YWo ZmFzgiSpG8aMQfkBewuHnySbv3UZHEt91gXdXWZ2CvUSmHOQPO2mLhln78XvglQQU82D 1nZbroQiM+QrAOWc28cSa/iE5j8BnVWUabZvZ6zclF1NY3FhbBD6u4Jv04Marh/eZKjA SL+g== X-Gm-Message-State: AOJu0YyMPckgMdmMDtM9Nb3OQgM/ohDgbc117WxNuKuDbledNwdQZkLP FP+DJ9seQICiaLL9fxIzvJUJdywoiwPgQ5v+oaY= X-Google-Smtp-Source: AGHT+IFuC8F+g7gmbxq4dCn0i8/b7DGfaW9hmsDK8xfwN8NBrynYy50Xv8TpUiB12lT1FEAn19/momSslHAd+nQDtBE= X-Received: by 2002:a81:5e0a:0:b0:59b:bed9:9a3a with SMTP id s10-20020a815e0a000000b0059bbed99a3amr33188696ywb.41.1697314466127; Sat, 14 Oct 2023 13:14:26 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> In-Reply-To: <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> From: Javier Olaechea <pirata@HIDDEN> Date: Sat, 14 Oct 2023 15:14:14 -0500 Message-ID: <CAFVS=zCVr_Vn_=xqr_Si4UVAsBCSALN5UMWL-A80Q3xWsUg_8w@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000d363ed0607b2d1ac" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000d363ed0607b2d1ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Can you test gopls shutdowns with your patch Javier? I have tested locally with gopls v0.11.0 and M-x eglot-shutdown works successfully afaict. Both w/o and w/ the patch applied. However I think it might be better to modify jsonrpc-request so that when the param argument is nil the JSON serialization omits the param key. I'm thinking of using the `,@(when param (list param)) idiom. jsonrpc has tests. I'd like to give it a go this weekend to see if I can come up with an acceptable way to have jsonrpc.el conform with the standard w/o changing the API. What do you think? On Sat, Oct 14, 2023 at 1:30=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > On Sat, Oct 14, 2023 at 7:02=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora= @gmail.com> wrote: > > > > On Sat, Oct 14, 2023 at 6:19=E2=80=AFPM Javier Olaechea <pirata@HIDDEN= om> > wrote: > > > > > > > If you can find some Eglot use case that is actually hurt by this, > we can reopen. > > > > > > The OP has an Eglot use case that is hurt by this, they cannot > shutdown the ocamllsp server. Because when they call M-x eglot-shutdown, > eglot sends an invalid request. The server dies instead of returning a > response and then eglot restarts the server. > > > > But what OP? I don't see this message, can you point to it? > > OK, I see the message now. In that case that changes things. > One of the misbehaving servers has to correct itself. I'd say it > should be gopls. > > Unless that has already happened. Can you test gopls shutdowns > with your patch Javier? > > Jo=C3=A3o > --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000d363ed0607b2d1ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>> Can you test gopls shutdowns<br> with your patch Javier?<br><br></div>I have tested locally with gopls v0.11= .0 and M-x eglot-shutdown works successfully afaict. Both w/o and w/ the pa= tch applied.<br><br>However I think it might be better to modify jsonrpc-re= quest so that when the param argument is nil the JSON serialization omits t= he param key. I'm thinking of using the `,@(when param (list param)) id= iom. jsonrpc has tests. I'd like to give it a go this weekend to see if= I can come up with an acceptable way to have jsonrpc.el conform with the s= tandard w/o changing the API. What do you think?<font color=3D"#888888"><br= ></font></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmai= l_attr">On Sat, Oct 14, 2023 at 1:30=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <<= a href=3D"mailto:joaotavora@HIDDEN">joaotavora@HIDDEN</a>> wrote:<= br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, Oct 14, = 2023 at 7:02=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <<a href=3D"mailto:joaotav= ora@HIDDEN" target=3D"_blank">joaotavora@HIDDEN</a>> wrote:<br> ><br> > On Sat, Oct 14, 2023 at 6:19=E2=80=AFPM Javier Olaechea <<a href=3D= "mailto:pirata@HIDDEN" target=3D"_blank">pirata@HIDDEN</a>> wrote:= <br> > ><br> > > > If you can find some Eglot use case that is actually hurt by= this, we can reopen.<br> > ><br> > > The OP has an Eglot use case that is hurt by this, they cannot sh= utdown the ocamllsp server. Because when they call M-x eglot-shutdown, eglo= t sends an invalid request. The server dies instead of returning a response= and then eglot restarts the server.<br> ><br> > But what OP?=C2=A0 I don't see this message, can you point to it?<= br> <br> OK, I see the message now.=C2=A0 In that case that changes things.<br> One of the misbehaving servers has to correct itself.=C2=A0 I'd say it<= br> should be gopls.<br> <br> Unless that has already happened.=C2=A0 Can you test gopls shutdowns<br> with your patch Javier?<br> <br> Jo=C3=A3o<br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature">"I objec= t to doing things that computers can do." =E2=80=94 Olin Shivers</div> --000000000000d363ed0607b2d1ac--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 18:30:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 14:30:55 2023 Received: from localhost ([127.0.0.1]:50497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrjPb-0005U1-5U for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 14:30:55 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:55413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1qrjPZ-0005Tm-7T for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 14:30:53 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507a0907896so1121224e87.2 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 11:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697308223; x=1697913023; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nH293QJWMCEPn8Kh+xylCDHIS4yTeX8Hew6f1eyij/E=; b=GEjhdfj5k9V1Lxx0ZrpGxiKMSuWqhy351qdbBJ1nlSKIauMU9Ue+agTpFP+DToOwe5 GzsZSQJurtwF68rWl3EamS3Zl+ilMM439ERwOoIsfv8g/qI96muaH8qvYnpOtShrYd8X t+B7xVaeTNekakSfVhV7K7F4uMfuiXmNZdtxWembMzl6jjWGd/bARp3QIzoWxdK2MkZV EDef+6MM3gB67KqkINPqcsST/8ZqvrzsD6/Yn5zI3x3gihiiJEKrd+xlFsYgNWwV9Ko1 4TtKDut6ZR3Z7UACKzsrWy9ovDY1IVvutkos+v5hC4bg2hx+1YV0ic28AqsGisUJz1Yl VLug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697308223; x=1697913023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nH293QJWMCEPn8Kh+xylCDHIS4yTeX8Hew6f1eyij/E=; b=j3UynnQj2cnhN8H1P5pi9Txc3i1xc3SihvBIZSkxmoti+pS1MRPV8J1xIvfYqoVL+a X3TJjVoTY6GwDk1/gZ4AzvyqSHnHV737zu7Mh7KQnZ2YYunkXgFrww+HGtclQuQ1k5Rl 8Pek7fgltESpwtbgyrtizn6+k3pW01MAgcqeVKH79JGOlFitrl0dNpziWkk5f6cQt/F6 wTQC1g++KXNH8NRl/kINpslUPaeWhx6wD4y9i/Nkm1Xzl4/UOJRyVdXVVa07xM68gvB2 nezsLIkWgOwTcOSuvL0nJQmoKrZCpAwiPIU00Qp3M0iATLl43GO1msg782jP+TuFZyT0 gHEw== X-Gm-Message-State: AOJu0YyE2Tponckz2XS1SAHQtBMdOAsLbGvnI4XMX4CfworXVG244Y5r 2h7VBnXI/kzCGrGy3+seeyb5d87soGQU6wF0t5s= X-Google-Smtp-Source: AGHT+IG+tbouCmx0JXUuC3n4ltseTw2MrvCIHbjm5Mq/LXTCprE3begSN0FkbFills5xWFwxNVayelcpVZXIra3s2PA= X-Received: by 2002:a05:6512:1155:b0:502:fdca:2eaa with SMTP id m21-20020a056512115500b00502fdca2eaamr29112938lfg.52.1697308223261; Sat, 14 Oct 2023 11:30:23 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> In-Reply-To: <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sat, 14 Oct 2023 19:33:09 +0100 Message-ID: <CALDnm51td3_PEHABDi137DNOCP=+K=p_PDQetdaF9Y6iRb-MbQ@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Oct 14, 2023 at 7:02=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > > On Sat, Oct 14, 2023 at 6:19=E2=80=AFPM Javier Olaechea <pirata@HIDDEN= > wrote: > > > > > If you can find some Eglot use case that is actually hurt by this, we= can reopen. > > > > The OP has an Eglot use case that is hurt by this, they cannot shutdown= the ocamllsp server. Because when they call M-x eglot-shutdown, eglot send= s an invalid request. The server dies instead of returning a response and t= hen eglot restarts the server. > > But what OP? I don't see this message, can you point to it? OK, I see the message now. In that case that changes things. One of the misbehaving servers has to correct itself. I'd say it should be gopls. Unless that has already happened. Can you test gopls shutdowns with your patch Javier? Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 18:00:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 14:00:07 2023 Received: from localhost ([127.0.0.1]:50473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrivm-0004TH-UD for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 14:00:07 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:60805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1qrivi-0004S4-Qu for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 14:00:05 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5079eed8bfbso1668172e87.1 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 10:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697306373; x=1697911173; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IzB5oLzcw7Wbm08ZjVaBneOatzB4jRC3Nt9+DyhjFfk=; b=WLHNmy9OjB3hR8Vn4J3CbFFYGtRGQmY6rsjNtWs+oIKUhEP0Sfa7JoHcvmEHV7JoLf 1GI0MyKgVjdv1AcWZZ93oCm7gON2OSgPr3rCBAbZfkAsh3Gz5lStD2Orzund8gzLttMU DzrXwxiLJuOkqNKxaajRicCzvsaoJ/sKOvg//WFBzjY3gGk2WKaYP+l09HuxjnyrfEYW mkbder9l4SLTyDZlP/XRTFNHazSfNtAWqYs+hiJNEZnu89dMVfjsjS+Op73fz2cwyxSz oHtBUAa8GAv2I+KOc+mJehEV73GMrnQePwgdvdhVu/lxJjgVw20IM94qofYFYDAZ9MwA h0/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697306373; x=1697911173; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IzB5oLzcw7Wbm08ZjVaBneOatzB4jRC3Nt9+DyhjFfk=; b=Wzh07yBW3uaJ2XkFpRCJ8pCchNRh2v0Y+vFMkLajOOB4QlOxSZwiAHYiGqS2sYq2H6 FZJsZaaCuhmxYMtug5rtZGhh1F4QYq8hzFFxd66VfwkoaETpNhKt4XZkVikMXXsQcDg3 /UP1lnkpsfz83lereJ/vfpmLLwblGHvze1+ljLQtuMqWNi2mPQM8j31PIiuME66QUqX9 ycqmUhVQmEC9DMoouc2wg4/x7vsjNh4gv5GN152Zk0nsQiA5j4CdaCH828vX8UTkADUK n3dA6SGaRGfHM898LLhu46cecstcZnjnCHuPVguVG9qW20jBRPVO4wTth1jv2R00mYXx tMeg== X-Gm-Message-State: AOJu0YwYPKPtn9kvkO3GI7Foh8kBsO01qRPmOhLplL8iD0UkGl0pPkHe /barbKu3efMiY4P1a/uc7CoTHY/dLBMkwHElKgM= X-Google-Smtp-Source: AGHT+IFnz6dKdipZv40JfJvZZA8ZfW4ZXHxrxHWQpgWKUlJJYhwEJtVVMf1kdkhbHc1W+uCubMvD4l1oAfg+in/a8m0= X-Received: by 2002:a05:6512:1326:b0:503:388f:30a3 with SMTP id x38-20020a056512132600b00503388f30a3mr27721962lfu.26.1697306372838; Sat, 14 Oct 2023 10:59:32 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> In-Reply-To: <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sat, 14 Oct 2023 19:02:18 +0100 Message-ID: <CALDnm50HE-QPGi-+F1F2UECog=W4Kt1kSwxBJKf4FZyUN6KriQ@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Oct 14, 2023 at 6:19=E2=80=AFPM Javier Olaechea <pirata@HIDDEN> = wrote: > > > If you can find some Eglot use case that is actually hurt by this, we c= an reopen. > > The OP has an Eglot use case that is hurt by this, they cannot shutdown t= he ocamllsp server. Because when they call M-x eglot-shutdown, eglot sends = an invalid request. The server dies instead of returning a response and the= n eglot restarts the server. But what OP? I don't see this message, can you point to it?
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 17:19:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 13:19:47 2023 Received: from localhost ([127.0.0.1]:50372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qriIk-0002yT-Pt for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 13:19:47 -0400 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]:57806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <pirata@HIDDEN>) id 1qriIi-0002yG-Sn for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 13:19:45 -0400 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5a7bbcc099fso39400877b3.3 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 10:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697303955; x=1697908755; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3p1XG66mbJ+l+r2fTmrNAQmyKIo8mnV5R4xq88Qj3p4=; b=Zw3tKjlilT0318K/dqTcvtidnJXCCNIKIxhrVO5CfM7vUhZAv+Bn6C3ffL+iXEoTEj pJhkqAFwtr86WkM6Qh/Jex/e3CF2e3bYrJFRrD3bEXMYQaSR8zzdyFXqKASfJVnVNaf2 rrTufD0Khy1ZIM3WlqIoSWG8tkqWznJoTiu+ms/8N33e9oQOQ7yLNbY0SyjFSMfNKfKo qvGxQZY1ITAKjdVtwPFwmoNs34fvvUskxGSpKspaMDbyfSrJVgN6OGHir56TnshHwM1i pHQHe9PE1CUO1Bv8i5dCQNA87bt/o4y7zbXxpLKgkbOI4n7ph3e0qJ1TgbJmZtuvk21+ 1tPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697303955; x=1697908755; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3p1XG66mbJ+l+r2fTmrNAQmyKIo8mnV5R4xq88Qj3p4=; b=bqA5K8c59rofOcDXBJJ8cmUa7FBFXN9nHSrDhBa8a3JoL317PSH97vyzVOr76W+Of/ e0BlwX8Gt6sePNCyp4cPM5pIpCUFdkuCadcTuIDYGR6vtL/NcdBaj8ZYQ2uin9Ltt6N0 FV0xVEmIVNqCt/yHhnkvWsg6UbmBYNMm9VfIVA99igt9zDIBP6ChX6q5y4yqSvrEWB7o zAiG2GmnsQeEdGQOpzU9vcDDuAaF+CfsE8vwIil/OJ8HDEOZ9Dw6zqyO/Kxevy16M/LQ K2h5tezwODh9V7VCicnjxEtVdi6x4gq/eL0BIPAoeMJj1h4JFGjbpuzCOJvDx3AkHVuP POVA== X-Gm-Message-State: AOJu0Yx2p7JwmwtZeSeKCgsyDVmya4CvRIfzAnw7uuGIJyS1IZcPxyqW 1ZmXm48dQ6saERmojew21AsJuCX5q1H7869MQceX9LJ945s= X-Google-Smtp-Source: AGHT+IGdZjJFkrft6vDFCn0mJoc/8gpdiwSNiMqQmiqXOfne0qSebQ9fQGb/T+Dsjhd6sd2le98riyoXr05fBj86HqM= X-Received: by 2002:a0d:c542:0:b0:586:a684:e7ba with SMTP id h63-20020a0dc542000000b00586a684e7bamr28052797ywd.39.1697303955571; Sat, 14 Oct 2023 10:19:15 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> In-Reply-To: <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> From: Javier Olaechea <pirata@HIDDEN> Date: Sat, 14 Oct 2023 12:19:04 -0500 Message-ID: <CAFVS=zD-ArYktOQNpmb33riOf4TBqqXwu+GydE9wNJ6d4oh+rg@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000005908270607b05f21" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000005908270607b05f21 Content-Type: text/plain; charset="UTF-8" > If you can find some Eglot use case that is actually hurt by this, we can reopen. The OP has an Eglot use case that is hurt by this, they cannot shutdown the ocamllsp server. Because when they call M-x eglot-shutdown, eglot sends an invalid request. The server dies instead of returning a response and then eglot restarts the server. --0000000000005908270607b05f21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">> If you can find some Eglot use case= that is actually hurt by this, we can reopen.</div><div dir=3D"ltr"><br></= div><div>The OP has an Eglot use case that is hurt by this, they cannot shu= tdown the ocamllsp server. Because when they call M-x eglot-shutdown, eglot= sends an invalid request. The server dies instead of returning a response = and then eglot restarts the server.<br></div><br></div> --0000000000005908270607b05f21--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 17:11:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 13:11:05 2023 Received: from localhost ([127.0.0.1]:50349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qriAL-0002i3-Hn for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 13:11:05 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:56667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1qriAF-0002hG-3k for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 13:11:01 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5041bb9ce51so3900404e87.1 for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 10:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697303429; x=1697908229; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZRPveTSoBwS5EksipqtSBSnh5CAled5QNT+rVUvh3q4=; b=K3nt7xiC2/Zy0Q2j9hlRLaVRJ4fK30Z36w9cLPp1gzC+hIq7xRASW89W3MZvkNiqZi 8xraKW9wOI2m6EqaEX9z7SXhvcVdUyuFabbabhbWZZkZ0rCOSERo2L9Mr1Ya4ndQb/W4 3juGqJcJSJiPUf8bjUBI/mfzdRumH8qXgrWaQCA+yAk0VjjUQU/0y/Gkgh9HvHu0bIeI IrG/a7KZNNEdbQils5meu96L5RnbacpTKO2g8TkbVCTIjuRG0tMzr6+sW54VLnCtIUdn GdTWm0M+EkKYZNRJaG+/OFCJ4Jdgvkdlvxpie7jWNuyWNQf0ZRJIz/GnJpeU3DHabyrz 1CUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697303429; x=1697908229; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZRPveTSoBwS5EksipqtSBSnh5CAled5QNT+rVUvh3q4=; b=OFIYA9glnVJF1FrSHkzEEJ22oActNwkwpak3X9cnMozjVXymhT6Sb0bxlWeS7rLjPk HCtbolOWy66yq9bGNUK3vcigk2IKgOBRKiqqqdLmfZd/Ot5JpOVH3FqUKe4vhWGeg0CU 22CcRdAStSiOqVcoHJYnsHNbEZyTYqWULYDX8sS6eW3LUYYdv/Xc8sasNaMi6iIvtuOu rNJUtQuaId6VxwNnipwinj14PijHJavnMYnvTGrV228E/kTjEjvmyYmylBSJ8CM2jB+q FaD9vIij+ne0NUYuQYVIvWnoSASQiS5j/k8K+85OL/WYX/vIfE9+1OK57didk5gsZJPm MGOw== X-Gm-Message-State: AOJu0YwO72bFjPKL1y/9e5cSa/mV8LZPqKyFSpA10Obiiho9UTHMDBX2 rrcvhd7nxKkmQ/3k7fV3O5cyv/IFvoY4/5KESCU= X-Google-Smtp-Source: AGHT+IEQfLeQav0fLjL6gIf4uoC7NDsDG7Bj5QPMeu+wsSCx95UXoDqWzUaoVIrcLqWtMU0Ow0s5BHgwFyDZDTydLTQ= X-Received: by 2002:ac2:4c4b:0:b0:503:cca:e52f with SMTP id o11-20020ac24c4b000000b005030ccae52fmr32932250lfk.51.1697303429222; Sat, 14 Oct 2023 10:10:29 -0700 (PDT) MIME-Version: 1.0 References: <q7ma5tfi6ot.fsf@HIDDEN> <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN> <83bkd1sjr1.fsf@HIDDEN> <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN> <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> In-Reply-To: <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Sat, 14 Oct 2023 18:13:15 +0100 Message-ID: <CALDnm527O-uD6=8BCaww+Tbk9FHjHa8iZt2hPujx3373P5bEVQ@HIDDEN> Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC To: Javier Olaechea <pirata@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66144 Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Sat, Oct 14, 2023 at 5:59=E2=80=AFPM Javier Olaechea <pirata@HIDDEN> = wrote: > > > Yes. What's the matter? What would the "fix" fix? > > That is illegal, So is a lot of stuff, like smoking certain plants. And yet, if it doesn't hurt anyone... > That said, upon further reflection I think the bug is in json-rpc not egl= ot. Maybe. Anyway, I think we should close this bug. If you can find some Egl= ot use case that is actually hurt by this, we can reopen.
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 16:59:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 12:59:48 2023
Received: from localhost ([127.0.0.1]:50305 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qrhzP-0002He-Qo
for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 12:59:48 -0400
Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]:60871)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <pirata@HIDDEN>) id 1qrhzM-0002FB-Bg
for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 12:59:45 -0400
Received: by mail-yw1-x1133.google.com with SMTP id
00721157ae682-5a7c011e113so42184027b3.1
for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 09:59:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1697302755; x=1697907555; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=tHbPJdhamM1uem0N1kjXFCTSYq/6280bGGPBchijfa0=;
b=gzbRrPrMmWqXMXSlpdQvmRJKhFFfJB1neo7xpCwjWqzWzzjN5b+9+ACgRHp/0F3QSk
iuFbeuwP4xbByNv4icbDzk+BQFgYe1Ef84eJ+QLXYPsiEkzles6cjy9ldQ7iWigMn9Lu
Ivd7/yuM6PCPQ8YwiHfFAY5sOb+2y+XRxrjxIzS4ASMVaWj/aAAvjFO4X81CcNO/D1Gn
vpb4+sUEq1NCPwqkMPfiLLJYoMlzFZ+q3KKwwmT9fIAJvxKgTc1neNfIbOsnJk1k2ue7
uG4AFpsKkIX5esDTrgXNFjzs8ML8Mbzmy4tFyduWHGp30N0XpDjvsueD1ICwaLlxQQSQ
v1qQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697302755; x=1697907555;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=tHbPJdhamM1uem0N1kjXFCTSYq/6280bGGPBchijfa0=;
b=QkhtxmVY3GDHoDTw468DyZ+MuHq9iY7YjCrUzPdR63etpkqPwyK8J9eXDkptm2JrMV
HO+1uyWUVvt9rbR9+3OA0DlH1mgq7JyUfsL4PYKHnDvBJnfSVCG2Tgq/NgW8GiaiIieO
/n8tckAHNYXTb5fuCo1r00tw11YHRpPHfH6jF8JwFYZ8IQcKx0JOfPVWZUfTEfedDJ3q
X2ajHu73EW6bc4N57CjGQ4z5Mj7OkxiqsPKkPOnzM7pm0DnxXKQB69ajsytukt8bSspS
e5iKUhVL/dAM7qa7d3fokGx5drRMcx9j3IBQOrXd3RHfW+mCK+QT3eEg6Bi4D6I/yt0J
2FPA==
X-Gm-Message-State: AOJu0Yzz6gY6xZV2A7Bal8eAbzdilljNFYor5DWYu25UTtcX45gPh4qx
8cu4Cb8H3bJ6P4EMM8RzKuIrlBdB1+SprfJ5To0=
X-Google-Smtp-Source: AGHT+IEc/ld+8wW5iHW21ZqiwGiCumj0nIUL/s3s7qTaC8VEadt1AnBKyBdshGaJL/7EZHMowWj61OR6lguXYkTydjc=
X-Received: by 2002:a05:690c:ece:b0:5a8:286d:339e with SMTP id
cs14-20020a05690c0ece00b005a8286d339emr5112748ywb.4.1697302754926; Sat, 14
Oct 2023 09:59:14 -0700 (PDT)
MIME-Version: 1.0
References: <q7ma5tfi6ot.fsf@HIDDEN>
<CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
<83bkd1sjr1.fsf@HIDDEN>
<CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN>
In-Reply-To: <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN>
From: Javier Olaechea <pirata@HIDDEN>
Date: Sat, 14 Oct 2023 11:59:03 -0500
Message-ID: <CAFVS=zC3QyqQj6Nuq+6rVJEiV62P_zaCKgQCVofakqox-rRowg@HIDDEN>
Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC
To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000c8a4b40607b01777"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66144
Cc: Eli Zaretskii <eliz@HIDDEN>, 66144 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--000000000000c8a4b40607b01777
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
> Yes. What's the matter? What would the "fix" fix?
That is illegal, as in against the JSON-RPC standard, to send a request
with `params: null.`. Quoting section 4.2 from the JSON RPC spec linked by
OP:
> If present, parameters for the rpc call MUST be provided as a Structured
value. Either by-position through an Array or by-name through an Object.
That means in a request object can not have a param key, but if present it
must be an Array or an Object.
That said, upon further reflection I think the bug is in json-rpc not
eglot.
On Sat, Oct 14, 2023 at 3:59=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <joaotavora@g=
mail.com> wrote:
> On Sat, Oct 14, 2023, 09:14 Eli Zaretskii <eliz@HIDDEN> wrote:
>
>> > From: Javier Olaechea <pirata@HIDDEN>
>> > Date: Sat, 7 Oct 2023 22:42:47 -0500
>> >
>> > It seems that eglot used to send an empty object as the params but it
>> got replaced by null to appease
>> > gopls.
>> >
>> >
>> https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca3=
13a58f4375e
>> >
>> > The fix would be replacing the call
>> > (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
>> > with
>> > (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))
>>
>> Jo=C3=A3o, any comments?
>>
>
> Yes. What's the matter? What would the "fix" fix?
>
>>
--=20
"I object to doing things that computers can do." =E2=80=94 Olin Shivers
--000000000000c8a4b40607b01777
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div><div><div>> Yes. What's the matter? What would=
the "fix" fix?<br><br></div>That is illegal, as in against the J=
SON-RPC standard, to send a request with `params: null.`. Quoting section 4=
.2 from the JSON RPC spec linked by OP:<br><br>> If present, parameters =
for the rpc call MUST be provided as a=20
Structured value. Either by-position through an Array or by-name through
an Object.<br><br></div>That means in a request object can not have a para=
m key, but if present it must be an Array or an Object.<br><br>That said, u=
pon further reflection I think the bug is in json-rpc not eglot. <br></div>=
</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">=
On Sat, Oct 14, 2023 at 3:59=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <<a href=
=3D"mailto:joaotavora@HIDDEN">joaotavora@HIDDEN</a>> wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto"><div=
><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, O=
ct 14, 2023, 09:14 Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=
=3D"_blank">eliz@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">> From: Javier Olaechea <<a href=3D"mailto:pi=
rata@HIDDEN" rel=3D"noreferrer" target=3D"_blank">pirata@HIDDEN</a>&g=
t;<br>
> Date: Sat, 7 Oct 2023 22:42:47 -0500<br>
> <br>
> It seems that eglot used to send an empty object as the params but it =
got replaced by null to appease<br>
> gopls.<br>
> <br>
> <a href=3D"https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39=
a888f747ecca313a58f4375e" rel=3D"noreferrer noreferrer" target=3D"_blank">h=
ttps://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a5=
8f4375e</a><br>
> <br>
> The fix would be replacing the call<br>
> (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))<br>
> with<br>
> (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))=
<br>
<br>
Jo=C3=A3o, any comments?<br></blockquote></div></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">Yes. What's the matter? What would the "fi=
x" fix?</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">
</blockquote></div></div></div>
</blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature">"I objec=
t to doing things that computers can do." =E2=80=94 Olin Shivers</div>
--000000000000c8a4b40607b01777--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 09:00:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 05:00:31 2023
Received: from localhost ([127.0.0.1]:47864 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qraVb-0008Ho-0j
for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 05:00:31 -0400
Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:56811)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <joaotavora@HIDDEN>) id 1qraVY-0008HS-FZ
for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 05:00:29 -0400
Received: by mail-lf1-x12a.google.com with SMTP id
2adb3069b0e04-5041bb9ce51so3552255e87.1
for <66144 <at> debbugs.gnu.org>; Sat, 14 Oct 2023 02:00:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1697273999; x=1697878799; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=H0zb1419Hwkt+UEXkpEIPTZFVVqV570d3Cg3F8CtJCw=;
b=c5BO7Qv7WcETS9xaoiBCszF3pZTIbXor19XgAhxCZGCcxDC0tWt8x+fx2J5+wcLeQ/
E8ujnpx8AZDWGaCprYSmeU1kQZbMSN5K6fECsPhon0HP3jAtzGoKWn7OMqtSYqN+nr6N
5HeTLiEFAfZJt2ayqNr4JQDi1IQFIS5H6ZxbCPVl9X49R4fr38fJXCDv2UFTvGeu9sPL
n1rc8LmnkBa+OQSuAXLvTJGtcw+G7GDj8Xst9/fL++VZsq0dnIaxsqg8B3oYgBLqO94M
/RJuXPCuneahSzME2VwHC035oi9kIePm5Vwtt3hvNByFJYCTWy5BMQLxOUrBH1JHkcLO
l+iQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697273999; x=1697878799;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=H0zb1419Hwkt+UEXkpEIPTZFVVqV570d3Cg3F8CtJCw=;
b=etqar+yQDvaTtvTtlSB5t7IT0mOOLpiNrsZgKsR3V/oN/AIYgsGDXabpis8zYMU5fg
9EQcrz2EBF/SNc3pRq6DfkNlOZ/KfWI812rlrLdCi5W/XRgZ4dErSc539QedYgezirak
7EZ9+38yuYOdeBGigV782qdAOKMp3+wiBipX0J1JLrZd97WcShN/UxnfUnDsIb56QWBZ
4/O0j5O91M8uRW3glzH9Q185rSj+wz4+zVBfclx1Il2CA3Rt0LC52Gk3sEkux87JEOh4
Va9+pOvMgPG/lIIZ8g8SIxcPvncIcYeKjCtOvEje1fPYfY+KEw1vusJY3gwwRaqVQLcl
lpQg==
X-Gm-Message-State: AOJu0Yw8K6IIFga9mBjI+8CXVsvnLbl3YqeNjbzU6zBajmnlPKRxwgF5
DLQDTLemWlrwYCQ9nYt4Wwisu5eLiRC05vlDpdU=
X-Google-Smtp-Source: AGHT+IF/7rls7/C4P/b0JrZg0yRb4WoXNVN593p8bgkDHWNUpTmiUmM+8E2S+/rxny55fOx9wgs99c8nBNrCpq727VQ=
X-Received: by 2002:ac2:522f:0:b0:500:b7dc:6c90 with SMTP id
i15-20020ac2522f000000b00500b7dc6c90mr22661254lfl.36.1697273998605; Sat, 14
Oct 2023 01:59:58 -0700 (PDT)
MIME-Version: 1.0
References: <q7ma5tfi6ot.fsf@HIDDEN>
<CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
<83bkd1sjr1.fsf@HIDDEN>
In-Reply-To: <83bkd1sjr1.fsf@HIDDEN>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Sat, 14 Oct 2023 09:59:46 +0100
Message-ID: <CALDnm51bEn4KiPP0GgU_4uJxHz+vpZBdd7Vj5p_h9RTesuKUyg@HIDDEN>
Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000c6033d0607a96556"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66144
Cc: Javier Olaechea <pirata@HIDDEN>, 66144 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--000000000000c6033d0607a96556
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Sat, Oct 14, 2023, 09:14 Eli Zaretskii <eliz@HIDDEN> wrote:
> > From: Javier Olaechea <pirata@HIDDEN>
> > Date: Sat, 7 Oct 2023 22:42:47 -0500
> >
> > It seems that eglot used to send an empty object as the params but it
> got replaced by null to appease
> > gopls.
> >
> >
> https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca31=
3a58f4375e
> >
> > The fix would be replacing the call
> > (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
> > with
> > (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))
>
> Jo=C3=A3o, any comments?
>
Yes. What's the matter? What would the "fix" fix?
>
--000000000000c6033d0607a96556
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Sat, Oct 14, 2023, 09:14 Eli Zaretskii <<a href=3D"mailt=
o:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-l=
eft:1ex">> From: Javier Olaechea <<a href=3D"mailto:pirata@HIDDEN"=
target=3D"_blank" rel=3D"noreferrer">pirata@HIDDEN</a>><br>
> Date: Sat, 7 Oct 2023 22:42:47 -0500<br>
> <br>
> It seems that eglot used to send an empty object as the params but it =
got replaced by null to appease<br>
> gopls.<br>
> <br>
> <a href=3D"https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39=
a888f747ecca313a58f4375e" rel=3D"noreferrer noreferrer" target=3D"_blank">h=
ttps://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a5=
8f4375e</a><br>
> <br>
> The fix would be replacing the call<br>
> (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))<br>
> with<br>
> (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))=
<br>
<br>
Jo=C3=A3o, any comments?<br></blockquote></div></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">Yes. What's the matter? What would the "fi=
x" fix?</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;padding-left:1ex">
</blockquote></div></div></div>
--000000000000c6033d0607a96556--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 08:15:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 14 04:15:30 2023
Received: from localhost ([127.0.0.1]:47824 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qrZo2-0006dW-1R
for submit <at> debbugs.gnu.org; Sat, 14 Oct 2023 04:15:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48980)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1qrZnz-0006dA-PP
for 66144 <at> debbugs.gnu.org; Sat, 14 Oct 2023 04:15:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1qrZnX-0002dX-0S; Sat, 14 Oct 2023 04:14:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=KaYtqSSmrAohMgJe85FEust9bZNjER26lFUI5aaGGpg=; b=dHC37kYJ5U+ZUCaDcKOC
5elHHGI+p/qvfhQQW1elIWVxcEXbL6fOfpkXDHMugrkrCJFhYq7Syomye8yh3nKJfDKbLFxD054Uv
5Og32Y7y53pv62P1O8vXaoPcQ/3y+AmnLNCXvz6Ka5D0VS47cmJUifbTpGONtXqnhNAC/EP3X9Xp0
m3cy7nSOFjV+hPkWp+fkHPGBbzjd0BOd4qFdgsd+elEyFnPPvGCjxnnZLboeLpsQDQ3Fa0HFiMZ3O
JR47JgZU9vl0V92rwsGTAofHyI5ioxz8+emKt96Ch+5OKSPW/lA9MrM1G8aEYnO6Syl8xVciihevd
wfoGCs5GnO66mg==;
Date: Sat, 14 Oct 2023 11:14:58 +0300
Message-Id: <83bkd1sjr1.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Javier Olaechea <pirata@HIDDEN>, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=
<joaotavora@HIDDEN>
In-Reply-To: <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
(message from Javier Olaechea on Sat, 7 Oct 2023 22:42:47 -0500)
Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC
References: <q7ma5tfi6ot.fsf@HIDDEN>
<CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66144
Cc: 66144 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Javier Olaechea <pirata@HIDDEN>
> Date: Sat, 7 Oct 2023 22:42:47 -0500
>
> It seems that eglot used to send an empty object as the params but it got replaced by null to appease
> gopls.
>
> https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a58f4375e
>
> The fix would be replacing the call
> (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
> with
> (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))
João, any comments?
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
Received: (at 66144) by debbugs.gnu.org; 8 Oct 2023 03:43:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 07 23:43:27 2023
Received: from localhost ([127.0.0.1]:56131 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qpKhS-00029S-UU
for submit <at> debbugs.gnu.org; Sat, 07 Oct 2023 23:43:27 -0400
Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]:56374)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <pirata@HIDDEN>) id 1qpKhR-00029F-4B
for 66144 <at> debbugs.gnu.org; Sat, 07 Oct 2023 23:43:25 -0400
Received: by mail-yw1-x112e.google.com with SMTP id
00721157ae682-5a24b03e22eso42128397b3.0
for <66144 <at> debbugs.gnu.org>; Sat, 07 Oct 2023 20:43:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1696736579; x=1697341379; darn=debbugs.gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=FSonRqX3uUFUwcAWDPOzPVPnLOaPgtao75JQGM+H1VQ=;
b=Ve55G19HSGAikgF1cQMEwGy4QtqByuNyuJwJ9OK+nTbtd6YypVVvhCn2ARiiHMvQEn
80KTqCUCtr/uF0MmuE2ZLE7ENLtZbzDasox9+52hKbKM9RN4vGkzv0Xx6B6X5BNGHbeT
tASu6yqZDE6bR6rQW2q6Lwecnj+YG8cXzDQPU9XbnpXEeeOQnUuZXtHVmGehy8N8Yzy6
B+lsyl4Ym8iThZnyUiOveZoD8FRvKZlK6rPch2SKD+HVHM48iry8DkerBjcM7IjuYO6u
/v/886SOFDP8yFxJoCYxJtU2mr0sXhDCoN+xDxbx7tuAMaYL3FpjZIOJt9Qo8n94Wjqc
XeSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1696736579; x=1697341379;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=FSonRqX3uUFUwcAWDPOzPVPnLOaPgtao75JQGM+H1VQ=;
b=Z2/0nm2WO0Q1rcwOzXs/NngQ9kKTDyx7teu/H9SZFj6/7pHsJ+4nC+rpBa1tBZmRU3
Wk1gm6lHmRXLCYctIWQHv1FNLZhaQRqt/E0VkAfT5r4+XBfbrP8dB3NIGPI+yqOTbIgW
J88tr99OjsIw5S6CA9pogbvETbfTZxcfGamoSY+FN3L/gSqly0+9BWhyHC/WB/3CaAy1
5837wxy5JI69agJrCpDZSgogPrzqf+RzfMc3fse9xSIwvjUTs9nhO60yLQCz7fqDVnpI
lUahVzYv48/5RzQCouLxUkrdjIIhz5lVHevkE1oLNPru0k6+Tl7nPAFwHTdKGPbXcpp5
4F4Q==
X-Gm-Message-State: AOJu0YyroTSWmw+DLbe4fMHn7SOGKER7mc9/3j+pab0WhsEYeLCeDSLq
4CHLF8lDl6dLg8/taxBuHGHnDPfgOmTH7DZsC3Tq4v0zONM=
X-Google-Smtp-Source: AGHT+IGpEaR/0AaTYvLlx/oT3c0Wp/Rb7umzTpdfLOxpeW9IAJy39RrGbNG5+uxgcEPCDacEVzgTq8iw4XYOj/5EmPY=
X-Received: by 2002:a81:5482:0:b0:59b:8da4:dc2 with SMTP id
i124-20020a815482000000b0059b8da40dc2mr12157974ywb.48.1696736578831; Sat, 07
Oct 2023 20:42:58 -0700 (PDT)
MIME-Version: 1.0
From: Javier Olaechea <pirata@HIDDEN>
Date: Sat, 7 Oct 2023 22:42:47 -0500
Message-ID: <CAFVS=zD+hAuMEoGk+NhM=8v5f0oZdhKBN5JAvTXrvAF1wZgv7A@HIDDEN>
Subject: Re: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC
To: "bug#66144" <66144 <at> debbugs.gnu.org>
Content-Type: multipart/alternative; boundary="0000000000000f0c4306072c45a7"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 66144
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--0000000000000f0c4306072c45a7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
It seems that eglot used to send an empty object as the params but it got
replaced by null to appease gopls.
https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a=
58f4375e
The fix would be replacing the call
(jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
with
(jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))
--=20
"I object to doing things that computers can do." =E2=80=94 Olin Shivers
--0000000000000f0c4306072c45a7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div><div>It seems that eglot used to send an empty object=
as the params but it got replaced by null to appease gopls.<br><br><a href=
=3D"https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca=
313a58f4375e">https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a8=
88f747ecca313a58f4375e</a><br><br></div>The fix would be replacing the call=
<br>(jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))<br></d=
iv><div>with</div><div>(jsonrpc-request server :shutdown eglot--{} :timeout=
(or timeout 1.5))</div><div><div><br><span class=3D"gmail_signature_prefix=
">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=
=3D"gmail_signature">"I object to doing things that computers can do.&=
quot; =E2=80=94 Olin Shivers</div></div></div></div>
--0000000000000f0c4306072c45a7--
bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 21 Sep 2023 20:59:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 21 16:59:39 2023
Received: from localhost ([127.0.0.1]:34878 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qjQlv-0000kl-05
for submit <at> debbugs.gnu.org; Thu, 21 Sep 2023 16:59:39 -0400
Received: from lists.gnu.org ([2001:470:142::17]:48612)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <azeng@HIDDEN>) id 1qjQlr-0000kV-9l
for submit <at> debbugs.gnu.org; Thu, 21 Sep 2023 16:59:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <azeng@HIDDEN>)
id 1qjQla-0004qR-U0
for bug-gnu-emacs@HIDDEN; Thu, 21 Sep 2023 16:59:18 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <azeng@HIDDEN>)
id 1qjQlY-0008Do-7P
for bug-gnu-emacs@HIDDEN; Thu, 21 Sep 2023 16:59:17 -0400
From: Aaron Zeng <azeng@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.1; eglot-shutdown request params violate JSONRPC spec
Date: Thu, 21 Sep 2023 16:59:14 -0400
Message-ID: <q7ma5tfi6ot.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.215.233.18; envelope-from=azeng@HIDDEN;
helo=mxout5.mail.janestreet.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H5=0.001,
RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
When using Eglot with ocamllsp (or other language servers built with the
same OCaml LSP server library), M-x eglot-shutdown sends an invalid
JSONRPC request to the language server and causes it to exit with an
error message instead of gracefully. As an additional side effect of
the error, eglot will restart/reconnect to the language server instead
of staying disconnected.
1. emacs -Q
2. C-x C-f ~/temp.ml
3. M-: (setq major-mode 'tuareg-mode)
4. M-x eglot
5. C-u M-x eglot-shutdown
This produces the following *Messages*:
[eglot] Connected! Server `ocamllsp' now managing `(tuareg-mode caml-mode reason-mode)' buffers in project `azeng'.
[eglot] Asking EGLOT (azeng/(tuareg-mode caml-mode reason-mode)) politely to terminate
[jsonrpc] Server exited with status 1
jsonrpc-error: "request id=5 failed:", (jsonrpc-error-code . -1), (jsonrpc-error-message . "Server died"), (jsonrpc-error-data)
And from the events buffer:
[client-request] (id:2) Thu Sep 21 16:48:11 2023:
(:jsonrpc "2.0" :id 2 :method "shutdown" :params nil)
[stderr] (monitor.ml.Error
[stderr] ("Jsonrpc: json conversion failed: invalid structured value")
[stderr] ("Raised at Lsp_json_rpc_types__Import.Json.error in file \"import.ml\" (inlined), line 31, characters 23-50"
[stderr] "Called from Lsp_json_rpc_types__Jsonrpc.Structured.t_of_yojson in file \"jsonrpc.ml\" (inlined), line 59, characters 14-56"
[stderr] "Called from Lsp_json_rpc_types__Import.Option.map in file \"import.ml\" (inlined), line 7, characters 21-26"
[stderr] "Called from Lsp_json_rpc_types__Import.Json.field in file \"import.ml\" (inlined), line 46, characters 31-79"
[stderr] "Called from Lsp_json_rpc_types__Jsonrpc.Packet.t_of_fields in file \"jsonrpc.ml\", line 298, characters 21-77"
[stderr] "Called from Lsp__Io.Make.read in file \"io.ml\" (inlined), line 108, characters 24-57"
[stderr] "Called from Fiber__Core.O.(>>=).(fun) in file \"core.ml\", line 251, characters 34-39"
[stderr] "Called from Fiber__Scheduler.exec in file \"scheduler.ml\", line 76, characters 8-11"
[stderr] "Re-raised at Stdune__Exn.raise_with_backtrace.(partial) in file \"exn.ml\" (inlined), line 38, characters 27-56"
[stderr] "Called from Stdune__Exn_with_backtrace.reraise in file \"exn_with_backtrace.ml\" (inlined), line 20, characters 33-71"
[stderr] "Called from Fiber__Scheduler.exec in file \"scheduler.ml\", line 81, characters 30-60"
[stderr] "Called from Fiber__Scheduler.advance in file \"scheduler.ml\" (inlined), line 194, characters 2-58"
[stderr] "Called from Fiber_async.deferred_of_fiber.loop.(fun) in file \"fiber_async.ml\" (inlined), line 44, characters 11-53"))
[internal] Thu Sep 21 16:48:11 2023:
(:message "Connection state changed" :change "exited abnormally with code 1\n")
----------b---y---e---b---y---e----------
It seems that jsonrpc.el is sending a "null" value for the params field
of a request, when it should instead be omitting the field or sending an
empty JSON object instead:
https://www.jsonrpc.org/specification#parameter_structures
Users of other editors have reported similar issues, and concluded that
this was correct (if pedantic) behavior by ocamllsp and should be fixed
in the editor: https://github.com/helix-editor/helix/issues/5400
In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.15.12, Xaw scroll bars) of 2023-09-21 built on
igm-qws-u12685a
Repository revision: a9b28224af0f73d1fe0f422e9b318c5b91af889b
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.8 (Green Obsidian)
Configured using:
'configure --with-x-toolkit=lucid --without-gpm --without-gconf
--without-selinux --without-imagemagick --with-modules --with-gif=no
--with-cairo --with-rsvg'
Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID
ZLIB
Important settings:
value of $LANG: en_US.utf8
locale-coding-system: utf-8-unix
Major mode: Fundamental
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
blink-cursor-mode: t
buffer-read-only: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
None found.
Features:
(tabify cus-edit cus-start cus-load wid-edit cl-print mailalias rmail
shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils time-date cl-extra eglot external-completion array
filenotify jsonrpc ert pp ewoc debug backtrace find-func xref
flymake-proc flymake warnings icons compile text-property-search comint
ansi-osc ansi-color ring pcase url-util url-parse auth-source cl-seq
eieio eieio-core cl-macs password-cache json subr-x map url-vars project
byte-opt gv bytecomp byte-compile imenu thingatpt help-fns radix-tree
help-mode cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process emacs)
Memory information:
((conses 16 114174 16392)
(symbols 48 11887 5)
(strings 32 36275 1576)
(string-bytes 1 1007705)
(vectors 16 22858)
(vector-slots 8 309640 13918)
(floats 8 79 204)
(intervals 56 351 0)
(buffers 976 20))
Aaron Zeng <azeng@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#66144; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.