GNU logs - #66152, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Sep 2023 11:25:01 +0000
Resent-Message-ID: <handler.66152.B.169538186714106 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66152 <at> debbugs.gnu.org
Content-Type: multipart/mixed; boundary="------------OF3a00agbJrc0Si65OhLyc06"
Message-ID: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
Date: Fri, 22 Sep 2023 13:23:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: fr, en-US
From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Received-SPF: pass client-ip=213.182.54.15; envelope-from=btuin@HIDDEN;
 helo=msg-4.mailo.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This is a multi-part message in MIME format.
--------------OF3a00agbJrc0Si65OhLyc06
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


There are missing indent rules in c-ts-mode.
Currently there is no rule if an identifier in a declaration is on a new
line. In these two cases, "variable_name" is not indented:

static myttype *
variable_name;

static myttype
variable_name;

The new behavior is the same as c-mode.


In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
  3.24.38, cairo version 1.17.8) of 2023-09-19 built on inspiron-5567
Repository revision: 991bf3f0f5dff66794785ebfcc867611fe75e0da
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12302001
System Description: Arch Linux

Configured using:
  'configure PKG_CONFIG_PATH=/home/arch-aug/.opam/default/lib/pkgconfig:'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
   value of $LANG: fr_FR.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   minibuffer-regexp-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x
cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 37844 9140) (symbols 48 5209 0) (strings 32 13243 1761)
  (string-bytes 1 376699) (vectors 16 10300)
  (vector-slots 8 156214 14950) (floats 8 22 23) (intervals 56 220 0)
  (buffers 992 10))
--------------OF3a00agbJrc0Si65OhLyc06
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Add-missing-indent-rules-in-c-ts-mode.patch"
Content-Disposition: attachment;
 filename="0001-Add-missing-indent-rules-in-c-ts-mode.patch"
Content-Transfer-Encoding: base64

RnJvbSAyZDUyNDhkOTYxMmZlYjZlNTViZjllMjJlNWQ4YmMxYjhmNTY1YmE4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QXVndXN0aW49MjBDaD1DMz1BOW5l
YXU/PSA8YnR1aW5AbWFpbG8uY29tPgpEYXRlOiBXZWQsIDIwIFNlcCAyMDIzIDEyOjIzOjA2
ICswMjAwClN1YmplY3Q6IFtQQVRDSCAxLzNdIEFkZCBtaXNzaW5nIGluZGVudCBydWxlcyBp
biBjLXRzLW1vZGUKCi0tLQogbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsIHwgMiArKwog
MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJv
Z21vZGVzL2MtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbAppbmRl
eCA3MDcxN2E5MGNhYS4uMzE0ZjM3ZjdlYzUgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVz
L2MtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwKQEAgLTQw
Nyw2ICs0MDcsOCBAQCBjLXRzLW1vZGUtLWluZGVudC1zdHlsZXMKICAgICAgICAgICAgKChw
YXJlbnQtaXMgInByZXByb2MiKSBjLXRzLW1vZGUtLWFuY2hvci1wcmV2LXNpYmxpbmcgMCkK
IAogICAgICAgICAgICAoKHBhcmVudC1pcyAiZnVuY3Rpb25fZGVmaW5pdGlvbiIpIHBhcmVu
dC1ib2wgMCkKKyAgICAgICAgICAgKChwYXJlbnQtaXMgInBvaW50ZXJfZGVjbGFyYXRvciIp
IHBhcmVudC1ib2wgMCkKKyAgICAgICAgICAgKChwYXJlbnQtaXMgImRlY2xhcmF0aW9uIikg
cGFyZW50LWJvbCAwKQogICAgICAgICAgICAoKHBhcmVudC1pcyAiY29uZGl0aW9uYWxfZXhw
cmVzc2lvbiIpIGZpcnN0LXNpYmxpbmcgMCkKICAgICAgICAgICAgKChwYXJlbnQtaXMgImFz
c2lnbm1lbnRfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wgYy10cy1tb2RlLWluZGVudC1vZmZz
ZXQpCiAgICAgICAgICAgICgocGFyZW50LWlzICJjb25jYXRlbmF0ZWRfc3RyaW5nIikgZmly
c3Qtc2libGluZyAwKQotLSAKMi40Mi4wCgo=

--------------OF3a00agbJrc0Si65OhLyc06--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Subject: bug#66152: Acknowledgement (30.0.50; Missing indent rules in
 c-ts-mode)
Message-ID: <handler.66152.B.169538186714106.ack <at> debbugs.gnu.org>
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
X-Gnu-PR-Message: ack 66152
X-Gnu-PR-Package: emacs
Reply-To: 66152 <at> debbugs.gnu.org
Date: Fri, 22 Sep 2023 11:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 66152 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66152: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66152
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
In-Reply-To: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
Resent-From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Sep 2023 12:30:01 +0000
Resent-Message-ID: <handler.66152.B66152.16957313711233 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66152 <at> debbugs.gnu.org
Content-Type: multipart/mixed; boundary="------------MWqV9IU0X9E49Vv5q3TdQEoA"
Message-ID: <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN>
Date: Tue, 26 Sep 2023 14:29:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: fr, en-US
From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------MWqV9IU0X9E49Vv5q3TdQEoA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I found some more issues.

First, there is no rule for an element in an else clause:


if (true)
   do_something();
else
do_something_else();


"do_something_else" is not indented.

There is also something weird with the bsd indent style.  It indents 
do_something and do_something_else to parent-bol with 0 offset, so the 
result is:

if (true)
do_something();
else
do_something_else();


It is very different from the bsd style from c-mode, which produces this:

if (true)
	do_something();
else
	do_something_else();

By looking at random files from OpenBSD, they do indent their 
expressions inside if and else:

<https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/net/bsd-comp.c?rev=1.17&content-type=text/plain>
(lines 277, 484, and 527)



Also there is a second patch which tries to handle specific types of 
comments.  I don't know how popular it is, but some people use these 
kind of comments:

/*---------.
| %param.  |
`---------*/

Here we want the vertical bar ("|") to be indented at the same column as 
the first "/".

Currently the result is this:

/*---------.
   | %param.  |
   `---------*/

This patch is a just proof of concept.  If this new behavior is indeed 
wanted, I would clean it up and adapt other modes.
--------------MWqV9IU0X9E49Vv5q3TdQEoA
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-c-ts-mode-Add-indentation-rule-for-else_clause.patch"
Content-Disposition: attachment;
 filename*0="0001-c-ts-mode-Add-indentation-rule-for-else_clause.patch"
Content-Transfer-Encoding: base64

RnJvbSBkMDUwNjE5NzQzYjI2MDRkZmEzYjEzNDJmYTEyZWU5OWE0YWE1NTBhIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QXVndXN0aW49MjBDaD1DMz1BOW5l
YXU/PSA8YnR1aW5AbWFpbG8uY29tPgpEYXRlOiBUdWUsIDI2IFNlcCAyMDIzIDE0OjAzOjE4
ICswMjAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIGMtdHMtbW9kZTogQWRkIGluZGVudGF0aW9u
IHJ1bGUgZm9yIGVsc2VfY2xhdXNlCgotLS0KIGxpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5l
bCB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEv
bGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2Rl
LmVsCmluZGV4IDMxNGYzN2Y3ZWM1Li5jYjIzNjQ0NzM2OCAxMDA2NDQKLS0tIGEvbGlzcC9w
cm9nbW9kZXMvYy10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5l
bApAQCAtNDU1LDYgKzQ1NSw3IEBAIGMtdHMtbW9kZS0taW5kZW50LXN0eWxlcwogICAgICAg
ICAgICA7OyBUaGVzZSBydWxlcyBhcmUgZm9yIGNhc2VzIHdoZXJlIHRoZSBib2R5IGlzIGJy
YWNrZXRsZXNzLgogICAgICAgICAgICA7OyBUZXN0ZWQgYnkgdGhlICJCcmFja2V0bGVzcyBT
aW1wbGUgU3RhdGVtZW50IiB0ZXN0LgogICAgICAgICAgICAoKHBhcmVudC1pcyAiaWZfc3Rh
dGVtZW50Iikgc3RhbmRhbG9uZS1wYXJlbnQgYy10cy1tb2RlLWluZGVudC1vZmZzZXQpCisg
ICAgICAgICAgICgocGFyZW50LWlzICJlbHNlX2NsYXVzZSIpIHN0YW5kYWxvbmUtcGFyZW50
IGMtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAgICAgICAoKHBhcmVudC1pcyAiZm9y
X3N0YXRlbWVudCIpIHN0YW5kYWxvbmUtcGFyZW50IGMtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0
KQogICAgICAgICAgICAoKHBhcmVudC1pcyAid2hpbGVfc3RhdGVtZW50Iikgc3RhbmRhbG9u
ZS1wYXJlbnQgYy10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICAgICAgICgocGFyZW50
LWlzICJkb19zdGF0ZW1lbnQiKSBzdGFuZGFsb25lLXBhcmVudCBjLXRzLW1vZGUtaW5kZW50
LW9mZnNldCkKLS0gCjIuNDIuMAoK
--------------MWqV9IU0X9E49Vv5q3TdQEoA
Content-Type: text/x-patch; charset=UTF-8;
 name="0002-c-ts-mode-handle-specific-comment-formatting.patch"
Content-Disposition: attachment;
 filename="0002-c-ts-mode-handle-specific-comment-formatting.patch"
Content-Transfer-Encoding: base64

RnJvbSAwMDc0ZGI0MjI0YjQyNjllZWM0NjRhYzAwZWI3NTFkOTE5YWVjNDA4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QXVndXN0aW49MjBDaD1DMz1BOW5l
YXU/PSA8YnR1aW5AbWFpbG8uY29tPgpEYXRlOiBUdWUsIDI2IFNlcCAyMDIzIDE0OjEwOjQw
ICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGMtdHMtbW9kZTogaGFuZGxlIHNwZWNpZmlj
IGNvbW1lbnQgZm9ybWF0dGluZwoKLS0tCiBsaXNwL3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5l
bCB8IDExICsrKysrKysrKysrCiBsaXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwgICB8ICA0
ICsrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt
KQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtY29tbW9uLmVsIGIvbGlzcC9w
cm9nbW9kZXMvYy10cy1jb21tb24uZWwKaW5kZXggM2IwODE0OTcwYWQuLjFlYTQxMjYwYWI4
IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5lbAorKysgYi9saXNw
L3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5lbApAQCAtNTYsNiArNTYsMTcgQEAKIAogOzs7IENv
bW1lbnQgaW5kZW50YXRpb24gYW5kIGZpbGxpbmcKIAorCisoZGVmdW4gYy10cy1jb21tb24t
bG9va2luZy1hdCAoY2hhciAmcmVzdCBjaGFycykKKyAgKGxhbWJkYSAoX24gX3AgYm9sICZy
ZXN0IF8pCisgICAgKGxldCAoKHJlcyBuaWwpKQorICAgICAgKHNldHEgcmVzIChlcSAoY2hh
ci1hZnRlciBib2wpIGNoYXIpKQorICAgICAgKHdoaWxlIChhbmQgY2hhcnMgKG5vdCByZXMp
KQorICAgICAgICAoc2V0cSBjaGFyIChjYXIgY2hhcnMpCisgICAgICAgICAgICAgIGNoYXJz
IChjZHIgY2hhcnMpCisgICAgICAgICAgICAgIHJlcyAoZXEgKGNoYXItYWZ0ZXIgYm9sKSBj
aGFyKSkpCisgICAgICByZXMpKSkKKwogKGRlZnVuIGMtdHMtY29tbW9uLWxvb2tpbmctYXQt
c3RhciAoX24gX3AgYm9sICZyZXN0IF8pCiAgICJBIHRyZWUtc2l0dGVyIHNpbXBsZSBpbmRl
bnQgbWF0Y2hlci4KIE1hdGNoZXMgaWYgdGhlcmUgaXMgYSBcIipcIiBhZnRlciBCT0wuIgpk
aWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9k
ZXMvYy10cy1tb2RlLmVsCmluZGV4IGNiMjM2NDQ3MzY4Li43NmNiYWQ1MGQwNiAxMDA2NDQK
LS0tIGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVz
L2MtdHMtbW9kZS5lbApAQCAtMzcxLDggKzM3MSwxMCBAQCBjLXRzLW1vZGUtLWluZGVudC1z
dHlsZXMKICAgICAgICAgICAgKChub2RlLWlzICJwcmVwcm9jX2FyZyIpIG5vLWluZGVudCkK
ICAgICAgICAgICAgOzsgYGMtdHMtY29tbW9uLWxvb2tpbmctYXQtc3RhcicgaGFzIHRvIGNv
bWUgYmVmb3JlCiAgICAgICAgICAgIDs7IGBjLXRzLWNvbW1vbi1jb21tZW50LTJuZC1saW5l
LW1hdGNoZXInLgotICAgICAgICAgICAoKGFuZCAocGFyZW50LWlzICJjb21tZW50IikgYy10
cy1jb21tb24tbG9va2luZy1hdC1zdGFyKQorICAgICAgICAgICAoKGFuZCAocGFyZW50LWlz
ICJjb21tZW50IikgYy10cy1jb21tb24tbG9va2luZy1hdCA/KikKICAgICAgICAgICAgIGMt
dHMtY29tbW9uLWNvbW1lbnQtc3RhcnQtYWZ0ZXItZmlyc3Qtc3RhciAtMSkKKyAgICAgICAg
ICAgKChhbmQgKHBhcmVudC1pcyAiY29tbWVudCIpIChjLXRzLWNvbW1vbi1sb29raW5nLWF0
ID98ID9cXCA/YCkpCisgICAgICAgICAgICBjLXRzLWNvbW1vbi1jb21tZW50LXN0YXJ0LWFm
dGVyLWZpcnN0LXN0YXIgLTIpCiAgICAgICAgICAgIChjLXRzLWNvbW1vbi1jb21tZW50LTJu
ZC1saW5lLW1hdGNoZXIKICAgICAgICAgICAgIGMtdHMtY29tbW9uLWNvbW1lbnQtMm5kLWxp
bmUtYW5jaG9yCiAgICAgICAgICAgICAxKQotLSAKMi40Mi4wCgo=

--------------MWqV9IU0X9E49Vv5q3TdQEoA--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 29 Sep 2023 07:19:02 +0000
Resent-Message-ID: <handler.66152.B66152.16959719014871 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>, Yuan Fu <casouri@HIDDEN>
Cc: 66152 <at> debbugs.gnu.org
Date: Fri, 29 Sep 2023 10:17:29 +0300
Message-Id: <83edih1m9i.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> (btuin@HIDDEN)
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Tue, 26 Sep 2023 14:29:07 +0200
> From: Augustin Chéneau (BTuin) <btuin@HIDDEN>
> 
> I found some more issues.
> 
> First, there is no rule for an element in an else clause:
> 
> 
> if (true)
>    do_something();
> else
> do_something_else();
> 
> 
> "do_something_else" is not indented.
> 
> There is also something weird with the bsd indent style.  It indents 
> do_something and do_something_else to parent-bol with 0 offset, so the 
> result is:
> 
> if (true)
> do_something();
> else
> do_something_else();
> 
> 
> It is very different from the bsd style from c-mode, which produces this:
> 
> if (true)
> 	do_something();
> else
> 	do_something_else();
> 
> By looking at random files from OpenBSD, they do indent their 
> expressions inside if and else:
> 
> <https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/net/bsd-comp.c?rev=1.17&content-type=text/plain>
> (lines 277, 484, and 527)
> 
> 
> 
> Also there is a second patch which tries to handle specific types of 
> comments.  I don't know how popular it is, but some people use these 
> kind of comments:
> 
> /*---------.
> | %param.  |
> `---------*/
> 
> Here we want the vertical bar ("|") to be indented at the same column as 
> the first "/".
> 
> Currently the result is this:
> 
> /*---------.
>    | %param.  |
>    `---------*/
> 
> This patch is a just proof of concept.  If this new behavior is indeed 
> wanted, I would clean it up and adapt other modes.

Yuan, any comments?  If the first patch looks good to you, I'd like to
install it on the release branch.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 30 Sep 2023 23:26:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 30 19:26:09 2023
Received: from localhost ([127.0.0.1]:60004 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qmjLc-0000u1-Sn
	for submit <at> debbugs.gnu.org; Sat, 30 Sep 2023 19:26:09 -0400
Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:53757)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qmjLb-0000t3-3y
 for control <at> debbugs.gnu.org; Sat, 30 Sep 2023 19:26:07 -0400
Received: by mail-lj1-x235.google.com with SMTP id
 38308e7fff4ca-2c16757987fso158254921fa.3
 for <control <at> debbugs.gnu.org>; Sat, 30 Sep 2023 16:25:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1696116345; x=1696721145; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=2pPU03pTEWKO2E33mHBqtdWQIYsPPc1EiWZDCEj68As=;
 b=lDYNl76Fmhbfqc3HWrOEP7Wz8gRKYxG6FFBdMrXo8+GaTmrIEOoltLAdyU64Jr6uVN
 sdfnjB7RCBwQWE17H21VH6pRlTSt+n6PQQSGDYMlZavQTI6cVkkNGoCKt8pRosc3xkk9
 Ponr46px7JwlP5qGUZWWa2hD/OcK7q9JWDjHgFogBvzIUraRHs5xA8H+Q7PaIQENpKUb
 RRZLvyLCG9QWc6UfvRG5oIuCkKLfh78macl2Anf+ETccU4oB1AbfibPZNAGZQj+weFJM
 +jzkdQ+Z24YjnRdLAFhUXue/o8RHRKRArl1FbXmOvNGKNM5FveFNHrzJOu7tvCYRuUVK
 h2CQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1696116345; x=1696721145;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=2pPU03pTEWKO2E33mHBqtdWQIYsPPc1EiWZDCEj68As=;
 b=EQ+K3LPrU7eHaKKfkGL2u31d272+jezeKatuVVbJ5hLrU/Je8UJKTN7DjXOOU5CQ5X
 9gW3zawNMfO/o771S6cZT0J5x41r+NbmybnuDpWVQVFNYq7YcOPGiLomRhBuMEUo4YQk
 7PdfDw9dogqB2oxHefYEZvPz5hQVL0wPStVNKmN2ZocdBDWkNRE44LMW8ESjh9fSXAzo
 pDYGway3Uxes2lcxdruz6kwfzuyvCMXRp0CGY12i4KLumLCZZJtSDQuDhTnZlFKw5t8t
 A8T+hnrzOLJJA0o0xxIEB5KSuf/BLARpUn89RXgG6CKFI1NwswiBsvfCHSgtLC71Tq0y
 c9EQ==
X-Gm-Message-State: AOJu0YydrPULxD5hNk6sNA/Yl6FqUIdzGPahLwP+5AJ/tyYqF4Dpmfrv
 +TOMPATtNSa3Ph1k5DlyrP5Dx4uJPJ8bSDUKa3GTcNm7
X-Google-Smtp-Source: AGHT+IE/G/+dhH/CTcmS1Po3uIf9USaqq86V0tjbYOvKUVMewlFFGP9gnuhfJ+WHc7N5HIes1LAxyLtl+TJ12wPSwvk=
X-Received: by 2002:a2e:8187:0:b0:2bf:ff17:811b with SMTP id
 e7-20020a2e8187000000b002bfff17811bmr6708514ljg.3.1696116345461; Sat, 30 Sep
 2023 16:25:45 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 30 Sep 2023 16:25:45 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sat, 30 Sep 2023 16:25:45 -0700
Message-ID: <CADwFkm=dmgwUrj09EHsvr=8-8Qi_0HHmkO-OAt051Ua+vgUizQ@HIDDEN>
Subject: control message for bug #66152
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 66152 + patch
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 05 Oct 2023 07:18:02 +0000
Resent-Message-ID: <handler.66152.B66152.169649023818816 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: casouri@HIDDEN
Cc: btuin@HIDDEN, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.169649023818816
          (code B ref 66152); Thu, 05 Oct 2023 07:18:02 +0000
Received: (at 66152) by debbugs.gnu.org; 5 Oct 2023 07:17:18 +0000
Received: from localhost ([127.0.0.1]:45892 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qoIbi-0004tL-5l
	for submit <at> debbugs.gnu.org; Thu, 05 Oct 2023 03:17:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:58774)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qoIbf-0004t0-Hz
 for 66152 <at> debbugs.gnu.org; Thu, 05 Oct 2023 03:17:12 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qoIbF-0003pJ-Tj; Thu, 05 Oct 2023 03:16:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=bUItr4yT+X7kule3whuY0YqZH0CGbhJAhc7ggvSp8Og=; b=rEYzO3hEPhzZtfPpVsUe
 o2DbW2BaPBG0AwpVuCc2T/fysmrfXBrI5elbyRm6wvb9jU1hV5Ig4JxM02mglw14O+OoqJY5FZIvh
 lnUMa0c87O5kE46x6wKfFXx5iPKfQJO/6s3mFR/FCedku4XTrwBmUmJTi7HfFi2LLjdvwqHo1QLVD
 LGnhjXYViXA17kfCe6qXPUYqriMs0s12IO8lYbjMbCuMQoKfybste7Ivl4g+dxjHx5IY16hwll8Gr
 +SlN4omAXDN1TKERSo3E/x59BG6hiFIiYWBg4N2VHy5zfoUVieV3zJ0wWfAbZUTfrBxEKt7LTNr7C
 Fm7yfRakS1ZN8w==;
Date: Thu, 05 Oct 2023 10:16:45 +0300
Message-Id: <83lech4jz6.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <83edih1m9i.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 29
 Sep 2023 10:17:29 +0300)
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping!  Yuan, I would really like to use the first patch in Emacs 29.2,
if it looks OK to you.

> Cc: 66152 <at> debbugs.gnu.org
> Date: Fri, 29 Sep 2023 10:17:29 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Tue, 26 Sep 2023 14:29:07 +0200
> > From: Augustin Chéneau (BTuin) <btuin@HIDDEN>
> > 
> > I found some more issues.
> > 
> > First, there is no rule for an element in an else clause:
> > 
> > 
> > if (true)
> >    do_something();
> > else
> > do_something_else();
> > 
> > 
> > "do_something_else" is not indented.
> > 
> > There is also something weird with the bsd indent style.  It indents 
> > do_something and do_something_else to parent-bol with 0 offset, so the 
> > result is:
> > 
> > if (true)
> > do_something();
> > else
> > do_something_else();
> > 
> > 
> > It is very different from the bsd style from c-mode, which produces this:
> > 
> > if (true)
> > 	do_something();
> > else
> > 	do_something_else();
> > 
> > By looking at random files from OpenBSD, they do indent their 
> > expressions inside if and else:
> > 
> > <https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/net/bsd-comp.c?rev=1.17&content-type=text/plain>
> > (lines 277, 484, and 527)
> > 
> > 
> > 
> > Also there is a second patch which tries to handle specific types of 
> > comments.  I don't know how popular it is, but some people use these 
> > kind of comments:
> > 
> > /*---------.
> > | %param.  |
> > `---------*/
> > 
> > Here we want the vertical bar ("|") to be indented at the same column as 
> > the first "/".
> > 
> > Currently the result is this:
> > 
> > /*---------.
> >    | %param.  |
> >    `---------*/
> > 
> > This patch is a just proof of concept.  If this new behavior is indeed 
> > wanted, I would clean it up and adapt other modes.
> 
> Yuan, any comments?  If the first patch looks good to you, I'd like to
> install it on the release branch.
> 
> 
> 
>

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 11 Dec 2023 02:18:02 +0000
Resent-Message-ID: <handler.66152.B66152.170226103622414 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: btuin@HIDDEN, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170226103622414
          (code B ref 66152); Mon, 11 Dec 2023 02:18:02 +0000
Received: (at 66152) by debbugs.gnu.org; 11 Dec 2023 02:17:16 +0000
Received: from localhost ([127.0.0.1]:52178 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rCVr9-0005pQ-QR
	for submit <at> debbugs.gnu.org; Sun, 10 Dec 2023 21:17:16 -0500
Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:59452)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <casouri@HIDDEN>) id 1rCVr5-0005pA-HQ
 for 66152 <at> debbugs.gnu.org; Sun, 10 Dec 2023 21:17:14 -0500
Received: by mail-pl1-x631.google.com with SMTP id
 d9443c01a7336-1d0a7b72203so34755735ad.2
 for <66152 <at> debbugs.gnu.org>; Sun, 10 Dec 2023 18:16:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1702261011; x=1702865811; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=L9aESXp/61PCEV2f6+HB6U1GD0djeTrcJBizKtwmuj0=;
 b=Y38Y/MgPF0F2hBu/IOlzoVpd/ddg+NeRFOe+Ms8XEtxbAxbFeAUrH1TgU8YNhBkf8j
 JYvADkKOB6br6ijs7fEuqFWTXpK48n3yc8cCoASZjRlXgDIrkakaxnhXP83nJpPQM/lI
 zmkDN7e2rJ/IAjEmVUVInakFi1M+mAKLlohvoTbEo5FMoDz6EQE/+U//EPsA3sntVesq
 0hFShsqxEjA8yLLj/kjR+a3TsAUIrNpDShGuswunZCw2oqlNNW7Vojyvx/KgQDow52qB
 VyLFVUTnxWmxVYATXwQmDo9LILGkxJIX6nc45yspJ1UOFHTZqeQU+qe5HDj6N/ipssYh
 i67w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1702261011; x=1702865811;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=L9aESXp/61PCEV2f6+HB6U1GD0djeTrcJBizKtwmuj0=;
 b=qr14venjsF5/qRggMRDo9XbzjIXbiiOe8i2weQgBy2WnLoiWGV9pWU+wsCvDxGuhpZ
 1ldQtuqB/PwLDtlMR1YyiQBWkhOl+kmI+MCDOOkiJsDM9/OcHRUb1gnY4fSeYOjj3Xt5
 2bGYDDc0D0f+U/F0qOCZQfofdSqZsFHoVTY4v/dw5Zu0Na3J/g17WDF6tKw6cw31lDde
 JEJBAfcovS5uY4eC9tLaeVBKEvG8lrjMBRB7dUaSMLb7TR8wf5y9lyXTUjSdfQPwbS7x
 kBqtE8RdtQeRISlVQWxJRdhGaVCzDoIqz5gu1SGJmv43ZqbZ3rktOh2O31qkl4gVknh8
 TqHQ==
X-Gm-Message-State: AOJu0Yw0HhTfBZtr4ci5BC4AZNlsYpTy62uYXyQuX7YWV6a6NNxbWIWP
 PaI2Ty6oUym+udrAnO3JLp4=
X-Google-Smtp-Source: AGHT+IGEmrQPU3V4omAvyicAJr4OBIodCHwD37tFEt+05KwCi9TEaX7IWPeTMqzf2GWm7sZA0u6oTQ==
X-Received: by 2002:a17:902:c950:b0:1d0:6ffe:a09 with SMTP id
 i16-20020a170902c95000b001d06ffe0a09mr4589852pla.103.1702261011078; 
 Sun, 10 Dec 2023 18:16:51 -0800 (PST)
Received: from [192.168.1.7] (172-117-161-177.res.spectrum.com.
 [172.117.161.177]) by smtp.gmail.com with ESMTPSA id
 c3-20020a170902d90300b001d1db5e39a6sm5386612plz.59.2023.12.10.18.16.50
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 10 Dec 2023 18:16:50 -0800 (PST)
Message-ID: <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
Date: Sun, 10 Dec 2023 18:16:49 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN>
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <83lech4jz6.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)



On 10/5/23 12:16 AM, Eli Zaretskii wrote:
> Ping!  Yuan, I would really like to use the first patch in Emacs 29.2,
> if it looks OK to you.
>
>> Cc: 66152 <at> debbugs.gnu.org
>> Date: Fri, 29 Sep 2023 10:17:29 +0300
>> From: Eli Zaretskii <eliz@HIDDEN>
>>
>>> Date: Tue, 26 Sep 2023 14:29:07 +0200
>>> From: Augustin Chéneau (BTuin) <btuin@HIDDEN>
>>>
>>> I found some more issues.
>>>
>>> First, there is no rule for an element in an else clause:
>>>
>>>
>>> if (true)
>>>     do_something();
>>> else
>>> do_something_else();
>>>
>>>
>>> "do_something_else" is not indented.
>>>
>>> There is also something weird with the bsd indent style.  It indents
>>> do_something and do_something_else to parent-bol with 0 offset, so the
>>> result is:
>>>
>>> if (true)
>>> do_something();
>>> else
>>> do_something_else();
>>>
>>>
>>> It is very different from the bsd style from c-mode, which produces this:
>>>
>>> if (true)
>>> 	do_something();
>>> else
>>> 	do_something_else();
>>>
>>> By looking at random files from OpenBSD, they do indent their
>>> expressions inside if and else:
>>>
>>> <https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/net/bsd-comp.c?rev=1.17&content-type=text/plain>
>>> (lines 277, 484, and 527)
>>>
>>>
>>>
>>> Also there is a second patch which tries to handle specific types of
>>> comments.  I don't know how popular it is, but some people use these
>>> kind of comments:
>>>
>>> /*---------.
>>> | %param.  |
>>> `---------*/
>>>
>>> Here we want the vertical bar ("|") to be indented at the same column as
>>> the first "/".
>>>
>>> Currently the result is this:
>>>
>>> /*---------.
>>>     | %param.  |
>>>     `---------*/
>>>
>>> This patch is a just proof of concept.  If this new behavior is indeed
>>> wanted, I would clean it up and adapt other modes.
>> Yuan, any comments?  If the first patch looks good to you, I'd like to
>> install it on the release branch.
LGTM, I applied the first patch to emacs-29.

Yuan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 11 Dec 2023 02:43:02 +0000
Resent-Message-ID: <handler.66152.B66152.170226252424845 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170226252424845
          (code B ref 66152); Mon, 11 Dec 2023 02:43:02 +0000
Received: (at 66152) by debbugs.gnu.org; 11 Dec 2023 02:42:04 +0000
Received: from localhost ([127.0.0.1]:52183 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rCWF7-0006SL-D1
	for submit <at> debbugs.gnu.org; Sun, 10 Dec 2023 21:42:04 -0500
Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:44177)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <casouri@HIDDEN>) id 1rCWF3-0006Rz-16
 for 66152 <at> debbugs.gnu.org; Sun, 10 Dec 2023 21:42:00 -0500
Received: by mail-oi1-x233.google.com with SMTP id
 5614622812f47-3b88f2a37deso3189785b6e.0
 for <66152 <at> debbugs.gnu.org>; Sun, 10 Dec 2023 18:41:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1702262497; x=1702867297; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=a8OVCKas6c4qmLW7Lhia4bAVY1/dinoddjOsT3sGP4A=;
 b=NhJW9d+MyC0pSjXDNekU4XsY/BkslnCjYxEgSbTIPw5zgbHm2XeWtaM/iQNlfMbRwn
 vzhPF/q5TxjahqhsT9rFkrfZRimu6MxQCeuGInQ7kIE5s1eBXorSfuiw1VcL2hCawtXT
 gGAbw1X7YppL+LIN9vj/6tyo4eYUd2NXOSZRrVmqnaDfMGZOw6skWcNEJhq/LecRbbmm
 2KrzFnTtowWCL1aUg/RwrJEX0JbYYPYDF+44GqXTT6UndzX1NDIyRQna7cdwIzoYjtgo
 dvJTuWegpUEOkClInc+4GghCr4WSqRlA0mIXOfVt7u7P0jnqJMzBNeSNTa7Sg2zDTioz
 b5fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1702262497; x=1702867297;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=a8OVCKas6c4qmLW7Lhia4bAVY1/dinoddjOsT3sGP4A=;
 b=GOjQ/A6sMGoXkQduR+yc/gCbXLdfmRF24A6dILAxCosBfX3jH954iJBBtEAnrHUxQJ
 UCGe1ex44tUpQvqYIrKfBXf+k8CAHoBwELsEQwi1qe3ixNBg8mkDRn92Cw5F0E3BjxWx
 GmU5IH1x1qEfjX1wxAq5Ooj+FreFyHWPpexcAE11JFP+HjhB8LwwTGhmBqk84MjE5auC
 mTokkBMW1DklcAahxkcRKTCJcS21MFhFT12w9KWfYh1NZZ4l5MdmSHw2uFLJgM843AdN
 ZP1jb+cqE2+R0KIaOoYWsjjt3MnB4q30I0wm6KWOxNElTGzFdMA41MrtBe2/OPSqk/h9
 3tQA==
X-Gm-Message-State: AOJu0Yyshmh5qkZPEAhbJY8qH5EdweDwNBsV1iD69TKWS81VI1bF/LF8
 HYskh99WK+fk7hPbw5TZOoQ=
X-Google-Smtp-Source: AGHT+IFAkeXP4wRjtyM9vsOKibEfkYqX6ei799hHqyaxSlFoIrmjwV4Td/+oCub2X3fPoOY1qJf6Ow==
X-Received: by 2002:a05:6808:1401:b0:3b8:b063:5053 with SMTP id
 w1-20020a056808140100b003b8b0635053mr5037139oiv.84.1702262496816; 
 Sun, 10 Dec 2023 18:41:36 -0800 (PST)
Received: from [192.168.1.7] (172-117-161-177.res.spectrum.com.
 [172.117.161.177]) by smtp.gmail.com with ESMTPSA id
 n9-20020a056a000d4900b006ce7e75cfa7sm5146208pfv.57.2023.12.10.18.41.36
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 10 Dec 2023 18:41:36 -0800 (PST)
Message-ID: <3e14a8c3-6518-44f5-a32a-25ffcf438e23@HIDDEN>
Date: Sun, 10 Dec 2023 18:41:35 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN>
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)



On 9/26/23 5:29 AM, Augustin Chéneau (BTuin) wrote:
> I found some more issues.
>
> First, there is no rule for an element in an else clause:
>
>
> if (true)
>   do_something();
> else
> do_something_else();
>
>
> "do_something_else" is not indented.

Right. tree-sitter-c recently changed their grammar and added 
else_clause. The fix for this is pushed to emacs-29 a few days ago.

>
> There is also something weird with the bsd indent style.  It indents 
> do_something and do_something_else to parent-bol with 0 offset, so the 
> result is:
>
> if (true)
> do_something();
> else
> do_something_else();
>
>
> It is very different from the bsd style from c-mode, which produces this:
>
> if (true)
>     do_something();
> else
>     do_something_else();
>
> By looking at random files from OpenBSD, they do indent their 
> expressions inside if and else:
>
> <https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/net/bsd-comp.c?rev=1.17&content-type=text/plain> 
>
> (lines 277, 484, and 527)
>
Thanks for reporting this, probably not a lot of people use c-ts-mode 
with bsd style, and things like this goes under the radar. I pushed a 
fix for it.

>
> Also there is a second patch which tries to handle specific types of 
> comments.  I don't know how popular it is, but some people use these 
> kind of comments:
>
> /*---------.
> | %param.  |
> `---------*/
>
> Here we want the vertical bar ("|") to be indented at the same column 
> as the first "/".
>
> Currently the result is this:
>
> /*---------.
>   | %param.  |
>   `---------*/
>
> This patch is a just proof of concept.  If this new behavior is indeed 
> wanted, I would clean it up and adapt other modes.

The gallery of artisan C comments is just endless :-) If we can support 
this style, it's definitely good, the only thing to watch out for is 
that the rules could unintentionally match some other comments that 
aren't really this style. Like, does people do this:

/*
  |
  |
  |
  */

in the wild? I don't know, maybe we need a embedded gpt-4 for formatting 
comments.

Yuan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Jan 2024 21:32:02 +0000
Resent-Message-ID: <handler.66152.B66152.170492230425504 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Yuan Fu <casouri@HIDDEN>
Cc: btuin@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170492230425504
          (code B ref 66152); Wed, 10 Jan 2024 21:32:02 +0000
Received: (at 66152) by debbugs.gnu.org; 10 Jan 2024 21:31:44 +0000
Received: from localhost ([127.0.0.1]:43345 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNgAq-0006dI-D8
	for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 16:31:44 -0500
Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:52500)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rNgAo-0006YZ-HB
 for 66152 <at> debbugs.gnu.org; Wed, 10 Jan 2024 16:31:42 -0500
Received: by mail-ed1-x532.google.com with SMTP id
 4fb4d7f45d1cf-5578485fc0eso3680468a12.1
 for <66152 <at> debbugs.gnu.org>; Wed, 10 Jan 2024 13:31:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1704922298; x=1705527098; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=K2RG/5tD4nQ9LaBm406t3jqQwqN334rJkGOJhA9c95c=;
 b=jXfLRX3XDXqlU6u5or13vCVRB97aZGivUi7FIpWIVJHXMRGF2OHeOiQ7K3x7sX224S
 86WIKbW0q157WN51mftLg5r4oUKbhOlc/aUkge7yb7ubp2DxigPpa4cKw04xK9/2JOB9
 A9fprzPUR7AoZdxl+5BDrzilfYds2SnAszAeS1rCbusS9BsSs5W6zbbfXdvYNGo6L+MO
 1kaKH4s0cOIjU7QlZKdyFSd+fEu2grUR0kNa+PxDNF/mqfxQ3BHiFBGjDmAxwMwXIUCS
 pkJi2Wg40et10b1JuzaFbz0FKYBlAMRush7fR3pahOlb5Xv+8TIDKNrC+x3voM5xU3bW
 9EXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1704922298; x=1705527098;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=K2RG/5tD4nQ9LaBm406t3jqQwqN334rJkGOJhA9c95c=;
 b=UbKwCQiAlVXMzfAiMs4AiriJyVbm7tlbHrgZ2AOQri3rwA6tbW5l7aBMXpZyBM2btd
 oLVsg4qWLS/KEoqmcQIiWyKo4UOPPK4KZiqQc5xJLk58F2ejZGU9AFy0yMo9n2Gbzad3
 BkefAWh9A3QfZCEktzbC99/weqGLiPDW++3eKDHljDkX0ejTStJ6tEei5/1mXdgwjBhv
 2kAJPKxRdqx/cmmPAdNMVqutUs2PFj4v32PwX0Krdkn/0XAqeHOrm5WQevRHCyXnHL26
 X3fPhieZMoZqzu3UYa1eD/b18pYlx5Ju/ITY/dRv6FPg1HSw06jyn3l7W2mmVzpVbUzu
 0rVw==
X-Gm-Message-State: AOJu0YzuLAnMX2i1qoDbaDHnHFfJC+pi8s51RY/4euwj2sfo+bW3/ptN
 b9Y7miWwlulSlmtS/c59nxVJk3rOe1d5r0bKBFk=
X-Google-Smtp-Source: AGHT+IH9ry1ECZ/XJK2KGcnggPFJnMssGE4AhTLV3guDMSvHg4tifT6oou5My2MId/FxHs8TSdOCUsnIs/U4gfZNO1I=
X-Received: by 2002:aa7:c6d5:0:b0:558:76da:b974 with SMTP id
 b21-20020aa7c6d5000000b0055876dab974mr51101eds.27.1704922297859; Wed, 10 Jan
 2024 13:31:37 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 10 Jan 2024 13:31:37 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN> (Yuan Fu's
 message of "Sun, 10 Dec 2023 18:16:49 -0800")
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
MIME-Version: 1.0
Date: Wed, 10 Jan 2024 13:31:37 -0800
Message-ID: <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Yuan Fu <casouri@HIDDEN> writes:

> LGTM, I applied the first patch to emacs-29.

What about patch 2 and 3?  Should they be installed on master?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 11 Jan 2024 07:06:02 +0000
Resent-Message-ID: <handler.66152.B66152.170495670712800 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: btuin@HIDDEN, casouri@HIDDEN, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170495670712800
          (code B ref 66152); Thu, 11 Jan 2024 07:06:02 +0000
Received: (at 66152) by debbugs.gnu.org; 11 Jan 2024 07:05:07 +0000
Received: from localhost ([127.0.0.1]:58550 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNp7i-0003KJ-IT
	for submit <at> debbugs.gnu.org; Thu, 11 Jan 2024 02:05:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53428)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rNp7f-0003JJ-FG
 for 66152 <at> debbugs.gnu.org; Thu, 11 Jan 2024 02:05:04 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rNoV3-00073y-Kv; Thu, 11 Jan 2024 01:25:09 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=qQPkeHnJvPZmhhquUHE2qo2Yks3sMonOigsD6OSnXqQ=; b=YgvXgIuDH9L8
 gpMu1MqNtFWfnZM5DZk1JIy2ujQlGN+6heWUBA9tJPaoqQsJKNUZdjlrSiSt0eWLjRde6sLyLbcff
 b2tmJyZ3AWqpuMJtY9p+1n4ezdm0CAzvpRynwLkbSPcsyGthQufpHb3DOb+gSvVb+O3BEGqO3LlpZ
 bfNwDcGfSprvVXl6FnebtAjIjcMW1udrK2rahp//AHNKYbflKHDpGp1p8ynwdiuvHYui3VYlX7xyi
 TdgTYd5/YrCY4VJlSTpHWlMhCMbK2Gq8lIbiUEKgo9vfV2h7uIhSQADWlr5hNDrs92YtQhtHiXe8z
 XNRRNtJ1ldFHTMJkBaisHg==;
Date: Thu, 11 Jan 2024 08:24:43 +0200
Message-Id: <83edeomlp0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
 (message from Stefan Kangas on Wed, 10 Jan 2024 13:31:37 -0800)
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
 <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Wed, 10 Jan 2024 13:31:37 -0800
> Cc: Eli Zaretskii <eliz@HIDDEN>, btuin@HIDDEN, 66152 <at> debbugs.gnu.org
> 
> Yuan Fu <casouri@HIDDEN> writes:
> 
> > LGTM, I applied the first patch to emacs-29.
> 
> What about patch 2 and 3?  Should they be installed on master?

Not sure.  It sounded like they were experimental, and no consensus
was reached.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Jan 2024 20:39:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 11 15:39:05 2024
Received: from localhost ([127.0.0.1]:34029 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rO1pQ-0002gd-Sm
	for submit <at> debbugs.gnu.org; Thu, 11 Jan 2024 15:39:05 -0500
Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:56501)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rO1pM-0002g7-KW
 for control <at> debbugs.gnu.org; Thu, 11 Jan 2024 15:39:03 -0500
Received: by mail-lj1-x229.google.com with SMTP id
 38308e7fff4ca-2cd0c17e42bso65177251fa.0
 for <control <at> debbugs.gnu.org>; Thu, 11 Jan 2024 12:39:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1705005537; x=1705610337; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=ZXezR3D9qTnkwCyGnIdLDZWTJ36U9Pi1b4hn/xZOwbE=;
 b=iZm6CYVtn1kCkGApZ7/gtmysGdDkdCrvRrN3Cnfr7D8zTMCjuICgYVbH1THyiWDPO3
 NEfz0d8SozzF0M3L0afKgw5rHFSrxDHWzbV4BoV0IJWpGVixg1ezGutADwCjiYmpDArS
 rekY4Rq+JqYIMU1yxBzAuSfmY4OfMdKyL2yAHqfsJ9r2MLtDC8ikH2D0malQZpcBG2DO
 qeOpFglMuEcVSq1ninZTUSW454AsxtazesOLs1Q7rOzJ4BKt4mD0EGeQjK8m+mmPY2C8
 jRvF8RcFxHYfY3uICt33sINAhT+R8iq0NTg56Xn43rHW2CAUPuJkkmvF1r1zse1JrE05
 DOWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705005537; x=1705610337;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=ZXezR3D9qTnkwCyGnIdLDZWTJ36U9Pi1b4hn/xZOwbE=;
 b=fP4uBxCI2/X/12+fym0S2QVVPvjHjbGPYVL7iftT1YLX5kW+qBByhQsu9mYBeqS25A
 YtHGu2bU/2vqBd1OzlzpJavuLC8hKI/hvCop6zcd4MzqhaqOxNGWszyxXNI+v25LjqJ2
 W8UqYzmx9uk33C4u7BmmXZIfmL4WzlTrp+LdXwgU+e4X73sZhLnvfFs8qrPxjT46cGJu
 yML2E06eT8Q3wZeEppT0mN6iwH976BHizZ6x+3aEqlQIsUROmx02CXKcuTEfZ5sBoWo9
 FObTkO5ue346fbX7/iL3y8bWH41v54kkXjTaprkZ2iu2mO+6YRSeCFZBN+Fiw4hO6qya
 /HWg==
X-Gm-Message-State: AOJu0YzA/xxlheUt3WwS5No/s5hLCLaLqDwO3W0ARenSKDLTvqq4VM53
 CDaQfeOQ5yF4Lo0kkOCykmAN8kFtftLgLq1vsKu76dC6gSs=
X-Google-Smtp-Source: AGHT+IHBqn4P8OlDV3odN+EcQJSEm4M6g1LA7wPzevbG/wAX6C9VxgJfy3HUpKKTOP8M9fIY5nTBy1I4mwbRQ4qLglg=
X-Received: by 2002:a05:651c:1550:b0:2cd:f97:3fa1 with SMTP id
 y16-20020a05651c155000b002cd0f973fa1mr208238ljp.19.1705005536928; Thu, 11 Jan
 2024 12:38:56 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 11 Jan 2024 12:38:56 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Thu, 11 Jan 2024 12:38:56 -0800
Message-ID: <CADwFkm=QvQPfP_u9B=Ebig3Nfb6YxxcFfoBz5HxDxTb9J5GAQg@HIDDEN>
Subject: 
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  tags 66152 + moreinfo thanks 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (stefankangas[at]gmail.com)
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2a00:1450:4864:20:0:0:0:229 listed in]
 [list.dnswl.org]
 2.0 BLANK_SUBJECT          Subject is present but empty
 0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
 lines -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

tags 66152 + moreinfo
thanks

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 Jan 2024 07:08:02 +0000
Resent-Message-ID: <handler.66152.B66152.170512967110393 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch moreinfo
To: Eli Zaretskii <eliz@HIDDEN>
Cc: btuin@HIDDEN, 66152 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170512967110393
          (code B ref 66152); Sat, 13 Jan 2024 07:08:02 +0000
Received: (at 66152) by debbugs.gnu.org; 13 Jan 2024 07:07:51 +0000
Received: from localhost ([127.0.0.1]:38240 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOY7T-0002hY-58
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 02:07:51 -0500
Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:54725)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <casouri@HIDDEN>) id 1rOY7O-0002hH-MP
 for 66152 <at> debbugs.gnu.org; Sat, 13 Jan 2024 02:07:50 -0500
Received: by mail-pl1-x629.google.com with SMTP id
 d9443c01a7336-1d4a980fdedso64723505ad.1
 for <66152 <at> debbugs.gnu.org>; Fri, 12 Jan 2024 23:07:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1705129662; x=1705734462; darn=debbugs.gnu.org;
 h=to:references:message-id:content-transfer-encoding:cc:date
 :in-reply-to:from:subject:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=DyCwavZX8LxT6RHKRmaEo6ikg+tTsbySlNYg/uyNLEI=;
 b=KO4cKmO2esikTNe+c/xnko1wTVH+tuF3IaF9t6NaTz5Apr5bzY3NWf9S9RehF1+awa
 ck1XU3nLbM+u11hdQLTHsfK1ENq6qtXzi9ikWogk1T8xA59B3k+QpWV3qnfEjSEUmouW
 tm1NezO0hd9nrWOGn21e6TgsP/jU1bnHoSTLTS+A4uBXKkej0MM6VLEqLS4sqYFhHoIK
 mP6bdYfBPZrkaXoR7akF+MFJ1AjOKcdF3lXcc3HjzSe7yK6OLNpNOUQ4cPA10ORme3nO
 FFI2vmrp0EJcjoAxXlPDZn/r98kSLtAQ0zj87XBhyW3AVjx1hEfQOAf5oAbWQA/D7DpT
 mb/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705129662; x=1705734462;
 h=to:references:message-id:content-transfer-encoding:cc:date
 :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=DyCwavZX8LxT6RHKRmaEo6ikg+tTsbySlNYg/uyNLEI=;
 b=DidDiO0xEAW8aVw/05bq0HH0rK9snQE+K7rv0S9aXWz+7Oh9LYCGJQUDleYUJ7qgS3
 aQQmrq6/H0QYaqMZodqCbl7mh6rDrWX8vaAx7RQJNAZGlCYn0MYybQl6B8tasUzuEGzj
 rr5EM9b0ekr1gVX++0qVlIbLcJhdmWdneGMGYbWGvqXUys93ZH1pjSG5tK24wHAAL5bX
 fvS1CsRenUZfjX7NgOd/97TxJhEbk6TUJHopukWB4ciNsC0xOEzgVJ/86UKsFg1WTXe3
 nQnScDO9nldw8+AtAQnsei5pe53U+8oGMEMCwYvCwZGK4F+GpzN0H78S8VuVehy3nPg9
 OrHQ==
X-Gm-Message-State: AOJu0YzkL6nztHur/Rb21nB5ON3oXbOqzDPqMvigzmZSWG/p2RL/IkcV
 Fj+RqytCL8LqSyEU9KWrKXU=
X-Google-Smtp-Source: AGHT+IEliWXQ444Szgl8vlM3vkNhR5vu5hx+ArRylAJxX/bQKcReVLymE+7QG45JPNPHcHBz58R9ZQ==
X-Received: by 2002:a17:902:e844:b0:1d4:d0e8:f9c8 with SMTP id
 t4-20020a170902e84400b001d4d0e8f9c8mr2964227plg.37.1705129662057; 
 Fri, 12 Jan 2024 23:07:42 -0800 (PST)
Received: from smtpclient.apple (172-117-161-177.res.spectrum.com.
 [172.117.161.177]) by smtp.gmail.com with ESMTPSA id
 r9-20020a170903014900b001d3e5271459sm4298346plc.55.2024.01.12.23.07.41
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 12 Jan 2024 23:07:41 -0800 (PST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <83edeomlp0.fsf@HIDDEN>
Date: Fri, 12 Jan 2024 23:07:30 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <1E6C674F-E848-46A9-BD58-9396E872940B@HIDDEN>
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
 <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
 <83edeomlp0.fsf@HIDDEN>
X-Mailer: Apple Mail (2.3731.700.6)
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)



> On Jan 10, 2024, at 10:24 PM, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>> From: Stefan Kangas <stefankangas@HIDDEN>
>> Date: Wed, 10 Jan 2024 13:31:37 -0800
>> Cc: Eli Zaretskii <eliz@HIDDEN>, btuin@HIDDEN, =
66152 <at> debbugs.gnu.org
>>=20
>> Yuan Fu <casouri@HIDDEN> writes:
>>=20
>>> LGTM, I applied the first patch to emacs-29.
>>=20
>> What about patch 2 and 3?  Should they be installed on master?
>=20
> Not sure.  It sounded like they were experimental, and no consensus
> was reached.

I had a look again, the first patch is applied, the second patch is =
fixed in another report, the third patch is still in discussion. =
Augustin said he=E2=80=99ll clean it up and extend it to apply to other =
modes if it=E2=80=99s desirable. I think it=E2=80=99s good to have, we =
just need to make sure it doesn=E2=80=99t bring any regression. Also I =
don=E2=80=99t know how widely used is this kind of comments and how =
important it is.

Yuan=

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Jan 2024 05:34:01 +0000
Resent-Message-ID: <handler.66152.B66152.170521039311651 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch moreinfo
To: Yuan Fu <casouri@HIDDEN>
Cc: btuin@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170521039311651
          (code B ref 66152); Sun, 14 Jan 2024 05:34:01 +0000
Received: (at 66152) by debbugs.gnu.org; 14 Jan 2024 05:33:13 +0000
Received: from localhost ([127.0.0.1]:41518 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOt7R-00031r-4v
	for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 00:33:13 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:41987)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rOt7O-00031d-IW
 for 66152 <at> debbugs.gnu.org; Sun, 14 Jan 2024 00:33:10 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5534dcfdd61so13670913a12.0
 for <66152 <at> debbugs.gnu.org>; Sat, 13 Jan 2024 21:33:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1705210386; x=1705815186; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=pNhwrkIwC3e0qHDUM+S9Z7277QG475RnnAidOl8YhjU=;
 b=hF2MrzVt3oEoquV/Ms4BlZGngzyI76SNtXWw5xdeSW1BVh8kQjq+0CkceiFPkNn5Pc
 98W03OwWTa5ESiTXZs3146z4DZerbQ6HR8bgKR+BfrRZi5Bvm60HpsqO6sBs22ibHpxH
 HadyxZix4BSB63HnLlhhPQf4hRlkfn6ykzz0dlcfrepwUNNHmca0F++QfOiGIqvcRdPq
 k2tZPCKPzR5PS0hjyVAWHrLe5lv9mr6YrA5YMyBCb9xQjLQaXcibrjgcxbfHmQJ2y3H3
 iP7A6stUMyY1DEwOy1craNHAbt6j9TqcQWU+E6UrG+8iht7GVxOlMt2CmMyP1WRmIUjR
 lrkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705210386; x=1705815186;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=pNhwrkIwC3e0qHDUM+S9Z7277QG475RnnAidOl8YhjU=;
 b=PKSCfElzh6Jh1yzojVZl2v/4SsEJrobM5V8i/c6ow7epTNc31QMSOkb4aq+yDxGhJ7
 vzSppd2myC4jYM3ENOLylskLx/94BpMt2d0f8uszYexJiVl64iaDbWR9sKcLcwSNaLLq
 DihzJZxr/AhurnmmDLb5NYrE0zKDIeK/zmTdjjNGoukUOdNJihrlCL5HfyF6tvpXrC+G
 Riwrh52NoG3i5U1OA+Sq1/37EKlDLbWkW0ENqw6Uw5Yb1Lx5tAMEtYbaMPmOU8+38akz
 fmUhae4iI51EOXqF/wS3YsGtXTX6fOCemH6V8/cTAByZvoo0B/351sSFjWO2cEw/TjF1
 X52A==
X-Gm-Message-State: AOJu0Yyjo3m2ffumIm4F9kjy2DqPzL3WjIY2clTgd9s+dk5t7x7E5IUp
 4/Z/B0DZpd4Kpz8YX7wYMqp8VEyHh84VXlR60mw=
X-Google-Smtp-Source: AGHT+IHTbvbDa6PI7rUWRmtV0OIMIcJx9vx2/juVr5IghgB6lGexCnvpvVAjsq4KGuzBDy1t3D470z3qsga8IqZEqXg=
X-Received: by 2002:a05:6402:a43:b0:557:5568:4828 with SMTP id
 bt3-20020a0564020a4300b0055755684828mr4462695edb.10.1705210385846; Sat, 13
 Jan 2024 21:33:05 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 13 Jan 2024 23:33:05 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <1E6C674F-E848-46A9-BD58-9396E872940B@HIDDEN> (Yuan Fu's
 message of "Fri, 12 Jan 2024 23:07:30 -0800")
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
 <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
 <83edeomlp0.fsf@HIDDEN> <1E6C674F-E848-46A9-BD58-9396E872940B@HIDDEN>
MIME-Version: 1.0
Date: Sat, 13 Jan 2024 23:33:05 -0600
Message-ID: <CADwFkmmsfix1dxrMrqCB7XtRCnGvwtKvWChbMSgk3kFNHuAfjA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Yuan Fu <casouri@HIDDEN> writes:

> I had a look again, the first patch is applied, the second patch is fixed=
 in
> another report,

Thanks.

> the third patch is still in discussion. Augustin said he=E2=80=99ll
> clean it up and extend it to apply to other modes if it=E2=80=99s desirab=
le. I think
> it=E2=80=99s good to have, we just need to make sure it doesn=E2=80=99t b=
ring any
> regression. Also I don=E2=80=99t know how widely used is this kind of com=
ments and how
> important it is.

I guess it's for indenting this kind of comment?

    /*---------.
    | %param.  |
    `---------*/

I have no idea either.  Are there any significant projects that use it?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Jan 2024 07:11:01 +0000
Resent-Message-ID: <handler.66152.B66152.170521620520431 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch moreinfo
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: btuin@HIDDEN, casouri@HIDDEN, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170521620520431
          (code B ref 66152); Sun, 14 Jan 2024 07:11:01 +0000
Received: (at 66152) by debbugs.gnu.org; 14 Jan 2024 07:10:05 +0000
Received: from localhost ([127.0.0.1]:41575 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOudB-0005JS-61
	for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 02:10:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:43562)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rOud9-0005Iu-BH
 for 66152 <at> debbugs.gnu.org; Sun, 14 Jan 2024 02:10:03 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rOud4-0008SU-7r; Sun, 14 Jan 2024 02:09:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=77zTY0lV1FZL4h+aeutBCiV92qUDJf3bmpasMGDOldY=; b=fsfVkg4GabRluZwFZ8Rr
 n71pvVKpEPfyEhDdTxDtMZ2mLv4tvMlVCF9WYYeLRqrtZ2yoU9617Q9TMb1LeyMlrXdK9ocm/Dpvm
 yEkvDqqPdqNUjzw+i5q/fKs4Rh6zhxs+SmBEqPImpQOHyJY7oyMZt6ydywo5kvKDGkJSA/xPVXXZT
 UPPPwrmlp6lLXf5+3TIMX8ayCU1BCD8D6h4KbYxnNUsDdkRNMgima8DFa5vtv0CG8+ogXji45ql7U
 AbmqOtqL02F/J9r5GQ6WCi/G+q+uRWAm2RWSM9R+kInn7ZwSpakVj542hvMsMqQj555f+Vuk6q3FX
 kyFYH9H6WoBEhQ==;
Date: Sun, 14 Jan 2024 09:09:39 +0200
Message-Id: <83bk9ofl1o.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmmsfix1dxrMrqCB7XtRCnGvwtKvWChbMSgk3kFNHuAfjA@HIDDEN>
 (message from Stefan Kangas on Sat, 13 Jan 2024 23:33:05 -0600)
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
 <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
 <83edeomlp0.fsf@HIDDEN> <1E6C674F-E848-46A9-BD58-9396E872940B@HIDDEN>
 <CADwFkmmsfix1dxrMrqCB7XtRCnGvwtKvWChbMSgk3kFNHuAfjA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Sat, 13 Jan 2024 23:33:05 -0600
> Cc: Eli Zaretskii <eliz@HIDDEN>, btuin@HIDDEN, 66152 <at> debbugs.gnu.org
> 
> Yuan Fu <casouri@HIDDEN> writes:
> 
> > the third patch is still in discussion. Augustin said he’ll
> > clean it up and extend it to apply to other modes if it’s desirable. I think
> > it’s good to have, we just need to make sure it doesn’t bring any
> > regression. Also I don’t know how widely used is this kind of comments and how
> > important it is.
> 
> I guess it's for indenting this kind of comment?
> 
>     /*---------.
>     | %param.  |
>     `---------*/
> 
> I have no idea either.  Are there any significant projects that use it?

IMO, it would be nice to be able to support box comments.  I've seen
it in the wild enough to know that some people prefer this style.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Resent-From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Jan 2024 10:23:02 +0000
Resent-Message-ID: <handler.66152.B66152.170522772212068 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66152
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch moreinfo
To: Stefan Kangas <stefankangas@HIDDEN>, Yuan Fu <casouri@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 66152 <at> debbugs.gnu.org
Received: via spool by 66152-submit <at> debbugs.gnu.org id=B66152.170522772212068
          (code B ref 66152); Sun, 14 Jan 2024 10:23:02 +0000
Received: (at 66152) by debbugs.gnu.org; 14 Jan 2024 10:22:02 +0000
Received: from localhost ([127.0.0.1]:41745 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOxcw-00038U-0p
	for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 05:22:02 -0500
Received: from msg-2.mailo.com ([213.182.54.12]:50044 helo=mailo.com)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <btuin@HIDDEN>) id 1rOxcu-000388-4l
 for 66152 <at> debbugs.gnu.org; Sun, 14 Jan 2024 05:22:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo;
 t=1705227709; bh=YvWCHk5khEqQUKBrMgR15er1EmJKykMMutvCbATLl8w=;
 h=X-EA-Auth:Message-ID:Date:MIME-Version:Subject:To:Cc:References:
 From:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=gE32CQEPt2wWnTg7yRWAfgaxpr6d0vTU4ciD+2mbj/CrSzBhy/2GxdtjPQCgOwCAX
 LO4hWgAgryb0dvEsO1VNqZS4oHZCVZQFV4wUeJxe+TFu/4j0SOAY8DlTwQO5+ET9EY
 zSkKxaXDONoBNKtjLPTCEcBEYk73+5qKoc7FaQvs=
Received: by b221-5.in.mailobj.net [192.168.90.25] with ESMTP
 via ip-20.mailobj.net [213.182.54.20]
 Sun, 14 Jan 2024 11:21:49 +0100 (CET)
X-EA-Auth: ywil6Pqf3jSO4gTI2zC+kY4eszPDPF0FbngvyBlwY8v7PmVmVZqHOkc/dVVjqUedfUrrfSXR+d8pn98p9TEJNIXK5l3NUixy
Message-ID: <c9b8d71d-d769-44f5-9357-cdc8306208d6@HIDDEN>
Date: Sun, 14 Jan 2024 11:21:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <ef80f9da-f889-4b80-8c90-ff09464084af@HIDDEN>
 <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@HIDDEN> <83edih1m9i.fsf@HIDDEN>
 <83lech4jz6.fsf@HIDDEN> <e2a4d081-4fc5-42b5-83d1-04b2520a1b5e@HIDDEN>
 <CADwFkmm=PpdVtkxtXxkq_Om4f5--VUHkT-mWxiLMWmNXfALNjQ@HIDDEN>
 <83edeomlp0.fsf@HIDDEN> <1E6C674F-E848-46A9-BD58-9396E872940B@HIDDEN>
 <CADwFkmmsfix1dxrMrqCB7XtRCnGvwtKvWChbMSgk3kFNHuAfjA@HIDDEN>
Content-Language: fr, en-US
From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) <btuin@HIDDEN>
In-Reply-To: <CADwFkmmsfix1dxrMrqCB7XtRCnGvwtKvWChbMSgk3kFNHuAfjA@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 14/01/2024 à 06:33, Stefan Kangas a écrit :
> Yuan Fu <casouri@HIDDEN> writes:
> 
>> I had a look again, the first patch is applied, the second patch is fixed in
>> another report,
> 
> Thanks.
> 
>> the third patch is still in discussion. Augustin said he’ll
>> clean it up and extend it to apply to other modes if it’s desirable. I think
>> it’s good to have, we just need to make sure it doesn’t bring any
>> regression. Also I don’t know how widely used is this kind of comments and how
>> important it is.
> 
> I guess it's for indenting this kind of comment?
> 
>      /*---------.
>      | %param.  |
>      `---------*/
> 
> I have no idea either.  Are there any significant projects that use it?


Yes, it is for indenting these kind of comments.

It depends on your definition of "significant", but GNU Bison sometimes 
uses it (example: 
<https://git.savannah.gnu.org/cgit/bison.git/tree/src/getargs.c#n171>).
However I don't know if it is more widely used, if some convention exist 
or if pretty much everyone has his own style.

It could be more annoying than helpful if it messes with your personal 
style, though.

In any case I won't be able to contribute for a while, as I recently 
moved to a new company. They never did copyright assignment and they are 
quite fussy (understandably) on copyright issues.

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.