GNU bug report logs - #66167
29.1; wrap-prefix text property with :align-to space keyword broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66167 in the body.
You can then email your comments to 66167 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <hello <at> paulwrankin.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1; wrap-prefix text property with :align-to space keyword broken
Date: Sat, 23 Sep 2023 18:04:27 +1000

Description:

The wrap-prefix text property with :align-to space keyword has been 
broken. (Regression).

To reproduce:

1. emacs -Q
2. in *scratch*, ensure visual-line-mode is enabled
3. insert enough text to wrap lines
4. M-: (put-text-property (point-min) (point-max) 'wrap-prefix '(space 
:align-to 10))

Expected results:

Wrapped text should align to column 10.

Actual result:

Wrapped text does not align. (No effect.)

Message #8 received at 66167 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <hello <at> paulwrankin.com>
Cc: 66167 <at> debbugs.gnu.org
Subject: Re: bug#66167: 29.1;
 wrap-prefix text property with :align-to space keyword broken
Date: Sat, 23 Sep 2023 11:41:29 +0300

tags 66167 notabug wontfix
thanks

> Date: Sat, 23 Sep 2023 18:04:27 +1000
> From:  "Paul W. Rankin" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Description:
> 
> The wrap-prefix text property with :align-to space keyword has been 
> broken. (Regression).
> 
> To reproduce:
> 
> 1. emacs -Q
> 2. in *scratch*, ensure visual-line-mode is enabled
> 3. insert enough text to wrap lines
> 4. M-: (put-text-property (point-min) (point-max) 'wrap-prefix '(space 
> :align-to 10))
> 
> Expected results:
> 
> Wrapped text should align to column 10.
> 
> Actual result:
> 
> Wrapped text does not align. (No effect.)

This is not a bug.  The argument of :align-to specifies a column
number, and the column number does not get reset when the line wraps
or the window is hscrolled.  IOW, the column number is measured from
the beginning of the physical line, not from the beginning of the
screen line.

The previous code handled this incorrectly and inconsistently, and was
fixed in Emacs 29 (or was it 28?).

Message #13 received at 66167 <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <hello <at> paulwrankin.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66167 <at> debbugs.gnu.org
Subject: Re: bug#66167: 29.1; wrap-prefix text property with :align-to space
 keyword broken
Date: Sat, 23 Sep 2023 19:24:25 +1000

On 2023-09-23 18:41, Eli Zaretskii wrote:
> tags 66167 notabug wontfix
> thanks
> 
>> Date: Sat, 23 Sep 2023 18:04:27 +1000
>> From:  "Paul W. Rankin" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Description:
>> 
>> The wrap-prefix text property with :align-to space keyword has been
>> broken. (Regression).
>> 
>> To reproduce:
>> 
>> 1. emacs -Q
>> 2. in *scratch*, ensure visual-line-mode is enabled
>> 3. insert enough text to wrap lines
>> 4. M-: (put-text-property (point-min) (point-max) 'wrap-prefix '(space
>> :align-to 10))
>> 
>> Expected results:
>> 
>> Wrapped text should align to column 10.
>> 
>> Actual result:
>> 
>> Wrapped text does not align. (No effect.)
> 
> This is not a bug.  The argument of :align-to specifies a column
> number, and the column number does not get reset when the line wraps
> or the window is hscrolled.  IOW, the column number is measured from
> the beginning of the physical line, not from the beginning of the
> screen line.
> 
> The previous code handled this incorrectly and inconsistently, and was
> fixed in Emacs 29 (or was it 28?).

You're suggesting that the wrap-prefix should not be applied to wrapped 
lines..??

Message #16 received at 66167 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <hello <at> paulwrankin.com>
Cc: 66167 <at> debbugs.gnu.org
Subject: Re: bug#66167: 29.1; wrap-prefix text property with :align-to space
 keyword broken
Date: Sat, 23 Sep 2023 12:38:34 +0300

> Date: Sat, 23 Sep 2023 19:24:25 +1000
> From: "Paul W. Rankin" <hello <at> paulwrankin.com>
> Cc: 66167 <at> debbugs.gnu.org
> 
> On 2023-09-23 18:41, Eli Zaretskii wrote:
> >> 1. emacs -Q
> >> 2. in *scratch*, ensure visual-line-mode is enabled
> >> 3. insert enough text to wrap lines
> >> 4. M-: (put-text-property (point-min) (point-max) 'wrap-prefix '(space
> >> :align-to 10))
> >> 
> >> Expected results:
> >> 
> >> Wrapped text should align to column 10.
> >> 
> >> Actual result:
> >> 
> >> Wrapped text does not align. (No effect.)
> > 
> > This is not a bug.  The argument of :align-to specifies a column
> > number, and the column number does not get reset when the line wraps
> > or the window is hscrolled.  IOW, the column number is measured from
> > the beginning of the physical line, not from the beginning of the
> > screen line.
> > 
> > The previous code handled this incorrectly and inconsistently, and was
> > fixed in Emacs 29 (or was it 28?).
> 
> You're suggesting that the wrap-prefix should not be applied to wrapped 
> lines..??

It _is_ applied.  Try giving wrap-prefix a value that is a string, and
you will see that it is applied.

The problem is not with wrap-prefix, the problem is with the
(space :align-to 10) form, and specifically with the value 10.
The value 10 is too small for wrapped lines (in most cases).

Message #21 received at 66167 <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <hello <at> paulwrankin.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66167 <at> debbugs.gnu.org
Subject: Re: bug#66167: 29.1; wrap-prefix text property with :align-to space
 keyword broken
Date: Sun, 24 Sep 2023 14:56:02 +1000

On 2023-09-23 19:38, Eli Zaretskii wrote:
> It _is_ applied.  Try giving wrap-prefix a value that is a string, and
> you will see that it is applied.
> 
> The problem is not with wrap-prefix, the problem is with the
> (space :align-to 10) form, and specifically with the value 10.
> The value 10 is too small for wrapped lines (in most cases).

I see now what it means. Sorry, my mistake. And what I want can be 
achieved with (space :width 10). Thanks.

Message #26 received at 66167-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <hello <at> paulwrankin.com>
Cc: 66167-done <at> debbugs.gnu.org
Subject: Re: bug#66167: 29.1; wrap-prefix text property with :align-to space
 keyword broken
Date: Sun, 24 Sep 2023 08:36:45 +0300

> Date: Sun, 24 Sep 2023 14:56:02 +1000
> From: "Paul W. Rankin" <hello <at> paulwrankin.com>
> Cc: 66167 <at> debbugs.gnu.org
> 
> On 2023-09-23 19:38, Eli Zaretskii wrote:
> > It _is_ applied.  Try giving wrap-prefix a value that is a string, and
> > you will see that it is applied.
> > 
> > The problem is not with wrap-prefix, the problem is with the
> > (space :align-to 10) form, and specifically with the value 10.
> > The value 10 is too small for wrapped lines (in most cases).
> 
> I see now what it means. Sorry, my mistake. And what I want can be 
> achieved with (space :width 10). Thanks.

Yes, '(space :width 10)' is exactly what you want, AFAIU.

So I'm now closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.