Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 12:51:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 13 08:51:26 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OYexK-00028l-A3
for submit <at> debbugs.gnu.org; Tue, 13 Jul 2010 08:51:26 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <dann@HIDDEN>) id 1OYexI-00028e-UG
for 6617 <at> debbugs.gnu.org; Tue, 13 Jul 2010 08:51:25 -0400
Received: from dann by fencepost.gnu.org with local (Exim 4.69)
(envelope-from <dann@HIDDEN>)
id 1OYexO-0007dl-99; Tue, 13 Jul 2010 08:51:30 -0400
To: Dimitrios Apostolou <jimis@HIDDEN>
Subject: Re: bug#6617: linux kernel C style (fwd)
References: <alpine.LNX.2.00.1007121306420.1500@HIDDEN>
<yxq4og3pxx6.fsf@HIDDEN>
<alpine.LNX.2.00.1007131202090.1500@HIDDEN>
From: Dan Nicolaescu <dann@HIDDEN>
X-Debbugs-No-Ack: yes
Date: Tue, 13 Jul 2010 08:51:30 -0400
In-Reply-To: <alpine.LNX.2.00.1007131202090.1500@HIDDEN>
(Dimitrios Apostolou's message of "Tue\,
13 Jul 2010 12\:17\:38 +0300 \(EEST\)")
Message-ID: <yxqzkxvo88d.fsf@HIDDEN>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -6.5 (------)
X-Debbugs-Envelope-To: 6617
Cc: 6617 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.5 (------)
Dimitrios Apostolou <jimis@HIDDEN> writes:
> On Tue, 13 Jul 2010, Dan Nicolaescu wrote:
>> Dimitrios Apostolou <jimis@HIDDEN> writes:
>>
>>> Hi, I sent the following to help-gnu-emacs and got no reply, maybe
>>> this list is more relevant.
>>>
>>> ---------- Forwarded message ----------
>>> Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST)
>>> From: Dimitrios Apostolou <jimis@HIDDEN>
>>> To: help-gnu-emacs@HIDDEN
>>> Subject: linux kernel C style
>>>
>>> Hello list,
>>>
>>> is the "linux" c-style supposed to be compliant to the linux kernel
>>> style guidelines? I just realised that all this time emacs was
>>> indenting my code slightly wrong, specifically the use of spaces is
>>> forbidden, even when continuing the argument list of a function.
>>
>> Is that really the case? Is this requirement documented anywhere?
>
> In the file Documentation/CodingStyle search for "emacs". Warning: the
> language is a bit toxic for emacs devs/users.
There's code there that seems to do what you stated, but there seems
to be no text that actually describes that...
> There is also another point which is not clear but says the following:
>
> Statements longer than 80 columns will be broken into sensible
> chunks. Descendants are always substantially shorter than the parent
> and are placed substantially to the right. The same applies to
> function headers with a long argument list. Long strings are as well
> broken into shorter strings. The only exception to this is where
> exceeding 80 columns significantly increases readability and does not
> hide information.
>
>
> It is then followed by an example which is is indented only with tabs.
>
>
>> Looking at a random file in the linux-2.6.34.1 kernel:
>> kernel/sched.c one can see:
>>
>> static void update_group_shares_cpu(struct task_group *tg, int cpu,
>> unsigned long sd_shares,
>> unsigned long sd_rq_weight,
>> unsigned long *usd_rq_weight)
>> {
>> [snip]
>>
>> The arguments starting from sd_shares are indented using a few tabs
>> followed by a few spaces.
>> The above is not the only occurrence, there are many others in the same file.
>
> My guess is that those are inconsistencies caused by the current
> "linux" style in emacs, but perhaps this should be posted to LKML to
> verify.
Please do that and report the conclusion here.
>> Another point: to enforce the use of the correct style, a file called
>> .dir-locals.el should be placed at the top level of the kernel tree
>> with the following [completely untested] contents:
>>
>> ((c-mode . ((c-file-style . "linux")
>> (tab-width . 8)
>> (indent-tabs-mode . t))))
>>
>> With this users of emacs-23+ will get the correct settings for editing
>> the kernel by default.
>>
>>
>
>
>
> Thanks,
> Dimitris
owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:bug#6617; Package emacs,cc-mode.
Full text available.
Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 10:17:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 13 06:17:19 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OYcYA-0000OC-Fb
for submit <at> debbugs.gnu.org; Tue, 13 Jul 2010 06:17:19 -0400
Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net)
by debbugs.gnu.org with smtp (Exim 4.69)
(envelope-from <jimis@HIDDEN>) id 1OYbaU-0008Os-K0
for 6617 <at> debbugs.gnu.org; Tue, 13 Jul 2010 05:15:39 -0400
Received: (qmail invoked by alias); 13 Jul 2010 09:15:42 -0000
Received: from unknown (EHLO thanos-desktop.ics.forth.gr) [139.91.92.11]
by mail.gmx.net (mp007) with SMTP; 13 Jul 2010 11:15:42 +0200
X-Authenticated: #4463548
X-Provags-ID: V01U2FsdGVkX1+qlhMNNbyqkvDCSYnJ5UxGG/PblKOgo4Dlvt5qBS
QnQJzar6IDuSUf
Date: Tue, 13 Jul 2010 12:17:38 +0300 (EEST)
From: Dimitrios Apostolou <jimis@HIDDEN>
X-X-Sender: jimis@HIDDEN
To: Dan Nicolaescu <dann@HIDDEN>
Subject: Re: bug#6617: linux kernel C style (fwd)
In-Reply-To: <yxq4og3pxx6.fsf@HIDDEN>
Message-ID: <alpine.LNX.2.00.1007131202090.1500@HIDDEN>
References: <alpine.LNX.2.00.1007121306420.1500@HIDDEN>
<yxq4og3pxx6.fsf@HIDDEN>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Y-GMX-Trusted: 0
X-Spam-Score: -3.6 (---)
X-Debbugs-Envelope-To: 6617
X-Mailman-Approved-At: Tue, 13 Jul 2010 06:17:17 -0400
Cc: 6617 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.3 (---)
On Tue, 13 Jul 2010, Dan Nicolaescu wrote:
> Dimitrios Apostolou <jimis@HIDDEN> writes:
>
>> Hi, I sent the following to help-gnu-emacs and got no reply, maybe
>> this list is more relevant.
>>
>> ---------- Forwarded message ----------
>> Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST)
>> From: Dimitrios Apostolou <jimis@HIDDEN>
>> To: help-gnu-emacs@HIDDEN
>> Subject: linux kernel C style
>>
>> Hello list,
>>
>> is the "linux" c-style supposed to be compliant to the linux kernel
>> style guidelines? I just realised that all this time emacs was
>> indenting my code slightly wrong, specifically the use of spaces is
>> forbidden, even when continuing the argument list of a function.
>
> Is that really the case? Is this requirement documented anywhere?
In the file Documentation/CodingStyle search for "emacs". Warning: the
language is a bit toxic for emacs devs/users.
There is also another point which is not clear but says the following:
Statements longer than 80 columns will be broken into sensible chunks.
Descendants are always substantially shorter than the parent and are
placed substantially to the right. The same applies to function headers
with a long argument list. Long strings are as well broken into shorter
strings. The only exception to this is where exceeding 80 columns
significantly increases readability and does not hide information.
It is then followed by an example which is is indented only with tabs.
> Looking at a random file in the linux-2.6.34.1 kernel: kernel/sched.c
> one can see:
>
> static void update_group_shares_cpu(struct task_group *tg, int cpu,
> unsigned long sd_shares,
> unsigned long sd_rq_weight,
> unsigned long *usd_rq_weight)
> {
> [snip]
>
> The arguments starting from sd_shares are indented using a few tabs
> followed by a few spaces.
> The above is not the only occurrence, there are many others in the same file.
My guess is that those are inconsistencies caused by the current "linux"
style in emacs, but perhaps this should be posted to LKML to verify.
>
>
> Another point: to enforce the use of the correct style, a file called
> .dir-locals.el should be placed at the top level of the kernel tree
> with the following [completely untested] contents:
>
> ((c-mode . ((c-file-style . "linux")
> (tab-width . 8)
> (indent-tabs-mode . t))))
>
> With this users of emacs-23+ will get the correct settings for editing
> the kernel by default.
>
>
Thanks,
Dimitris
owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:bug#6617; Package emacs,cc-mode.
Full text available.
Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 08:51:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 13 04:51:15 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OYbCs-0008Dx-Sk
for submit <at> debbugs.gnu.org; Tue, 13 Jul 2010 04:51:15 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <dann@HIDDEN>) id 1OYbCq-0008Ds-Nw
for 6617 <at> debbugs.gnu.org; Tue, 13 Jul 2010 04:51:13 -0400
Received: from dann by fencepost.gnu.org with local (Exim 4.69)
(envelope-from <dann@HIDDEN>)
id 1OYbCv-0004nK-Hh; Tue, 13 Jul 2010 04:51:17 -0400
To: Dimitrios Apostolou <jimis@HIDDEN>
Subject: Re: bug#6617: linux kernel C style (fwd)
References: <alpine.LNX.2.00.1007121306420.1500@HIDDEN>
From: Dan Nicolaescu <dann@HIDDEN>
X-Debbugs-No-Ack: yes
Date: Tue, 13 Jul 2010 04:51:17 -0400
In-Reply-To: <alpine.LNX.2.00.1007121306420.1500@HIDDEN>
(Dimitrios Apostolou's message of "Mon\,
12 Jul 2010 13\:08\:42 +0300 \(EEST\)")
Message-ID: <yxq4og3pxx6.fsf@HIDDEN>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -6.5 (------)
X-Debbugs-Envelope-To: 6617
Cc: 6617 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.5 (------)
Dimitrios Apostolou <jimis@HIDDEN> writes:
> Hi, I sent the following to help-gnu-emacs and got no reply, maybe
> this list is more relevant.
>
> ---------- Forwarded message ----------
> Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST)
> From: Dimitrios Apostolou <jimis@HIDDEN>
> To: help-gnu-emacs@HIDDEN
> Subject: linux kernel C style
>
> Hello list,
>
> is the "linux" c-style supposed to be compliant to the linux kernel
> style guidelines? I just realised that all this time emacs was
> indenting my code slightly wrong, specifically the use of spaces is
> forbidden, even when continuing the argument list of a function.
Is that really the case? Is this requirement documented anywhere?
Looking at a random file in the linux-2.6.34.1 kernel: kernel/sched.c
one can see:
static void update_group_shares_cpu(struct task_group *tg, int cpu,
unsigned long sd_shares,
unsigned long sd_rq_weight,
unsigned long *usd_rq_weight)
{
[snip]
The arguments starting from sd_shares are indented using a few tabs
followed by a few spaces.
The above is not the only occurrence, there are many others in the same file.
Another point: to enforce the use of the correct style, a file called
.dir-locals.el should be placed at the top level of the kernel tree
with the following [completely untested] contents:
((c-mode . ((c-file-style . "linux")
(tab-width . 8)
(indent-tabs-mode . t))))
With this users of emacs-23+ will get the correct settings for editing
the kernel by default.
owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:bug#6617; Package emacs,cc-mode.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Jul 2010 10:35:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 12 06:35:09 2010
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1OYGLs-0006YK-Sj
for submit <at> debbugs.gnu.org; Mon, 12 Jul 2010 06:35:09 -0400
Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <jimis@HIDDEN>) id 1OYFuk-0006Kx-22
for submit <at> debbugs.gnu.org; Mon, 12 Jul 2010 06:07:06 -0400
Received: from lists.gnu.org ([199.232.76.165]:54553)
by monty-python.gnu.org with esmtps
(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
(envelope-from <jimis@HIDDEN>) id 1OYFum-000326-Hm
for submit <at> debbugs.gnu.org; Mon, 12 Jul 2010 06:07:08 -0400
Received: from [140.186.70.92] (port=46025 helo=eggs.gnu.org)
by lists.gnu.org with esmtp (Exim 4.43) id 1OYFuh-0000e1-AV
for bug-gnu-emacs@HIDDEN; Mon, 12 Jul 2010 06:07:08 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL
autolearn=unavailable version=3.3.1
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
(envelope-from <jimis@HIDDEN>) id 1OYFuf-0001h0-Tz
for bug-gnu-emacs@HIDDEN; Mon, 12 Jul 2010 06:07:03 -0400
Received: from mail.gmx.net ([213.165.64.20]:60083)
by eggs.gnu.org with smtp (Exim 4.69) (envelope-from <jimis@HIDDEN>)
id 1OYFuf-0001gS-HA
for bug-gnu-emacs@HIDDEN; Mon, 12 Jul 2010 06:07:01 -0400
Received: (qmail invoked by alias); 12 Jul 2010 10:06:58 -0000
Received: from unknown (EHLO thanos-desktop.ics.forth.gr) [139.91.92.11]
by mail.gmx.net (mp041) with SMTP; 12 Jul 2010 12:06:58 +0200
X-Authenticated: #4463548
X-Provags-ID: V01U2FsdGVkX18xbTAziYsxtTPzL7fkkEo+r9QAgTaUlGkyVNR6vN
lYlYCZYDo2nAQE
Date: Mon, 12 Jul 2010 13:08:42 +0300 (EEST)
From: Dimitrios Apostolou <jimis@HIDDEN>
X-X-Sender: jimis@HIDDEN
To: bug-gnu-emacs@HIDDEN
Subject: linux kernel C style (fwd)
Message-ID: <alpine.LNX.2.00.1007121306420.1500@HIDDEN>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Y-GMX-Trusted: 0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6,
seldom 2.4 (older, 4)
X-Spam-Score: -3.3 (---)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Mon, 12 Jul 2010 06:35:06 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.6 (----)
Hi, I sent the following to help-gnu-emacs and got no reply, maybe this
list is more relevant.
---------- Forwarded message ----------
Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST)
From: Dimitrios Apostolou <jimis@HIDDEN>
To: help-gnu-emacs@HIDDEN
Subject: linux kernel C style
Hello list,
is the "linux" c-style supposed to be compliant to the linux kernel style
guidelines? I just realised that all this time emacs was indenting my code
slightly wrong, specifically the use of spaces is forbidden, even when
continuing the argument list of a function.
I use the following lines in my .emacs, taken from Documentation/CodingStyle of
the kernel tree. Perhaps they should be added to "linux" style?
(defun c-lineup-arglist-tabs-only (ignored)
"Line up argument lists by tabs, not spaces"
(let* ((anchor (c-langelem-pos c-syntactic-element))
(column (c-langelem-2nd-pos c-syntactic-element))
(offset (- (1+ column) anchor))
(steps (floor offset c-basic-offset)))
(* (max steps 1)
c-basic-offset)))
;; Add kernel style
(c-add-style
"linux-tabs-only"
'("linux" (c-offsets-alist
(arglist-cont-nonempty
c-lineup-gcc-asm-reg
c-lineup-arglist-tabs-only))))
(custom-set-variables
'(c-default-style "linux-tabs-only")
)
Thanks,
Dimitris
Dimitrios Apostolou <jimis@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:bug#6617; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.