GNU bug report logs - #66191
erc-ibuffer.el: suspicious use of hash-table-size

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66191 in the body.
You can then email your comments to 66191 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: "J.P." <jp <at> neverwas.me>
Subject: erc-ibuffer.el: suspicious use of hash-table-size
Date: Mon, 25 Sep 2023 11:45:16 +0200

In erc-ibuffer.el:

(define-ibuffer-column
 erc-members (:name "Users")
  (if (and (eq major-mode 'erc-mode)
	   (boundp 'erc-channel-users)
	   (hash-table-p erc-channel-users)
	   (> (hash-table-size erc-channel-users) 0))
     (number-to-string (hash-table-size erc-channel-users))
    ""))

Perhaps I'm mistaken but shouldn't hash-table-size be hash-table-count here?

Message #8 received at 66191 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 66191 <at> debbugs.gnu.org
Subject: Re: bug#66191: erc-ibuffer.el: suspicious use of hash-table-size
Date: Mon, 25 Sep 2023 08:02:41 -0700

[Message part 1 (text/plain, inline)]

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> In erc-ibuffer.el:
>
> (define-ibuffer-column
>  erc-members (:name "Users")
>   (if (and (eq major-mode 'erc-mode)
> 	   (boundp 'erc-channel-users)
> 	   (hash-table-p erc-channel-users)
> 	   (> (hash-table-size erc-channel-users) 0))
>      (number-to-string (hash-table-size erc-channel-users))
>     ""))
>
> Perhaps I'm mistaken but shouldn't hash-table-size be hash-table-count here?

Nice find! I've attached a patch that should fix the issue. If no one
says anything, I will add it or something similar in a few days. Thanks.

[0001-5.6-Fix-wrong-User-column-count-in-erc-ibuffer.patch (text/x-patch, attachment)]

Message #15 received at 66191-done <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 66191-done <at> debbugs.gnu.org
Cc: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 emacs-erc <at> gnu.org
Subject: Re: bug#66191: erc-ibuffer.el: suspicious use of hash-table-size
Date: Mon, 02 Oct 2023 18:20:21 -0700

"J.P." <jp <at> neverwas.me> writes:

> If no one says anything, I will add it or something similar in a few
> days.

I ended up only installing the bug fix portions, but I may open another
report for the feature parts eventually. Thanks and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.