GNU bug report logs - #66214
[PATCH] gnu: psautohint: Disable flaky tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66214 in the body.
You can then email your comments to 66214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH] gnu: psautohint: Disable flaky tests.
Date: Tue, 26 Sep 2023 23:08:44 +0800

* gnu/packages/fontutils.scm (psautohint)[#:test-flags]: Disable tests
test_hashmap_no_version and test_hashmap_old_version.
---
 gnu/packages/fontutils.scm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 18697cd821..c781ae2baf 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -789,9 +789,18 @@ (define-public psautohint
     (build-system pyproject-build-system)
     (arguments
      (list
-      ;; The CJKSparseVar.subset.hinted.otf test fails with slightly different
-      ;; output caused by the newer fonttools version used in Guix.
-      #:test-flags #~(list "-k" "not CJKSparseVar.subset.hinted.otf")
+      #:test-flags
+      #~(list "-k"
+              (string-join
+               '(;; The CJKSparseVar.subset.hinted.otf test fails with slightly
+                 ;; different output caused by the newer fonttools version used
+                 ;; in Guix.
+                 "not CJKSparseVar.subset.hinted.otf"
+                 ;; These tests fails underministically, See also:
+                 ;; https://github.com/adobe-type-tools/afdko/issues/1678
+                 "not test_hashmap_no_version"
+                 "not test_hashmap_old_version")
+               " and "))
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'copy-font-data

base-commit: b2887da40c6cb9d541a9df67aa726694f64d8943
-- 
2.41.0

Message #8 received at 66214 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 66214 <at> debbugs.gnu.org, Josselin Poiret <dev <at> jpoiret.xyz>
Subject: Re: [bug#66214] [PATCH] gnu: psautohint: Disable flaky tests.
Date: Fri, 29 Sep 2023 23:10:47 +0200

Ohai,

On 2023-09-26 17:08, Hilton Chain via Guix-patches via wrote:
> * gnu/packages/fontutils.scm (psautohint)[#:test-flags]: Disable tests
> test_hashmap_no_version and test_hashmap_old_version.

Pushed to master as b268842ec4808f5030f3bda95f52ff39dd88e3ad with a 
minor commit message tweak ([#:test-flags] → [arguments]).

Thanks,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.