GNU logs - #66342, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Thuna <thuna.cing@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 04 Oct 2023 14:20:02 +0000
Resent-Message-ID: <handler.66342.B.16964291469801 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66342 <at> debbugs.gnu.org
From: Thuna <thuna.cing@HIDDEN>
Date: Wed, 04 Oct 2023 16:18:20 +0200
Message-ID: <87leci1nf7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::431;
 envelope-from=thuna.cing@HIDDEN; helo=mail-wr1-x431.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain

Currently, cl-generic-current-method-specializers expands into an alist
of the form ((ARG . TYPE)...).  The patch I provide quotes this so that
it can serve as a proper sexp.

Without quoting, this expansion is a bad sexp that, when evaluated,
results in an error.  If quoted, the form will simply not macroexpand,
and any other method causes it to be evaluated after expanding.  As it
relies on the cl-defmethod's context, I see no obvious and/or convenient
ways to use macroexpand to get the result unevaluated.

A quick grep brought up no uses of this macro, so I feel that this
change shouldn't effect many people, if any at all, although feel free
to correct me if this is not the case.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Quote-cl-generic-current-method-specializers-inside-.patch
Content-Description: The patch

From a5b3065b8db59570cd98e8799c0ba0b0c46b9d6f Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing@HIDDEN>
Date: Sun, 1 Oct 2023 21:15:29 +0200
Subject: [PATCH] Quote cl-generic-current-method-specializers inside method
 body

* lisp/emacs-lisp/cl-generic.el (cl--generic-lambda): Quote spec-args
when using cl-generic-current-method-specializers inside a method
body.
---
 lisp/emacs-lisp/cl-generic.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index dec14bd5df6..a938195f097 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -393,7 +393,7 @@ cl-generic-define-context-rewriter
                   (cl--generic-split-args args))
                  (fun `(cl-function (lambda ,plain-args ,@body)))
                  (macroenv (cons `(cl-generic-current-method-specializers
-                                   . ,(lambda () spec-args))
+                                   . ,(lambda () (list 'quote spec-args)))
                                  macroexpand-all-environment)))
       (require 'cl-lib)        ;Needed to expand `cl-flet' and `cl-function'.
       (when (assq 'interactive body)
-- 
2.39.3


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Thuna <thuna.cing@HIDDEN>
Subject: bug#66342: Acknowledgement (Quote cl-generic-current-method-specializers)
Message-ID: <handler.66342.B.16964291469801.ack <at> debbugs.gnu.org>
References: <87leci1nf7.fsf@HIDDEN>
X-Gnu-PR-Message: ack 66342
X-Gnu-PR-Package: emacs
Reply-To: 66342 <at> debbugs.gnu.org
Date: Wed, 04 Oct 2023 14:20:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 66342 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66342: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66342
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 5 Oct 2023 21:53:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 05 17:53:31 2023
Received: from localhost ([127.0.0.1]:48816 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qoWHj-0003BF-B3
	for submit <at> debbugs.gnu.org; Thu, 05 Oct 2023 17:53:31 -0400
Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:50247)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qoWHg-0003Ax-DN
 for control <at> debbugs.gnu.org; Thu, 05 Oct 2023 17:53:30 -0400
Received: by mail-lj1-x236.google.com with SMTP id
 38308e7fff4ca-2c16bc71e4cso17336451fa.0
 for <control <at> debbugs.gnu.org>; Thu, 05 Oct 2023 14:53:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1696542784; x=1697147584; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=yUDLFClPcMdPQancfpoOON4BIM8nwmcfVBW9Z9Urepw=;
 b=UkDUWrH0SNP90uKjuiC0hHPOe8OgsKDVoGSI4qK+JUHB+qbu4gTNALNHEM9bYiLiHN
 itvBeoORc2osf2+zqOprlwwl1tr2AT9Y02OEMwFQ5F07OniwSiVlyfY+5B4Cpg6a0gaD
 4g5NMzUOMm6madXmRIORNeIanzgodYTdAU3JczblCQ4cvnSXkvQIKxEwBJE/2+xE3VSE
 pFwN48KqeYTffWNe9lLuBtTYALT400yOMNkAGPmMx8DXcZq6kUyUKp+xlo0aqmvUx2Hs
 twDt1J96//gfbwJzQ38odBs4PvRqMNnglc7pSgvyFlad/TPEsJp3OxqhvWwodJc9Z9L+
 2dfw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1696542784; x=1697147584;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=yUDLFClPcMdPQancfpoOON4BIM8nwmcfVBW9Z9Urepw=;
 b=wIGoxgdgezdu8/iz4kCoRdbumkoQVbS0n+PJb3IiUWXFWRre8LKZla+muA5jPtvU/5
 B0OzdOUZQ27r4DJ/KzXlyuyw5omELmDDDPz14TxTUvYHH368ciW/ooRDNEyaXtoFPms0
 Jpr4EEqbtVLgVsuWepGWZ0/dQav+P2jCiMmTXaVCB8EX40QDo9MwoloUwjtU9EyS/PJN
 tYr/NKlQRAeSAY+c3snZJ8lpj3AvJcQp+720qPGZiHnuG7dWEJx3godHucZ3ora4KlB7
 drAWVO0DjDw7nUJ3hT5DWGEx8yswsiPS5n9vX/N9Vj6rMvxcNfmGRPGzuZEd8jCS6xkn
 a48Q==
X-Gm-Message-State: AOJu0YzsCXGmXro7TjCgdeMOSs7xAiqZb/hl1nkPSxY9hxuBOj+FHGXG
 9LPrafWTr0r/KQQzPEe9g2t2q1rYUHQqaPnQep809szZ
X-Google-Smtp-Source: AGHT+IEpqm/PbiXajooXJee/Q7EPsbvDKbFOos9CsalLJLDyFh94FWupJ9TxaO6CZFTCR6lmtlfFV2eXnGYXH3vWs7U=
X-Received: by 2002:a2e:7d03:0:b0:2b9:f13b:6139 with SMTP id
 y3-20020a2e7d03000000b002b9f13b6139mr6287921ljc.20.1696542784051; Thu, 05 Oct
 2023 14:53:04 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 5 Oct 2023 21:53:03 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Thu, 5 Oct 2023 21:53:03 +0000
Message-ID: <CADwFkmkuLKpEQ1y6+QvkF2hPosC4wGq2+tDbUaG-DY8LbrWrnw@HIDDEN>
Subject: control message for bug #66342
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 66342 + patch
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Feb 2025 04:18:01 +0000
Resent-Message-ID: <handler.66342.B66342.173933385817836 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Thuna <thuna.cing@HIDDEN>
Cc: Stefan Monnier <monnier@HIDDEN>, 66342 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87leci1nf7.fsf@HIDDEN>
References: <87leci1nf7.fsf@HIDDEN>
MIME-Version: 1.0
Date: Tue, 11 Feb 2025 20:17:28 -0800
Message-ID: <CADwFkm=NVRU4kdKietBtJDX4Rwxh6tRu1c=zwgWccysN7KbO5g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Thuna <thuna.cing@HIDDEN> writes:

> Currently, cl-generic-current-method-specializers expands into an alist
> of the form ((ARG . TYPE)...).  The patch I provide quotes this so that
> it can serve as a proper sexp.
>
> Without quoting, this expansion is a bad sexp that, when evaluated,
> results in an error.  If quoted, the form will simply not macroexpand,
> and any other method causes it to be evaluated after expanding.  As it
> relies on the cl-defmethod's context, I see no obvious and/or convenient
> ways to use macroexpand to get the result unevaluated.
>
> A quick grep brought up no uses of this macro, so I feel that this
> change shouldn't effect many people, if any at all, although feel free
> to correct me if this is not the case.
>

Stefan M, could you please take a look at this patch?

>
> From a5b3065b8db59570cd98e8799c0ba0b0c46b9d6f Mon Sep 17 00:00:00 2001
> From: Thuna <thuna.cing@HIDDEN> Date: Sun, 1 Oct 2023 21:15:29
> +0200 Subject: [PATCH] Quote cl-generic-current-method-specializers
> inside method body
>
> * lisp/emacs-lisp/cl-generic.el (cl--generic-lambda): Quote spec-args
> when using cl-generic-current-method-specializers inside a method
> body.
> ---
>  lisp/emacs-lisp/cl-generic.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
> index dec14bd5df6..a938195f097 100644
> --- a/lisp/emacs-lisp/cl-generic.el
> +++ b/lisp/emacs-lisp/cl-generic.el
> @@ -393,7 +393,7 @@ cl-generic-define-context-rewriter
>                    (cl--generic-split-args args))
>                   (fun `(cl-function (lambda ,plain-args ,@body)))
>                   (macroenv (cons `(cl-generic-current-method-specializers
> -                                   . ,(lambda () spec-args))
> +                                   . ,(lambda () (list 'quote spec-args)))
>                                   macroexpand-all-environment)))
>        (require 'cl-lib)        ;Needed to expand `cl-flet' and `cl-function'.
>        (when (assq 'interactive body)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Feb 2025 22:17:01 +0000
Resent-Message-ID: <handler.66342.B66342.173957141325162 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66342
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Thuna <thuna.cing@HIDDEN>
Cc: 66342 <at> debbugs.gnu.org
Received: via spool by 66342-submit <at> debbugs.gnu.org id=B66342.173957141325162
          (code B ref 66342); Fri, 14 Feb 2025 22:17:01 +0000
Received: (at 66342) by debbugs.gnu.org; 14 Feb 2025 22:16:53 +0000
Received: from localhost ([127.0.0.1]:52143 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tj3zR-0006Xm-E0
	for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 17:16:53 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53940)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1tj3zN-0006XT-VQ
 for 66342 <at> debbugs.gnu.org; Fri, 14 Feb 2025 17:16:50 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F2AE580964;
 Fri, 14 Feb 2025 17:16:43 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1739571403;
 bh=002Hns07dalZ3w9QfBl9dbfFV4C0i0ywmeXjtXB3eQ8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=orPM1wjV8K0Jdx0LH5/Rg1Iww0SlMFok/TlubGkvcim+cUYqPQuOTOqz0NFR/0tGG
 xBCNCSgKUDxxDyJhunq0/FLOrqV6yk08tqQ5D4Ae7/Opib9Q3Jn/gVCIPyZMqco1qx
 kC9np8prUKlzu3siRbEEB9igvsUTAwbmOfW4jBCQmuJf0GOyOeAzCQHk7HURezZ5IQ
 zhHv+l7suK0qCz/0LtSL7WtnumY/GyVlVgV2famWDN0+zfKwPWvPsJgcM9EOjiDqD0
 cnqiOjr1KUdfZZWFxHKBrda6Qp0VY/uQ8J9ndYn+Jb6nCQqUdX/YmoLFUm6RBwFGUo
 Jp0ljlrLDQqfw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 33505801C2;
 Fri, 14 Feb 2025 17:16:43 -0500 (EST)
Received: from pastel (unknown [104.247.242.5])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D2224120317;
 Fri, 14 Feb 2025 17:16:42 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <87leci1nf7.fsf@HIDDEN> (Thuna's message of "Wed, 04 Oct 2023
 16:18:20 +0200")
Message-ID: <jwvv7tc5gei.fsf-monnier+emacs@HIDDEN>
References: <87leci1nf7.fsf@HIDDEN>
Date: Fri, 14 Feb 2025 17:16:40 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.275 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

> Currently, cl-generic-current-method-specializers expands into an alist
> of the form ((ARG . TYPE)...).  The patch I provide quotes this so that
> it can serve as a proper sexp.

Interesting.  Out of curiosity, where/how did you bump into this?

> Without quoting, this expansion is a bad sexp that, when evaluated,
> results in an error.

Indeed, it was never meant to be inserted as-is in the macro-expanded
code, instead the idea was that a macro could use

    (macroexpand '(cl-generic-current-method-specializers)
                 macroexpand-all-environment)

to collect type information about the variables to decide how to
generate its code.  This was not very well thought out (e.g. this typing
information may be invalid if the method mutates those vars) and AFAIK
it's never been used anywhere.

Maybe it's best to get rid of it?


        Stefan

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 23 Feb 2025 01:18:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 20:18:56 2025
Received: from localhost ([127.0.0.1]:58131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tm0e0-0007q2-1w
	for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 20:18:56 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:56394)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tm0dx-0007pj-Qq
 for control <at> debbugs.gnu.org; Sat, 22 Feb 2025 20:18:54 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5e02eba02e8so4474505a12.0
 for <control <at> debbugs.gnu.org>; Sat, 22 Feb 2025 17:18:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740273528; x=1740878328; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=U7brWVM2UMM9lsZcJIRHEGv1Fn3UBiIQekX7XYVeJFA=;
 b=ntNQYC4PbuK0kSrR4PfOzjyJ7MkOVYSEkdNkGUMyR1SA6/zfhBmu/TC7IUhxrf/4NR
 5s5x5FhdOviF/5MS2vcwyyC8UYqUK1HNJX577Ypk78l2IqSwkAahSCDEYmXOwKldNCZ/
 VJu3rLY6Uf80oF/RLwkr/s6SDMyx13poFz5Q+TZmLOiBhGAIN5yRqftOsDh/f0Kj41Lg
 MK5nPLKj75JasBYEPJ2qq/D39ROiDSKdW+LWzukHdCfipSBiJEQ4jp2rFVWtWXESih9t
 TuRMQ/TYE8JAdP/JY5bw8swXC6ocwNTHJxbmymBO9MVWGBNty79z9UCxAGtdtrDjCLdj
 d/EA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740273528; x=1740878328;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=U7brWVM2UMM9lsZcJIRHEGv1Fn3UBiIQekX7XYVeJFA=;
 b=f1UAp8h8fgO3uEDbbExniqnX/UhFq4u4JWxIy6SVDicmrYd8WMmPJRJ/FhZRfJdrhj
 713S2QQberuoSKItTdaDqt06dPQMqUw2ldFjdXX+ykzutiiJufoKf6HW8fHzZ1Bz/oVZ
 wKA5BDkpGJmV2UJp+tTJXeSjbvDC8Nz2ANEjAFwJYwpOuatAJuuTL67zvZtr5sTVIP3I
 RSVdgKIbVgOrwXfnsK4NEEjUzOKuaJlBd8RcoGIHygL2wm6O5H0XpVVzkeDRFyhNX4u4
 xAjzoVnRrDcPD+SiVkyr1s4FowJz16Bgab8uLx5SRUiAW6MWZSRKZ2NuTHaueZ2H+oCA
 bRig==
X-Gm-Message-State: AOJu0YzBb3E8VcTxyaq8/V+48Rl6OyXtAvk0kOkm4n+DEhWSPX14so6w
 pLKWFfsA9EUj3HW7r1mC4v7wno8KNP12700I/13+hJ+uWP3n/8O40ibR6ZLr9FsTcP0pOQ5VvgT
 ogq+XltoLEx/xbFkbRyVVcHmlx/5tiXai6TLjHw==
X-Gm-Gg: ASbGncsfP7HZnwCL5rBrcmt3wIz1pmP1hWJDSXeruv6h1WpRbFCWf/gofM3PxPQaoBu
 zdxCl5gRWJRFmJs0HLfV8RF2WE2xREqPEYk3GkW+ObeB/ehMDcnIUEnnKiAMfSA9R3a+yJ2/k6i
 SIYhHyYIXw
X-Google-Smtp-Source: AGHT+IFEuVr0gH6i8KUpcspUwdJzFmsjheWBgWug+KdIxbGwBGaPC/60U1qXXqEmLgnLf54Z8utU8vsZ714zFYTU69k=
X-Received: by 2002:a05:6402:4617:b0:5d9:f5c4:a227 with SMTP id
 4fb4d7f45d1cf-5e0b72276c7mr6697552a12.20.1740273527633; Sat, 22 Feb 2025
 17:18:47 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 23 Feb 2025 01:18:47 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sun, 23 Feb 2025 01:18:47 +0000
X-Gm-Features: AWEUYZmsDdqvohLjNDPiDtLRlnOfKEUzaNzkH8fuvo4liqMkbQenqNRhTurRg8c
Message-ID: <CADwFkm=GC3VF0fhN5ZGEc3Fv9GF2jsKOdDtZ8x_X2YSZfaxb5g@HIDDEN>
Subject: control message for bug #66342
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 66342 + moreinfo
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Mar 2025 03:42:01 +0000
Resent-Message-ID: <handler.66342.B66342.174088687914434 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66342
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: moreinfo patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: 66342 <at> debbugs.gnu.org, Thuna <thuna.cing@HIDDEN>
Received: via spool by 66342-submit <at> debbugs.gnu.org id=B66342.174088687914434
          (code B ref 66342); Sun, 02 Mar 2025 03:42:01 +0000
Received: (at 66342) by debbugs.gnu.org; 2 Mar 2025 03:41:19 +0000
Received: from localhost ([127.0.0.1]:49200 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toaCc-0003ka-4Q
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 22:41:18 -0500
Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:56402)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1toaCZ-0003jz-Mr
 for 66342 <at> debbugs.gnu.org; Sat, 01 Mar 2025 22:41:16 -0500
Received: by mail-ed1-x533.google.com with SMTP id
 4fb4d7f45d1cf-5e4d50ed90aso3235122a12.0
 for <66342 <at> debbugs.gnu.org>; Sat, 01 Mar 2025 19:41:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1740886869; x=1741491669; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=ARKHbElYAh8/3cHHIqWRrxmIWu7L514o6mCCQ5oVJmQ=;
 b=Kk9tnw+dBU6l3fOHUBK/QvtD5tSvNy2TZINfNZsqY5wjzCGVtE7d0GEWKCjgbMHmER
 6ovntPoovWfIUPFm9fJggAlUfG/EkR4V6ehtYo8aNVJGEK3JmpmKGuC720jvqHxK7J0G
 LneNFrD4yUEVPoO0oOtJRxeZe75Wh/8Qb5UXS7/LtKfJT+KL6x+vQEQQTWGkzYjPAtzJ
 RCleSUii0oPMHemqID6H2b3vUC3Iw4gCzZkuO6XvdBxn6oO6XinzsiHIR47V5ZL7FdeA
 P8Zqe6HUYiOjyARdlmduKNlS6C7X1+jQBaZ1Vy2kIpWpFojg2im6oVcou/D1nCE/g5dO
 CG4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1740886869; x=1741491669;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=ARKHbElYAh8/3cHHIqWRrxmIWu7L514o6mCCQ5oVJmQ=;
 b=L3pAs/wqOubYIaD/8q5lx3pOcgbu2g1Xt722xjmB5Xji2WX0IkuyMyv7ysbAowQwvI
 nuBZBO8lQ1e3t0LQUXfMyGchmg+Vwnpzotudvogbwm7rHj18DgmjJ0npiTtaJ6koYs5G
 NdCSXymLG2P846E8luBwZNMYuqLH3BJ8/o5s+3Hfx6wpbGxPtV2/s6yQZR8tZVzygY4U
 YLgi8FCSgyrEW8e/SYyaUcMe7MHbDDNQrFLMjR84AuP2QcUQntBbxurXQ4SfWiKNZ32m
 P5aLmSUOCMqPjAr7Z1CWlQZ9VjO4fJaZKGso8a8rpV+skfAZ6tZKOlOyP4Mss80WtLGl
 TMyw==
X-Forwarded-Encrypted: i=1;
 AJvYcCXPzR4NvMj5XJJIHTpr3P51P5ZgKT/fWkzJayY06EQ1oLIdYCoqtIFrGInCgCEnqNHPMyePeQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzpAMtVMofEuKMDP0NiZhBr6Qwooxtbd32t4vi1VdIIPCKW+WFZ
 qA4OjApv9CwbUXzCE+rvneIwABCgBIazJHwbDRhYvekKk62C8e59llDAhN/ISyYvy84MAstdN6j
 YkL5XrcWXp7SoYoaqRcxb6mvaBdufxIdb3+w=
X-Gm-Gg: ASbGnctmYWvrnu6ozZJBErn37R0ggIRzZJdllLSNwgKUj1kwPTqNRa9SwnbD6rjnX2I
 sViqDwjvFqT+NmhtuE9trgt7WG0TXJ0RfUJgsO1qGYSdUUCX2uwQEqhoEm0kED1Y9PJKM9YCpIP
 i+NCTioLfzloX1f0TTiNsIOgUCVQ==
X-Google-Smtp-Source: AGHT+IGWO7pD0brq7+H8i9rE4wmdDn56wl5aVeWVBW6NgwW+Tvwrtb4ubNIWA8w4hwkjxywz6yPmNqoBCL0Q8PKh7ZQ=
X-Received: by 2002:a05:6402:3482:b0:5e4:cfb0:f66b with SMTP id
 4fb4d7f45d1cf-5e4d6acd48fmr10875425a12.7.1740886869359; Sat, 01 Mar 2025
 19:41:09 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 1 Mar 2025 19:41:08 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <jwvv7tc5gei.fsf-monnier+emacs@HIDDEN>
References: <87leci1nf7.fsf@HIDDEN> <jwvv7tc5gei.fsf-monnier+emacs@HIDDEN>
MIME-Version: 1.0
Date: Sat, 1 Mar 2025 19:41:08 -0800
X-Gm-Features: AQ5f1JodQ5A8ABZxRGhe9EQapWsgG9r7gy-x5q2ie6vwbKA5v9qvZN4-L2ut4Qw
Message-ID: <CADwFkmkp1W14n8DAgQ=QCZQfctPfe9uNidjTshXUkyp4-s7GvQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

> Hi,
>
>> Currently, cl-generic-current-method-specializers expands into an alist
>> of the form ((ARG . TYPE)...).  The patch I provide quotes this so that
>> it can serve as a proper sexp.
>
> Interesting.  Out of curiosity, where/how did you bump into this?
>
>> Without quoting, this expansion is a bad sexp that, when evaluated,
>> results in an error.
>
> Indeed, it was never meant to be inserted as-is in the macro-expanded
> code, instead the idea was that a macro could use
>
>     (macroexpand '(cl-generic-current-method-specializers)
>                  macroexpand-all-environment)
>
> to collect type information about the variables to decide how to
> generate its code.  This was not very well thought out (e.g. this typing
> information may be invalid if the method mutates those vars) and AFAIK
> it's never been used anywhere.
>
> Maybe it's best to get rid of it?

If it's not useful, and anyways not used by anyone, I think it's better
to get rid of it.

Thuna, would you like to propose a patch that does that?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Thuna <thuna.cing@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Mar 2025 21:29:01 +0000
Resent-Message-ID: <handler.66342.B66342.17411237044693 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66342
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: moreinfo patch
To: Stefan Kangas <stefankangas@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Cc: 66342 <at> debbugs.gnu.org
Received: via spool by 66342-submit <at> debbugs.gnu.org id=B66342.17411237044693
          (code B ref 66342); Tue, 04 Mar 2025 21:29:01 +0000
Received: (at 66342) by debbugs.gnu.org; 4 Mar 2025 21:28:24 +0000
Received: from localhost ([127.0.0.1]:33237 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpZoO-0001Db-6S
	for submit <at> debbugs.gnu.org; Tue, 04 Mar 2025 16:28:24 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:45417)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <thuna.cing@HIDDEN>)
 id 1tpZoL-0001DF-Mj
 for 66342 <at> debbugs.gnu.org; Tue, 04 Mar 2025 16:28:22 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5dee07e51aaso11401335a12.3
 for <66342 <at> debbugs.gnu.org>; Tue, 04 Mar 2025 13:28:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741123695; x=1741728495; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=5x9GiOH2wQ/KJ+wfeXly0t+sSO4ZIwhWRlCWWVNw1b0=;
 b=ap7gMlBGo8jcbN3dHnHQu/pECjPZxSBLXsCzJ7lReQaG7rXHye+yf+aXBHmDxlZuot
 lQa3kW8dotoMSOFXILpVbv9B/IHztFpvKGGZ+1Z4TCqwAIbmrBvnyq+IpKR6BOJcQTpX
 bb4Dat8yx0+1EdemAXXQlUE2gKxPiIZeoerhaK0jzrS78I3wEUyKzwcMV6CFCepUJLKW
 LqBwxrvZNCr+9Exns/dOvqYNDbWlg+fQ8zYGSH7jMHu78ka/BIiPhqEvC61prmTvIgNw
 DnHb3TlyQ0HKp7zuwhwecPtNQJYE3NgsO28YYJayNG2VBozMjHcCwzJj74+Kw4YSPn6n
 1C4Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741123695; x=1741728495;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=5x9GiOH2wQ/KJ+wfeXly0t+sSO4ZIwhWRlCWWVNw1b0=;
 b=UKVsi/7vfZjnPARo4m4HUAq0Y3SNS0MRlZNyOUV1DN5UYDFdmYApPwT8TcjzzNVEo8
 VULFvLvUzXc1hvp1ba8XDedWEudlb3xHGhN1/4GpS9eGUuws0Weh2tBdMnqQcE/X6lE0
 WWmeS7LNHu9CJTVcOX4sRguzIGDy9Kv38HyiNL928VfyxgNKzMQn394YhmIYT3JnfW1P
 ud54mNX8HxgGWBNpoQ4xbXWuPfKQM7ofn+8TqnhPCFmE3Iuiq/4iGT8HxAp2e1T6e1m2
 l6Dk0pbHY/R4dcEOnhtqcaO03njNdru9mNSjU4EZoal7jCj05QmEaAabm242AFoofOcx
 dUIg==
X-Gm-Message-State: AOJu0Yyw3ZHecbOPlOLYuQqWuMnEV6i20Qd2ZXeEwu//Qz4VFpEvmlnA
 uxA8iCVClR4z3KQWGsSMArND8N+NvpTyKHphzNzQFre81pfxZX6pSSf95xZ1eUH4rg==
X-Gm-Gg: ASbGncsUW+ZNgjs00GySCmlCy8aSmW5wThu7CE7LumUglITg9JzFZKOrLH4igpu+qiR
 HvZs++hlq0WtLA/XeDnLvKDHAKJjVyw9UM8pVcLFW55f01N03hqiaag/sFnDl+ORLwfSQ2P5uzP
 qNEaMHr+wsI0wm9t23hxkETbzSjp7CTeRrTa5A0gq5fx3iUAFbqt0M5WcdfCffvrFVC8P2yalVX
 md2G9HHxPOuZLOSX1U3g+7qfG17VesubZeWSaW2lup1nhtkxx4bx488lpNQM1+26Oy8CMf/9PiF
 ntEQunnbHwcXqad+ULsqG3pb6VFhgs000+bUC8zjzbZ+
X-Google-Smtp-Source: AGHT+IF58Ik3QkM97MHchmvueKu9l2/kYJ6TJDlkb8a7wBbW8mZBCJkeGKmHlghC6JFPdpSnBHX3kw==
X-Received: by 2002:a05:6402:3784:b0:5db:e7eb:1b34 with SMTP id
 4fb4d7f45d1cf-5e59f3d67famr615746a12.13.1741123695219; 
 Tue, 04 Mar 2025 13:28:15 -0800 (PST)
Received: from thuna-lis3 ([178.249.211.77]) by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5e4c3b4af4dsm8695252a12.11.2025.03.04.13.28.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Mar 2025 13:28:13 -0800 (PST)
From: Thuna <thuna.cing@HIDDEN>
In-Reply-To: <CADwFkmkp1W14n8DAgQ=QCZQfctPfe9uNidjTshXUkyp4-s7GvQ@HIDDEN>
References: <87leci1nf7.fsf@HIDDEN> <jwvv7tc5gei.fsf-monnier+emacs@HIDDEN>
 <CADwFkmkp1W14n8DAgQ=QCZQfctPfe9uNidjTshXUkyp4-s7GvQ@HIDDEN>
Date: Tue, 04 Mar 2025 22:28:12 +0100
Message-ID: <87ikooa3kj.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

> If it's not useful, and anyways not used by anyone, I think it's better
> to get rid of it.
>
> Thuna, would you like to propose a patch that does that?

Hm, I still think it's a shame, but sure.  Something like the attached
patch should do the trick, though I've not tested it in the slightest.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Remove-cl-generic-current-method-specializers.patch

From 6d1fbc312fb2a73141a28c3abe7d94c88429f88a Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing@HIDDEN>
Date: Tue, 4 Mar 2025 22:25:32 +0100
Subject: [PATCH] Remove `cl-generic-current-method-specializers'

* lisp/emacs-lisp/cl-generic.el (cl-generic-define-context-rewriter): Do
not bind `cl-generic-current-method-specializers' in the macro
environment.
(cl-generic-current-method-specializers): Remove macro.
---
 lisp/emacs-lisp/cl-generic.el | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 11685d09d12..ea2bca4c1e0 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -339,11 +339,6 @@ cl-generic-define
     (setf (cl--generic-options generic) options)
     (cl--generic-make-function generic)))
 
-(defmacro cl-generic-current-method-specializers ()
-  "List of (VAR . TYPE) where TYPE is var's specializer.
-This macro can only be used within the lexical scope of a cl-generic method."
-  (error "cl-generic-current-method-specializers used outside of a method"))
-
 (defmacro cl-generic-define-context-rewriter (name args &rest body)
   "Define a special kind of context named NAME.
 Whenever a context specializer of the form (NAME . ARGS) appears,
@@ -391,17 +386,14 @@ cl-generic-define-context-rewriter
     "Make the lambda expression for a method with ARGS and BODY."
     (pcase-let* ((`(,spec-args . ,plain-args)
                   (cl--generic-split-args args))
-                 (fun `(cl-function (lambda ,plain-args ,@body)))
-                 (macroenv (cons `(cl-generic-current-method-specializers
-                                   . ,(lambda () spec-args))
-                                 macroexpand-all-environment)))
+                 (fun `(cl-function (lambda ,plain-args ,@body))))
       (require 'cl-lib)        ;Needed to expand `cl-flet' and `cl-function'.
       (when (assq 'interactive body)
         (message "Interactive forms not supported in generic functions: %S"
                  (assq 'interactive body)))
       ;; First macroexpand away the cl-function stuff (e.g. &key and
       ;; destructuring args, `declare' and whatnot).
-      (pcase (macroexpand fun macroenv)
+      (pcase (macroexpand fun macroexpand-all-environment)
         (`#'(lambda ,args . ,body)
          (let* ((parsed-body (macroexp-parse-body body))
                 (nm (make-symbol "cl--nm"))
@@ -412,7 +404,7 @@ cl-generic-define-context-rewriter
                         `(cl-flet ((cl-call-next-method ,cnm)
                                    (cl-next-method-p ,nmp))
                            ,@(cdr parsed-body))
-                        macroenv))
+                        macroexpand-all-environment))
                 ;; FIXME: Rather than `grep' after the fact, the
                 ;; macroexpansion should directly set some flag when cnm
                 ;; is used.
-- 
2.44.2


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66342: Quote cl-generic-current-method-specializers
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Mar 2025 22:16:01 +0000
Resent-Message-ID: <handler.66342.B66342.174112654313944 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66342
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: moreinfo patch
To: Thuna <thuna.cing@HIDDEN>
Cc: Stefan Kangas <stefankangas@HIDDEN>, 66342 <at> debbugs.gnu.org
Received: via spool by 66342-submit <at> debbugs.gnu.org id=B66342.174112654313944
          (code B ref 66342); Tue, 04 Mar 2025 22:16:01 +0000
Received: (at 66342) by debbugs.gnu.org; 4 Mar 2025 22:15:43 +0000
Received: from localhost ([127.0.0.1]:33363 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpaY8-0003cj-Ty
	for submit <at> debbugs.gnu.org; Tue, 04 Mar 2025 17:15:43 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26428)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
 id 1tpaXm-0003Xj-DF
 for 66342 <at> debbugs.gnu.org; Tue, 04 Mar 2025 17:15:19 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 08707100154;
 Tue,  4 Mar 2025 17:15:10 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1741126509;
 bh=zdEIYCK6QkwScLMysIMTWWsvU3DsuEZy84aEU2nl6CA=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=UYZuUdxmIWmsacCQsqM4OzIJBEiEfH7RhidCpfdZFbG5YVlTfr4Vu1hKTc7dWTW1/
 k9JpmJ0AZXtdqhP/razaaG/dUD4fM16aEpbQjPGMTYHWWDnLUHWNZ3DsqZ4viSPXdd
 K3F6KANQX7hHhAUkaTTOisJ8bnnC1sLRVjUijEKC+WT+NSOQiFyC04nYMFHoExkXDH
 ji4Wy4yhxb8vz2o0SLTbRMiZcB8wMaqngwkdArUCZVpjbFidIchWHBd6R1yWgbgbId
 v2NhKXo4POkdVxMTGbvwVgYppkDj32jXqeZQPj23Rt70WEf0JAl3pEBcB4PqMeY2N0
 XiarS3O1hmQpw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 22DBC100035;
 Tue,  4 Mar 2025 17:15:09 -0500 (EST)
Received: from alfajor (unknown [104.247.242.5])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7495120198;
 Tue,  4 Mar 2025 17:15:08 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <87ikooa3kj.fsf@HIDDEN>
Message-ID: <jwvwmd41m1m.fsf-monnier+emacs@HIDDEN>
References: <87leci1nf7.fsf@HIDDEN> <jwvv7tc5gei.fsf-monnier+emacs@HIDDEN>
 <CADwFkmkp1W14n8DAgQ=QCZQfctPfe9uNidjTshXUkyp4-s7GvQ@HIDDEN>
 <87ikooa3kj.fsf@HIDDEN>
Date: Tue, 04 Mar 2025 17:15:07 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.261 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Thuna, would you like to propose a patch that does that?
> Hm, I still think it's a shame, but sure.

Which brings back my first question:

    Interesting.  Out of curiosity, where/how did you bump into this?


- Stefan

Last modified: Tue, 4 Mar 2025 22:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.