GNU bug report logs - #66506
30.0.50; java/INSTALL contains unnecessary patch for Android-ImageMagick7.

Previous Next

Package: emacs;

Reported by: Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>

Date: Thu, 12 Oct 2023 21:18:01 UTC

Severity: wishlist

Tags: notabug, patch

Found in version 30.0.50

Done: Po Lu <luangruo <at> yahoo.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66506 in the body.
You can then email your comments to 66506 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#66506; Package emacs. (Thu, 12 Oct 2023 21:18:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 12 Oct 2023 21:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50;
 java/INSTALL contains unnecessary patch for Android-ImageMagick7.
Date: Fri, 13 Oct 2023 06:16:45 +0900

[Message part 1 (text/plain, inline)]
Hello,

When I tried building Android port of emacs-30.0.50 with modules, I
realized unnecessary hunk is included in the patch for
libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.

This hunk seems deletes empty lines only.

diff --git a/libjpeg-turbo-2.0.2/jconfig.h b/libjpeg-turbo-2.0.2/jconfig.h
index 47d14c9..5c6f8ee 100644
--- a/libjpeg-turbo-2.0.2/jconfig.h
+++ b/libjpeg-turbo-2.0.2/jconfig.h
@@ -1,57 +1,43 @@
-/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
+/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
 #ifndef JPEG_LIB_VERSION
 #define JPEG_LIB_VERSION 62
 #endif
-
 #ifndef LIBJPEG_TURBO_VERSION
 #define LIBJPEG_TURBO_VERSION 2.0.2
 #endif
-
 #ifndef LIBJPEG_TURBO_VERSION_NUMBER
 #define LIBJPEG_TURBO_VERSION_NUMBER 202
 #endif
-
 #ifndef C_ARITH_CODING_SUPPORTED
 #define C_ARITH_CODING_SUPPORTED
 #endif
-
 #ifndef D_ARITH_CODING_SUPPORTED
 #define D_ARITH_CODING_SUPPORTED
 #endif
-
 #ifndef MEM_SRCDST_SUPPORTED
 #define MEM_SRCDST_SUPPORTED
 #endif
-
 #ifndef WITH_SIMD
 #define WITH_SIMD
 #endif
-
 #ifndef BITS_IN_JSAMPLE
 #define BITS_IN_JSAMPLE 8
 #endif
-
 #ifndef HAVE_LOCALE_H
 #define HAVE_LOCALE_H
 #endif
-
 #ifndef HAVE_STDDEF_H
 #define HAVE_STDDEF_H
 #endif
-
 #ifndef HAVE_STDLIB_H
 #define HAVE_STDLIB_H
 #endif
-
 #ifndef NEED_SYS_TYPES_H
 #define NEED_SYS_TYPES_H
 #endif
-
 #ifndef HAVE_UNSIGNED_CHAR
 #define HAVE_UNSIGNED_CHAR
 #endif
-
 #ifndef HAVE_UNSIGNED_SHORT
 #define HAVE_UNSIGNED_SHORT
 #endif
-

Thanks,

[Message part 2 (text/html, inline)]
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 22 Oct 2023 19:50:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66506; Package emacs. (Wed, 10 Jan 2024 22:04:01 GMT) Full text and rfc822 format available.

Message #10 received at 66506 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>
Cc: 66506 <at> debbugs.gnu.org, Po Lu <luangruo <at> yahoo.com>
Subject: Re: bug#66506: 30.0.50;
 java/INSTALL contains unnecessary patch for Android-ImageMagick7.
Date: Wed, 10 Jan 2024 14:03:29 -0800

Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com> writes:

> Hello,
>
> When I tried building Android port of emacs-30.0.50 with modules, I realized unnecessary hunk is included in the patch for
> libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.
>
> This hunk seems deletes empty lines only.

Po Lu, any comments?

>
> diff --git a/libjpeg-turbo-2.0.2/jconfig.h b/libjpeg-turbo-2.0.2/jconfig.h
> index 47d14c9..5c6f8ee 100644
> --- a/libjpeg-turbo-2.0.2/jconfig.h
> +++ b/libjpeg-turbo-2.0.2/jconfig.h
> @@ -1,57 +1,43 @@
> -/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
> +/* autogenerated jconfig.h based on Android.mk var JCONFIG_FLAGS */
>  #ifndef JPEG_LIB_VERSION
>  #define JPEG_LIB_VERSION 62
>  #endif
> -
>  #ifndef LIBJPEG_TURBO_VERSION
>  #define LIBJPEG_TURBO_VERSION 2.0.2
>  #endif
> -
>  #ifndef LIBJPEG_TURBO_VERSION_NUMBER
>  #define LIBJPEG_TURBO_VERSION_NUMBER 202
>  #endif
> -
>  #ifndef C_ARITH_CODING_SUPPORTED
>  #define C_ARITH_CODING_SUPPORTED
>  #endif
> -
>  #ifndef D_ARITH_CODING_SUPPORTED
>  #define D_ARITH_CODING_SUPPORTED
>  #endif
> -
>  #ifndef MEM_SRCDST_SUPPORTED
>  #define MEM_SRCDST_SUPPORTED
>  #endif
> -
>  #ifndef WITH_SIMD
>  #define WITH_SIMD
>  #endif
> -
>  #ifndef BITS_IN_JSAMPLE
>  #define BITS_IN_JSAMPLE 8
>  #endif
> -
>  #ifndef HAVE_LOCALE_H
>  #define HAVE_LOCALE_H
>  #endif
> -
>  #ifndef HAVE_STDDEF_H
>  #define HAVE_STDDEF_H
>  #endif
> -
>  #ifndef HAVE_STDLIB_H
>  #define HAVE_STDLIB_H
>  #endif
> -
>  #ifndef NEED_SYS_TYPES_H
>  #define NEED_SYS_TYPES_H
>  #endif
> -
>  #ifndef HAVE_UNSIGNED_CHAR
>  #define HAVE_UNSIGNED_CHAR
>  #endif
> -
>  #ifndef HAVE_UNSIGNED_SHORT
>  #define HAVE_UNSIGNED_SHORT
>  #endif
> -
>
> Thanks,
Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 10 Jan 2024 22:04:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66506; Package emacs. (Thu, 11 Jan 2024 01:26:02 GMT) Full text and rfc822 format available.

Message #15 received at 66506 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 66506 <at> debbugs.gnu.org, Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>
Subject: Re: bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for
 Android-ImageMagick7.
Date: Thu, 11 Jan 2024 09:25:18 +0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com> writes:
>
>> Hello,
>>
>> When I tried building Android port of emacs-30.0.50 with modules, I
>> realized unnecessary hunk is included in the patch for
>> libjpeg-turbo-2.0.2/jconfig.h part of Android-ImageMagick7.
>>
>> This hunk seems deletes empty lines only.
>
> Po Lu, any comments?

Parts of these patches are generated by a computer program, and since
one of its actions is to remove empty lines in a header file, that
should be reflected in the patches generated, if only for consistency's
sake.

Thanks.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66506; Package emacs. (Thu, 11 Jan 2024 18:25:02 GMT) Full text and rfc822 format available.

Message #18 received at 66506 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 66506 <at> debbugs.gnu.org, Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>
Subject: Re: bug#66506: 30.0.50;
 java/INSTALL contains unnecessary patch for Android-ImageMagick7.
Date: Thu, 11 Jan 2024 10:24:04 -0800

Po Lu <luangruo <at> yahoo.com> writes:

> Parts of these patches are generated by a computer program, and since
> one of its actions is to remove empty lines in a header file, that
> should be reflected in the patches generated, if only for consistency's
> sake.

What action do you propose here?  Close as notabug?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66506; Package emacs. (Fri, 12 Jan 2024 01:50:02 GMT) Full text and rfc822 format available.

Message #21 received at 66506 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 66506 <at> debbugs.gnu.org, Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com>
Subject: Re: bug#66506: 30.0.50; java/INSTALL contains unnecessary patch for
 Android-ImageMagick7.
Date: Fri, 12 Jan 2024 09:48:43 +0800

tags 66506 notabug
close 66506
thanks

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Po Lu <luangruo <at> yahoo.com> writes:
>
>> Parts of these patches are generated by a computer program, and since
>> one of its actions is to remove empty lines in a header file, that
>> should be reflected in the patches generated, if only for consistency's
>> sake.
>
> What action do you propose here?  Close as notabug?

Yes, thanks.  Now done.
Added tag(s) notabug. Request was from Po Lu <luangruo <at> yahoo.com> to control <at> debbugs.gnu.org. (Fri, 12 Jan 2024 01:50:03 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 66506 <at> debbugs.gnu.org and Takesi Ayanokoji <ayanokoji.takesi <at> gmail.com> Request was from Po Lu <luangruo <at> yahoo.com> to control <at> debbugs.gnu.org. (Fri, 12 Jan 2024 01:50:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 09 Feb 2024 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 91 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.