Received: (at 66531) by debbugs.gnu.org; 25 Oct 2023 14:02:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 25 10:02:34 2023 Received: from localhost ([127.0.0.1]:59725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qveSn-0003gX-Vg for submit <at> debbugs.gnu.org; Wed, 25 Oct 2023 10:02:34 -0400 Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:40105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spk121@HIDDEN>) id 1qveSk-0003gI-Sx for 66531 <at> debbugs.gnu.org; Wed, 25 Oct 2023 10:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=oosYU0reBa6YPYsM+Px6rgqmYz+vG5EZbQ6zKAKE9Hk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=dBC77cEw+uRbr0fB4xZPIgt36ICWvSkSKT0eW+nMTRH1lkWUohQY4K5cuZN1PqD6FtSgcQl6KtvEqNbQC/zDhmiE8x2X5AU65IJiqVHqxhDoWdmMoz1qBupWIxWpTgoURuInWLHdLgoCUmukA/K+5VZ8uQBun9YxS3zJdSnAT9HOyRqNRSUBIsbrOXcxrV7junA/Ie1n+/iVqa0LZueDj6cxLJr2pCMgix4DESZ7lqdr3hkcwxedjhERs6JjHyXKr1BQvQJgIwB+JtyWz6KyMandF6+ajsXFWaLaQmkPGZWG9NrMJy96UJk7COG+UhsgtXJWhtGjVH9p4yGpbjlakQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=I7lKmrfa6qn4b7ANeRZQ/ev7rRQ8xwW3I61qe7h6eM7=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=j72/yHY6/yGEpSTo5FqRI9wApEy2ghqkOb8OJuo+zKuc0qw+46rzATLUELv3kF+ubc0SX3QJVNBHPBh2fZvudDVEXL+ypKwn0Nb8l0K9YrSY20FfOi61T9UMdw/rqS6MUIZ9kI8+ODfGTb8t7eTsvGjcyMHmCFGDF1DogHQ+Z3LsVhxjDJ+lvE5uAION1knei8a8xRZBUF1jXO6G2yakt/ll20r0Rb7UB50ynb8OQpSDxSf6673MaHfi0JOqDzRiV5FlyzzC0LLrHhKsvHTMdF5Vt/yShWWEmQUb9L0+fMKv52a3X+XZg0UmXfqj3+u8q1AAekLeXdI7prKIx0h1ug== X-YMail-OSG: UeCfebsVM1nAndXIGINYS3Ke9IlsgwHNg.aOL5mitQIZldFsHKUrZixxpbGPC2E yHF1DprqetkvnSYPftkVM4oOnW31awjDRKVTQ8KZ4dA._7g0qZXNaLa4LGFY9zJdQsmR4TF7SONl KtTcIS5qLqb.VOS5RSO5b7o4KFVJvUeqrT3.GLpwvCvMCz2ZQP37lPMoYIDlw5C3exOYNsInYEEF iCuuyk6tQBPgs8BxPhgysw1yEPR_jdaLQm9JSEIt9Ih6UlrYN_2vb1nTP9F1EObh6YYLkjE9xJXD tbxn3xjWpZ44k4XK_AvXTkGYZTfa7oVHr06pw8xf9lBbVl4kiCY2R.hDHdnO2I4rsLkTEsTIBbni i4FvFfoX0gVOM5TtaX3X9ZXHZ5LfNx9GFZmhUmdIntl8OfBBdaqeT_RVJZ6kJbE.z0UyetxlRdXN MPnBkqUxhi1MmzmZfFXdhoEFyRZGokVZwh7lqimJ4FApyc75l0sEgVelPnz9P0KHD0rEcJzFbUQA NQ7tEA7WVmV68aTRNEpjLWNnTA5zBb0nT6EH9FqrhwHf7fZxNRqXHqRqEHgoWz.S1ayYLbYWaEZ1 gsKU1zOhemd1Vn73j7BgQB4zWxrONhQxS376sdiCBMorES5HI060KJnuPQ_Ql3VJhXTRhXDWexzZ mX8Cd_5JRDK9R2AwCkpHBde7uP.xo4aFKHtPSMU3ITF7JeAckwI0gac6ObPY6rWIjPggcVkxNflu 5JEBpPL5XALzPUz2AMXV5U2.uBGUOkkSgygUKNYhQsghe2Gm9UBUe21HY1bLV3p3gHoAT1VI.MC0 IXtgiaHa05R8emOdpXLIA3KRsa6APQyeLVxyTxUsWwZk7ldemENcUOzPwYAkBcfWYsNNwYGukdvE CT._xT5n9_K8vxYerkGl57i2LsKhcVpHDG7uNTmtpuhnkN7RoHH.kvwQgDb6B9aOG5CrfaSZ0Vuw udJ7hNZzQ53jlwpNY3bwL638FV.39PaaLw_gn5V5Vlu8mp6Gcs.l2rXLsCX0_BpBOEimaijN3_f7 hCXgf4XTFycE6D9QRmonZAZ.Uwzmw0IEVqojkJ.YPhEEBffM0TQ9g3ZxvLAF7OB0pILkWPueKje0 RnTSvQaIuHyqyJRTJfkz1AfW3h1h9aO1gPSaL37qa84vsYYFLEy43jh4d23Lrf3regmppWa_jPZl radpqzCz74gaCLcHq59yTGc7xErf_2wuP.dPZHQ9N.m3W2YS33kDDo4jS3NbVA8xTHmXblb3v2Fp EKlp_9KCHK.KBI14yTjR_f.nu7AwVtIcuNUD2JLrM56rbN.T01gmrkLgEuC7q88lORPQ96EBVYUv N8pdl8RXQgKdam69BWfRIxvMu6Nyl7Tfj4S_H7vayMnV7kyG_X08Hz_4Pi7u6lwzHMGRE3tjsAOO CU.grx_YDGg22H8rqf65fCJgYF5MF6lUocLwag8psJ9qb62eAwelKo_fiC0HDI6YdGO2Ed8atDfM D2Cqodq3SBuO2QUUpHssbrAMDeeiabuW0OZwXloUnz.MrMRTN3wyvUbf5zk73iRjZqq.FbwiayW9 MINZ49T.uBzwUrpjVPAWwSoDzQ_bF5IPr4uzHs3DDH0OqWaXMDzh_bZyPcg84cgnkN1Zw2T7s5mc TJ.RNqB08FHp7JWoyyfQFEVPqE3WkrHUAdcGDUHsaD52Hqe7ubD0FEzqAjWhsCELsnGBznSPS06a 3koCJvbe5tu5wIttCNZcEHzpZEBUnrEfSMVAj2cPNNMS5P6xu0Xp7cOZYB_fUHMz2mVrFORYacy1 b3dnCH87u9LVdRYqzIbaBrb_ekB8DSUT2dftJiQcz0dhZDJ2I06S9RFktpc7EvLlIWCrEt.Bvsfz 6Nb7fBEw2KSItZSjp92KIokdo6AOz3H36HsTQLyi0td8gkK3aTh2U2L2F8VBsOQiLK9dpfrUS30H VGSE.7BeY7Lu9ODHYFAbdshS4KPhNUA2a7kF0oS3VXNK9Rh2mwTmjOhEHnZGTUWpF7hPhheAdeDU TuuDiFCvX07YcaC3gBnCTTJZSUuqFWhW.97i19t6_bWLDyb5LiO3XwoRSFpQFK2MVOnBCXUcGJTJ FKoPtaVyCatBA8abtLgPeVA7AgYye88fy3BUkVuMkbR_Og4eZGik3mVthumScVhnqYM9YG.8M4cE MVfJ1mq.S1cEeAgBU5f1yjcfSvZRC.DOm.LUn9tpsFld5AtEYv1zHcOKFtdi9ENAeJKMJzAvwuI2 X_kmbPPlj8FDlStgy2xSy5u72idcHDdNFrCnOr6PomJAleRNhv3EjJEFwAYpjONE- X-Sonic-MF: <spk121@HIDDEN> X-Sonic-ID: 1a264ea9-8781-47ca-a832-3ea9c838c9b8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Wed, 25 Oct 2023 14:01:46 +0000 Date: Wed, 25 Oct 2023 14:01:43 +0000 (UTC) From: Mike Gran <spk121@HIDDEN> To: Tomas Volf <wolf@HIDDEN> Message-ID: <1644276721.1249459.1698242503726@HIDDEN> In-Reply-To: <ZSmKU-2YPcKEwrfX@ws> References: <20231013161811.19233-1-wolf@HIDDEN> <458374241.8000448.1697218206032@HIDDEN> <ZSmKU-2YPcKEwrfX@ws> Subject: Re: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 YMailNorrin Content-Length: 1004 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 66531 Cc: "66531 <at> debbugs.gnu.org" <66531 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) I haven't forgotten about this. My linux devel box died. Maybe someone else can make the push, otherwise, I'll be back in business i= n a couple weeks. On Friday, October 13, 2023 at 11:20:11 AM PDT, Tomas Volf <wolf@HIDDEN= z> wrote:=20 On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=C2=A0 Snippet from disassembly of ftw.go does confirm th= at: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.
bug-guile@HIDDEN:bug#66531; Package guile.
Full text available.Received: (at 66531) by debbugs.gnu.org; 13 Oct 2023 18:20:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 13 14:20:40 2023 Received: from localhost ([127.0.0.1]:47396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrMm8-00012b-HV for submit <at> debbugs.gnu.org; Fri, 13 Oct 2023 14:20:40 -0400 Received: from wolfsden.cz ([37.205.8.62]:43056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ws@HIDDEN>) id 1qrMm2-00012K-NK for 66531 <at> debbugs.gnu.org; Fri, 13 Oct 2023 14:20:39 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id B7D0526CB9F; Fri, 13 Oct 2023 18:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221208; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SUqUkoOMU70jBsMGtC/nlcm2UGgWerq1ZW7xWfmB/uvNGDfOctPllKL6gcXoTy/BS zpVRHvfHT7k3iPYisgfU1cUfPOGX0KzKOWXrm1PEhBs47MfOfJxs3qn+Gkts99JPjN b0DTog+GsuSDcB7QZaLGByFG7o+tOQ/vhYLlHiPH8SPVLwIZifNM9ETPqapTAVke2w xKI741/gnwPYO0UJnMGMPZ+dy/VgAarZ+Ygtrw4/XKLNfcdgel6ZjQo2JyuahJvl3d PQeyaQNzwYSTTdiBb8nsMk0goE7q/mK/hUJgtYYglP9KU72dUDmj3w8xlFWoUk7LUP U0TvxdYrVWVS/IcRMonbymu+jVvyoMoq+L7ktyyCdAoVW8pu+kTEdkfMhjWqlzR3sW hNQ709JmDA8Z+9TPLfcyu1GBAhMHko9ji7YOb9VmyVZzbmSOOFt3acBtaqse5hZzIj lG7Vud3Eq60MndM2Yrcq2XKdVcvniy4H1FQkUCg5JTToPOmUwSCVd0fQlvpbJNvMu0 WelUMIkowEZNTCswEN9IX7GS7HG1yVjI2m73lKYhYYNmVIStabFP7WYyxlIfknMDTs mrSOUXpHqN57qlca2TB7j9H2ZRa35bOQU/jCim+1SkJRtyqYWSLTo7Y3I+Cq+zPvOQ ixavs9gbedPCRr5XbxZZZMO0= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.88]) by wolfsden.cz (Postfix) with ESMTPSA id 6DAE426C78D; Fri, 13 Oct 2023 18:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221207; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=vNYnUJD/hmwaEPDS7wdafiq7crtIhe5nQ9esQokwGlquxR0oJEsL86hlUjRnZGHSw xpvudaiL//UEXWDXNQ0D61zesI23CVMYkedKiKC4FlSWjTANR49kmgJELSWNtTyDAB DUIhzosZyBEEV34lbeJE2kmDgGVu+mA+N1xCSMcGAVdl98fbewzi2sH7olY/5RDuiy AarY/j3ZWys8skPtgt8mzGAib72aIEu81lj3k/WEl3N9tu//N8Rk2FXN81IcT+QD15 Y1So/HlUwszqrZ1naffPN+RT20qj43JVITQ5dRVE/dny13pPLzEnJ9aVfFYE6TfQ9z PQ2/+B6j/CM+UCPwjPsWM4hCxzPcvl+0hup4q4EU1W68tsaDTfjXXECLruT5kr5yJJ bs1uU6T2e+nYqBJe9TRoH1l+7AJlWzG4O4Sz7GbYNyFABgo4LOj4ZIZ/eID5H+BquX Wa0i8KTvmxnonjn8nbjr4gsdGnoTZDMD9OkCETrpb5DeyKcy7Q/uLvpDG4wEPC7rU5 3bbPlCG+WrWdptqPGvndfhIIHSOMzOo6pONoz/oqDMYNyncgTxIfjEI7ySN150gbNP D55LUriH55yaMrG7NaNrBplYMnwzTDkhJHvPTh6LcNDJcxZr0CEMc7/okkIKCXOtI3 G9Zo8xLPEZ3QgNRyPikPR668= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ffb90aca; Fri, 13 Oct 2023 18:20:03 +0000 (UTC) Date: Fri, 13 Oct 2023 20:20:03 +0200 From: Tomas Volf <wolf@HIDDEN> To: Mike Gran <spk121@HIDDEN> Subject: Re: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Message-ID: <ZSmKU-2YPcKEwrfX@ws> References: <20231013161811.19233-1-wolf@HIDDEN> <458374241.8000448.1697218206032@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LI0+977NKn5E6PUe" Content-Disposition: inline In-Reply-To: <458374241.8000448.1697218206032@HIDDEN> X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 66531 Cc: "66531 <at> debbugs.gnu.org" <66531 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) --LI0+977NKn5E6PUe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=A0 Snippet from disassembly of ftw.go does confirm that: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --LI0+977NKn5E6PUe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmUpilMACgkQL7/ufbZ/ waku8RAAsBcAmNEcEVr2S+gKv09shY2mNmI0eovF8jPlzBfm/49jlEPbQFa9cOdT ASXQB7wkjGz9tum9IhzU6Q2UW7AcR0IS+g2Rvr4JATuKTds3vfShxhw+1WQccoCh YvzT/OugnhL+89pth+RjM9wUmJMKF81DBZa/Sdya7CdE9xVniJaiLhgjd7xNy3Pe gBcnBGk6KcAruie5lElpVxZyeXUDaUPUtQTQqqSMkOOhbPjtOP+LA+RQAIV2NSg4 UlABG+LTMhAfo94puj6ZEpGCg6MQZcrE28rX5sMP3SfC3THwu9yox56z19Ti+L4p EkPtf6Bn1+ySgJF/mslHc4Cu2AJGUaYnwxmkJl3M7fL4eJtmWMZUyuD/gzlRCOkt pSmwQsusPciHoxNVck+lU16krZbgAsNr2TlkFSlzWub+5K+xBuSWiDzU7cft+OcM EQBIxuDSqCZ4aLlSJ1ybd8fiZLeWzDWm9ZtGne/Fuv2S7C0soEs/39eXO5d8szBt phNf3KfPtqXe9lRJxyw2ioUnjKf4FtA36zRx363PXzNg/vDrjNDsjTsJHw7WjfwY CBPcX6uxqpaMbSy5Uj4zwD9LC3EY/0WcZxyPS7t34KpIxvl7lwtYbyTscWAE//BG d4RnwdlGk+g/3s7C27E0RKxkth/B70hoKBOv2paDj0PGM+nbtcg= =HeZA -----END PGP SIGNATURE----- --LI0+977NKn5E6PUe--
bug-guile@HIDDEN:bug#66531; Package guile.
Full text available.Received: (at 66531) by debbugs.gnu.org; 13 Oct 2023 17:31:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 13 13:31:02 2023 Received: from localhost ([127.0.0.1]:47384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qrM03-0007sg-NS for submit <at> debbugs.gnu.org; Fri, 13 Oct 2023 13:31:02 -0400 Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:33517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spk121@HIDDEN>) id 1qrLzw-0007sL-V1 for 66531 <at> debbugs.gnu.org; Fri, 13 Oct 2023 13:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697218223; bh=F0a4m+DJpj75zlgJzcQ9phsVX4MZ/CD2u4dGjsMGx+E=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=C8dTox6FvXaje3AZxsImj7Ffh+1dqIJX4E5Q89oy0m9zYNzJCovfk0ia0CRO35qz9sPPnSmhFTCLyLB+zFbZhkntAa6GxqAiXXBN+bbvL+rFLNaI1EIqG725SYqq51hep5ICGUWSRmS1J8zVcp7vsf9JAEjSUdehQnuJqKaXjPOts9jNBF/1YhU3nOPOo8FKXVIRa8/lMLPST7cQ6YKHvvaC6Y5YemjTgVUGKTncjYhh2SGfKMB0Xs8/JhHctnLK23EBc3+JOQerLYsuMflHsxerJ+tRBC1P/e2NJgvRs4zrFbeN/pAwDnTAVXpPwUP/yc3M+UOHWmRzgZ4IueHLWQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697218223; bh=Fx0Ja2P8C6kqX4PQdnk8b7G9PvtkKWi4zxMDW6xs8Ly=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=fcxNUIZLzmMiZmq0MpyRT8Gzbesl4ksM1qS32uvPRh2QMDdLVwEYN+zRipsKJGlz+RDp26aQBhtA3KSB7Gt10CPag/4M3K9TjQdHcJ5nwj19dl/ouDvqteLinFpNtmrJBZf/90ZQyS34dtLkpEpg8e4NM6HtB6zmuxK4wrotdNJSt1pFs9zfZA286LnnsY8B/NbsCcczenZM63yYnmn5zInO/JDhhHHUaaKZir1Vu2YAVVV8oTEjxBluSAD6hz+K25w0Nw/FQfGe6PGNhCqlK45nG69yQ3u3jIht/c5WfE/Wj3PDBULwOCWeABF+5sFAaCGHtbcnPydeYAS62eZkrA== X-YMail-OSG: yd2TDK4VM1l5fKCpcOqplBRH05a.F5aPY6CtcshwMMwM1D5nqtI0HW2Ebogqqll 3sVeq1gLMW8BuiX.SiTXo_nTvj16m4RDERYyXKSGOEJr72TFo3SiXICwXsS75C6xgi.VRgAHDPQD u2FKoTb7cN31yfRHvi4HwEN9EbI4kaHG3Tw5G3oCtKLeDSgkhM9X9R0IZ6hj6ihITrPtXGrcH5Ha DyF3p8zWysMBxAjjMjl7Gx96iDpbVQix050dCyhvTJSfa8v26VxBonoem.dPend9lgETrcDzJH4K lshUZif8b_HHRdoJNzWES5JX9ZrhkyQM6M3hfZH6xN5Y1.bqNczdd79BdKxStMAkruFrWSi.TUFo 7hsS48uSEa0PtelMlz7mGCLRVABQ__C2NQodhRhJhcF7ECrMQcqqLfn7PeWOJ0mOKdwtRVd3woaP DJ3PON8pCaBSbLy_lJrNJxVKLyw6K9DjJn_zG0y5cH3Gl4FXkBjzXm_FmVtrV3bfN1LCDBkX8wfw ANC3V4HgXAcNpRP7uLh0MNat2KyJx7eEQHAghWIhTD5Fuba88fB4xWDs51FA_bEqINkcXorrrjyo IbW3pKZLVTULnaXLR9LArxKPoMzZpd6dM0e_gqw_pZDglAJrYKwldSU0HnXIKNXF7BHbL4wN36tI PAsT6RmKR7rXVyw8GQmbyNRxUeJ07.O3WtltQ54H4NmzR3YNVc30MFSfJmkUTdoQRGwhTuPc6jDz YylqPuUdQeXBnqAw8SSH4CsOJI0FnQ0e2.8l1exmyDb1rYlrhkFR5f0roxiYP8vG5NQwrCt49lXb cVL5AQctDXOaxGBlJRU5K_6KMsadXLmuUlHP1ubEtsft.IuGCf8LJQGnWfAirOcufDhqvt.jK6ut Q8d2oG3na_o1AEftu6aLafinfxNOLXlGEjikudMqdgaOqdWnbEcWsc.K18Pl0NzcJTZRPGokOKns cUP539WvCizCmm3QCBOXY0EXMZnS9bde06kwAOgxLdHbT1CbHxxA_6LVsmHnAHXyW9G4.Ongh6cm BpodDg8biKDzatjq0CJWSfl9W0g.xdvOyAlZ3Kxt96j7ZTvmldoM9MfiyidI4jQXwQCLPWNgV3eh cGfnKkSvwzZjlFzoJJcYr1kZ9s1wQFadwMbMqmyZcP5usNgochGPPCbX1ktg4qTOeTkLjM43zutv 2r2PeIKS.kUqvfvjZaLIOjXn599o1uQpn0FmSmKbgzwHO395zEOkrlkE7lQkjcX3lGEh0Xz8MXLO YHWKS.A2y2xxbel3cXtMHtnv8NicpN9Gpwyz2tEndFYDP3wx8_6u1ow_y4s7RIeCm0IdQ0yuUFBp MVt3jBpsplEjEY9biy6dqI320FGafCB98D7yLVihxh_fOg_ygvlqFhsi0jBzQjWTNKq67wpfA_Tv tbjHDj0KFUW1QcH7sEYjwvDPE7GPVimcSY0OG60qw8BFVbStk_7qgpcoGNyU5xC4bOuflSnNfpzz HYb5HEAP5a93TaYq2JrY5gXCNQXRwIw7bmxSk216tCgF2PPGtG2pAZg9r8PZLWJqMJ2LPZDPRNRM HpYVcPhO913WST3qOCvp2rkfYn9eCegfFIxIrsMFk3GYeOxcyGsujLXgfVFgfBXREUhbORtSoWZ6 0Yk9AZ9B9Kdn9KGxMQrXQvt06TjJtulbpXdgdmh7LE8G9nvs2KZE8vwn_gTfFoK4UHsqwlHNSr.L lb1tDkKpiDEwW1Igq2A_ke2gO9a_QQsKaSNw.KX.TgvNbvTkmRo9Sv.OPCvaYZpo4UFt7kDZ1hcm iHjeDI4FrFdmd1QHruwDowepov4FBy4mT11TCGke4CDFmqnMJjrElQU3bh4SxGY2IkImwtzM9Eyc OqvoqWZYxSCI4zhpksbAh4kl0plpoEkw2Qa2ROf_cNxYN42kpkCU6raG4El7V07hhBNBECw2.gsm gSuPvjI_34coAdGRe2t.MBq93f67y8yCs6KatkQjr1IxiSkarPkfehLJioLRvS0Vh9iUU0P6T9YT Fimo2UhBw3hsycPyO0muW03muRXL39u_yieK3_9z8.EhLj1klnQANQEfnP1VkZz5zee53BA4zTaM m9u..Ygi3afC4bosnZsGhpkQ4wHYjutxmeiL5bBj_bwCouq8s_KqhOXqgWegKnqmJ2PqKxhd48gD RR5o6kiDzI6uQuHQV6ZDWiaO5bFIgeKvlGvUMuUndB0KI3FvEVPqSjiA_eI1qRwR6W4gzgeq2Lsx faBPdCCgjFNaBDQEu9dxMgRMCsy4M0k56ZAFoCgjJjfnGe3cS_Ey9xmiEtIA7BPk- X-Sonic-MF: <spk121@HIDDEN> X-Sonic-ID: 596d0c91-c2bd-4e4b-a4f6-d90dfb154dde Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Fri, 13 Oct 2023 17:30:23 +0000 Date: Fri, 13 Oct 2023 17:30:06 +0000 (UTC) From: Mike Gran <spk121@HIDDEN> To: "66531 <at> debbugs.gnu.org" <66531 <at> debbugs.gnu.org>, Tomas Volf <wolf@HIDDEN> Message-ID: <458374241.8000448.1697218206032@HIDDEN> In-Reply-To: <20231013161811.19233-1-wolf@HIDDEN> References: <20231013161811.19233-1-wolf@HIDDEN> Subject: Re: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 YMailNorrin Content-Length: 390 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 66531 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.2 (-) > Both macros were missing a quote for the procedure call, causing the > actual return value to be compiled into the ftw.go, instead of the >procedure call.=C2=A0 Snippet from disassembly of ftw.go does confirm that= : Looks good to me. If you don't have commit approval, I can take the action to commit it, and write a test case, since I was the one who broke it back in 2021. Mike Gran
bug-guile@HIDDEN:bug#66531; Package guile.
Full text available.
Received: (at submit) by debbugs.gnu.org; 13 Oct 2023 16:18:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 13 12:18:58 2023
Received: from localhost ([127.0.0.1]:47300 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qrKsM-0005OM-2A
for submit <at> debbugs.gnu.org; Fri, 13 Oct 2023 12:18:58 -0400
Received: from lists.gnu.org ([2001:470:142::17]:35272)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ws@HIDDEN>) id 1qrKsJ-0005O8-AZ
for submit <at> debbugs.gnu.org; Fri, 13 Oct 2023 12:18:57 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ws@HIDDEN>) id 1qrKrp-0006sb-IY
for bug-guile@HIDDEN; Fri, 13 Oct 2023 12:18:26 -0400
Received: from wolfsden.cz ([37.205.8.62])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ws@HIDDEN>) id 1qrKrn-00039e-1Q
for bug-guile@HIDDEN; Fri, 13 Oct 2023 12:18:25 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
id EF67A26B373; Fri, 13 Oct 2023 16:18:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=;
h=From:To:Cc:Subject:Date;
b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH
rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr
3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb
xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD
aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe
P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS
U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE
DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN
H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk
bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP
p7ykBCeALIf/yi2xbfh9/sRY=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,URIBL_BLOCKED
autolearn=no autolearn_force=no version=3.4.6
Received: from localhost (unknown [81.17.16.88])
by wolfsden.cz (Postfix) with ESMTPSA id 0F89926B4E1;
Fri, 13 Oct 2023 16:18:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=;
h=From:To:Cc:Subject:Date;
b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH
rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr
3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb
xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD
aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe
P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS
U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE
DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN
H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk
bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP
p7ykBCeALIf/yi2xbfh9/sRY=
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id b04980c0;
Fri, 13 Oct 2023 16:18:15 +0000 (UTC)
From: Tomas Volf <wolf@HIDDEN>
To: bug-guile@HIDDEN
Subject: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros.
Date: Fri, 13 Oct 2023 18:18:11 +0200
Message-ID: <20231013161811.19233-1-wolf@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: none client-ip=37.205.8.62; envelope-from=ws@HIDDEN;
helo=wolfsden.cz
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25,
SPF_HELO_PASS=-0.001, SPF_NONE=0.001,
UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
Cc: Tomas Volf <wolf@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
Both macros were missing a quote for the procedure call, causing the
actual return value to be compiled into the ftw.go, instead of the
procedure call. Snippet from disassembly of ftw.go does confirm that:
55 (make-immediate 2 3990) ;; 997 at ice-9/ftw.scm:319:46
56 (make-long-immediate 1 120002) ;; 30000 at ice-9/ftw.scm:320:46
That effectively prevented ftw from entering directories without access
for others. Simple reproduction:
scheme@(guile-user)> ,use (ice-9 ftw)
scheme@(guile-user)> (mkdir "/tmp/xxxx")
scheme@(guile-user)> (chmod "/tmp/xxxx" #o0700)
scheme@(guile-user)> (ftw "/tmp/xxxx" (lambda (_ __ f) (pk f) #t))
;;; (directory-not-readable)
$1 = #t
scheme@(guile-user)> (system "ls -al /tmp/xxxx")
total 0
drwx------ 1 wolf wolf 0 Oct 11 22:54 .
drwxrwxrwt 1 root root 888 Oct 11 22:54 ..
$2 = 0
The fix is to quote the procedure call, leading to the intended
behavior.
This fixes bug 55344.
* module/ice-9/ftw.scm (getuid-or-false): Quote the (getuid).
(getgid-or-false): Quote the (getgid).
---
module/ice-9/ftw.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/module/ice-9/ftw.scm b/module/ice-9/ftw.scm
index ac6aa6316..8496086a1 100644
--- a/module/ice-9/ftw.scm
+++ b/module/ice-9/ftw.scm
@@ -201,12 +201,12 @@
(define-macro (getuid-or-false)
(if (defined? 'getuid)
- (getuid)
+ '(getuid)
#f))
(define-macro (getgid-or-false)
(if (defined? 'getgid)
- (getgid)
+ '(getgid)
#f))
(define (directory-files dir)
--
2.41.0
Tomas Volf <wolf@HIDDEN>:bug-guile@HIDDEN.
Full text available.bug-guile@HIDDEN:bug#66531; Package guile.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.