GNU bug report logs - #66545
[PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66545 in the body.
You can then email your comments to 66545 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Sat, 14 Oct 2023 19:47:37 +0200

* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): New variable.
---
 gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..1d10188b9c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11057,6 +11057,46 @@ (define-public emacs-moe-theme-el
 variants.")
     (license license:gpl3+)))
 
+(define-public emacs-color-theme-sanityinc-tomorrow
+  (let ((commit "d34e8db507ee0c7b465ff18a8f220c33ed77cd79")
+        (revision "0"))
+    (package
+      (name "emacs-color-theme-sanityinc-tomorrow")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url
+                "https://github.com/purcell/color-theme-sanityinc-tomorrow")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1mfildi7rav2j42avii7z4gp4ghl04cqv8wp1vyxzl8vkyj60nkb"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #true
+        #:test-command
+        #~(list "emacs" "-Q" "--batch" "--eval" "
+(progn
+  (setq byte-compile-error-on-warn t)
+  (push default-directory load-path))
+"
+                "-f" "batch-byte-compile"
+                "color-theme-sanityinc-tomorrow.el"
+                "sanityinc-tomorrow-blue-theme.el"
+                "sanityinc-tomorrow-bright-theme.el"
+                "sanityinc-tomorrow-day-theme.el"
+                "sanityinc-tomorrow-eighties-theme.el"
+                "sanityinc-tomorrow-night-theme.el")))
+      (home-page "https://github.com/purcell/color-theme-sanityinc-tomorrow")
+      (synopsis "Emacs color themes based on Chris Kempson's 'tomorrow' themes")
+      (description
+       "An Emacs version of Chris Kempson's \"Tomorrow\" themes, with much more
+extensive face definitions than the \"official\" Emacs variant.")
+      (license license:gpl3+))))
+
 (define-public emacs-solarized-theme
   (package
     (name "emacs-solarized-theme")

base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
-- 
2.41.0

Message #8 received at 66545 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>, 66545 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Sat, 14 Oct 2023 20:29:34 +0200

Am Samstag, dem 14.10.2023 um 19:47 +0200 schrieb Rostislav Svoboda:
> * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow):
> New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 40
> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..1d10188b9c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -11057,6 +11057,46 @@ (define-public emacs-moe-theme-el
>  variants.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-color-theme-sanityinc-tomorrow
> +  (let ((commit "d34e8db507ee0c7b465ff18a8f220c33ed77cd79")
> +        (revision "0"))
> +    (package
> +      (name "emacs-color-theme-sanityinc-tomorrow")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url
> +               
> "https://github.com/purcell/color-theme-sanityinc-tomorrow")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "1mfildi7rav2j42avii7z4gp4ghl04cqv8wp1vyxzl8vkyj60nkb"))))
> +      (build-system emacs-build-system)
> +      (arguments
> +       (list
> +        #:tests? #true
> +        #:test-command
> +        #~(list "emacs" "-Q" "--batch" "--eval" "
> +(progn
> +  (setq byte-compile-error-on-warn t)
> +  (push default-directory load-path))
> +"
> +                "-f" "batch-byte-compile"
> +                "color-theme-sanityinc-tomorrow.el"
> +                "sanityinc-tomorrow-blue-theme.el"
> +                "sanityinc-tomorrow-bright-theme.el"
> +                "sanityinc-tomorrow-day-theme.el"
> +                "sanityinc-tomorrow-eighties-theme.el"
> +                "sanityinc-tomorrow-night-theme.el")))
The tests should not be byte compilation.  In fact, these files should
be compiled by the build phase.
> +      (home-page
> "https://github.com/purcell/color-theme-sanityinc-tomorrow")
> +      (synopsis "Emacs color themes based on Chris Kempson's
> 'tomorrow' themes")
> +      (description
> +       "An Emacs version of Chris Kempson's \"Tomorrow\" themes,
> with much more
> +extensive face definitions than the \"official\" Emacs variant.")
> +      (license license:gpl3+))))
> +
>  (define-public emacs-solarized-theme
>    (package
>      (name "emacs-solarized-theme")
> 
> base-commit: 3d0cdf963820da665d71987c15cae6e503efc701

Cheers

Message #11 received at 66545 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 66545 <at> debbugs.gnu.org
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Sat, 14 Oct 2023 22:26:07 +0200

[Message part 1 (text/plain, inline)]

> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.

I see now that the emacs-build-system 'byte compiles all Emacs Lisp
files.' Then, I think the entire `(arguments ...)` can be elided. If
this is correct, I am resending the patch (see attachment). If not,
please direct me to some examples or explain in more detail how to
byte-compile the *.el file during the build phase. Thank you.

(FYI the code under #:test-command was from
https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)

[0001-gnu-Add-emacs-color-theme-sanityinc-tomorrow.patch (application/x-patch, attachment)]

Message #14 received at 66545 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: 66545 <at> debbugs.gnu.org
Subject: Re: bug#66545: Acknowledgement ([PATCH] gnu: Add
 emacs-color-theme-sanityinc-tomorrow.)
Date: Sun, 15 Oct 2023 00:09:23 +0200

Please consider reviewing the following two patches together:

[PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
https://issues.guix.gnu.org/issue/66545

[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
https://issues.guix.gnu.org/issue/66550

Le sam. 14 oct. 2023 à 19:49, GNU bug Tracking System
<help-debbugs <at> gnu.org> a écrit :
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> As you requested using X-Debbugs-CC, your message was also forwarded to
>   Andrew Tropin <andrew <at> trop.in>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
> (after having been given a bug report number, if it did not have one).
>
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 66545 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 66545: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66545
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems

Message #21 received at 66545-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 66545-done <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 66550-done <at> debbugs.gnu.org
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Tue, 12 Nov 2024 20:52:08 +0900

Hi,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

>> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)

I've applied it.

Thank you!

-- 
Maxim

Message #29 received at 66545 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: Andrew Tropin <andrew <at> trop.in>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 66545 <at> debbugs.gnu.org,
 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Tue, 12 Nov 2024 23:12:30 +0900

Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

>> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)
>
> From 1ab65dedbca8d38cf9291e93265cf48c0e473a58 Mon Sep 17 00:00:00 2001
> Message-ID: <1ab65dedbca8d38cf9291e93265cf48c0e473a58.1697312893.git.Rostislav.Svoboda <at> gmail.com>
> From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
> Date: Sat, 14 Oct 2023 19:17:22 +0200
> Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
>
> * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..b5fd851b38 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -11057,6 +11057,30 @@ (define-public emacs-moe-theme-el
>  variants.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-color-theme-sanityinc-tomorrow

I've added this comment here:

;; Use the latest commit as there are no release/tag.

We always justify why using a made-up version or random commit, to help
the next person who'll update the package.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.