GNU bug report logs - #66547
[PATCH 0/2] Update `notmuch' package to support sexp queries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66547 in the body.
You can then email your comments to 66547 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: guix-patches <at> gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH 0/2] Update `notmuch' package to support sexp queries
Date: Sat, 14 Oct 2023 21:19:38 +0200

This opens a patch series containing the `sfsexp' package required by
`notmuch' to compile with support for sexp queries. The other patch modifies
the `notmuch' package to include the `sfsexp' library as a native input so its
path is picked up by the build system.

Sergio Pastor Pérez (2):
  gnu: Add sfsexp.
  gnu: notmuch: Update to support sexp queries.

 gnu/packages/c.scm    | 23 +++++++++++++++++++++++
 gnu/packages/mail.scm |  5 ++++-
 2 files changed, 27 insertions(+), 1 deletion(-)


base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
-- 
2.41.0

Message #8 received at 66547 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: 66547 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH 1/2] gnu: Add sfsexp.
Date: Sat, 14 Oct 2023 21:28:46 +0200

* gnu/packages/c.scm (sfsexp): New variable.
---
 gnu/packages/c.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index ea58c68262..0a63b81188 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -571,6 +571,29 @@ (define-public libwuya
       ;; clarified (see: https://github.com/WuBingzheng/libwuya/issues/2).
       (license license:gpl2+))))
 
+(define-public sfsexp
+  (package
+    (name "sfsexp")
+    (version "1.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mjsottile/sfsexp")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03srnpc7p1j7ygd0wx9gybcxhqm50kjzkybh1xs75nwz97q3y2dq"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
+    (home-page "https://github.com/mjsottile/sfsexp")
+    (synopsis "Small Fast S-Expression Library")
+    (description
+     "Sfsexp provides an interface to manipulate (read, parse, modify, and
+create) symbolic expressions from C or C++ programs.  A symbolic expression,
+or s-expression, is essentially a LISP-like expression such as (a (b c)).")
+    (license license:gpl2)))
+
 (define-public packcc
   (package
     (name "packcc")
-- 
2.41.0

Message #11 received at 66547 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: 66547 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH 2/2] gnu: notmuch: Update to support sexp queries.
Date: Sat, 14 Oct 2023 21:28:47 +0200

* gnu/packages/mail.scm (notmuch): Update to support sexp queries.
---
 gnu/packages/mail.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index be458a2d92..f330b1d8a2 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -80,6 +80,7 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
+  #:use-module (gnu packages c)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -1403,13 +1404,15 @@ (define-public notmuch
            python-docutils
            python-sphinx
            texinfo
+           sfsexp               ; required to support sexp queries
            ;; The following are required for tests only.
            emacs-no-x           ; -minimal lacks libxml, needed for some tests
            which
            dtach
            gnupg
            man-db
-           perl))
+           perl
+           git))                ; required by the sexp query tests
     (inputs
      (list glib gmime talloc xapian zlib))
     (home-page "https://notmuchmail.org/")
-- 
2.41.0

Message #14 received at 66547 <at> debbugs.gnu.org (full text, mbox):

From: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
To: "66547 <at> debbugs.gnu.org" <66547 <at> debbugs.gnu.org>
Subject: Review
Date: Fri, 8 Dec 2023 11:10:15 +0000

[Message part 1 (text/plain, inline)]

Thanks for your patches! They look good to me, except for the fact that you state "GPL 2" as the license even though in the repo they say LGPL2.1 (or is it LGPL2.1+).

Please send us a corrected version of your patches.

[Message part 2 (text/html, inline)]

Message #17 received at 66547 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: 66547 <at> debbugs.gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH v2] gnu: Add sfsexp.
Date: Fri,  8 Dec 2023 16:50:37 +0100

* gnu/packages/c.scm (sfsexp): New variable.
---
Corrected license.

 gnu/packages/c.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index ac83336ba5..29b89c5cb1 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -572,6 +572,29 @@ (define-public libwuya
       ;; clarified (see: https://github.com/WuBingzheng/libwuya/issues/2).
       (license license:gpl2+))))
 
+(define-public sfsexp
+  (package
+    (name "sfsexp")
+    (version "1.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mjsottile/sfsexp")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03srnpc7p1j7ygd0wx9gybcxhqm50kjzkybh1xs75nwz97q3y2dq"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
+    (home-page "https://github.com/mjsottile/sfsexp")
+    (synopsis "Small Fast S-Expression Library")
+    (description
+     "Sfsexp provides an interface to manipulate (read, parse, modify, and
+create) symbolic expressions from C or C++ programs.  A symbolic expression,
+or s-expression, is essentially a LISP-like expression such as (a (b c)).")
+    (license license:lgpl2)))
+
 (define-public packcc
   (package
     (name "packcc")

base-commit: 06f25a9a85be1bbe7a709e58ce41c1a834e5f1ae
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.