GNU bug report logs - #66550
[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66550 in the body.
You can then email your comments to 66550 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
Date: Sun, 15 Oct 2023 00:04:06 +0200

* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-solarized): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5fd851b38..26ea9dd84b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11081,6 +11081,30 @@ (define-public emacs-color-theme-sanityinc-tomorrow
 extensive face definitions than the \"official\" Emacs variant.")
       (license license:gpl3+))))
 
+(define-public emacs-color-theme-sanityinc-solarized
+  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
+        (revision "0"))
+    (package
+      (name "emacs-color-theme-sanityinc-solarized")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/purcell/color-theme-sanityinc-solarized")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "10vfbl9dry03dw264w7b4grmzcv78x3p7r86bsyhyl74hwwvx1hp"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/purcell/color-theme-sanityinc-solarized")
+      (synopsis
+       "Emacs color themes based on Ethan Schoonover's 'solarized' theme")
+      (description
+       "An alternate Emacs color-theme version of Ethan Schoonover's \"Solarized\"
+theme pair.")
+      (license license:gpl3+))))
+
 (define-public emacs-solarized-theme
   (package
     (name "emacs-solarized-theme")

base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
prerequisite-patch-id: 0d0169efa833e9dd39a2b5c7ff264f733f212e5b
-- 
2.41.0

Message #8 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: 66550 <at> debbugs.gnu.org
Subject: Re: bug#66550: Acknowledgement ([PATCH] gnu: Add
 emacs-color-theme-sanityinc-solarized.)
Date: Sun, 15 Oct 2023 00:09:33 +0200

Please consider reviewing the following two patches together:

[PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
https://issues.guix.gnu.org/issue/66545

[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
https://issues.guix.gnu.org/issue/66550

Le dim. 15 oct. 2023 à 00:05, GNU bug Tracking System
<help-debbugs <at> gnu.org> a écrit :
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> As you requested using X-Debbugs-CC, your message was also forwarded to
>   Andrew Tropin <andrew <at> trop.in>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
> (after having been given a bug report number, if it did not have one).
>
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 66550 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 66550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66550
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems

Message #13 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: rostislav.svoboda <at> gmail.com
Cc: 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66550] [PATCH] gnu: Add
 emacs-color-theme-sanityinc-solarized.
Date: Thu, 07 Nov 2024 11:52:06 +0100

+  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")

It could be great to include latest commits from 2024

+      (license license:gpl3+))))

I see no license whatsoever in upstream repository, is that correct ?

Message #16 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66550] [PATCH] gnu: Add
 emacs-color-theme-sanityinc-solarized.
Date: Thu, 7 Nov 2024 13:32:01 +0100

[Message part 1 (text/plain, inline)]

Hello

> +  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
>
> It could be great to include latest commits from 2024

Uff, that's been more than a year since I sent the patch!
Anyway, I updated it and also slightly tweaked the synopsis. See attachment.

> +      (license license:gpl3+))))
>
> I see no license whatsoever in upstream repository, is that correct ?

The color-theme-sanityinc-solarized repository does not include an
explicit license file. However, the main source file,
color-theme-sanityinc-solarized.el, contains the following header:

;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

Cheers Bost

[0001-gnu-Add-emacs-color-theme-sanityinc-solarized.patch (text/x-patch, attachment)]

Message #19 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: control <at> debbugs.gnu.org,66550 <at> debbugs.gnu.org
Subject: QA review for 66550
Date: Thu, 07 Nov 2024 13:55:10 +0100

user guix
usertag 66550 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked:

- Commit messages
- Package builds
- Lint warnings
- Package tests
- Package style
- List dependent packages build

- New package licenses
- New package tests
- New package synopsis and descriptions

Message #22 received at 66550-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 66545-done <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 66550-done <at> debbugs.gnu.org
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Tue, 12 Nov 2024 20:52:08 +0900

Hi,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

>> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)

I've applied it.

Thank you!

-- 
Maxim

Message #25 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: Andrew Tropin <andrew <at> trop.in>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 66545 <at> debbugs.gnu.org,
 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Tue, 12 Nov 2024 23:12:30 +0900

Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

>> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)
>
> From 1ab65dedbca8d38cf9291e93265cf48c0e473a58 Mon Sep 17 00:00:00 2001
> Message-ID: <1ab65dedbca8d38cf9291e93265cf48c0e473a58.1697312893.git.Rostislav.Svoboda <at> gmail.com>
> From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
> Date: Sat, 14 Oct 2023 19:17:22 +0200
> Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
>
> * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..b5fd851b38 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -11057,6 +11057,30 @@ (define-public emacs-moe-theme-el
>  variants.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-color-theme-sanityinc-tomorrow

I've added this comment here:

;; Use the latest commit as there are no release/tag.

We always justify why using a made-up version or random commit, to help
the next person who'll update the package.

-- 
Thanks,
Maxim

Message #28 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66550] [PATCH] gnu: Add
 emacs-color-theme-sanityinc-solarized.
Date: Thu, 14 Nov 2024 12:56:11 +0100

Hello Cayetano,

It would be great if you could merge my patch. It’s not particularly
important - just a trivial piece of code - but it has been lingering
for quite some time now. Specifically, for 1 year and 1 month, minus 1
day ;-)

Cheers,
Bost

Message #31 received at 66550 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 66550 <at> debbugs.gnu.org
Subject: Re: [bug#66550] [PATCH] gnu: Add
 emacs-color-theme-sanityinc-solarized.
Date: Thu, 14 Nov 2024 14:17:23 +0100

>jeu. 14 nov. 2024 at 12:56, Rostislav Svoboda <rostislav.svoboda <at> gmail.com> wrote:

> Hello Cayetano,
>
> It would be great if you could merge my patch. It’s not particularly
> important - just a trivial piece of code - but it has been lingering
> for quite some time now. Specifically, for 1 year and 1 month, minus 1
> day ;-)

I’m not a guix committer, I’m just reviewing patches, and yours was fine to me.

I think I understand the tweak here. You have ask to merge 66545
(solarized) and 66550 (tomorrow). The later was merged a couple of days
ago, so both are considered as done now.

https://issues.guix.gnu.org/66550
https://issues.guix.gnu.org/66545

If I’m right, you’ll better ask Maxim (the committer) to consider the
situation.

C.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.