GNU bug report logs - #66584
[PATCH] gnu: add emacs-flexoki-themes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66584 in the body.
You can then email your comments to 66584 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Jose <arnav.jose <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Andrew Jose <arnav.jose <at> gmail.com>
Subject: [PATCH] gnu: add emacs-flexoki-themes
Date: Tue, 17 Oct 2023 11:05:30 +0530

This commit adds the flexoki-themes package imported from MELPA
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..40773b13ff 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
 supports type hints, definition-jumping, completion, and more.")
     (license license:gpl3+)))
 
+(define-public emacs-flexoki-themes
+(package
+  ((name "emacs-flexoki-themes")
+   (version "20231015.2014")
+   (source
+    (origin
+      (method git-fetch)
+      (uri
+       (git-reference
+        (url
+         "https://github.com/crmsnbleyd/flexoki-emacs-theme.git")
+        (commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")))
+      (sha256
+       (base32
+        "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+   (build-system emacs-build-system)
+   (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+   (synopsis "An inky colour scheme for prose and code")
+   (description
+    "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+   (license licence:gpl3+))))
+
 (define-public emacs-flycheck
   (package
     (name "emacs-flycheck")
-- 
2.34.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andrew Jose <arnav.jose <at> gmail.com>
Cc: 66584 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
Date: Tue, 17 Oct 2023 09:48:02 +0100

[Message part 1 (text/plain, inline)]

Andrew Jose <arnav.jose <at> gmail.com> writes:

> This commit adds the flexoki-themes package imported from MELPA
> ---
>  gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..40773b13ff 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -2451,6 +2451,29 @@ (define-public emacs-dante
>  supports type hints, definition-jumping, completion, and more.")
>      (license license:gpl3+)))
>
> +(define-public emacs-flexoki-themes
> +(package
> +  ((name "emacs-flexoki-themes")
> +   (version "20231015.2014")

The bit above where you've got (package (( looks wrong, have you managed
to build this pacakge locally?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 66584 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Jose <arnav.jose <at> gmail.com>
To: 66584 <at> debbugs.gnu.org
Cc: Andrew Jose <arnav.jose <at> gmail.com>, mail <at> cbaines.net
Subject: [PATCH] gnu: add emacs-flexoki-themes
Date: Tue, 17 Oct 2023 14:52:07 +0530

imported from melpa

This patch reverts the previous one and also uses the latest ref from MELPA. It is tested to build and I apologise for the previous one, which was indeed wrong
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..b59a3f1321 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
 supports type hints, definition-jumping, completion, and more.")
     (license license:gpl3+)))
 
+(define-public emacs-flexoki-themes
+  (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
+        (revision "20231017.501"))
+    (package
+      (name "emacs-flexoki-themes")
+      (version revision)
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+      (synopsis "An inky colour scheme for prose and code")
+      (description
+       "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+      (license license:gpl3+))))
+
 (define-public emacs-flycheck
   (package
     (name "emacs-flycheck")
-- 
2.34.1

Message #17 received at 66584 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Jose <arnav.jose <at> gmail.com>
Cc: 66584 <at> debbugs.gnu.org, mail <at> cbaines.net
Subject: Re: [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
Date: Tue, 17 Oct 2023 11:48:41 +0200

Hello,

Andrew Jose <arnav.jose <at> gmail.com> writes:

> +(define-public emacs-flexoki-themes

Thanks.

> +  (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
> +        (revision "20231017.501"))
> +    (package
> +      (name "emacs-flexoki-themes")
> +      (version revision)


The version should be "0.12". Guix doesn't follow MELPA numbering, but
rather upstream versioning.

> +      (synopsis "An inky colour scheme for prose and code")

The synopsis shouldn't start out with an article, such as "An":

  "Inky colour scheme …"

Regards,
-- 
Nicolas Goaziou

Message #20 received at 66584 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Jose <arnav.jose <at> gmail.com>
To: 66584 <at> debbugs.gnu.org
Cc: Andrew Jose <arnav.jose <at> gmail.com>, mail <at> cbaines.net,
 mail <at> nicolasgoaziou.fr
Subject: [PATCH] gnu: add emacs-flexoki-themes
Date: Tue, 17 Oct 2023 20:07:29 +0530

This patch invalidates any previous patches sent on this issue.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..e2a546d35d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
 supports type hints, definition-jumping, completion, and more.")
     (license license:gpl3+)))
 
+(define-public emacs-flexoki-themes
+  (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
+        (revision "0.12"))
+    (package
+      (name "emacs-flexoki-themes")
+      (version revision)
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+      (synopsis "Inky colour scheme for prose and code")
+      (description
+       "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+      (license license:gpl3+))))
+
 (define-public emacs-flycheck
   (package
     (name "emacs-flycheck")
-- 
2.34.1

Message #25 received at 66584-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Jose <arnav.jose <at> gmail.com>
Cc: 66584-done <at> debbugs.gnu.org, mail <at> cbaines.net
Subject: Re: [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
Date: Mon, 22 Jan 2024 00:27:28 +0100

Hello,

Andrew Jose <arnav.jose <at> gmail.com> writes:

> +(define-public emacs-flexoki-themes
> +  (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
> +        (revision "0.12"))

Thank you. I applied your patch and bumped version to 0.20.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.