GNU bug report logs -
#66586
[PATCH] gnu: lvm2: Remove systemd rule.
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66586 in the body.
You can then email your comments to 66586 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 17 Oct 2023 08:59:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Simon Tournier <zimon.toutoune <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org
.
(Tue, 17 Oct 2023 08:59:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Yann Dupont <Yann.Dupont <at> univ-nantes.fr>
Fixes <https://issues.guix.gnu.org/65177>.
Reported by Adrien 'neox' Bourmault <neox <at> gnu.org>.
* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 22 ++++++++++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch
Hi,
Here is the patch from Yann sent in patch 65177 [1]. I have just reformatted
it and preprare it for merging if it is correct. I know nothing about udev.
1: https://issues.guix.gnu.org/65177#3
Cheers,
simon
diff --git a/gnu/local.mk b/gnu/local.mk
index daacd786a7..3d74c3e228 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1625,6 +1625,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 6bb6d62182..6882244e92 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4527,6 +4527,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..46b4dcffbb
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,22 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
+and activate the volume group. lvm2 was updated recently from 2.03.11 to
+2.03.21, then 2.03.22, and probably started exhibiting this behavior then. It
+removes the indirection through systemd-run and directly run vgchange.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
base-commit: b437896e87a51cc610388d4c462893652dd773e6
--
2.38.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Mon, 23 Oct 2023 21:53:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Hi!
Simon Tournier <zimon.toutoune <at> gmail.com> skribis:
> From: Yann Dupont <Yann.Dupont <at> univ-nantes.fr>
>
> Fixes <https://issues.guix.gnu.org/65177>.
> Reported by Adrien 'neox' Bourmault <neox <at> gnu.org>.
>
> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
> * gnu/local.mk: Register new patch.
One minor nit:
> +++ b/gnu/packages/patches/lvm2-no-systemd.patch
> @@ -0,0 +1,22 @@
> +Fixes <https://issues.guix.gnu.org/65177>.
> +
> +Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
> +and activate the volume group. lvm2 was updated recently from 2.03.11 to
> +2.03.21, then 2.03.22, and probably started exhibiting this behavior then. It
> +removes the indirection through systemd-run and directly run vgchange.
I propose to change this paragraph so that it is self-contained, like:
Run ‘vgchange’ directly instead of attempting to run it via
‘systemd-run’ as the udev rules included in lvm2 >= 2.03.14 do.
LGTM with a change along these lines!
Ludo’.
Information forwarded
to
ludo <at> gnu.org, guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 24 Oct 2023 16:49:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 66586 <at> debbugs.gnu.org (full text, mbox):
From: Yann Dupont <Yann.Dupont <at> univ-nantes.fr>
Fixes <https://issues.guix.gnu.org/65177>.
Reported by Adrien 'neox' Bourmault <neox <at> gnu.org>.
* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 20 ++++++++++++++++++++
3 files changed, 22 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 43145caf80..4c8800b274 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1627,6 +1627,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f02577d2d5..c618651553 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4494,6 +4494,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..440559b96d
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,20 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
base-commit: f3714b3d5f51aced4b31447c42d5e89c75e3079f
--
2.38.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 24 Oct 2023 18:15:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Hi Ludo,
On Mon, 23 Oct 2023 at 23:52, Ludovic Courtès <ludo <at> gnu.org> wrote:
> I propose to change this paragraph so that it is self-contained, like:
>
> Run ‘vgchange’ directly instead of attempting to run it via
> ‘systemd-run’ as the udev rules included in lvm2 >= 2.03.14 do.
I copy/pasted these lines in v2.
Cheers,
simon
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Sun, 29 Oct 2023 23:24:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Simon Tournier <zimon.toutoune <at> gmail.com> skribis:
> From: Yann Dupont <Yann.Dupont <at> univ-nantes.fr>
>
> Fixes <https://issues.guix.gnu.org/65177>.
> Reported by Adrien 'neox' Bourmault <neox <at> gnu.org>.
>
> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
> * gnu/local.mk: Register new patch.
LGTM, thanks!
Reply sent
to
Simon Tournier <zimon.toutoune <at> gmail.com>
:
You have taken responsibility.
(Tue, 31 Oct 2023 11:00:05 GMT)
Full text and
rfc822 format available.
Notification sent
to
Simon Tournier <zimon.toutoune <at> gmail.com>
:
bug acknowledged by developer.
(Tue, 31 Oct 2023 11:00:06 GMT)
Full text and
rfc822 format available.
Message #22 received at 66586-done <at> debbugs.gnu.org (full text, mbox):
Hi,
On lun., 30 oct. 2023 at 00:22, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Simon Tournier <zimon.toutoune <at> gmail.com> skribis:
>
>> From: Yann Dupont <Yann.Dupont <at> univ-nantes.fr>
>>
>> Fixes <https://issues.guix.gnu.org/65177>.
>> Reported by Adrien 'neox' Bourmault <neox <at> gnu.org>.
>>
>> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
>> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
>> * gnu/local.mk: Register new patch.
>
> LGTM, thanks!
Pushed as c0895371c5759c7d9edb330774e90f192cc4cf2c.
Cheers,
simon
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 31 Oct 2023 20:09:01 GMT)
Full text and
rfc822 format available.
Message #25 received at 66586-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi everyone,
The given .patch file is malformed: there are no closing double quotes
for each of the strings. Additionally, I don't believe that the
reference to systemd has been truly removed with this, as it's
referenced in the second line of the patch.
I get errors immediately in my dmesg when booting with this patch. Has
this been tested? I believe this will affect users relying on LVM
volumes.
Best,
--
Josselin Poiret
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 31 Oct 2023 21:30:01 GMT)
Full text and
rfc822 format available.
Message #28 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Hi,
On Tue, 31 Oct 2023 at 21:07, Josselin Poiret via Guix-patches via <guix-patches <at> gnu.org> wrote:
> I get errors immediately in my dmesg when booting with this patch.
Reverted 3991d9e4d9867ec499283bfc71b34d7bfebe49b3. Oops, sorry for the
annoyance. I screwed up!
Could you propose a fix for <https://issues.guix.gnu.org/65177>?
Cheers,
simon
Did not alter fixed versions and reopened.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 31 Oct 2023 21:30:02 GMT)
Full text and
rfc822 format available.
Removed tag(s) patch.
Request was from
Simon Tournier <zimon.toutoune <at> gmail.com>
to
control <at> debbugs.gnu.org
.
(Tue, 31 Oct 2023 21:30:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 31 Oct 2023 22:13:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Follow-up of 3991d9e4d9867ec499283bfc71b34d7bfebe49b3.
* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
Change-Id: I916fb5f6ae786d22af69f0a7d81c0c28da3c96ea
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 19 +++++++++++++++++++
3 files changed, 21 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 8d817379a7..27e57302ae 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1629,6 +1629,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7a9f357681..6abdb23958 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4494,6 +4494,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..f786cd9705
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,19 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..d3cc125 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,7 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
base-commit: 3991d9e4d9867ec499283bfc71b34d7bfebe49b3
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 05 Mar 2024 15:53:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Hi, this bug is still open, and, as far as I can tell, generating a VM
using lvm2 is still currently broken.
Is there still a problem preventing this path from being integrated?
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Tue, 02 Apr 2024 22:44:03 GMT)
Full text and
rfc822 format available.
Message #41 received at 66586 <at> debbugs.gnu.org (full text, mbox):
Hi there, I just tested it but it did not work while not showing the error I
reported earlier. I just obtain "Device ... not found or access denied".
However, it might be linked to 70051 too, so I'll try to test with that too (or
wait it's merged).
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Wed, 10 Apr 2024 13:21:10 GMT)
Full text and
rfc822 format available.
Message #44 received at 66586 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi there,
I'd looked at the patch Simon reformatted and it seemed fine, but I just
tested *this* thread's patch, and it doesn't seem to work.
I suspect there's an extra "-" in the 1st line of the 3rd patch (it
wasn't in my original patch https://issues.guix.gnu.org/65177#3)
<https://issues.guix.gnu.org/65177#3>.
the « - » in the line '-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache
--listvg --checkcomplete --vgonline --autoactivation event --udevoutput
--journal=output $env{DEVNAME}' is too much in the patch.
I've just tested the generation of a VM generated with the patch
amputated from the excess line and it's ok.
Unless someone does it before me, I'll try again to post the correct
version.
[Message part 2 (text/html, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Thu, 18 Apr 2024 10:22:12 GMT)
Full text and
rfc822 format available.
Message #47 received at 66586 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
I hope this time patch won't be garbled… (trying to attach patch)
[patch-for-65177 (text/plain, attachment)]
Reply sent
to
Lars-Dominik Braun <lars <at> 6xq.net>
:
You have taken responsibility.
(Sat, 25 May 2024 18:04:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Simon Tournier <zimon.toutoune <at> gmail.com>
:
bug acknowledged by developer.
(Sat, 25 May 2024 18:04:02 GMT)
Full text and
rfc822 format available.
Message #52 received at 66586-done <at> debbugs.gnu.org (full text, mbox):
Hi,
> I hope this time patch won't be garbled… (trying to attach patch)
LGTM. Pushed as commit 83fc6c7f72fcab3a68c82dd02f872429d632a2c0.
Lars
Information forwarded
to
guix-patches <at> gnu.org
:
bug#66586
; Package
guix-patches
.
(Mon, 27 May 2024 07:27:02 GMT)
Full text and
rfc822 format available.
Message #55 received at 66586-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Le 25/05/2024 à 20:03, Lars-Dominik Braun a écrit :
> Hi,
>
>> I hope this time patch won't be garbled… (trying to attach patch)
> LGTM. Pushed as commit 83fc6c7f72fcab3a68c82dd02f872429d632a2c0.
>
> Lars
>
Hi Lars-Dominik, thanks !
Regards,
--
Yann Dupont - GLiCID Centre Calcul Intensif Pays de la Loire
Tel : 02.53.48.49.39 - Mail/Mattermost : Yann.Dupont <at> univ-nantes.fr
[smime.p7s (application/pkcs7-signature, attachment)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 24 Jun 2024 11:24:11 GMT)
Full text and
rfc822 format available.
This bug report was last modified 319 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.