GNU bug report logs - #66608
[PATCH] gnu: Add yara.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66608 in the body.
You can then email your comments to 66608 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH] gnu: Add yara.
Date: Wed, 18 Oct 2023 16:57:14 +0200

* gnu/packages/antivirus.scm (yara): New variable.
---
 gnu/packages/antivirus.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/antivirus.scm b/gnu/packages/antivirus.scm
index 750db04040..45a85e2faf 100644
--- a/gnu/packages/antivirus.scm
+++ b/gnu/packages/antivirus.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2018 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2019–2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2023 Jakob Kirsch <jakob.kirsch <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,9 +25,11 @@ (define-module (gnu packages antivirus)
   #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -38,6 +41,7 @@ (define-module (gnu packages antivirus)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml))
@@ -156,3 +160,38 @@ (define-public clamav
                    (license:non-copyleft "libclamav/strlcat.c") ;"OpenBSD" license
                    license:asl2.0       ;libclamav/yara*
                    license:expat))))    ;shared/getopt.[ch]
+
+(define-public yara
+  (package
+    (name "yara")
+    (version "v4.4.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/VirusTotal/yara")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1jc468iybjl1n0r6prpw7pwhd9jvfbjghqg9qdq1hbihnv5wa4bb"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool protobuf pkg-config))
+    (inputs (list openssl bash))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-before 'check 'remove-bin-sh-in-test
+                    (lambda* (#:key build-inputs #:allow-other-keys)
+                      (substitute* "tests/test-rules.c"
+                        (("/bin/sh")
+                         (string-append (assoc-ref %build-inputs "bash")
+                                        "/bin/sh"))))))))
+
+    (synopsis "The pattern matching swiss knife")
+    (description
+     "YARA is a tool aimed at (but not limited to) helping malware researchers to
+identify and classify malware samples.  With YARA you can create descriptions of
+malware families (or whatever you want to describe) based on textual or binary patterns.
+Each description, a.k.a. rule, consists of a set of strings and a boolean expression
+which determine its logic.")
+    (home-page "https://github.com/VirusTotal/yara")
+    (license license:bsd-3)))

base-commit: 1076f32111e512ed437f135c9eb6ce2daaafd623
--
2.41.0

Message #8 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: 66608 <at> debbugs.gnu.org
Subject: Re: [bug#66608] [PATCH] gnu: Add yara.
Date: Thu, 19 Oct 2023 16:08:10 +0100

Hi Jakob,

Jakob Kirsch <jakob.kirsch <at> web.de> writes:

> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-before 'check 'remove-bin-sh-in-test
> +                    (lambda* (#:key build-inputs #:allow-other-keys)
> +                      (substitute* "tests/test-rules.c"
> +                        (("/bin/sh")
> +                         (string-append (assoc-ref %build-inputs "bash")
> +                                        "/bin/sh"))))))))

This can be written with G-Expressions as:
--8<---------------cut here---------------start------------->8---
(arguments
 (list
  #:phases
  #~(modify-phases %standard-phases
      (add-before …
       (lambda _
         (substitute* …
          (string-append #$(this-package-input "bash") "/bin/sh")
          …))))))
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Bruno.

Message #11 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: 66608 <at> debbugs.gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH v1] gnu: Add yara.
Date: Thu, 19 Oct 2023 18:35:07 +0200

* gnu/packages/antivirus.scm (yara): New variable.
---
 gnu/packages/antivirus.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/antivirus.scm b/gnu/packages/antivirus.scm
index 750db04040..db039447bf 100644
--- a/gnu/packages/antivirus.scm
+++ b/gnu/packages/antivirus.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2018 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2019–2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2023 Jakob Kirsch <jakob.kirsch <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,9 +25,11 @@ (define-module (gnu packages antivirus)
   #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -38,6 +41,7 @@ (define-module (gnu packages antivirus)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml))
@@ -156,3 +160,39 @@ (define-public clamav
                    (license:non-copyleft "libclamav/strlcat.c") ;"OpenBSD" license
                    license:asl2.0       ;libclamav/yara*
                    license:expat))))    ;shared/getopt.[ch]
+
+(define-public yara
+  (package
+    (name "yara")
+    (version "v4.4.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/VirusTotal/yara")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1jc468iybjl1n0r6prpw7pwhd9jvfbjghqg9qdq1hbihnv5wa4bb"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool protobuf pkg-config))
+    (inputs (list openssl bash))
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'remove-bin-sh-in-test
+                     (lambda _
+                       (substitute* "tests/test-rules.c"
+                         (("/bin/sh")
+                          (string-append #$(this-package-input "bash")
+                                         "/bin/sh"))))))))
+
+    (synopsis "The pattern matching swiss knife")
+    (description
+     "YARA is a tool aimed at (but not limited to) helping malware researchers to
+identify and classify malware samples.  With YARA you can create descriptions of
+malware families (or whatever you want to describe) based on textual or binary patterns.
+Each description, a.k.a. rule, consists of a set of strings and a boolean expression
+which determine its logic.")
+    (home-page "https://github.com/VirusTotal/yara")
+    (license license:bsd-3)))

base-commit: c065da01ff956d3c2bdfc45a33d910e509a211d9
--
2.41.0

Message #14 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: divya <at> subvertising.org
To: 66608 <at> debbugs.gnu.org
Subject: [bug#66608] [PATCH v1] gnu: Add yara.
Date: Wed, 05 Mar 2025 20:53:31 +0000

[Message part 1 (text/plain, inline)]

Here's an updated version of the patch:

[0001-gnu-Add-yara.patch (text/x-diff, attachment)]

Message #17 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: 66608 <at> debbugs.gnu.org
Cc: Divya Ranjan <divya <at> subvertising.org>
Subject: [PATCH] gnu: Add yara.
Date: Wed,  5 Mar 2025 21:55:30 +0000

* gnu/packages/antivirus.scm (yara): New variable.

Change-Id: I6ecad2cc6cc797102269ccde80071f7290db44e4
---
 gnu/packages/antivirus.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/antivirus.scm b/gnu/packages/antivirus.scm
index 23af26f411..9e714ae092 100644
--- a/gnu/packages/antivirus.scm
+++ b/gnu/packages/antivirus.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2018 Christopher Baines <mail <at> cbaines.net>
+;;; Copyright © 2023 Jakob Kirsch <jakob.kirsch <at> web.de>
 ;;; Copyright © 2019–2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2024 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;;
@@ -27,8 +28,11 @@ (define-module (gnu packages antivirus)
   #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cmake)
@@ -40,6 +44,7 @@ (define-module (gnu packages antivirus)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-check)
   #:use-module (gnu packages rust-apps)
@@ -185,3 +190,39 @@ (define-public clamav
                    (license:non-copyleft "libclamav/strlcat.c") ;"OpenBSD" license
                    license:asl2.0       ;libclamav/yara*
                    license:expat))))    ;shared/getopt.[ch]
+
+(define-public yara
+  (package
+    (name "yara")
+    (version "v4.5.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/VirusTotal/yara")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1qaw1zv618jkqa5g39p1sdv8s6a7q23ayqfrqv0bj2z1g4nmn95g"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool protobuf pkg-config))
+    (inputs (list openssl bash-minimal))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'remove-bin-sh-in-test
+            (lambda _
+              (substitute* "tests/test-rules.c"
+                (("/bin/sh")
+                 (string-append #$(this-package-input "bash") "/bin/sh"))))))))
+
+    (synopsis "The pattern matching swiss knife")
+    (description
+     "YARA is a tool aimed at (but not limited to) helping malware researchers to
+identify and classify malware samples.  With YARA you can create descriptions of
+malware families (or whatever you want to describe) based on textual or binary patterns.
+Each description, a.k.a. rule, consists of a set of strings and a boolean expression
+which determine its logic.")
+    (home-page "https://github.com/VirusTotal/yara")
+    (license license:bsd-3)))

base-commit: 310adf4ce70cbb864859274fcc7842bd519bbddc
-- 
2.48.1

Message #20 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: Divya Ranjan <divya <at> subvertising.org>
To: 66608 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#66608] [PATCH v2] gnu: Add yara.
Date: Wed, 05 Mar 2025 22:12:44 +0000

[Message part 1 (text/plain, inline)]

The last patch was failing because I forgot to change bash to bash-minimal in the gexp, here’s a revised patch that builds and the linter doesn’t complain:

[0001-gnu-Add-yara.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

- 
Divya Ranjan,
Philosophy, Mathematics, Libre Software.

PGP Fingerprint: F0B3 1A69 8006 8FB8 096A  2F12 B245 10C6 108C 8D4A

Message #23 received at 66608 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To: Divya Ranjan <divya <at> subvertising.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 66608 <at> debbugs.gnu.org
Subject: Re: [bug#66608] [PATCH v2] gnu: Add yara.
Date: Thu, 06 Mar 2025 16:10:28 +0100

Hello Divyá, thanks for the version bump.

The patch builds and lints successfully.

Guix style will add a line break at the `string-append' line, like so:
--8<---------------cut here---------------start------------->8---
(string-append #$(this-package-input "bash-minimal")
               "/bin/sh")
--8<---------------cut here---------------end--------------->8---

I think this can be done by the committer.

Other than that, the patch looks good to go.

Reviewed-by: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>

Thanks!
Sergio.

Message #28 received at 66608-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>, 
 Divya Ranjan <divya <at> subvertising.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 66608-done <at> debbugs.gnu.org
Subject: Re: [bug#66608] [PATCH v2] gnu: Add yara.
Date: Thu, 06 Mar 2025 21:48:47 +0100

Am Donnerstag, dem 06.03.2025 um 16:10 +0100 schrieb Sergio Pastor
Pérez:
> Hello Divyá, thanks for the version bump.
> 
> The patch builds and lints successfully.
> 
> Guix style will add a line break at the `string-append' line, like
> so:
> --8<---------------cut here---------------start------------->8---
> (string-append #$(this-package-input "bash-minimal")
>                "/bin/sh")
> --8<---------------cut here---------------end--------------->8---
> 
> I think this can be done by the committer.
> 
> Other than that, the patch looks good to go.
Well, I also reworded the synopsis and description and reordered the
fields, but it's done.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.