GNU logs - #66655, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: tomasralph2000@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Oct 2023 20:29:01 +0000
Resent-Message-ID: <handler.66655.B.169783368917586 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66655 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Fri, 20 Oct 2023 20:27:19 +0000
Content-Type: multipart/alternative;
 boundary="--=_RainLoop_375_704826040.1697833639"
From: tomasralph2000@HIDDEN
Message-ID: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
Received-SPF: pass client-ip=2607:f8b0:4864:20::534;
 envelope-from=tomasralph2000@HIDDEN; helo=mail-pg1-x534.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: If using =display-line-numbers-mode= with the =visual= style
 set for it, sometimes clicking buttons does not actually click it. It instead
 shifts the buffer slightly, either to the left or to the righ [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (tomasralph2000[at]gmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (tomasralph2000[at]gmail.com)
 0.0 HTML_MESSAGE           BODY: HTML included in message
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)


----=_RainLoop_375_704826040.1697833639
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

If using =3Ddisplay-line-numbers-mode=3D with the =3Dvisual=3D style set =
for it,=0Asometimes clicking buttons does not actually click it. It inste=
ad shifts=0Athe buffer slightly, either to the left or to the right, and =
a mark is=0Aset (by clicking I refer with the mouse, specifically). You w=
ill need to=0Apress again in order to actually click the button.=0A=0AThi=
s is inconsistent, there's no guarantee that it will happen, it=0Asometim=
es does, but it is often enough for you to be able to notice within=0Ajus=
t a couple of seconds of clicking through things.=0A=0AYou can launch =3D=
emacs -Q=3D and run these two lines:=0A=0A(setq display-line-numbers-type=
 'visual)=0A(global-display-line-numbers-mode)=0A=0AThen just click throu=
gh buttons. A good test is to open the emacs manual=0A=3DC-h R emacs=3D s=
ince it has a big index.=0A=0AThe bug does not happen with =3Drelative=3D=
 style line numbers.=0A=0AIn GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu=
, GTK+ Version 3.24.38,=0Acairo version 1.17.8)=0ASystem Description: Arc=
h Linux=0A=0AConfigured using:=0A 'configure --with-pgtk --with-native-co=
mpilation=3Daot --sysconfdir=3D/etc=0A --prefix=3D/usr --libexecdir=3D/us=
r/lib --with-tree-sitter=0A --localstatedir=3D/var --with-cairo --disable=
-build-details=0A --with-harfbuzz --with-libsystemd --with-modules 'CFLAG=
S=3D-march=3Dx86-64=0A -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions -=
Wp,-D_FORTIFY_SOURCE=3D2=0A -Wformat -Werror=3Dformat-security -fstack-cl=
ash-protection=0A -fcf-protection -g=0A -ffile-prefix-map=3D/build/emacs/=
src=3D/usr/src/debug/emacs -flto=3Dauto'=0A 'LDFLAGS=3D-Wl,-O1,--sort-com=
mon,--as-needed,-z,relro,-z,now -flto=3Dauto'=0A 'CXXFLAGS=3D-march=3Dx86=
-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions=0A -Wp,-D_FORTIFY_SO=
URCE=3D2 -Wformat -Werror=3Dformat-security=0A -fstack-clash-protection -=
fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g=0A -ffile-prefix-map=3D/build=
/emacs/src=3D/usr/src/debug/emacs -flto=3Dauto''=0A=0AConfigured features=
:=0AACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JP=
EG=0AJSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOT=
IFY=0APDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF=0ATOOLKIT_=
SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB=0A=0AImportant settings:=0A va=
lue of $LANG: en_US.UTF-8=0A locale-coding-system: utf-8-unix=0A=0AMajor =
mode: Dashboard=0A=0AMinor modes in effect:=0A global-undo-tree-mode: t=
=0A undo-tree-mode: t=0A marginalia-mode: t=0A which-key-mode: t=0A globa=
l-tree-sitter-mode: t=0A recentf-mode: t=0A treemacs-filewatch-mode: t=0A=
 treemacs-follow-mode: t=0A treemacs-git-mode: t=0A global-git-commit-mod=
e: t=0A magit-auto-revert-mode: t=0A shell-dirtrack-mode: t=0A override-g=
lobal-mode: t=0A vertico-mouse-mode: t=0A vertico-mode: t=0A global-compa=
ny-mode: t=0A company-mode: t=0A pixel-scroll-precision-mode: t=0A xterm-=
mouse-mode: t=0A global-auto-revert-mode: t=0A electric-pair-mode: t=0A d=
elete-selection-mode: t=0A tooltip-mode: t=0A global-eldoc-mode: t=0A sho=
w-paren-mode: t=0A electric-indent-mode: t=0A mouse-wheel-mode: t=0A file=
-name-shadow-mode: t=0A context-menu-mode: t=0A global-font-lock-mode: t=
=0A font-lock-mode: t=0A blink-cursor-mode: t=0A buffer-read-only: t=0A l=
ine-number-mode: t=0A transient-mark-mode: t=0A auto-composition-mode: t=
=0A auto-encryption-mode: t=0A auto-compression-mode: t=0A=0ALoad-path sh=
adows:=0A/home/tralph3/.local/share/emacs/elpa/transient-20230919.2146/tr=
ansient hides /usr/share/emacs/29.1/lisp/transient=0A/home/tralph3/.local=
/share/emacs/elpa/seq-2.24/seq hides /usr/share/emacs/29.1/lisp/emacs-lis=
p/seq=0A=0AFeatures:=0A(shadow sort mail-extr emacsbug mule-util display-=
line-numbers time=0Aorg-tempo tempo eglot external-completion array jsonr=
pc ert ewoc debug=0Abacktrace flymake-proc flymake vterm tramp tramp-load=
defs trampver=0Atramp-integration files-x tramp-compat parse-time iso8601=
 face-remap=0Aterm disp-table ehelp vterm-module term/xterm xterm embark-=
consult=0Aconsult treemacs-bookmarks treemacs-tags magit-bookmark bookmar=
k=0Aembark-org embark multiple-cursors mc-separate-operations=0Arectangul=
ar-region-mode mc-mark-pop mc-edit-lines=0Amc-hide-unmatched-lines-mode m=
c-mark-more mc-cycle-cursors=0Amultiple-cursors-core advice rect undo-tre=
e queue org-fragtog=0Aorg-superstar org-element org-persist xdg org-id or=
g-refile avl-tree org=0Aob ob-tangle ob-ref ob-lob ob-table ob-exp org-ma=
cro org-src ob-comint=0Aorg-pcomplete org-list org-footnote org-faces org=
-entities noutline=0Aoutline ob-emacs-lisp ob-core ob-eval org-cycle org-=
table ol org-fold=0Aorg-fold-core org-keys oc org-loaddefs find-func cal-=
menu calendar=0Acal-loaddefs org-version org-compat org-macs marginalia w=
hich-key=0Atree-sitter-langs tree-sitter-langs-build tar-mode arc-mode ar=
chive-mode=0App tree-sitter-hl tree-sitter tree-sitter-load tree-sitter-c=
li tsc=0Atsc-dyn tsc-dyn-get dired-aux tsc-obsolete dashboard dashboard-w=
idgets=0Arecentf tree-widget wid-edit ffap treemacs treemacs-header-line=
=0Atreemacs-compatibility treemacs-mode treemacs-interface=0Atreemacs-per=
sistence treemacs-filewatch-mode treemacs-follow-mode=0Atreemacs-renderin=
g treemacs-annotations treemacs-async=0Atreemacs-workspaces treemacs-dom =
treemacs-visuals=0Atreemacs-fringe-indicator pulse color treemacs-faces t=
reemacs-icons=0Atreemacs-scope treemacs-themes treemacs-core-utils pfutur=
e inline=0Ahl-line ht treemacs-logging treemacs-customization treemacs-ma=
cros s=0Aorderless magit-submodule magit-blame magit-stash magit-reflog=
=0Amagit-bisect magit-push magit-pull magit-fetch magit-clone magit-remot=
e=0Amagit-commit magit-sequence magit-notes magit-worktree magit-tag=0Ama=
git-merge magit-branch magit-reset magit-files magit-refs magit-status=0A=
magit magit-repos magit-apply magit-wip magit-log which-func imenu=0Amagi=
t-diff smerge-mode diff diff-mode git-commit log-edit message=0Asendmail =
yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa=0Aderived epg=
 rfc6068 epg-config gnus-util time-date mm-decode mm-bodies=0Amm-encode m=
ail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums=0Amail-prsvr mailabb=
rev mail-utils gmm-utils mailheader pcvs-util add-log=0Amagit-core magit-=
autorevert magit-margin magit-transient magit-process=0Awith-editor shell=
 pcomplete server magit-mode transient magit-git=0Amagit-base magit-secti=
on format-spec cursor-sensor crm dash=0Ause-package-bind-key bind-key eas=
y-mmode vertico-mouse vertico compat=0Ayaml-mode lua-mode edmacro kmacro =
dart-mode flutter flutter-l10n=0Aflutter-project rust-utils thingatpt rus=
t-mode rust-rustfmt rust-playpen=0Arust-compile compile text-property-sea=
rch comint ansi-osc ansi-color=0Arust-cargo company-oddmuse company-keywo=
rds company-etags etags fileloop=0Agenerator xref project company-gtags c=
ompany-dabbrev-code=0Acompany-dabbrev company-files company-clang company=
-capf company-cmake=0Acompany-semantic company-template company-bbdb comp=
any all-the-icons=0Aall-the-icons-faces data-material data-weathericons d=
ata-octicons=0Adata-fileicons data-faicons data-alltheicons use-package-e=
nsure=0Ause-package-core system-theme system-theme-theme pixel-scroll cua=
-base=0Aring xt-mouse autorevert filenotify elec-pair delsel comp comp-cs=
tr=0Awarnings icons rx cl-extra help-mode all-the-icons-autoloads=0Acompa=
ny-autoloads corfu-autoloads dart-mode-autoloads=0Adashboard-autoloads di=
rvish-autoloads embark-consult-autoloads=0Aconsult-autoloads embark-autol=
oads flutter-autoloads kind-icon-autoloads=0Alua-mode-autoloads magit-aut=
oloads pcase git-commit-autoloads=0Amarginalia-autoloads multiple-cursors=
-autoloads orderless-autoloads=0Aorg-fragtog-autoloads org-roam-ui-autolo=
ads org-roam-autoloads=0Amagit-section-autoloads emacsql-autoloads org-su=
perstar-autoloads=0Arust-mode-autoloads simple-httpd-autoloads svg-lib-au=
toloads=0Atransient-autoloads tree-sitter-langs-autoloads tree-sitter-aut=
oloads=0Atreemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoload=
s=0Ahydra-autoloads lv-autoloads pfuture-autoloads ace-window-autoloads=
=0Aavy-autoloads s-autoloads dash-autoloads tsc-autoloads=0Aundo-tree-aut=
oloads queue-autoloads vertico-autoloads vterm-autoloads=0Awebsocket-auto=
loads which-key-autoloads with-editor-autoloads info=0Acompat-autoloads s=
eq-autoloads yaml-mode-autoloads package browse-url=0Aurl url-proxy url-p=
rivacy url-expand url-methods url-history url-cookie=0Agenerate-lisp-file=
 url-domsuf url-util mailcap url-handlers url-parse=0Aauth-source cl-seq =
eieio eieio-core cl-macs password-cache json subr-x=0Amap byte-opt gv byt=
ecomp byte-compile url-vars cl-loaddefs cl-lib rmc=0Aiso-transl tooltip c=
conv eldoc paren electric uniquify ediff-hook=0Avc-hooks lisp-float-type =
elisp-mode mwheel term/pgtk-win pgtk-win=0Aterm/common-win pgtk-dnd tool-=
bar dnd fontset image regexp-opt fringe=0Atabulated-list replace newcomme=
nt text-mode lisp-mode prog-mode register=0Apage tab-bar menu-bar rfn-esh=
adow isearch easymenu timer select=0Ascroll-bar mouse jit-lock font-lock =
syntax font-core term/tty-colors=0Aframe minibuffer nadvice seq simple cl=
-generic indonesian philippine=0Acham georgian utf-8-lang misc-lang vietn=
amese tibetan thai tai-viet lao=0Akorean japanese eucjp-ms cp51932 hebrew=
 greek romanian slovak czech=0Aeuropean ethiopic indian cyrillic chinese =
composite emoji-zwj charscript=0Acharprop case-table epa-hook jka-cmpr-ho=
ok help abbrev obarray oclosure=0Acl-preloaded button loaddefs theme-load=
defs faces cus-face macroexp=0Afiles window text-properties overlay sha1 =
md5 base64 format env=0Acode-pages mule custom widget keymap hashtable-pr=
int-readable backquote=0Athreads dbusbind inotify dynamic-setting system-=
font-setting=0Afont-render-setting cairo gtk pgtk lcms2 multi-tty make-ne=
twork-process=0Anative-compile emacs)=0A=0AMemory information:=0A((conses=
 16 446436 331408)=0A (symbols 48 33070 158)=0A (strings 32 125268 59058)=
=0A (string-bytes 1 4550538)=0A (vectors 16 73483)=0A (vector-slots 8 170=
9579 787318)=0A (floats 8 1069 2511)=0A (intervals 56 1048 450)=0A (buffe=
rs 984 14))

----=_RainLoop_375_704826040.1697833639
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><meta http-equiv=3D"Content-Type" content=3D"t=
ext/html; charset=3Dutf-8" /></head><body><div data-html-editor-font-wrap=
per=3D"true" style=3D"font-family: arial, sans-serif; font-size: 13px;">I=
f using =3Ddisplay-line-numbers-mode=3D with the =3Dvisual=3D style set f=
or it,<br>sometimes clicking buttons does not actually click it. It inste=
ad shifts<br>the buffer slightly, either to the left or to the right, and=
 a mark is<br>set (by clicking I refer with the mouse, specifically). You=
 will need to<br>press again in order to actually click the button.<br><b=
r>This is inconsistent, there's no guarantee that it will happen, it<br>s=
ometimes does, but it is often enough for you to be able to notice within=
<br>just a couple of seconds of clicking through things.<br><br>You can l=
aunch =3Demacs -Q=3D and run these two lines:<br><br>(setq display-line-n=
umbers-type 'visual)<br>(global-display-line-numbers-mode)<br><br>Then ju=
st click through buttons. A good test is to open the emacs manual<br>=3DC=
-h R emacs=3D since it has a big index.<br><br>The bug does not happen wi=
th =3Drelative=3D style line numbers.<br><br>In GNU Emacs 29.1 (build 1, =
x86_64-pc-linux-gnu, GTK+ Version 3.24.38,<br>cairo version 1.17.8)<br>Sy=
stem Description: Arch Linux<br><br>Configured using:<br> 'configure --wi=
th-pgtk --with-native-compilation=3Daot --sysconfdir=3D/etc<br> --prefix=
=3D/usr --libexecdir=3D/usr/lib --with-tree-sitter<br> --localstatedir=3D=
/var --with-cairo --disable-build-details<br> --with-harfbuzz --with-libs=
ystemd --with-modules 'CFLAGS=3D-march=3Dx86-64<br> -mtune=3Dgeneric -O2 =
-pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3D2<br> -Wformat -Werro=
r=3Dformat-security -fstack-clash-protection<br> -fcf-protection -g<br> -=
ffile-prefix-map=3D/build/emacs/src=3D/usr/src/debug/emacs -flto=3Dauto'<=
br> 'LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=3D=
auto'<br> 'CXXFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt=
 -fexceptions<br> -Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-sec=
urity<br> -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTI=
ONS -g<br> -ffile-prefix-map=3D/build/emacs/src=3D/usr/src/debug/emacs -f=
lto=3Dauto''<br><br>Configured features:<br>ACL CAIRO DBUS FREETYPE GIF G=
LIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG<br>JSON LCMS2 LIBOTF LIBSYSTEM=
D LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY<br>PDUMPER PGTK PNG RSVG SEC=
COMP SOUND SQLITE3 THREADS TIFF<br>TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X=
IM GTK3 ZLIB<br><br>Important settings:<br> value of $LANG: en_US.UTF-8<b=
r> locale-coding-system: utf-8-unix<br><br>Major mode: Dashboard<br><br>M=
inor modes in effect:<br> global-undo-tree-mode: t<br> undo-tree-mode: t<=
br> marginalia-mode: t<br> which-key-mode: t<br> global-tree-sitter-mode:=
 t<br> recentf-mode: t<br> treemacs-filewatch-mode: t<br> treemacs-follow=
-mode: t<br> treemacs-git-mode: t<br> global-git-commit-mode: t<br> magit=
-auto-revert-mode: t<br> shell-dirtrack-mode: t<br> override-global-mode:=
 t<br> vertico-mouse-mode: t<br> vertico-mode: t<br> global-company-mode:=
 t<br> company-mode: t<br> pixel-scroll-precision-mode: t<br> xterm-mouse=
-mode: t<br> global-auto-revert-mode: t<br> electric-pair-mode: t<br> del=
ete-selection-mode: t<br> tooltip-mode: t<br> global-eldoc-mode: t<br> sh=
ow-paren-mode: t<br> electric-indent-mode: t<br> mouse-wheel-mode: t<br> =
file-name-shadow-mode: t<br> context-menu-mode: t<br> global-font-lock-mo=
de: t<br> font-lock-mode: t<br> blink-cursor-mode: t<br> buffer-read-only=
: t<br> line-number-mode: t<br> transient-mark-mode: t<br> auto-compositi=
on-mode: t<br> auto-encryption-mode: t<br> auto-compression-mode: t<br><b=
r>Load-path shadows:<br>/home/tralph3/.local/share/emacs/elpa/transient-2=
0230919.2146/transient hides /usr/share/emacs/29.1/lisp/transient<br>/hom=
e/tralph3/.local/share/emacs/elpa/seq-2.24/seq hides /usr/share/emacs/29.=
1/lisp/emacs-lisp/seq<br><br>Features:<br>(shadow sort mail-extr emacsbug=
 mule-util display-line-numbers time<br>org-tempo tempo eglot external-co=
mpletion array jsonrpc ert ewoc debug<br>backtrace flymake-proc flymake v=
term tramp tramp-loaddefs trampver<br>tramp-integration files-x tramp-com=
pat parse-time iso8601 face-remap<br>term disp-table ehelp vterm-module t=
erm/xterm xterm embark-consult<br>consult treemacs-bookmarks treemacs-tag=
s magit-bookmark bookmark<br>embark-org embark multiple-cursors mc-separa=
te-operations<br>rectangular-region-mode mc-mark-pop mc-edit-lines<br>mc-=
hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors<br>multiple-curso=
rs-core advice rect undo-tree queue org-fragtog<br>org-superstar org-elem=
ent org-persist xdg org-id org-refile avl-tree org<br>ob ob-tangle ob-ref=
 ob-lob ob-table ob-exp org-macro org-src ob-comint<br>org-pcomplete org-=
list org-footnote org-faces org-entities noutline<br>outline ob-emacs-lis=
p ob-core ob-eval org-cycle org-table ol org-fold<br>org-fold-core org-ke=
ys oc org-loaddefs find-func cal-menu calendar<br>cal-loaddefs org-versio=
n org-compat org-macs marginalia which-key<br>tree-sitter-langs tree-sitt=
er-langs-build tar-mode arc-mode archive-mode<br>pp tree-sitter-hl tree-s=
itter tree-sitter-load tree-sitter-cli tsc<br>tsc-dyn tsc-dyn-get dired-a=
ux tsc-obsolete dashboard dashboard-widgets<br>recentf tree-widget wid-ed=
it ffap treemacs treemacs-header-line<br>treemacs-compatibility treemacs-=
mode treemacs-interface<br>treemacs-persistence treemacs-filewatch-mode t=
reemacs-follow-mode<br>treemacs-rendering treemacs-annotations treemacs-a=
sync<br>treemacs-workspaces treemacs-dom treemacs-visuals<br>treemacs-fri=
nge-indicator pulse color treemacs-faces treemacs-icons<br>treemacs-scope=
 treemacs-themes treemacs-core-utils pfuture inline<br>hl-line ht treemac=
s-logging treemacs-customization treemacs-macros s<br>orderless magit-sub=
module magit-blame magit-stash magit-reflog<br>magit-bisect magit-push ma=
git-pull magit-fetch magit-clone magit-remote<br>magit-commit magit-seque=
nce magit-notes magit-worktree magit-tag<br>magit-merge magit-branch magi=
t-reset magit-files magit-refs magit-status<br>magit magit-repos magit-ap=
ply magit-wip magit-log which-func imenu<br>magit-diff smerge-mode diff d=
iff-mode git-commit log-edit message<br>sendmail yank-media puny dired di=
red-loaddefs rfc822 mml mml-sec epa<br>derived epg rfc6068 epg-config gnu=
s-util time-date mm-decode mm-bodies<br>mm-encode mail-parse rfc2231 rfc2=
047 rfc2045 mm-util ietf-drums<br>mail-prsvr mailabbrev mail-utils gmm-ut=
ils mailheader pcvs-util add-log<br>magit-core magit-autorevert magit-mar=
gin magit-transient magit-process<br>with-editor shell pcomplete server m=
agit-mode transient magit-git<br>magit-base magit-section format-spec cur=
sor-sensor crm dash<br>use-package-bind-key bind-key easy-mmode vertico-m=
ouse vertico compat<br>yaml-mode lua-mode edmacro kmacro dart-mode flutte=
r flutter-l10n<br>flutter-project rust-utils thingatpt rust-mode rust-rus=
tfmt rust-playpen<br>rust-compile compile text-property-search comint ans=
i-osc ansi-color<br>rust-cargo company-oddmuse company-keywords company-e=
tags etags fileloop<br>generator xref project company-gtags company-dabbr=
ev-code<br>company-dabbrev company-files company-clang company-capf compa=
ny-cmake<br>company-semantic company-template company-bbdb company all-th=
e-icons<br>all-the-icons-faces data-material data-weathericons data-octic=
ons<br>data-fileicons data-faicons data-alltheicons use-package-ensure<br=
>use-package-core system-theme system-theme-theme pixel-scroll cua-base<b=
r>ring xt-mouse autorevert filenotify elec-pair delsel comp comp-cstr<br>=
warnings icons rx cl-extra help-mode all-the-icons-autoloads<br>company-a=
utoloads corfu-autoloads dart-mode-autoloads<br>dashboard-autoloads dirvi=
sh-autoloads embark-consult-autoloads<br>consult-autoloads embark-autoloa=
ds flutter-autoloads kind-icon-autoloads<br>lua-mode-autoloads magit-auto=
loads pcase git-commit-autoloads<br>marginalia-autoloads multiple-cursors=
-autoloads orderless-autoloads<br>org-fragtog-autoloads org-roam-ui-autol=
oads org-roam-autoloads<br>magit-section-autoloads emacsql-autoloads org-=
superstar-autoloads<br>rust-mode-autoloads simple-httpd-autoloads svg-lib=
-autoloads<br>transient-autoloads tree-sitter-langs-autoloads tree-sitter=
-autoloads<br>treemacs-autoloads cfrs-autoloads posframe-autoloads ht-aut=
oloads<br>hydra-autoloads lv-autoloads pfuture-autoloads ace-window-autol=
oads<br>avy-autoloads s-autoloads dash-autoloads tsc-autoloads<br>undo-tr=
ee-autoloads queue-autoloads vertico-autoloads vterm-autoloads<br>websock=
et-autoloads which-key-autoloads with-editor-autoloads info<br>compat-aut=
oloads seq-autoloads yaml-mode-autoloads package browse-url<br>url url-pr=
oxy url-privacy url-expand url-methods url-history url-cookie<br>generate=
-lisp-file url-domsuf url-util mailcap url-handlers url-parse<br>auth-sou=
rce cl-seq eieio eieio-core cl-macs password-cache json subr-x<br>map byt=
e-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc<br>iso-tra=
nsl tooltip cconv eldoc paren electric uniquify ediff-hook<br>vc-hooks li=
sp-float-type elisp-mode mwheel term/pgtk-win pgtk-win<br>term/common-win=
 pgtk-dnd tool-bar dnd fontset image regexp-opt fringe<br>tabulated-list =
replace newcomment text-mode lisp-mode prog-mode register<br>page tab-bar=
 menu-bar rfn-eshadow isearch easymenu timer select<br>scroll-bar mouse j=
it-lock font-lock syntax font-core term/tty-colors<br>frame minibuffer na=
dvice seq simple cl-generic indonesian philippine<br>cham georgian utf-8-=
lang misc-lang vietnamese tibetan thai tai-viet lao<br>korean japanese eu=
cjp-ms cp51932 hebrew greek romanian slovak czech<br>european ethiopic in=
dian cyrillic chinese composite emoji-zwj charscript<br>charprop case-tab=
le epa-hook jka-cmpr-hook help abbrev obarray oclosure<br>cl-preloaded bu=
tton loaddefs theme-loaddefs faces cus-face macroexp<br>files window text=
-properties overlay sha1 md5 base64 format env<br>code-pages mule custom =
widget keymap hashtable-print-readable backquote<br>threads dbusbind inot=
ify dynamic-setting system-font-setting<br>font-render-setting cairo gtk =
pgtk lcms2 multi-tty make-network-process<br>native-compile emacs)<br><br=
>Memory information:<br>((conses 16 446436 331408)<br> (symbols 48 33070 =
158)<br> (strings 32 125268 59058)<br> (string-bytes 1 4550538)<br> (vect=
ors 16 73483)<br> (vector-slots 8 1709579 787318)<br> (floats 8 1069 2511=
)<br> (intervals 56 1048 450)<br> (buffers 984 14))<br><br> </div></body>=
</html>

----=_RainLoop_375_704826040.1697833639--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: tomasralph2000@HIDDEN
Subject: bug#66655: Acknowledgement (29.1; Clicking buttons sometimes
 doesn't work)
Message-ID: <handler.66655.B.169783368917586.ack <at> debbugs.gnu.org>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
X-Gnu-PR-Message: ack 66655
X-Gnu-PR-Package: emacs
Reply-To: 66655 <at> debbugs.gnu.org
Date: Fri, 20 Oct 2023 20:29:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 66655 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66655: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66655
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 20 Oct 2023 20:40:02 +0000
Resent-Message-ID: <handler.66655.B66655.169783435019882 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
MIME-Version: 1.0
Date: Fri, 20 Oct 2023 13:38:30 -0700
Message-ID: <CADwFkm=+uXtRmSVbQFja=OnGa0v_8bkiVYScQaVjVEweQUkGFw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

tomasralph2000@HIDDEN writes:

> If using =display-line-numbers-mode= with the =visual= style set for it,
> sometimes clicking buttons does not actually click it. It instead shifts
> the buffer slightly, either to the left or to the right, and a mark is
> set (by clicking I refer with the mouse, specifically). You will need to
> press again in order to actually click the button.
>
> This is inconsistent, there's no guarantee that it will happen, it
> sometimes does, but it is often enough for you to be able to notice within
> just a couple of seconds of clicking through things.
>
> You can launch =emacs -Q= and run these two lines:
>
> (setq display-line-numbers-type 'visual)
> (global-display-line-numbers-mode)
>
> Then just click through buttons. A good test is to open the emacs manual
> =C-h R emacs= since it has a big index.
>
> The bug does not happen with =relative= style line numbers.

I can reproduce this on master, but it did take like 1-2 minutes of
clicking around to trigger it.

I might be making this up, but I feel like I've seen this before --
without `display-line-numbers-mode'.  Perhaps there's some rare bug that
is just more frequently triggered when that mode is on?  But I'm not
really sure about that, it's quite possible that I'm wrong.


In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.7 (Build 21G816)) of 2023-10-18 built on
 Newton.local
Repository revision: 50514298cf98fcd0dfb0d59a7e03b1ebb0d03490
Repository branch: scratch/no-purespace
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.7

Configured using:
 'configure 'LDFLAGS=-L/usr/local/opt/llvm/lib
 -L/usr/local/opt/libffi/lib' 'CPPFLAGS=-I/usr/local/opt/llvm/include
 -I/usr/local/opt/libffi/include''

Configured features:
ACL GIF GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS
PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM ZLIB

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 21 Oct 2023 10:59:01 +0000
Resent-Message-ID: <handler.66655.B66655.169788588216897 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: tomasralph2000@HIDDEN, Stefan Monnier <monnier@HIDDEN>
Cc: 66655 <at> debbugs.gnu.org
Date: Sat, 21 Oct 2023 13:57:21 +0300
Message-Id: <8334y4s0oe.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 (tomasralph2000@HIDDEN)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Fri, 20 Oct 2023 20:27:19 +0000
> From: tomasralph2000@HIDDEN
> 
> If using =display-line-numbers-mode= with the =visual= style set for it,
> sometimes clicking buttons does not actually click it. It instead shifts
> the buffer slightly, either to the left or to the right, and a mark is
> set (by clicking I refer with the mouse, specifically). You will need to
> press again in order to actually click the button.
> 
> This is inconsistent, there's no guarantee that it will happen, it
> sometimes does, but it is often enough for you to be able to notice within
> just a couple of seconds of clicking through things.
> 
> You can launch =emacs -Q= and run these two lines:
> 
> (setq display-line-numbers-type 'visual)
> (global-display-line-numbers-mode)
> 
> Then just click through buttons. A good test is to open the emacs manual
> =C-h R emacs= since it has a big index.

Thanks, should be fixed now on the master branch.

I only tested this in Info buffers, so any testing with other kinds of
buttons/links will be welcome.

Stefan, I'd appreciate your review of the change, as this is a tricky
code, where we already had quite a few changes to avoid interpreting
an up-event as a drag event.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 21 Oct 2023 11:25:02 +0000
Resent-Message-ID: <handler.66655.B66655.169788745320203 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, tomasralph2000@HIDDEN,  Stefan Monnier <monnier@HIDDEN>
Cc: 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169788745320203
          (code B ref 66655); Sat, 21 Oct 2023 11:25:02 +0000
Received: (at 66655) by debbugs.gnu.org; 21 Oct 2023 11:24:13 +0000
Received: from localhost ([127.0.0.1]:42390 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quA5S-0005Fj-7e
	for submit <at> debbugs.gnu.org; Sat, 21 Oct 2023 07:24:12 -0400
Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:54497)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1quA5N-0005F7-4n
 for 66655 <at> debbugs.gnu.org; Sat, 21 Oct 2023 07:24:09 -0400
Received: by mail-lj1-x22a.google.com with SMTP id
 38308e7fff4ca-2c54c8934abso23800971fa.0
 for <66655 <at> debbugs.gnu.org>; Sat, 21 Oct 2023 04:23:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1697887411; x=1698492211; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=u4KoDTRNMbhzsApYRMJ7gUr7S0rb98nWA+nsCP+7wgk=;
 b=CBwafYp0PGqhhwmfmavZeDEqjLxjzeQ15eIP3D5seatd6JVhy0s6jwsnXoQ52WYY5D
 zwIaKkoP4Of8GKh4TT4eNatszeQ9iI8Rg0OWLq/ZiGSMx20oWLGGijzm/z+607QU1/c+
 zMyqlpgikW/tRVJt5R4Kvb4akXXD0fANiPqY0/DWBDz4jwb7FGtW13yVyKiPrL/AhrRq
 31NMTj6FaukobBi5q3EfVuKgkwZXWxGqhI+HLdWWDvgzNfN9nosIfh/KG7IXfbBROQea
 DL5tKjVqSdQB40BGlnveU65RqXEu/l9t++TX3uhyFVcPEnWtR41+YGyBtMJt4PGkAXLh
 aPmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1697887411; x=1698492211;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=u4KoDTRNMbhzsApYRMJ7gUr7S0rb98nWA+nsCP+7wgk=;
 b=VD+zXvCB5e1moohHpzVQPtIeru9Zj/w5ygP60/cYjgnT/vfAyzvxANFzsM9z2zf2zQ
 71YmjZ0YRIl21Xp6qF1PNuT0ltN9wwvD7dyPivv3NXoNqe9KEgpWWLGWyV+Asscmnu4y
 tNo0uIoHmuFDGtoecyRwxQb0WggWJgPmTJfNJwoZyH5ZyEDgvfyG+ZddKgmk/2p+uT12
 mOKki7NEavzxApu2jDWoKzw6Yqd+qwHEdWEyztQUbFmtwxjMO+DG5LfqO2Lm3ke9dpa2
 pEU64x9WBs6K0uuLOJyClC3Ev0iVZZAolW8GeI057pPnuiwVKYFzKu4/aldKLO2AJBVJ
 MnjQ==
X-Gm-Message-State: AOJu0YyoC8iAW2U2y+oIPBKSF3xWQYAfBVtucO5coFUHFhtWFgo//BWg
 Hwg8y10EEJ4ge/zfZop0S6SeEnZyT3LykMEK454=
X-Google-Smtp-Source: AGHT+IH1GpN3RwXDz5PCG7Xqn1G3CcCRMqp2wQiT0ssFh2kmlVJOTf8vaFHHOLY6HIBTDBcFBy1x8IOfpJd1N1+8FFo=
X-Received: by 2002:a2e:bc12:0:b0:2c5:8b1:7561 with SMTP id
 b18-20020a2ebc12000000b002c508b17561mr3911639ljf.10.1697887411352; Sat, 21
 Oct 2023 04:23:31 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 21 Oct 2023 04:23:30 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8334y4s0oe.fsf@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 21 Oct 2023 04:23:30 -0700
Message-ID: <CADwFkmkG6xq_gQxVP7vBnGu1AQ9Y5hRor_vWAwwh1EmmeiyS8A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> Stefan, I'd appreciate your review of the change, as this is a tricky
> code, where we already had quite a few changes to avoid interpreting
> an up-event as a drag event.

I can't see the change on master.  Did you forget to push perhaps?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 21 Oct 2023 11:36:02 +0000
Resent-Message-ID: <handler.66655.B66655.169788812631805 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169788812631805
          (code B ref 66655); Sat, 21 Oct 2023 11:36:02 +0000
Received: (at 66655) by debbugs.gnu.org; 21 Oct 2023 11:35:26 +0000
Received: from localhost ([127.0.0.1]:42414 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quAGI-0008Gq-2Y
	for submit <at> debbugs.gnu.org; Sat, 21 Oct 2023 07:35:25 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55392)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1quAGD-0008GX-Ef
 for 66655 <at> debbugs.gnu.org; Sat, 21 Oct 2023 07:35:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1quAFf-0002HI-H0; Sat, 21 Oct 2023 07:34:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=EFPYLEGQcmRggUD8cKwqbITaiBZRz3xiWO+pR4HXDl8=; b=CmcZtR+GkhU1
 yBb/4LzhnOmHRLycXN/7UeUg2D0drOO5UziCK4ylide9D+6Zu5N6ZYXs5M+BCjYIA31hL+AzHHq6S
 Ng4pMGkZNIH8VGIcRvXFoMfjvjAoWTzriGnz2F58SrkFFBRnHyMDxElgN2mU3rYpwHooLE7yOEgOv
 7/1C5yMqQrbXdSsf+8Ai1GzHm7At9rpRQYXsRf8oFYFaBKehznTmaqZBw6v4ptLkfJGJmZtGgaJAY
 f9/iaTdMhgSU1ZnP7GBIgoSksMcfOKcUs86EOKc1uCvXyRsqJS3S8eIW/yaA69X/LvuHgA1rGgHVq
 gktyvbRiVzHU0HQFepaUyw==;
Date: Sat, 21 Oct 2023 14:34:41 +0300
Message-Id: <83ttqkqkdq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmkG6xq_gQxVP7vBnGu1AQ9Y5hRor_vWAwwh1EmmeiyS8A@HIDDEN>
 (message from Stefan Kangas on Sat, 21 Oct 2023 04:23:30 -0700)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN>
 <CADwFkmkG6xq_gQxVP7vBnGu1AQ9Y5hRor_vWAwwh1EmmeiyS8A@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Sat, 21 Oct 2023 04:23:30 -0700
> Cc: 66655 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > Stefan, I'd appreciate your review of the change, as this is a tricky
> > code, where we already had quite a few changes to avoid interpreting
> > an up-event as a drag event.
> 
> I can't see the change on master.  Did you forget to push perhaps?

Oops.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 21 Oct 2023 12:07:02 +0000
Resent-Message-ID: <handler.66655.B66655.16978899783442 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, tomasralph2000@HIDDEN,  Stefan Monnier <monnier@HIDDEN>
Cc: 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.16978899783442
          (code B ref 66655); Sat, 21 Oct 2023 12:07:02 +0000
Received: (at 66655) by debbugs.gnu.org; 21 Oct 2023 12:06:18 +0000
Received: from localhost ([127.0.0.1]:42453 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quAkE-0000tR-0F
	for submit <at> debbugs.gnu.org; Sat, 21 Oct 2023 08:06:18 -0400
Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:60727)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1quAk8-0000sv-75
 for 66655 <at> debbugs.gnu.org; Sat, 21 Oct 2023 08:06:13 -0400
Received: by mail-lj1-x22b.google.com with SMTP id
 38308e7fff4ca-2bfed7c4e6dso25294211fa.1
 for <66655 <at> debbugs.gnu.org>; Sat, 21 Oct 2023 05:05:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1697889938; x=1698494738; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=o3/Fv0G2MTcSQBytbXqm4Lj4BDtOmVAzubW7k4rWTqo=;
 b=Y6StiBI1op3qKSl/zrTu+a+/yBf6eLP8rdf5MfTtkeSkjK14VUh+xkydv6fjEHflhv
 HWwN5/uFZq6UpuC5AtiFKE+qP8yGyS8Qwv1WmVmcIx5OIyXjIP0v19tdJRCRyHKR8hfN
 BwHEcsaN5AbKtaLWmtK723PJ3FvXT90Wxgf4b9/WG8Pe1+U+c191sJcc0RWou1+Udqiz
 SBBrml9/NlBFJ24uabQAJvchN3Jr4Y2lBSd5a6zEyUT8gRGRQ5QlksrpVRXNw3ff/+Wr
 eHSt59rV0Cx6vdy1T2tOErrankoFXk3TsJX3D5S0gLLUtDxQIk4Z6W/oOxP4nZjVYwzW
 6SQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1697889938; x=1698494738;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=o3/Fv0G2MTcSQBytbXqm4Lj4BDtOmVAzubW7k4rWTqo=;
 b=tjQrxp5Vx9qYp+1tXlw0a5cjPeiNTA6Jdcnren9sIMPceV/oJ1dZO4orTEnTIGUCb9
 p6Tl0ycbfqRnAZvrXqxnj1qEX1Zyv+9xDA6LbH91qqpqW1Y5uXJdFH2VFBbPuDnSQYbU
 reNbZjSC44Vw7fX94Sqh4e4pZqhapDXLLuSpfiZg9O/8fXqXByAVS6dcvyUj0hdPSdYY
 CJdFZw7+4qea4hUPdImTFY1xP/V1mlCUPu24sZpGZR3LtqUWyXGcJCph5MvCi9sszVVJ
 JGXsHLJ3107KX8cLTjHHRU+CAVODQ5id/BK4C7Vi/7XEkAzmqmgtHbbukI6vAAeNgBGD
 HVEA==
X-Gm-Message-State: AOJu0Ywr1tKx2c4PMdiBLguolS099dZEh/GqGlb2Vrd+cncoGmWc5zVd
 SupEkXclaXmvqt3x4ujhN6qM8ptFYnCL4Jrd4AY=
X-Google-Smtp-Source: AGHT+IGq3bnSX/pMJV5IZy7hRgvlIy6hnCV6lii46z3v9PbLjvicBhrhvfc/fx5TyrjKDMUbsv1KrPrdf9/sdr8Dw8s=
X-Received: by 2002:a05:651c:1986:b0:2c0:afd:e7ed with SMTP id
 bx6-20020a05651c198600b002c00afde7edmr3773978ljb.10.1697889938408; Sat, 21
 Oct 2023 05:05:38 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 21 Oct 2023 05:05:38 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8334y4s0oe.fsf@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 21 Oct 2023 05:05:38 -0700
Message-ID: <CADwFkmn+KH53q5OnmfdWJx5kaiEp0gyKkUcghGDuCpYDS7Q2XQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 66655 fixed
thanks

Eli Zaretskii <eliz@HIDDEN> writes:

> Thanks, should be fixed now on the master branch.

I'm adding the fixed tag.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Oct 2023 12:06:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 21 08:06:14 2023
Received: from localhost ([127.0.0.1]:42451 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quAk9-0000t9-Nj
	for submit <at> debbugs.gnu.org; Sat, 21 Oct 2023 08:06:13 -0400
Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:61819)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1quAk8-0000su-7H
 for control <at> debbugs.gnu.org; Sat, 21 Oct 2023 08:06:12 -0400
Received: by mail-lj1-x229.google.com with SMTP id
 38308e7fff4ca-2c51388ccebso25091821fa.3
 for <control <at> debbugs.gnu.org>; Sat, 21 Oct 2023 05:05:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1697889938; x=1698494738; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=o3/Fv0G2MTcSQBytbXqm4Lj4BDtOmVAzubW7k4rWTqo=;
 b=Y6StiBI1op3qKSl/zrTu+a+/yBf6eLP8rdf5MfTtkeSkjK14VUh+xkydv6fjEHflhv
 HWwN5/uFZq6UpuC5AtiFKE+qP8yGyS8Qwv1WmVmcIx5OIyXjIP0v19tdJRCRyHKR8hfN
 BwHEcsaN5AbKtaLWmtK723PJ3FvXT90Wxgf4b9/WG8Pe1+U+c191sJcc0RWou1+Udqiz
 SBBrml9/NlBFJ24uabQAJvchN3Jr4Y2lBSd5a6zEyUT8gRGRQ5QlksrpVRXNw3ff/+Wr
 eHSt59rV0Cx6vdy1T2tOErrankoFXk3TsJX3D5S0gLLUtDxQIk4Z6W/oOxP4nZjVYwzW
 6SQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1697889938; x=1698494738;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=o3/Fv0G2MTcSQBytbXqm4Lj4BDtOmVAzubW7k4rWTqo=;
 b=tbHdxeCNTV9DS3rNr697k/grsrd1bYbREhcKx30RuYmLLSLj0fQHOZXLSFo7VW2rtN
 4pbzbQTrJTAlA5Xr2N9wHUx7pWmG8cvs+v3Sgt+pZtX3WOKiQLrgvRHtSttnfBIZyRBa
 xWt1hCZcrF1twuNYSzsd9WbxP6li9c7wqmLQUFSNPWPQTVYR+Rr547aMFw+VC+K/70UW
 fXSFFWyCINbZ79ju1t9fiW2U+l6vfPtmmnQ7DnTFBmHXe23/yetVpbTV88XeRCOpJigx
 MyXza2pxCuAIt98Yq8dpjqvVh+dtl+0exYJBxI9I5LCEo3dAl03k2WcjoIzdn6cq7BWP
 jv5Q==
X-Gm-Message-State: AOJu0YzJUkO5S/4dX/r51ISw0XESEt5h4G5Ji33HXN1VNeeMHMlO+0Gg
 Z/Q4WTGPfAG+oXgarI0e4SwhJ6irLRXX69jSp7U=
X-Google-Smtp-Source: AGHT+IGq3bnSX/pMJV5IZy7hRgvlIy6hnCV6lii46z3v9PbLjvicBhrhvfc/fx5TyrjKDMUbsv1KrPrdf9/sdr8Dw8s=
X-Received: by 2002:a05:651c:1986:b0:2c0:afd:e7ed with SMTP id
 bx6-20020a05651c198600b002c00afde7edmr3773978ljb.10.1697889938408; Sat, 21
 Oct 2023 05:05:38 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 21 Oct 2023 05:05:38 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8334y4s0oe.fsf@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 21 Oct 2023 05:05:38 -0700
Message-ID: <CADwFkmn+KH53q5OnmfdWJx5kaiEp0gyKkUcghGDuCpYDS7Q2XQ@HIDDEN>
Subject: Re: bug#66655: 29.1; Clicking buttons sometimes doesn't work
To: Eli Zaretskii <eliz@HIDDEN>, tomasralph2000@HIDDEN, 
 Stefan Monnier <monnier@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Bcc: control <at> debbugs.gnu.org
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 66655 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 66655 fixed
thanks

Eli Zaretskii <eliz@HIDDEN> writes:

> Thanks, should be fixed now on the master branch.

I'm adding the fixed tag.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Oct 2023 16:42:01 +0000
Resent-Message-ID: <handler.66655.B66655.169807928412657 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169807928412657
          (code B ref 66655); Mon, 23 Oct 2023 16:42:01 +0000
Received: (at 66655) by debbugs.gnu.org; 23 Oct 2023 16:41:24 +0000
Received: from localhost ([127.0.0.1]:51452 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quxzX-0003I4-Je
	for submit <at> debbugs.gnu.org; Mon, 23 Oct 2023 12:41:23 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52680)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1quxzV-0003Hp-Av
 for 66655 <at> debbugs.gnu.org; Mon, 23 Oct 2023 12:41:22 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B134C442AF6;
 Mon, 23 Oct 2023 12:40:46 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698079245;
 bh=uNFr8zL9rLj9bbbjVOh7RZaRZGU7oHnq1obp/8d6XCQ=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=B2ZG08pQDXKrxXnkRCIf1avdf/vGbbHVtoaff5rtGQPvyGxVbuY7L1vRECJG5ZbEQ
 GMYQYVsg22DauzA+UKwuqKb2/GHduwptlIz7Ydxi2Qr/1TRVsaiUw4DiTCIVSH4GU9
 UsFQ02SY95qW651NR0hsmY1XsN2tCnos17PujgBZUgRdFDi644C5Mhwq3Ypr0craDu
 zkv7s75I+jXzx6rPipSHPChC5rOlpSwPKq9Au7Thc3+ixaG9oFvaVkIWTVH+gQ8m3R
 R1f14Qjx4w9PM5fmU9kWLDbHxgoUfLbPiuU7jvTLpBgpGenbYXk3yoOEK9Fu6P6VUy
 MGptHkwKlVx0A==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2CD3A442AEC;
 Mon, 23 Oct 2023 12:40:45 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1D305120376;
 Mon, 23 Oct 2023 12:40:45 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <8334y4s0oe.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 21 Oct
 2023 13:57:21 +0300")
Message-ID: <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN>
Date: Mon, 23 Oct 2023 12:38:35 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.102 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Stefan, I'd appreciate your review of the change, as this is a tricky
> code, where we already had quite a few changes to avoid interpreting
> an up-event as a drag event.

The change looks OK.  But yeah, it does feel like adding yet an
other hack.  The whole:

		       /* Maybe the mouse has moved a lot, caused scrolling, and
			  eventually ended up at the same screen position (but
			  not buffer position) in which case it is a drag, not
			  a click.  */
		       /* FIXME: OTOH if the buffer position has changed
			  because of a timer or process filter rather than
			  because of mouse movement, it should be considered as
			  a click.  But mouse-drag-region completely ignores
			  this case and it hasn't caused any real problem, so
			  it's probably OK to ignore it as well.  */
		       && (EQ (Fcar (Fcdr (start_pos)),
			       Fcar (Fcdr (position))) /* Same buffer pos */
			   /* Redisplay hscrolled text between down- and
                              up-events due to display-line-numbers-mode.  */
			   || line_number_mode_hscroll (start_pos, position)
			   || !EQ (Fcar (start_pos),
				   Fcar (position))))) /* Different window */

is unsatisfactory.  But it's not clear what is the right way to look at
the problem.  As the comment says, we generally want "down+scroll+up" to
be treated as a drag, but not in the current case.  I think the
difference relies on what caused the scroll: if the scroll was the
result of a deliberate act by the user (they moved the mouse after
`down` to cause a scroll), then it's a drag and else it's not?


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Oct 2023 18:32:01 +0000
Resent-Message-ID: <handler.66655.B66655.169808587924164 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Stefan Monnier <monnier@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169808587924164
          (code B ref 66655); Mon, 23 Oct 2023 18:32:01 +0000
Received: (at 66655) by debbugs.gnu.org; 23 Oct 2023 18:31:19 +0000
Received: from localhost ([127.0.0.1]:51656 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1quzhv-0006Hg-7H
	for submit <at> debbugs.gnu.org; Mon, 23 Oct 2023 14:31:19 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36368)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1quzhq-0006HQ-1T
 for 66655 <at> debbugs.gnu.org; Mon, 23 Oct 2023 14:31:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1quzhG-00034I-MV; Mon, 23 Oct 2023 14:30:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=2Dq5qdsCSQTxQj3D54wweJerH/hOFFK3/o30V1USGbg=; b=Q1jYieKp5paE
 jVj2Y3JT/ZR1MyVWTNJszJJb7svPpPxKubFu52q+jKDn28GZ94/0z5cPxVng0yQ5RTTpH/CmUoPeu
 DLpMdJLwEUZJGtDGx9Mj60SSIjgUKEU4bVbySxT2m68Q8QteA117wjMk/qNx3y4SghF2RWtbAGJx+
 3gIHP4a6N9ypHLWHjDP2WCBj7K/TamKtoBE8ECwvgsIb5yCT2T7ku1qeKKFLzrm+WNYD6tfrWxse3
 5WFBzuC4+95ak33i5xTLBvVv+fRsvUkIfnXDs7wgjenfqhl3oxgVGX/XYkstd9hqStOR5R1Aoz8z/
 PAEcWMTQBraGm6fL6e6pWA==;
Date: Mon, 23 Oct 2023 21:30:38 +0300
Message-Id: <83v8axmbsh.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Mon, 23 Oct 2023 12:38:35 -0400)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
> Date: Mon, 23 Oct 2023 12:38:35 -0400
> 
> > Stefan, I'd appreciate your review of the change, as this is a tricky
> > code, where we already had quite a few changes to avoid interpreting
> > an up-event as a drag event.
> 
> The change looks OK.  But yeah, it does feel like adding yet an
> other hack.  The whole:
> 
> 		       /* Maybe the mouse has moved a lot, caused scrolling, and
> 			  eventually ended up at the same screen position (but
> 			  not buffer position) in which case it is a drag, not
> 			  a click.  */
> 		       /* FIXME: OTOH if the buffer position has changed
> 			  because of a timer or process filter rather than
> 			  because of mouse movement, it should be considered as
> 			  a click.  But mouse-drag-region completely ignores
> 			  this case and it hasn't caused any real problem, so
> 			  it's probably OK to ignore it as well.  */
> 		       && (EQ (Fcar (Fcdr (start_pos)),
> 			       Fcar (Fcdr (position))) /* Same buffer pos */
> 			   /* Redisplay hscrolled text between down- and
>                               up-events due to display-line-numbers-mode.  */
> 			   || line_number_mode_hscroll (start_pos, position)
> 			   || !EQ (Fcar (start_pos),
> 				   Fcar (position))))) /* Different window */
> 
> is unsatisfactory.  But it's not clear what is the right way to look at
> the problem.  As the comment says, we generally want "down+scroll+up" to
> be treated as a drag, but not in the current case.  I think the
> difference relies on what caused the scroll: if the scroll was the
> result of a deliberate act by the user (they moved the mouse after
> `down` to cause a scroll), then it's a drag and else it's not?

Yes, that's the logic here.  Technically, it happens because clicking
the mouse emits 2 events: down-mouse-1 followed by another one caused
by releasing the mouse button, and the first event could cause
redisplay (as happens in this case) because it generally moves point
to the location of the click.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Oct 2023 22:39:01 +0000
Resent-Message-ID: <handler.66655.B66655.16981007375439 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.16981007375439
          (code B ref 66655); Mon, 23 Oct 2023 22:39:01 +0000
Received: (at 66655) by debbugs.gnu.org; 23 Oct 2023 22:38:57 +0000
Received: from localhost ([127.0.0.1]:52486 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qv3ZZ-0001Pe-Hx
	for submit <at> debbugs.gnu.org; Mon, 23 Oct 2023 18:38:57 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4022)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qv3ZW-0001PQ-KN
 for 66655 <at> debbugs.gnu.org; Mon, 23 Oct 2023 18:38:55 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 052F1807D1;
 Mon, 23 Oct 2023 18:38:20 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698100698;
 bh=I+uT2xtL+iYrNVovbx9lFBJAUmMjzC3TJQWKfycrzVY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=OTPw2Dr/pZmX5QkdXNbKi7mlDGBda+nDT2J/YHjD4pWL1du5IuqjzFNSrj9fo0lCD
 P0EAsJRH53AqD0DlZzjnRERc/v5CCTANwr98/Z1X4eiOHvlRoqN2KyAdbZNuhMrklq
 4LviYs7WH0owV8WbyLDq1AiVVq17bMaH6awpOA0OAt3GV7idrMipgDAF2wwcQAlnfK
 MgjzDdBpyjmm2VKWZ9wRO1Q7r8tgkbQJc7ZbrzVu6pxK0xuOJsDx6X02QYfVVzZs7U
 qEeA/6NqIoFBztV7JAOoNarIaoebvcJx2iSJvxQ4OJLKNJKs9MlQzZGAJzoidysZRv
 W6lOmIhUrPVTA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B5D0A8044C;
 Mon, 23 Oct 2023 18:38:18 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A94441207CC;
 Mon, 23 Oct 2023 18:38:18 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83v8axmbsh.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 23 Oct
 2023 21:30:38 +0300")
Message-ID: <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN>
Date: Mon, 23 Oct 2023 18:36:11 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.071 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Yes, that's the logic here.  Technically, it happens because clicking
> the mouse emits 2 events: down-mouse-1 followed by another one caused
> by releasing the mouse button, and the first event could cause
> redisplay (as happens in this case) because it generally moves point
> to the location of the click.

So maybe, in order to upgrade an `up` to a `drag` we should check that:
- the end (buffer) position is different.
- and the mouse has actually moved.
Currently we detect a mouse-has-moved when the start and end (screen)
position of the mouse are different, but maybe we should additionally
set a flag when the mouse is moved, so that it's still considered as
"moved" if the mouse returns to its initial (screen) position?


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 23 Oct 2023 23:04:01 +0000
Resent-Message-ID: <handler.66655.B66655.16981022198120 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.16981022198120
          (code B ref 66655); Mon, 23 Oct 2023 23:04:01 +0000
Received: (at 66655) by debbugs.gnu.org; 23 Oct 2023 23:03:39 +0000
Received: from localhost ([127.0.0.1]:52502 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qv3xS-00026t-A3
	for submit <at> debbugs.gnu.org; Mon, 23 Oct 2023 19:03:38 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qv3xQ-00026f-1M
 for 66655 <at> debbugs.gnu.org; Mon, 23 Oct 2023 19:03:37 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3130C100167;
 Mon, 23 Oct 2023 19:03:01 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698102179;
 bh=YtLtdE3IKkOhtbhRYwjNTxQ6yLI6xjBz11dENFL1WZo=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=PvUeJNzK8Ow+z0mTOfwQLcY8hgJYp+53sVVo6jVT5Ast2kfAJShYeJ3/pP5qqyXWo
 14eNdGE7OIitr/BTrLTEa2B8ZX8ZEOyDXQjvmZ2uCQA2h64aIx4dt9i5y87Asc6y+G
 QakQ7a8SEjhzZr0IJeh4jINQO2ZxmQJpLpgyh3qr1A5oRMINEuS0JbWGBjzfpecab/
 FrtQknKrYj0v33exHwfXxnr1m4RaoqKsyJP0SxdbPhyacR4yKzeAwnw3RNAI77FkC5
 dLWPLOEUq2IShEnOQORBOdcajFjgJpkyNk8Hz9+F8Ti+Id5EIprZUgKsT9UQk7vBag
 a84NmPkoGFLWQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C8D1C100043;
 Mon, 23 Oct 2023 19:02:59 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BAC561201E3;
 Mon, 23 Oct 2023 19:02:59 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83v8axmbsh.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 23 Oct
 2023 21:30:38 +0300")
Message-ID: <jwvil6xlzmj.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN>
Date: Mon, 23 Oct 2023 19:00:53 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.070 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain

Eli Zaretskii [2023-10-23 21:30:38] wrote:

>> From: Stefan Monnier <monnier@HIDDEN>
>> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
>> Date: Mon, 23 Oct 2023 12:38:35 -0400
>> 
>> > Stefan, I'd appreciate your review of the change, as this is a tricky
>> > code, where we already had quite a few changes to avoid interpreting
>> > an up-event as a drag event.
>> 
>> The change looks OK.  But yeah, it does feel like adding yet an
>> other hack.  The whole:
>> 
>> 		       /* Maybe the mouse has moved a lot, caused scrolling, and
>> 			  eventually ended up at the same screen position (but
>> 			  not buffer position) in which case it is a drag, not
>> 			  a click.  */
>> 		       /* FIXME: OTOH if the buffer position has changed
>> 			  because of a timer or process filter rather than
>> 			  because of mouse movement, it should be considered as
>> 			  a click.  But mouse-drag-region completely ignores
>> 			  this case and it hasn't caused any real problem, so
>> 			  it's probably OK to ignore it as well.  */
>> 		       && (EQ (Fcar (Fcdr (start_pos)),
>> 			       Fcar (Fcdr (position))) /* Same buffer pos */
>> 			   /* Redisplay hscrolled text between down- and
>>                               up-events due to display-line-numbers-mode.  */
>> 			   || line_number_mode_hscroll (start_pos, position)
>> 			   || !EQ (Fcar (start_pos),
>> 				   Fcar (position))))) /* Different window */
>> 
>> is unsatisfactory.  But it's not clear what is the right way to look at
>> the problem.  As the comment says, we generally want "down+scroll+up" to
>> be treated as a drag, but not in the current case.  I think the
>> difference relies on what caused the scroll: if the scroll was the
>> result of a deliberate act by the user (they moved the mouse after
>> `down` to cause a scroll), then it's a drag and else it's not?
>
> Yes, that's the logic here.  Technically, it happens because clicking
> the mouse emits 2 events: down-mouse-1 followed by another one caused
> by releasing the mouse button, and the first event could cause
> redisplay (as happens in this case) because it generally moves point
> to the location of the click.

How 'bout something like the 100% untested patch below?

Basically, generate a drag only if all 3 are satisfied:
- the mouse has moved (and maybe come back).
- the buffer position has changed.
- the window has not changed (not sure why we have that, but IIUC
  that's a constraint we have on drag events).
And to check the first we simply "mess up" the remembered start position
whenever we emit a mouse-movement.


        Stefan

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=drag.patch

diff --git a/src/keyboard.c b/src/keyboard.c
index dc2f78a7c26..43d5b085857 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -5530,10 +5530,7 @@ #define ISO_FUNCTION_KEY_OFFSET 0xfe00
 /* A cons recording the original frame-relative x and y coordinates of
    the down mouse event.  */
 static Lisp_Object frame_relative_event_pos;
-
-/* The line-number display width, in columns, at the time of most
-   recent down mouse event.  */
-static int down_mouse_line_number_width;
+static bool mouse_has_moved;
 
 /* Information about the most recent up-going button event:  Which
    button, what location, and what time.  */
@@ -5931,57 +5928,6 @@ coords_in_tab_bar_window (struct frame *f, int x, int y)
 
 #endif /* HAVE_WINDOW_SYSTEM */
 
-static void
-save_line_number_display_width (struct input_event *event)
-{
-  struct window *w;
-  int pixel_width;
-
-  if (WINDOWP (event->frame_or_window))
-    w = XWINDOW (event->frame_or_window);
-  else if (FRAMEP (event->frame_or_window))
-    w = XWINDOW (XFRAME (event->frame_or_window)->selected_window);
-  else
-    w = XWINDOW (selected_window);
-  line_number_display_width (w, &down_mouse_line_number_width, &pixel_width);
-}
-
-/* Return non-zero if the change of position from START_POS to END_POS
-   is likely to be the effect of horizontal scrolling due to a change
-   in line-number width produced by redisplay between two mouse
-   events, like mouse-down followed by mouse-up, at those positions.
-   This is used to decide whether to converts mouse-down followed by
-   mouse-up event into a mouse-drag event.  */
-static bool
-line_number_mode_hscroll (Lisp_Object start_pos, Lisp_Object end_pos)
-{
-  if (!EQ (Fcar (start_pos), Fcar (end_pos)) /* different window */
-      || list_length (start_pos) < 7	     /* no COL/ROW info */
-      || list_length (end_pos) < 7)
-    return false;
-
-  Lisp_Object start_col_row = Fnth (make_fixnum (6), start_pos);
-  Lisp_Object end_col_row = Fnth (make_fixnum (6), end_pos);
-  Lisp_Object window = Fcar (end_pos);
-  int col_width, pixel_width;
-  Lisp_Object start_col, end_col;
-  struct window *w;
-  if (!WINDOW_VALID_P (window))
-    {
-      if (WINDOW_LIVE_P (window))
-	window = XFRAME (window)->selected_window;
-      else
-	window = selected_window;
-    }
-  w = XWINDOW (window);
-  line_number_display_width (w, &col_width, &pixel_width);
-  start_col = Fcar (start_col_row);
-  end_col = Fcar (end_col_row);
-  return EQ (start_col, end_col)
-	 && down_mouse_line_number_width >= 0
-	 && col_width != down_mouse_line_number_width;
-}
-
 /* Given a struct input_event, build the lisp event which represents
    it.  If EVENT is 0, build a mouse movement event from the mouse
    movement buffer, which should have a movement event in it.
@@ -6383,9 +6329,8 @@ make_lispy_event (struct input_event *event)
 	    button_down_time = event->timestamp;
 	    *start_pos_ptr = Fcopy_alist (position);
 	    frame_relative_event_pos = Fcons (event->x, event->y);
+	    mouse_has_moved = false;
 	    ignore_mouse_drag_p = false;
-	    /* Squirrel away the line-number width, if any.  */
-	    save_line_number_display_width (event);
 	  }
 
 	/* Now we're releasing a button - check the coordinates to
@@ -6415,34 +6360,18 @@ make_lispy_event (struct input_event *event)
 		  - XFIXNUM (XCDR (frame_relative_event_pos));
 
 		if (! (0 < double_click_fuzz
+		       && !mouse_has_moved
 		       && - double_click_fuzz < xdiff
 		       && xdiff < double_click_fuzz
 		       && - double_click_fuzz < ydiff
-		       && ydiff < double_click_fuzz
-		       /* Maybe the mouse has moved a lot, caused scrolling, and
-			  eventually ended up at the same screen position (but
-			  not buffer position) in which case it is a drag, not
-			  a click.  */
-		       /* FIXME: OTOH if the buffer position has changed
-			  because of a timer or process filter rather than
-			  because of mouse movement, it should be considered as
-			  a click.  But mouse-drag-region completely ignores
-			  this case and it hasn't caused any real problem, so
-			  it's probably OK to ignore it as well.  */
-		       && (EQ (Fcar (Fcdr (start_pos)),
-			       Fcar (Fcdr (position))) /* Same buffer pos */
-			   /* Redisplay hscrolled text between down- and
-                              up-events due to display-line-numbers-mode.  */
-			   || line_number_mode_hscroll (start_pos, position)
-			   || !EQ (Fcar (start_pos),
-				   Fcar (position))))) /* Different window */
-
+		       && ydiff < double_click_fuzz)
+		     && (!EQ (Fcar (Fcdr (start_pos)),
+			      Fcar (Fcdr (position)))) /* Different buffer pos */
+		     && EQ (Fcar (start_pos), Fcar (position))) /* Same window */
 		  {
 		    /* Mouse has moved enough.  */
 		    button_down_time = 0;
 		    click_or_drag_modifier = drag_modifier;
-		    /* Reset the value for future clicks.  */
-		    down_mouse_line_number_width = -1;
 		  }
 		else if (((!EQ (Fcar (start_pos), Fcar (position)))
 			  || (!EQ (Fcar (Fcdr (start_pos)),
@@ -7084,6 +7013,7 @@ make_lispy_movement (struct frame *frame, Lisp_Object bar_window, enum scroll_ba
     {
       Lisp_Object position;
       position = make_lispy_position (frame, x, y, t);
+      mouse_has_moved = true;
       return list2 (Qmouse_movement, position);
     }
 }

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 12:15:02 +0000
Resent-Message-ID: <handler.66655.B66655.169814969912734 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Stefan Monnier <monnier@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169814969912734
          (code B ref 66655); Tue, 24 Oct 2023 12:15:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 12:14:59 +0000
Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvGJH-0003JJ-1K
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 08:14:59 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48128)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qvGJD-0003J2-Cn
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 08:14:58 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qvGIe-0003ix-Ca; Tue, 24 Oct 2023 08:14:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=d+4NU+1f420TS+XI9EAttHnf2mDO+PzNPM4Y3syXqUI=; b=CaJTsfm1eLrC
 sSr5ri3KoWxDjkt1aitYZ1f/+sbRXgb5P4VIyjmZperky/UvDDiizEmNt0vZOnnaDXbVKx4jnavo0
 5Ke434kLoTzT2U/PEAM4xDHLb4/pBIAJy7kChChDj3DeFynQzRf8ItUi5N1C8l87Daf6C9PIjSror
 BcDr45cB1EBRWVIfBsmw3cnPzMq6pVvQMULpX3NsTTjQaRLv/926hJH9yhPESknqRsBWkO3EijP68
 HamWxtWqIxYw4tTNxLaTq/rqj5qb3NHzuaI+33q3VRbib9dboifCGqz4jvj/CpNrXNXS4fbKn48Li
 9+o0nrobUpjVKu3KZ9Hxrw==;
Date: Tue, 24 Oct 2023 15:14:24 +0300
Message-Id: <83y1fskyjj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Mon, 23 Oct 2023 18:36:11 -0400)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
> Date: Mon, 23 Oct 2023 18:36:11 -0400
> 
> > Yes, that's the logic here.  Technically, it happens because clicking
> > the mouse emits 2 events: down-mouse-1 followed by another one caused
> > by releasing the mouse button, and the first event could cause
> > redisplay (as happens in this case) because it generally moves point
> > to the location of the click.
> 
> So maybe, in order to upgrade an `up` to a `drag` we should check that:
> - the end (buffer) position is different.
> - and the mouse has actually moved.

How do you do the latter in a way that still supports arbitrary values
in double-click-fuzz?

> Currently we detect a mouse-has-moved when the start and end (screen)
> position of the mouse are different, but maybe we should additionally
> set a flag when the mouse is moved, so that it's still considered as
> "moved" if the mouse returns to its initial (screen) position?

What will that do if the mouse was moved, then returned to the
original position before the button is released?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 13:45:02 +0000
Resent-Message-ID: <handler.66655.B66655.169815510122509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815510122509
          (code B ref 66655); Tue, 24 Oct 2023 13:45:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 13:45:01 +0000
Received: from localhost ([127.0.0.1]:53482 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvHiO-0005qz-Sm
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:45:01 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56377)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qvHiL-0005qk-PT
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:44:59 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 996E110013E;
 Tue, 24 Oct 2023 09:44:22 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698155061;
 bh=fRHXK+huguE7JzNry8mdq2Y2DbBd6lTPEo4Ic7wyBZo=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Aq5LmmDChpkZom+0VgqUEph2xb9HtmqHUVUZO5DBviRQ7Cy9iqrh/rSVhiqucqUO/
 8udINqJGNa9MWvFoTmE36+2vIrNQmLYkIGPyZU6m0+q9xt7kHnV3hdWEkFq+QAE8Qe
 ISWxQ/mUr8NfdUFcw4IBqYmYTKsS84OTJp72UoELZL+5d/RXtttlDkKFK4goVKsZlY
 3YrfOrgeAqtQPUUVnklZ0v3itZ5Rxtwg7SNBgBHfyKZdLTJtpmOUQTmE7YNR7WynQc
 g5n7KzLMkrI0poblqfcCXAckx+LC+bN+ig9bA+I0DrphG7ZH/Q0IcJSVlBVHcQyqaI
 SxosmqNDyqKUA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 628E1100061;
 Tue, 24 Oct 2023 09:44:21 -0400 (EDT)
Received: from pastel (unknown [45.72.216.111])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 39935120352;
 Tue, 24 Oct 2023 09:44:21 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83y1fskyjj.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Oct
 2023 15:14:24 +0300")
Message-ID: <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN>
Date: Tue, 24 Oct 2023 09:44:20 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.152 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> What will that do if the mouse was moved, then returned to the
> original position before the button is released?

In the sample patch I sent it depends if the original mouse/screen position
still shows the same buffer position.  If it does, then the `up` will
stay as an `up`, otherwise it will turn into a `drag`.
[ At least, that's what I think my code does.  ]


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 13:55:02 +0000
Resent-Message-ID: <handler.66655.B66655.169815566923743 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Stefan Monnier <monnier@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815566923743
          (code B ref 66655); Tue, 24 Oct 2023 13:55:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 13:54:29 +0000
Received: from localhost ([127.0.0.1]:53498 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvHrY-0006As-OX
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:54:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35418)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qvHrR-0006AL-Ht
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:54:23 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qvHqr-0001RB-6m; Tue, 24 Oct 2023 09:53:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=8/+nMSDwJI/h3k0Ot32kuYHWWfRdIIAx26Fd0RAQ+xs=; b=kIxyyrxl7a6/
 7E/oZ03oAP7TrrlQCXGvzJx/rAKwC7facCRiyLA6lXb6m6oa6DdTCLgnGUMi+Vx3XY9VPSYe367Le
 ey0J1Nw43ayJtuptLo6ujaKlWDs1JEip8wgzinjIVJVLMzRdcaueJE/xe42V/wTE9bDiAafgsSgM0
 77KwQ2DTIPcxZWQPq3nFsqZ0dPhb8pPOJiQxUfjPf7cCIq8ggLFf6Gn04NRJrBjkw1ORYeJIKhOhA
 EWPMxcEZLaz+3kRc/zz9loCcm9oiqY81pC7muTx/GNPTWBkrgMKtUX6EZWqDXz8MnSmnAdX6iT4Xh
 ER7KzuZG2A6K1sT1fowD6g==;
Date: Tue, 24 Oct 2023 16:53:50 +0300
Message-Id: <83il6wktxt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Tue, 24 Oct 2023 09:44:20 -0400)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
> Date: Tue, 24 Oct 2023 09:44:20 -0400
> 
> > What will that do if the mouse was moved, then returned to the
> > original position before the button is released?
> 
> In the sample patch I sent it depends if the original mouse/screen position
> still shows the same buffer position.  If it does, then the `up` will
> stay as an `up`, otherwise it will turn into a `drag`.
> [ At least, that's what I think my code does.  ]

OK, but I think the issue with double-click-fuzz still remains to be
solved with this approach.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 13:59:02 +0000
Resent-Message-ID: <handler.66655.B66655.169815588626472 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815588626472
          (code B ref 66655); Tue, 24 Oct 2023 13:59:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 13:58:06 +0000
Received: from localhost ([127.0.0.1]:56032 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvHv3-0006su-PZ
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:58:06 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7349)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qvHv1-0006sP-Gi
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 09:58:04 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 63AA210013E;
 Tue, 24 Oct 2023 09:57:28 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698155847;
 bh=b2OpWSE6QJW8pBEEaw4SGatgqrO+N5psSuD/8WrWWd0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=BQRZA+KracbZmUgzPuvhiZxjMBZRQzd6klfOnfpflZVd/lurQjYgg4GLp3jedzqXA
 D+GS4jIrSkTeJDn0S3AMITtK+aPATwpTggH9FmyQpuETPM8suxTzO3PR63j8XbFcbJ
 QXtnFXCCiIdhzATv8dw1sHE0SM1WxeN1dzCNBpjkNFH4nmPkPVwSZXUWoQs106WScR
 kf+ocqyWbXnOgOTJuI4Me5q88f2gTbyfwwtOv5HVeBiZkRIOdQx44sLhLhrH2Fz+IF
 sexVnVda7AzUMLMN9xqvsyUupPn3rDpmmd0Tc6glLyb5Igbti8B+VGOBSslrBMd9hI
 Mz4Ps/WY8lWAw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3063A100061;
 Tue, 24 Oct 2023 09:57:27 -0400 (EDT)
Received: from pastel (unknown [45.72.216.111])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 090DF12016C;
 Tue, 24 Oct 2023 09:57:27 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83il6wktxt.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Oct
 2023 16:53:50 +0300")
Message-ID: <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN>
Date: Tue, 24 Oct 2023 09:57:26 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.151 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> > What will that do if the mouse was moved, then returned to the
>> > original position before the button is released?
>> 
>> In the sample patch I sent it depends if the original mouse/screen position
>> still shows the same buffer position.  If it does, then the `up` will
>> stay as an `up`, otherwise it will turn into a `drag`.
>> [ At least, that's what I think my code does.  ]
>
> OK, but I think the issue with double-click-fuzz still remains to be
> solved with this approach.

Not sure what you men by that (probably because I don't know enough of
what we do with double-click-fuzz, i.e. where we do obey it and where we
don't).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 14:01:01 +0000
Resent-Message-ID: <handler.66655.B66655.169815603226842 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815603226842
          (code B ref 66655); Tue, 24 Oct 2023 14:01:01 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:00:32 +0000
Received: from localhost ([127.0.0.1]:56047 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvHxP-0006yr-RL
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:00:32 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56984)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qvHxN-0006ya-PZ
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:00:30 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9F2234422A1;
 Tue, 24 Oct 2023 09:59:54 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698155988;
 bh=yXsP20c6KGHIBMURWrXYk2pRc2MYgCo/gLTo2bB4MnU=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=gmMd1Ti/MOAVTDs9v4mH+l6uUeS+4KEGu1IoPIGhSQ1NwtSp+4dL+mcBwl3ZHxBnF
 KkPMxNLoCE5ihEUqxD7fWRydJ8+QZ0Dr0q3uUq25wX13MFFBO+ekZbBY9d9lGO/qlv
 W/DzGTYde2zj1LRxnezI5r3o7Bgy1zpRIpxczEJTrbZRgS+XB8A4nIHIwJTOVx4OiP
 9bDXyUaSoRxspissOzCkTL/LKGx5O4zoNX20EqIPHDhHNRiwRGVGL08WovkSLQK+Fm
 sWXN/iibpAWXbL3+BJ2gcTXf+Maqqh5Nz3igNBHp2G6qfSE4s/TF5MPjndUwDvSRPd
 mMOjFwS8/0OMA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E70F64422A7;
 Tue, 24 Oct 2023 09:59:48 -0400 (EDT)
Received: from pastel (unknown [45.72.216.111])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BE5D612022B;
 Tue, 24 Oct 2023 09:59:48 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83il6wktxt.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Oct
 2023 16:53:50 +0300")
Message-ID: <jwvcyx4yven.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN>
Date: Tue, 24 Oct 2023 09:59:48 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> OK, but I think the issue with double-click-fuzz still remains to be
> solved with this approach.

I suspect another problem with my patch is that it only takes effect when
we generate `mouse-movement` events, i.e. inside `track-mouse`.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 14:19:01 +0000
Resent-Message-ID: <handler.66655.B66655.169815713128577 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Stefan Monnier <monnier@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815713128577
          (code B ref 66655); Tue, 24 Oct 2023 14:19:01 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:18:51 +0000
Received: from localhost ([127.0.0.1]:56082 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvIF8-0007Qq-Q1
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:18:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59010)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qvIF6-0007Qd-AP
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:18:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qvIEV-0006nv-PJ; Tue, 24 Oct 2023 10:18:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=ULjaRhVmCW8mVnLGQNkPuAiV2TXJkv43zrlEepB18/8=; b=fPpF8kahhuLp
 zKKRowR/HeJS4vw3IUrEsgbsgYKFU8o6WdtpZRPVFyqpeGsSrqOX9h0tzr5HWrx6QWCekBFasEPNz
 zN84TiITyFd20tkXiy9k92gMROV4RJtMO1OMUBT98O5kITzvM0vaPI8it0aGZh6vcgTLR08TRvyrZ
 FpAixss/+RlfksL2rV9T7m0FkHfcWC7m+Ths/OYT1ktGexw4kaWs7Sqb/xYdrMVD3lrT9EhWSZMnw
 vU/MB6vtFP5QgCUxNZyHoIBh0WqkqkZm9YRH9sPnPfRpOTff+K9IHqMN6eJ27845VqsnA4nMCDb6Y
 qRE492Nh4vk5ER5P4HRhkg==;
Date: Tue, 24 Oct 2023 17:18:16 +0300
Message-Id: <83h6mgkst3.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Tue, 24 Oct 2023 09:57:26 -0400)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN> <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
> Date: Tue, 24 Oct 2023 09:57:26 -0400
> 
> >> > What will that do if the mouse was moved, then returned to the
> >> > original position before the button is released?
> >> 
> >> In the sample patch I sent it depends if the original mouse/screen position
> >> still shows the same buffer position.  If it does, then the `up` will
> >> stay as an `up`, otherwise it will turn into a `drag`.
> >> [ At least, that's what I think my code does.  ]
> >
> > OK, but I think the issue with double-click-fuzz still remains to be
> > solved with this approach.
> 
> Not sure what you men by that (probably because I don't know enough of
> what we do with double-click-fuzz, i.e. where we do obey it and where we
> don't).

It is used to decide whether to emit a drag event or a click event,
just search for it in keyboard.c and you will find the code.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 14:31:01 +0000
Resent-Message-ID: <handler.66655.B66655.169815781129797 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815781129797
          (code B ref 66655); Tue, 24 Oct 2023 14:31:01 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:30:11 +0000
Received: from localhost ([127.0.0.1]:56109 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvIQ7-0007kW-6u
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:30:11 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24020)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qvIQ4-0007io-64
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:30:09 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B1D684427E1;
 Tue, 24 Oct 2023 10:29:32 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698157771;
 bh=W5l7gptfDAte8O88ObY4wp5jSJLO8fasXZjXJJa85jg=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=cWvFzLr40IKBU6loAE7IA75OnTA54vO9rgm0U2me2vgDMmPKWMlKedOSu/K85/2hu
 Y6nGZHOa9sIBbENcC7H+vkxrF9/D3OMFdxeBFOw+LAnGHHawmDG2MiAwt2OuCR6S7I
 dd8NcHtfYQPAO43Vt93GjBhwqf5hYCfoskuWR2hM3DC4icPPIurEB3d65ww/sQ2a8p
 elQq5Hc7ZbXNPeSYKwQJiaMt5XtIbq7jX35R5znUtPN3IbJKJwm1FBIEqKlOQ64BgL
 S4EBwouGlekbc1jVj9LH13CusS3M2bA8MRLxMkv/vQb1/Rxa6s5gZNAqNy0J3D1lDv
 LFGHG0lGuR+KA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 50F0E44265C;
 Tue, 24 Oct 2023 10:29:31 -0400 (EDT)
Received: from pastel (unknown [45.72.216.111])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C11F120330;
 Tue, 24 Oct 2023 10:29:31 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83h6mgkst3.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Oct
 2023 17:18:16 +0300")
Message-ID: <jwv7cncyu1b.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN> <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN>
 <83h6mgkst3.fsf@HIDDEN>
Date: Tue, 24 Oct 2023 10:29:30 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> > OK, but I think the issue with double-click-fuzz still remains to be
>> > solved with this approach.
>> 
>> Not sure what you men by that (probably because I don't know enough of
>> what we do with double-click-fuzz, i.e. where we do obey it and where we
>> don't).
>
> It is used to decide whether to emit a drag event or a click event,
> just search for it in keyboard.c and you will find the code.

I still don't see what you mean by "the issue with double-click-fuzz
still remains to be solved with this approach".

AFAICT my patch still obeys `double-click-fuzz` at the same place using
the same code.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 14:37:02 +0000
Resent-Message-ID: <handler.66655.B66655.169815820030525 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Stefan Monnier <monnier@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815820030525
          (code B ref 66655); Tue, 24 Oct 2023 14:37:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:36:40 +0000
Received: from localhost ([127.0.0.1]:56119 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvIWO-0007wG-03
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:36:40 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:34232)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1qvIWL-0007w2-Qa
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:36:39 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1qvIVm-0002b6-3a; Tue, 24 Oct 2023 10:36:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=EZLP3LoldldQfAC3OXHi+rVnMR29IPgLOMbrVNePo+s=; b=HG237n5EqxcB
 IS0YB4c/sRFDnMnAqJJAjhU/jnFhWLmdzyeekERmkcGvmL1pIF/Opfhjgs0qzzCneB9FnRd96KxVu
 /I+idI4jpe3wZ3zDUuJs/d0r7v0c9Gf8RDC4P0BN4j+NV67qx9Ve1F98oZSXp20krUvP6Lzvqc6iH
 D+PFzycdpj7VaLX/xExgXMrBkOztlVt+MTC8MIv4OHWj65mupLT6U8ytChBdFm8xXsYw5JfMktPNt
 F4laAJ8zrvx6/aKEnB4eCP/xMFw7Dm+k7g8fr/UQvOoDGyxCJVA3/A8t+fMzBUR92RZvFfv85dd5m
 wgz3GPHyGSSFeYvPUYZguA==;
Date: Tue, 24 Oct 2023 17:36:06 +0300
Message-Id: <83edhkkrzd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwv7cncyu1b.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Tue, 24 Oct 2023 10:29:30 -0400)
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN> <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN>
 <83h6mgkst3.fsf@HIDDEN> <jwv7cncyu1b.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: tomasralph2000@HIDDEN,  66655 <at> debbugs.gnu.org
> Date: Tue, 24 Oct 2023 10:29:30 -0400
> 
> >> > OK, but I think the issue with double-click-fuzz still remains to be
> >> > solved with this approach.
> >> 
> >> Not sure what you men by that (probably because I don't know enough of
> >> what we do with double-click-fuzz, i.e. where we do obey it and where we
> >> don't).
> >
> > It is used to decide whether to emit a drag event or a click event,
> > just search for it in keyboard.c and you will find the code.
> 
> I still don't see what you mean by "the issue with double-click-fuzz
> still remains to be solved with this approach".
> 
> AFAICT my patch still obeys `double-click-fuzz` at the same place using
> the same code.

You suggested to check whether the mouse coordinates changed between
the down- and up-event.  My point is that we already check the screen
position of the mouse between these two events, and allow them to
change if the change is small enough.  So I'm not sure I understand
what is new in your idea, if you want to keep the double-click-fuzz
test.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 24 Oct 2023 14:51:02 +0000
Resent-Message-ID: <handler.66655.B66655.169815904932323 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66655
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: tomasralph2000@HIDDEN, 66655 <at> debbugs.gnu.org
Received: via spool by 66655-submit <at> debbugs.gnu.org id=B66655.169815904932323
          (code B ref 66655); Tue, 24 Oct 2023 14:51:02 +0000
Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 14:50:49 +0000
Received: from localhost ([127.0.0.1]:56156 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qvIk4-0008PG-Hf
	for submit <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:50:49 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63151)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1qvIjw-0008Ou-6N
 for 66655 <at> debbugs.gnu.org; Tue, 24 Oct 2023 10:50:47 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3C99D10013E;
 Tue, 24 Oct 2023 10:50:05 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1698159004;
 bh=dyHlfO/ieYUIf9QHaInNAtYmnsROhAcvnYoh0Mg9Xmo=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=FWzpowhWPM1dY0REoKfZ0CtXUEPJ/2lCWsbUryEtuzqwznqfS7UQJTMbPSILgIeBr
 AIQ8lMDqn7tNhvagkeAeJiehjnMetOf4aAS0Pqnd2ZmFBKVAIayTvY889J1w1OHaNE
 3ldZiIVFYUpaDKt7vutUtXL2IjvNg44K2yqM4luMROhqxe+gtWMlBK6Ui24ljKNRZg
 nYNc+8lQN715oyWF8qoUV4L7rbJDohMKL5rjUrefsSSrJagP3eAVcor/jHKrrr6Wyf
 60OLcFfyaFM5gNCQM9WDaYdWA1cCCdVIahBvsRec4QuxOm26eDiMMbEbZkBL8SpJGR
 wuqjok3kwWtdQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EF703100061;
 Tue, 24 Oct 2023 10:50:03 -0400 (EDT)
Received: from pastel (unknown [45.72.216.111])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C6C851201BB;
 Tue, 24 Oct 2023 10:50:03 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <83edhkkrzd.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 24 Oct
 2023 17:36:06 +0300")
Message-ID: <jwv1qdkyt4l.fsf-monnier+emacs@HIDDEN>
References: <1d9187b71e7288eaf08ac9a2f0559bdf@HIDDEN>
 <8334y4s0oe.fsf@HIDDEN> <jwvh6mhnvzp.fsf-monnier+emacs@HIDDEN>
 <83v8axmbsh.fsf@HIDDEN> <jwvo7gpm0ly.fsf-monnier+emacs@HIDDEN>
 <83y1fskyjj.fsf@HIDDEN> <jwvo7goyw5v.fsf-monnier+emacs@HIDDEN>
 <83il6wktxt.fsf@HIDDEN> <jwvil6wyvi4.fsf-monnier+emacs@HIDDEN>
 <83h6mgkst3.fsf@HIDDEN> <jwv7cncyu1b.fsf-monnier+emacs@HIDDEN>
 <83edhkkrzd.fsf@HIDDEN>
Date: Tue, 24 Oct 2023 10:50:03 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.151 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> change if the change is small enough.  So I'm not sure I understand
> what is new in your idea, if you want to keep the double-click-fuzz
> test.

What's new is the `mouse_has_moved` boolean which remembers if the mouse
has been moved some time between the down and the up, contrary to the
current code which only looks at the relative position of the down and
the up.

The patch looks big mostly because it reverts your patch.


        Setfan

Last modified: Tue, 24 Oct 2023 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.